GitLab

The "if" removed in MaybeFinishConnectorRequest would prevent the auth
request from completing since received_connector_responses_ is populated
by tags in OnGetConnectorResponse. Since the auth request doesn't use
tags, that map entry would stay empty and the request would be blocked
from finishing.

This CL also removes MaybeFinishRequest since it has no caller.

Change-Id: Iae87f675bb8fb1690c34d3fececf1698a7e391e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261165Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781548}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5d4e2463f77d73d8fdd46dbc0d876ea58e97e115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261097Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781547}

When LiteMode is enabled and https image compression experiment is
active, this CL surfaces whether https images in the page got
compressed to page info.

The pageinfo screenshot is here
https://storage.cloud.google.com/chromium-translation-screenshots/212a781d980587ffb65c0d71cc96ce0bdb3832bb

TBR=twellington@chromium.org

Bug: 1091856
Change-Id: I8cc52b253f037bebf444880cd62183bd1f27f61d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250541
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781546}

Sqlite is using v3.32.1 now.

Bug: 1087629
Change-Id: I504f751e8c361e081a8a969da0be09c138ab71c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261147
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781545}

This CL fixes two things:
(1) We use a solid-color layer to draw hotseat background. However,
Layer::SetBounds() does not mirror bounds under RTL. So we should do
it manually.
(2) View::SetBounds() mirrors bounds under RTL. So mirroring bounds
manually in ShelfView's member function is unnecessary.

Bug: 1094026
Change-Id: Iab5564b6687d7279733e5aa6d37fe41ef28cd15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261421Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781544}

Change-Id: Idea598dc21a96c4297841db2a733a2721f2d08e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261212
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781543}

See bug for screencast of issue.

The issue only seems to be present on Mac, and I tested dragging on both Mac and Windows with this change.

Bug: 1033534
Change-Id: I10553e4121f1e3566f66ffd215cfd276ac8ab801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261222Reviewed-by: Charlene Yan <cyan@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781542}

Bug: 1092931
Change-Id: I07e6f2b343ec368ce161a742f2b69548b44e2fd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261359
Commit-Queue: Xi Han <hanxi@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781541}

In order to give a more seamless transition. This CL captures the scroll
state of the page at time of recording. Then this can be used to replay
the scroll position when loading the paint preview. This behavior can
be disabled via PlayerManager if not desired.

Bug: 1096598
Change-Id: I4dffa033e12d5cac9cbf521a330cefa9201b4ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250589
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781540}

The motivation behind this change is for ATs to be able to switch from
an IA2 element to its corresponding UIA element. In order to achieve
the above, this CL implemented the following:
- IItemContainerProvider::FindItemByProperty for finding an
UIA element through its unique id.
https://docs.microsoft.com/en-us/windows/win32/api/uiautomationcore/nf-uiautomationcore-iitemcontainerprovider-finditembyproperty
- A custom UIA property id that maps to an element's unique id.
- Introduced ui::UiaRegistrarWin class for managing custom UIA
  property/event.

AX-Relnotes: ATs will be able to lookup an UIA element from and IA2
element.

Bug: 1084630
Change-Id: Ief9664ff04224972af6607304c6893c25772f95d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242046Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Victor Fei <vicfei@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781539}

OnSecurityEventEnterpriseConnector policy.

Before connectors the URL for reporting was hardcode to one value.
Connectors adds the ability for the URL to change dynamically based on
the connector chosen by the admin, as identified by the connector
policy.

Bug: 1069031
Change-Id: Ic59379283d7651be45d65f6f9785c43c0d43e1ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251742
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781538}

Bug: 1082505
Change-Id: I3c6fff27d5f2d8a418b0f6f79823fa88d1575f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261158
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781537}

Introduces a new directory for temporary code related to the PDF
viewer's PPAPI migration. Code in this directory should abstract away
usage of PPAPI, so it may easily be removed after the migration is done.

Also moves the existing pdf/geometry_conversions.{cc, h} files, as an
early example of the kind of code that should be in this directory.

Bug: 10611824
Change-Id: I01372843f4149a607ef1b6dab80277986c177d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261413
Commit-Queue: K Moon <kmoon@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781536}

The issue was related to TabStrip::AddTabToGroup firing causing too much churn. I fixed it elsewhere, but I did clean up a spot in TabStrip::AddTabToGroup that was problematic memory-wise.

I started writing a test in tab_group_editor_bubble_view_browsertest, but then I realized I'd have to change several things about the setup (add extra tabs, branch the logic so that it can collapse the group conditionally, modify all the tests, etc.). If there are any other thoughts on where to test this, I'd be happy to take a look!

Bug: 1095801
Change-Id: I283970e6f2242ac387114eb303a8529bb2764593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261261Reviewed-by: Charlene Yan <cyan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781535}

In some circumstances, ProfileNetworkContextService can set the
directories it populates in NetworkContextParams (for the cookie store,
reporting store, and so on) to a nonexistent path. Currently, the Trust
Tokens backing store doesn't attempt to create directories when
nonexistent, causing some tests to fail flakily when sql::Database::Open
hits a LOG(DFATAL) after attempting to open a database at a path with a
nonexistent parent directory. (It's flaky because the failure races with
other backing stores that do attempt to create the directory in this
scenario.)

This change hopefully resolves the failures, by making
SQLiteTrustTokenPersister::CreateForFilePath create the given path's
directory if it does not exist.

R=mmenke

Fixed: 1098019
Change-Id: Id075718035e1fd7e29cebc063d9126f1f33c4c83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258685Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781534}

When the selected tab in a tab group changes, the length of the group
underline may need to change. This was not happening, resulting in the
attached bug.

This CL refactors TabStrip::SetSelection() in a handful of small ways:
- makes old selected tab and new selected tab explicit local variables
- simplifies conditional logic slightly
- makes an implicit assumption that new selected tab is valid explicit
  * there had been a check in one place for an invalid index
  * however, it just blindly dereferences it later in the function which
    would have caused a crash
- when active tab changes, if either tab was in a group, recalculates
  group underline and highlight bounds via UpdateTabGroupVisuals()

Fixed: 1098392
Change-Id: Ib4b41bd8ce3e7c601d0329cef9d96b8d5846d7b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261166
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Connie Wan <connily@chromium.org>
Auto-Submit: Dana Fried <dfried@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781533}

https://android.googlesource.com/platform/external/perfetto.git/+log/d724122c7d1e..c865364ae842

2020-06-23 cfijalkovich@google.com Merge "Improvements to trace processor HSC-like metrics strategy."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I56824162d3af58c8fd4eb6c97d900caa70e3f1a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261056Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781532}

https://quiche.googlesource.com/quiche.git/+log/d7afab2f4566..bd7ad68ab12b14

$ git log d7afab2f4..bd7ad68ab --date=short --no-merges --format='%ad %ae %s'
2020-06-23 fayang Fixes to make chromium merge happy. No functional change.
2020-06-23 haoyuewang Use writevarint62 instead of writeuint8 to write the frame type in ietf quic as the ietf draft specifies that the frame_type uses variable length integer encoding. no behavior change.
2020-06-23 dschinazi Remove QUIC draft-28
2020-06-22 nharper Remove unused server designated connection ID from QUIC
2020-06-22 fayang In quic, include minplaintextpacketsize when deterine whether removing soft limit for crypto frames. protected by enabled gfe2_reloadable_flag_quic_fix_min_crypto_frame_size.
2020-06-22 wub For quic loss detection, replace quicconnectionstats.total_loss_detection_time by quicconnectionstats. total_loss_detection_response_time to improve the accuracy of detection speed. protected by existing --gfe2_reloadable_flag_quic_enable_loss_detection_experiment_at_gfe.
2020-06-22 dschinazi Avoid crash in QuicDispatcher
2020-06-22 dschinazi Allow setting connection options from command line in QuicToyClient
2020-06-22 wub Deprecate --gfe2_reloadable_flag_quic_bbr_default_exit_startup_on_loss.
2020-06-22 fayang In quic, let client bundle handshake data (containing client finished) with handshake ack. protected by existing gfe2_reloadable_flag_quic_bundle_crypto_data_with_initial_ack.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=dschinazi@chromium.org

Change-Id: I3984c4289194ff0e6f5c509dc958fed9d4551d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261357
Commit-Queue: Fan Yang <fayang@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Auto-Submit: Fan Yang <fayang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781531}

Split setIds(internalId, primaryId) into 2 distinct methods,
setInternalId(id) and setPrimaryId(id).

Bug: 1075656
Change-Id: I312950db43d0044cbaf923e458912816a06834e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245616
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781530}

ScopedObserver makes sure that the observers are always removed on
destruction. Found while running tests and adding a CHECK to the
destructor to see if it is still inany observer list.

Bug: 1055483
Change-Id: Ia230170ac17a558ec9257df15fa115b2e83d6dcb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257423Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781529}

On each decoration level, a thickness can be specified that is
individual to the decoration specified at this decorating box /
level. Carry those in AppliedTextDecorations to ensure that ancestral
decorations do not get incorrectly painted using the stroke thickness
that is specified on the current element.

A previous attempt had been made to carry the resolved thickness (e.g. a
percentage resolved against a font size but that won't work due to the
AppliedTextDecoration vector being const in ComputedStyle and
ComputedStyle generally kept const). Also, computing the resolved
thickness in ComputeDecorationInfo fits the current conventions better.

Thus, instead of carrying a single thickness in DecorationInfo, which
overrides all thicknesses of previous AppliedTextDecorations' carry a
parallel array with as many entries as there are AppliedTextDecorations
and store the resolved thicknesses in those.

Bug: 1096038
Change-Id: Ifdaf6dd167024a919fafae297e5a01a226b9cda1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252081
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781528}

Roll Chrome Win64 PGO profile from chrome-win64-master-1592924274-08d5db635b74d1eb292c1b13837063587fddd457.profdata to chrome-win64-master-1592927234-93fd17f09f62ae1a92f26a9127978b7f390ce8f1.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Iadd7df5276ccda216aefa676d6fa72691a17d43d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261057Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781527}

This CL adds a new string that will be used for the in-product help that
will direct the user to Downloads Home when the offline indicator
appears.

Screenshot: https://crbug.com/1068700#c6

Bug: 1068700
Change-Id: Ia6ca521f5818427423db22f9143c290cf9738bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261240Reviewed-by: Sinan Sahin <sinansahin@google.com>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781526}

TBR=takumif@chromium.org

Bug: 1095068
Change-Id: I60ea6b482f0436b0113b33d8a50e2530829e6658
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260431Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781525}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ic5e8f6e32c62bd98b042c0401a93090038b87b1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261397Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781524}

Two inputs were added controlling the inbound/outbound node display. The
visualization now does a BFS outwards from the filtered node set to find
more nodes to show, specific details on this logic can be found in
Graph.getDataForD3. The inbound/outbound nodes are color coded with the
closer ones being darker.

Bug: 1093962
Change-Id: I56ee9c9401a46bc0a45ca9274954429155a3b27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258253
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781523}

On Windows, print drivers can only be safely accessed on the UI thread,
but the UI thread disallows blocking by default. Make an exception for
PrintJobWorker::UseDefaultSettings() for the same reason as
PrintJobWorker::UpdatePrintSettings().

Bug: 1098434
Change-Id: Ic589a07faa7865e25b1007c8103662e006f7de5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261144Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781522}

TabSearchUI is used for serving webui resources for tab search feature,
which will be checked in later. TabSearchPageHandler implements the
tab_search.mojom interface. The logic of this CL is mostly mimicking
TabStripUIHandler. Some code is moved from TabStripUIHandler to
chrome/browser/ui/webui/util/image_util.h to be able to used in
TabSearchPageHandler as well.

Bug: 1096120
Change-Id: I4668ad18ebb84282dc44d2dfb78916f54cd55abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242215
Commit-Queue: Yuheng Huang <yuhengh@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781521}

ios14-beta-sim to compile with xcode 11e146, and run tests on xcode
 12a6159 and sims version 14.0.
ios14-sdk-sim to compile with xcode 12a6159 and run tests on 12a6159
 with sims 12.4, 13.6 and 14.0.

Change-Id: Ibb26eeba9e393437e45ba2b81f423e4ade220870
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259516
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781520}

Before this CL, the code was mistakenly adding internal padding to
the menu position. But both the combobox and the dropdown draw their
borders similarly and hence they should use the same bounds.

Screenshots:
Before: https://screenshot.googleplex.com/DrCgx0mp5Th.png
After: https://screenshot.googleplex.com/0EEH40BOw1p.png

Bug: 1044038
Change-Id: I275b3ae320d44e93357364a64a9f37a607445d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261273
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781519}

Adds SequenceChecker to UpgradeDetector so that all accesses take
place on the same thread, and moves ServiceProcessControl's calls to the
UpgradeDetector to functions that happen on the browser/UI thread.

Bug: 1096318
Change-Id: I5bf92ff4011c314c44b6e6e40f77ebec81bf9f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244127Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Michael Li <michli@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781518}

fuchsia runner.

This enables fuchsia test runner scripts to write auxiliary log files
to a logs directory using runner_logs.RunnerLogManager.

Bug: 1067356
Change-Id: I3fd98b23c62c5d452ff29fa1208fbfa9bc6c21e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249040Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Stephen Roe <steveroe@google.com>
Cr-Commit-Position: refs/heads/master@{#781517}

AX-Relnotes: n/a.
Bug: None
Change-Id: I7b808caae181c14bf47ba69f6b24f18aed755c79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256851Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#781516}

This reverts commit 7c9e1f12.

Reason for revert: Test failures were due to untriaged images, fixed now.

No change from original CL.

Original change's description:
> Revert "Switch RenderTests to use SkiaGold"
> 
> This reverts commit 3ed31ecf.
> 
> Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester/32796
> 
> Bug:1098417
> Original change's description:
> > Switch RenderTests to use SkiaGold
> > 
> > Switches all uses of RenderTestRule to use the SkiaGoldBuilder method
> > of constructing it, which results in all Android RenderTests being
> > backed by Skia Gold.
> > 
> > Bug: 1057851
> > Change-Id: I63d40faef7863dddb5edaa93aef8559eb4d3696d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248742
> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> > Reviewed-by: Theresa  <twellington@chromium.org>
> > Reviewed-by: Bo <boliu@chromium.org>
> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > Reviewed-by: Peter Conn <peconn@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#780931}
> 
> TBR=boliu@chromium.org,twellington@chromium.org,wychen@chromium.org,peconn@chromium.org,bsheedy@chromium.org,tiborg@chromium.org
> 
> Change-Id: I58bd6a0289cb496c62ae4b5556374ffcbfa333ce
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1057851
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261178
> Reviewed-by: Gang Wu <gangwu@chromium.org>
> Commit-Queue: Gang Wu <gangwu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781429}

TBR=boliu@chromium.org,twellington@chromium.org,gangwu@chromium.org,wychen@chromium.org,peconn@chromium.org,bsheedy@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1098417, 1057851
Change-Id: I4762d97220b6b0745c462d220e90ffd8ed1043ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261257Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781515}

Part I to setup logger for TileService.

Logger: The public interface to the log code.  Can be queried for state
and returns base::Value objects.
Logger::Observer: Used to notify external components (e.g. WebUI) about
internal state changes.
LogSink: The internal interface that should be notified by internal
components about potential log-worthy changes.
LogSource: The internal interface that Logger will request state from.

Also Add BlackHoleLogSink and EmptyLogger for test purpose.


Bug: 1066556
Change-Id: Ib8ee202c650cf72de20ab5cb6b9038ea51d5f651
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250891Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781514}

Adding template specialized class VariantUtil which adds Get and Set
methods for the underlying data in a VARIANT specific to a VARTYPE.
This is useful for template methods, since it makes it easier to
templatize VARIANT logic, avoiding macros like V_BOOL, V_UNKNOWN, etc.

The VariantUtil class also has a typedef |type| for the underlying type
associated with a specific VARTYPE.
e.g. VT_BOOL => VARIANT_BOOL, VT_UNKNOWN => IUnknown*.

Moving IsLeakableVarType out of ScopedVariant and into variant_util.h.

Split out from :
https://chromium-review.googlesource.com/c/chromium/src/+/2188057

Bug: 928948
Change-Id: I8f8e4bcbf7620122ec361c4947175271ee5e6be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244454
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781513}

Before this CL, the code was mistakenly adding internal padding to
the menu position. But both the EditableCombobox and the dropdown
draw their borders similarly and hence they should use the same bounds.

Screenshots:
Before: https://screenshot.googleplex.com/RBcFKJ0WqBC.png
After: https://screenshot.googleplex.com/HfCZTOgE8dv.png

Bug: 1044038
Change-Id: Ib6595b9165518886a88e5513653d22f197534545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260879
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781512}

Let's keep monitoring it for health check.

Bug: 1089488
Change-Id: Ieacbd68692b0176bf5500f11b3b76984f24325c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259754
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781511}

Some cases in the KioskAppManagerBrowsertest are flaky because
SimpleURLLoaderImpl::OnReceiveResponse may get non-500 failure response
code. I suspect they are actually 400 error, but don't have enough
evidence.

Add some additional logic to log this information to figure out the root
cause.

Bug: 1090937
Change-Id: Ia343519dbd06311dfde2bccd25d9ebf86bb72566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257857Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781510}

If |chromeos::AccountManager::Initialize| is called twice, it may happen
that the second call may complete before |AccountManager|'s
initialization is actually complete.

Fix this by keeping duplicate initialization callbacks in a queue until
initialization is complete.

Change-Id: Ib44ffaed733fd3a567bdd8d256d04b182b1dbff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255458
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781509}