Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 02 Sep, 2020 2 commits
    • James Cook's avatar
      lacros: Support high DPI notification icons and images · b10c2671
      James Cook authored 
      Convert icons and images to use the newly-stabilized ImageSkia mojo
transport. This allows high DPI images. It is also higher performance
than the existing crosapi::Bitmap serializer because it uses shared
memory for large images.

Lacros still sends icons and images in the old format to allow
backwards compatibility with older ash. We can remove this old
serialization in 6 weeks or so. Until then we won't see the
performance benefit.

Manually tested on gLinux with high-DPI screen.

Bug: 1113889
Test: added to unit_tests
Change-Id: I1cf4b86512fd59e287a32dfb4ac2d59d2962a6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388152Reviewed-by: default avatarJun Mukai <mukai@chromium.org>
Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Reviewed-by: default avatarGreg Kerr <kerrnel@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803711}
      b10c2671
    • Amr Aboelkher's avatar
      Revert "Reland "PSM: Support PSM RLWE based message definitions in Chromium"" · 79bb0c73
      Amr Aboelkher authored 
      This reverts commit 2cb2db95.

Reason for revert: tree is broken cause of win related issues, see: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17181?

Original change's description:
> Reland "PSM: Support PSM RLWE based message definitions in Chromium"
> 
> This reverts commit 6e670242.
> 
> Reason for reland: shell-encryption tests were failing for Win and Android, see: crbug.com/1124018. Then all tests have been disabled for all platforms except for ChromeOS, until the problem being solved from the upstream, then being rolled into Chromium.
> 
> Original change's description:
> > Revert "PSM: Support PSM RLWE based message definitions in Chromium"
> >
> > This reverts commit 33d4fbea.
> >
> > Reason for revert: We believe this is causing the build failure that closed the tree: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17171?
> >
> > Original change's description:
> > > PSM: Support PSM RLWE based message definitions in Chromium
> > >
> > > This CL adds the communication between client and server
> > > for issuing and retrieving determination using PSM. It also
> > > supports the usage of private_membership third_party protos
> > > package in device_management_backend.
> > >
> > > BUG=chromium:1094675
> > >
> > > Binary-Size: Increase is temporary.
> > > Change-Id: If791aa1a4a936e1d42fde397a33c1a19c640359d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245131
> > > Reviewed-by: David Benjamin <davidben@chromium.org>
> > > Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
> > > Reviewed-by: Pavol Marko <pmarko@chromium.org>
> > > Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#803532}
> >
> > TBR=davidben@chromium.org,emaxx@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org
> >
> > Change-Id: I33f2f9200c3ef24d7c6059d116a88807d83aa0f0
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:1094675
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388267
> > Reviewed-by: Tommy Martino <tmartino@chromium.org>
> > Commit-Queue: Tommy Martino <tmartino@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#803555}
> 
> # Not skipping CQ checks because this is a reland.
> 
> 
> TBR=davidben@chromium.org,emaxx@chromium.org,tmartino@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org
> 
> Bug: chromium:1094675
> Binary-Size: Increase is temporary.
> Change-Id: Ia5c92b07b3614228823d2b4e883eb03e80474f37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388621
> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org>
> Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803700}

TBR=davidben@chromium.org,emaxx@chromium.org,tmartino@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org

Change-Id: I884e0bd9295696b2434e34f62f90eb39d4551c9e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1094675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388123Reviewed-by: default avatarAmr Aboelkher <amraboelkher@google.com>
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Cr-Commit-Position: refs/heads/master@{#803710}
      79bb0c73
  3. 01 Sep, 2020 38 commits