GitLab

Add group policy to disable taking screenshots:
* by keyboard shortcut (using local state)
* when reporting feedback (using local state)
* by extension API (using user prefs)

How to test:
- Press Ctrl+F5 (or the corresponding key combination on chromebook) to take a screenshot. This should flash a screen and create a screenshot in your files, if the policy is not enabled.
- Install http://code.google.com/chrome/extensions/examples/api/tabs/screenshot.zip extension to test extension APIs. This allows to take tab screenshots of code.google.com.
- In Chrome menu, use Tools -> Report an Issue... to go to issue screen, which should contain a screenshot (if the policy is not enabled)

Implementation:
- Changed browser::GrabWindowSnapshot and ScreenshotTaker::GrabWindowSnapshot to block screenshots triggered by accelerators and feedback form
- CaptureVisibleTabFunction::RunImpl to disable tab screenshots made by extension API

BUG= chromium-os:24747
TEST= Disable screenshots through policy, check I screenshots can created/viewed
TBR= zmo@chromium.org, jbates@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10692110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10831056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10828062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148961 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes the "options" drop box a proper size, so that it does not need to be as wide as "Always allow this site to use this camera and this microphone and camera".
It guarantees no overlap when the window is resizing.
It also corrects the layout by putting the cancelButton on the left of the okButton.



BUG=137837,138447
TEST= try with site: https://apprtc.appspot.com 

Review URL: https://chromiumcodereview.appspot.com/10802090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148960 0039d316-1c4b-4281-b951-d872f2087c98

crash with a null-bitmap-ptr. The callers already check for a NULL-BitmapPlatformDevice
return value.

Places where we perform this check/return on other platforms

bitmap_platform_device_win.cc#187 iff CreateDIBSection failed
bitmap_platform_device_mac.cc#120,144
Review URL: https://chromiumcodereview.appspot.com/10828069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Adding new strings should not require LGTM from src/chrome/app owners

Review URL: https://chromiumcodereview.appspot.com/10823078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148958 0039d316-1c4b-4281-b951-d872f2087c98

They're no longer necessary as crbug.com/129834 is implemented.

BUG=None
TEST=try


Review URL: https://chromiumcodereview.appspot.com/10829065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148957 0039d316-1c4b-4281-b951-d872f2087c98

BUG=134319


Review URL: https://chromiumcodereview.appspot.com/10833070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148956 0039d316-1c4b-4281-b951-d872f2087c98

app is launched.

Review URL: https://chromiumcodereview.appspot.com/10831050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148955 0039d316-1c4b-4281-b951-d872f2087c98

This builds a small subset of net containing only the dependencies needed to build the ui target.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10834051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148953 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO for sky@.

R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10796106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148952 0039d316-1c4b-4281-b951-d872f2087c98

The entry point to the Java Bridge is JavaBridgeDispatcherHostManager. This is
not part of the content API so is available only on WebContentsImpl, not
WebContents. We therefore modify ContentViewCoreImpl to store and use
WebContentsImpl*, rather than WebContents*. It's safe for ContentViewCoreImpl
to cast the WebContents* it receives in its constructor to WebContentsImpl*
because WebContentsImpl is the only concrete implementation of the WebContents
interface.

BUG=110637

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148945

Review URL: https://chromiumcodereview.appspot.com/9192008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139083
R=ben@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10821083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148950 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 4c4c2a2e.

This commit included inintended changes not present in code review.

BUG=110637

Review URL: https://chromiumcodereview.appspot.com/10827085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139471

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148948 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148947 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148946 0039d316-1c4b-4281-b951-d872f2087c98

The entry point to the Java Bridge is JavaBridgeDispatcherHostManager. This is
not part of the content API so is available only on WebContentsImpl, not
WebContents. We therefore modify ContentViewCoreImpl to store and use
WebContentsImpl*, rather than WebContents*. It's safe for ContentViewCoreImpl
to cast the WebContents* it receives in its constructor to WebContentsImpl*
because WebContentsImpl is the only concrete implementation of the WebContents
interface.

BUG=110637

Review URL: https://chromiumcodereview.appspot.com/9192008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148945 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danno@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10831046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148944 0039d316-1c4b-4281-b951-d872f2087c98

On newer JB builds, the JNINativeInterface struct appears to be held
in read-only memory so attempting to repoint individual function pointers
in it causes segfault. So instead we repoint the top-level struct pointer
to refer to our own copy held in read/write memory.

BUG=137348
TEST=JNIAndroidTest


Review URL: https://chromiumcodereview.appspot.com/10828050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148943 0039d316-1c4b-4281-b951-d872f2087c98

Simple fix like other build files

BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10825033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138638

Review URL: https://chromiumcodereview.appspot.com/10820046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138703
TEST=Changing search string or directory while previous search or directory scan is still running.

Review URL: https://chromiumcodereview.appspot.com/10828051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148940 0039d316-1c4b-4281-b951-d872f2087c98

highest-priority PrefStore only. Recommended values are interesting even
if they are currently being overridden by a higher-priority source.

This CL adds a getter for the recommended value and makes pref change
notifications be sent on all value changes, even if the change occurs in
a PrefStore that is currently overridden. This will allow the settings UI
to adapt when recommended values change.

BUG=104955

Review URL: https://chromiumcodereview.appspot.com/10821047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107108

Review URL: https://chromiumcodereview.appspot.com/10824073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117154

Review URL: https://chromiumcodereview.appspot.com/10825056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148935 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139443

Review URL: https://chromiumcodereview.appspot.com/10823074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148934 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148933 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10831069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148931 0039d316-1c4b-4281-b951-d872f2087c98

It also changes :
- dmprof messages,
- how to run subprocesses in prepare_symbol_info,
- to prepare readelf result in prepare_symbol_info,
- to rename procedure_boundaries => static_symbols,
- how to parse nm results in static_symbols,
- additional --keep option,
- to ignore empty files, and
- to store addresses in int.


BUG=123749
TEST=use dmprof.

Review URL: https://chromiumcodereview.appspot.com/10826008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138018


Review URL: https://chromiumcodereview.appspot.com/10824059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148929 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115047
R=rsleevi@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10824076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=browser_tests --single_process --gtest_filter=DownloadExtensionTest.DownloadExtensionTest_Download_DataURL

Review URL: https://chromiumcodereview.appspot.com/10703089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148927 0039d316-1c4b-4281-b951-d872f2087c98

Adds a parameter to the SyncManager::Initialize() callback to inform the
caller which sync data types were successfully loaded from disk. This
allows the SyncBackendHost and related classes make better decisions
during initialization.

If necessary, the SyncBackendHost will send a configure request to the
syncer during early initialization asking it to download the nigori
node. Now we can guarantee that the node will be available by the type
ProfileSyncService::OnBackendInitialized() is called.

The SyncBackendHost test expectations had to be amended to account for
this test. Most of the changes are related to the fact that our
behaviour no longer depends on the SyncPrefs.

The ProfileSyncService*Tests were very much affected by this change.
Those tests are parameterized with a callback that is used to initialize
the sync DB and pretend that it had been loaded from disk. Previously,
this callback would be executed later on during initialization, around
the time of ProfileSyncService::OnBackendInitialize(). That approach was
incompatible with this change, which requires that we have access to the
fully initialized database around the time we return from
SyncBackendHost::Initialize(). The callback had to be moved, which meant
that it now required an explicit UserShare parameter, which meant that a
lot of call sites had to be updated.

BUG=129825
TEST=

Review URL: https://chromiumcodereview.appspot.com/10804039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148926 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=138735


Review URL: https://chromiumcodereview.appspot.com/10834053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148925 0039d316-1c4b-4281-b951-d872f2087c98

This adds some JSON feeds and an image that'll be used by a
later change.

BUG=128805
TEST=none
TBR=satorux@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148924 0039d316-1c4b-4281-b951-d872f2087c98

There's no OOBE to skip in retail mode.
This test broke when I switched on OOBE in test images.

R=rkc@chromium.org
BUG=
TEST=
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10834041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148923 0039d316-1c4b-4281-b951-d872f2087c98

P.S. This CL is in honor of François Beaufort's birthday.

BUG=137998


Review URL: https://chromiumcodereview.appspot.com/10824074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148922 0039d316-1c4b-4281-b951-d872f2087c98

And while I'm here, clean this mess up!

BUG=133088
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10821078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148920 0039d316-1c4b-4281-b951-d872f2087c98