- 02 Oct, 2020 40 commits
-
-
Joshua Pawlicki authored
This prevents the --install process from exiting before the global service is actually available. Additionally, since we are going to call UpdateService to update the app registration anyways, this is the appropriate time to wait until its there. Bug: 1131654 Change-Id: Ifff75fafdf71a46877e9918bc26a40961703b86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441283 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813275}
-
Anastasia Helfinstein authored
This is a pure refactor with no functional change. TBR=akihiroota@chromium.org AX-Relnotes: n/a. Bug: None. Change-Id: Ic729688e78abc23769b56f6aceb0aff4201e40c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444433Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#813274}
-
Becca Hughes authored
This is a reland of af996d67 The break is fixed upstream and rolled into Chromium. TBR=calamity@chromium.org,steimel@chromium.org Original change's description: > Reland "Use JS modules for the NTP module" > > This is a reland of 7927c8a6 > > TBR=calamity@chromium.org,steimel@chromium.org > > Original change's description: > > Use JS modules for the NTP module > > > > Uses JS modules for the NTP module and updates > > closure so it can resolve chrome://kaleidoscope. > > > > Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441 > > Reviewed-by: calamity <calamity@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#811807} > > Change-Id: I348d2116dc851394804866642a24da48d25e3edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441109 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812268} Change-Id: I2c7dde07d627238c7789f21be2fecc0f49bf2e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446110Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813273}
-
Scott Violet authored
It should only call OffsetFromScrollableContainer() if the supplied LayoutObject is a scroll container. BUG=1134184 TEST=covered by clusterfuzz Change-Id: I1109a8514590882246dfebe46b7340ac654829cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442895Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813272}
-
Marijn Kruisselbrink authored
This adds use counters for the entry points to the File System Access API (https://wicg.github.io/file-system-access/) to UKM use counters to record usage of the API and observe how it is being used to help with improvements to the shape of the API. Change-Id: I31a0491771f31a14b86c6f29fff42457e1503072 Bug: 1134624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438678 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#813271}
-
Joshua Pawlicki authored
Flakiness is expected to be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2441283 If not, revert this CL. Bug: 1131654 Change-Id: Iecc0f750e62349a94df04309974147ab23f46f92 Fixed: 1131654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441380 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Jamie Madill authored
Uses the new 'use_isolated_scripts_api' feature added here: https://crrev.com/c/2425210 to switch the tests to the ANGLE standalone testing harness. Bug: angleproject:5124 Change-Id: I363997060874df09653bcb78bb9c57f3cce3f6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441149 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813269}
-
Steve Kobes authored
A subframe's PaintTimingDetector is supposed to stop recording after an input, but we were only calling NotifyInputEvent on the same-site codepath (WebViewImpl) and not the OOPIF codepath (WebFrameWidgetImpl). This also ensures that we set first_input_or_scroll_notified_timestamp in PageLoadMetrics timing updates after an OOPIF input. Bug: 1115529 Change-Id: I9599d1cc7094551b899cfa19591eeaf5c85eb88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436770Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#813268}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/02818d1fdd05..375fee944c76 2020-10-02 zzyiwei@google.com Use vndk/window.h instead of the system one If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I693c1d7442c2211dbbb7f98d1fb26a8b65b95ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813267}
-
Chris Hamilton authored
This CL implements the data structures that are needed for bookkeeping V8 contexts, and related concepts. The lifetime management of these structures is testing in isolation. A further CL will implement business logic on V8ContextTracker, and add tests for that. BUG=1085129 Change-Id: Iececc631fa38f04359ebeb823c53b641e57a4f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443490 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#813266}
-
Xiaodan Zhu authored
The M87 changes the switching desk gesture direction when reverse scrolling for touchpad is off. This CL flips gesture direction of switching desks and show a toast when reverse scrolling is off. Bug: 1107183 Change-Id: I58dc18331bc9f917a571b033b8caac63a3da95bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444438 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#813265}
-
Guillaume Jenkins authored
It appears that in some rare cases that aren't fully understood yet, old versions of intents are passed to Chrome instead of the new intents. This makes it so any new intent parameter isn't there or is of the wrong type, which can lead to crashes. This CL attempts to prevent these crashes by adding type checks and null checks for properties missing in old intent versions. Bug: 1133825 Change-Id: I55ec931ccdaf1afaf36ab31f73c405ac7c2b49b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441631Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#813264}
-
Erik Chen authored
A full test cannot be written right now because the ash instance being launched does not support attestation. The stub is a browser_test because there is no infrastructure for creating low-level crosapi integration tests. Bug: 1134349, 1134340 Change-Id: I54c47be5d2e22b0efa1dec3d130e1223bffd56a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443515 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#813263}
-
Joshua Pawlicki authored
These will be uploaded together to the signing infra. Bug: 926234 Change-Id: Ie6939d996687727db3c67be444fa8d7062b80433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443792 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I193b419c898ae177d40d57831fa4b4cebce30600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443971Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#813261}
-
Alice Wang authored
This CL refactors AccountPickerDelegateTest by moving some common part to the test setup. Bug: 1121536 Change-Id: I758ed411a0e9e91129e917d214a3ad4e0afb3e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444313Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813260}
-
ssid authored
BUG=1132511 Change-Id: Ic6d3b50b5c2cd5a7bed896d8afe6108f73ccea98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443939 Commit-Queue: ssid <ssid@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#813259}
-
Ben Joyce authored
Reduces time 56683ms from 4247ms Bug: 989569 Change-Id: I1c4a1fbeca865bbce30c3cdf769954425fd3f845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439434Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#813258}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3e40e9e1f3d..13f6549d5a10 2020-10-02 tvanderlippe@chromium.org Typecheck sources/CallStackSidebarPane.js with TypeScript 2020-10-02 jobay@google.com Typecheck quick_open/QuickOpen.js with TypeScript 2020-10-02 alexrudenko@chromium.org Migrate ScreencastView.js to TypeScript 2020-10-02 jacktfranklin@chromium.org Add text node updates to Mutation test helpers 2020-10-02 changhaohan@chromium.org TypeScriptify elements/ColorSwatchPopoverIcon.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296,chromium:1129881 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I088d68443996943c0bf5799568720c42e29f5469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445725Reviewed-by:
-
Caitlin Fischer authored
The feature was added in https://codereview.chromium.org/1294923003. Bug: 1126640 Change-Id: Ic725b63fd699f1d1ab46534e27deb2536814c582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427883Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#813256}
-
Maria Kazinova authored
Adding a check for _suggestionHandledCompletion in a block prior to calling it. Bug: 1134005 Change-Id: I8a8fae7abe4567925514bd98841d5866f70c2dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445010Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#813255}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010020800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/4PfglR4idxErCwlOi4wGGe41pnR_tcljR1Vo_Sa5OzcC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Iaacfa75bf3a4771c0ce23527843d0b2c90d7781b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445728Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813254}
-
Dave Tapuska authored
Keep the API internal on WebFrameWidgetBase but change the API to use gfx::Rect. The return value from SelectionBounds was removed since the return code was never checked. BUG=1097816 Change-Id: I0d4427eb78f646da06763fb99dc701726d73ce91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442642 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#813253}
-
Charlene Yan authored
Logging the number of tabs in a particular domain along with a rough estimate of the total number of tabs across all windows. Bug: 109917 Change-Id: I7c88cc6693b41d34b671342697b20772ef377f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441285 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813252}
-
Yunke Zhou authored
Bug: 1133679 Change-Id: Ifad8d8ae4a3bf23372b274eaa5ed776d18a64ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445171Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#813251}
-
Nina Satragno authored
Wire up the WebAuthn largeBlob extension for navigator.credentials.create. Also fix compiler warnings on files I modified (most notably use-after-move). This feature is guarded behind the WebAuthenticationLargeBlobExtension feature flag. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I8446d8d3d78b4028763080531da58d08aec2d997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441249Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#813250}
-
Antonio Gomes authored
AudioRendererSinkCache::DeleteLaterIfUnused signature was changed to take a scoped_refptr<> instead of raw pointer, which is needed by WTF::UnretainedRef(). The TODO in WebAudioDeviceFactory::GetOutputDeviceInfo() was also removed, given that other part of Blink use base::ThreadPool::CreateSequencedTaskRunner(). The relevant aspect is that the SequencedTaskRunner instance created operates iver WTF::CrossThreadBind variants. BUG=787252 R=guido@chromium.org Change-Id: If8d7453874d13599280fbe9d3c6c2cb8fc5623c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419373 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#813249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/31a694a309d3..7f2fceb9ed0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC anthonyvd@google.com,grt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: anthonyvd@google.com,grt@google.com Change-Id: I103b6ee9a8e083a35667eb612f0f22203ddd8402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445722Reviewed-by:
-
Bo Liu authored
Essentially matches the implementation in chrome. Need to enable getting the view for readback from WindowAndroid, and supply either the SurfaceView or TextureView directly (parent view will not work since Magnifier has a separate implementation for SurfaceView). Then need to disable surface control when text selection is active. Add a new allow surface control as a SurfaceData state and then go through the same request mode code. Bug: 1132448 Change-Id: I6309b83623e07b4be1a8949b1c31a304da0c3222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444531 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#813247}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/124ea2073720..af5911446cd0 2020-10-02 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-02 tcwang@google.com toolchain: Add workaround when parsing clang version. 2020-10-02 fdegros@chromium.org Remove user and group avfs 2020-10-02 rupertl@chromium.org Remove ARC++ unit tests 2020-10-02 saklein@chromium.org GetBuildDependency: Fix no sysroot case. 2020-10-01 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-01 moragues@google.com trogdor64: Add builder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: If4d61c0aa9452a893013a330a2df3f3bf7b27eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445723Reviewed-by:
-
Moe Ahmadi authored
- Removes the field trial config entry for NtpWebUIDesktop experiment. - Adjusts test expectations as needed. Feature is approved for launch in crbug.com/998352 Change-Id: I9df0ff6ed790283be85a52b928751b2c0901437a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378731 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#813245}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010020800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/V6gjYXMRLJxHGHFBf1xdXOzgqXS9c8VnXY5Dm66uN6AC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/165769056,b/165878563,b/169896133 Tbr: media-app@grotations.appspotmail.com Change-Id: I18dffaa0865a09201c80829211fcd76ec2175680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446249Reviewed-by:
-
James Cook authored
This method returns a list of the ids of displayed notifications. Later CLs will use this for two things: - To re-synchronize lacros-chrome's cached view of existing notifications after a crash (see C++ NotificationPlatformBridge GetDisplayed() method). - To integration-test the MessageCenter crosapi. Bug: 1134389 Test: added to unit_tests Change-Id: Iad877a20216c813b72c265d1b23deb1cfeed1353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445849Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#813243}
-
Gayane Petrosyan authored
Adding histograms to text fragment selector generation logic. Also adding a histogram that indicates if the origin of a link with text fragment is a known search engine. For finding out if a given url is a known search engine, I am separating template_url_prepopulate_data::GetEngineType and deps into a separate file to use it from blink/renderer/platform. Otherwise, template_url_prepopulate_data pulls deps that are also pulled by deps which somehow triggers AddressSanitizer: odr-violation(one definition rule) on some targets. See https://ci.chromium.org/p/chromium/builders/try/linux-libfuzzer-asan-rel/569669 Unit tests for histograms in in a followup. Change-Id: I9d496b883f32041b5bd612b0cf8e447cc79fa68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432674 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#813242}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I3129dd962fb4d4ab5fe4872ee21f0704f94e3f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442831 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#813241}
-
Ewann authored
This CL closes the "Close All" confirmationActionSheet when the app is running on background. Bug: 1133304 Change-Id: I20ca7342ea74c14615379f97acdcf8ba02a67fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442532 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#813240}
-
Philip Rogers authored
The value of clamped was never used and we can remove it to save some branching. Change-Id: I7f041ed5762782d0073a225e09285a6d99a5cdb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445850 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#813239}
-
adoneria authored
Bug: 1122196 Change-Id: Ic66ac3ce36019cf5936a5bdbf8d908b36bd00de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443641Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#813238}
-
Felipe Andrade authored
Fix comments in OS People Page, to avoid confusions about our Kerberos feature on ChromeOS, which only uses Kerberos tickets inside user sessions (logged on using GAIA accounts). Also, fixes HTML syntax on OS Icons file. These changes were made in preparation for upcoming changes to support Kerberos on MGS (see corresponding bug below). Bug: 983041 Change-Id: I8cac5703ef68aa1c640f390b1f85b899f78b1edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440586Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#813237}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bef393a5a340..935a915963e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I76c57cd529c79127357e0eb45f5ae7da863949c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446070Reviewed-by:
-
