GitLab

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bb0e6881e53477341891c9e3abe91e0abfbec937 Add comma to prevent unintended string concatenation (tikuta@chromium.org)
  https://crrev.com/eac0c99f5e54e20af75ce3277a42f2c31c614338 Make all the rest of the recipes explicitly specify GIT_MODE (agable@chromium.org)
  https://crrev.com/245c516049e221f79dc8cf8fe395138b782308a0 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/4b21db06e48e90335a0a1ae5d5b911b960ea0e5a Default gclient's GIT_MODE to True (agable@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2272333002
Cr-Commit-Position: refs/heads/master@{#414357}

By moving the url_formatter methods out of
org.chromium.chrome.browser.UrlUtilities to it's component, other emdedders than
Chrome can benefit from the Java version.

This CL removes the tests originally written for a Java implementation of the
methods replaced by FormatUrlForSecurityDisplay in
https://codereview.chromium.org/1357563002. It's not trivial to move the tests
over to the component as they depend on native library initialization performed
by //content which is disallowed in components/url_formatter/DEPS. Also, the
tests are redundant as the code is thoroughly tested by other means.

Currently there are no users of formatUrlForDisplay() in Chromium, but Opera
would like it exposed.

BUG=624407

Review-Url: https://codereview.chromium.org/2110543004
Cr-Commit-Position: refs/heads/master@{#414356}

The pickle protocol uses __dict__ if __getstate__ and __setstate__
aren't defined. Using __dict__ is enough for IdlArgument.

BUG=569301

Review-Url: https://codereview.chromium.org/2272283002
Cr-Commit-Position: refs/heads/master@{#414355}

BUG=640628
TBR=pthatcher@chromium.org

Review-Url: https://codereview.chromium.org/2274173002
Cr-Commit-Position: refs/heads/master@{#414354}

https://codereview.chromium.org/2110993003 implemented the filtering for empty usernames.

BUG=400674

Review-Url: https://codereview.chromium.org/2277793002
Cr-Commit-Position: refs/heads/master@{#414353}

BUG=624086,640876
TBR=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2278843002
Cr-Commit-Position: refs/heads/master@{#414352}

Revert of Add ARC++ specific fields to launch data for specific apps. (patchset #7 id:120001 of https://codereview.chromium.org/2272813003/ )

Reason for revert:
This broke compilation of ChromeOS:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/22483

Original issue's description:
> Add ARC++ specific fields to launch data for specific apps.
>
> On devices that have ARC++ available or enabled, certain internal apps need
> to be able to get this information. Currently these are limited to the
> GetHelp and the demo app.
>
> These are fields we'd like to eventually just expose to all apps but currently
> security is not comfortable with that yet, so for now, we'll set these flags
> only for the apps that currently need it.
>
> Reviews requested,
> xiyuan@ - General review.
> asargent@ - //apps and extension parts
> lhchavez@ - ARC++ parts
> sky@ - //chrome/browser/ui
>
> R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org
> BUG=640330
>
> Committed: https://crrev.com/3d97de469a486debcb8956de8f7ed679fa862cbf
> Cr-Commit-Position: refs/heads/master@{#414348}

TBR=asargent@chromium.org,lhchavez@chromium.org,sky@chromium.org,xiyuan@chromium.org,rkc@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640330

Review-Url: https://codereview.chromium.org/2276293002
Cr-Commit-Position: refs/heads/master@{#414351}

On https://codereview.chromium.org/2256653002/ it was implemented last fix to UI of change passowrd forms on Android. Since it seems no other significant problems are present from launching change password support on Android, this CL turns on change password support by default, without flag. The flag is not removed yet, just in case, if some problems will be found. It's going to be quite big CL for removing a flag and cleaning all places which depend on it, it will be done in a month, when it will be clear that everything is ok.

BUG=564674

Review-Url: https://codereview.chromium.org/2274913002
Cr-Commit-Position: refs/heads/master@{#414350}

A callsite with NotDispatchSelectEvent is updated so that it calls the
four-argument version of setSelectedRange().

This CL has no behavior changes.

BUG=640861

Review-Url: https://codereview.chromium.org/2274413003
Cr-Commit-Position: refs/heads/master@{#414349}

On devices that have ARC++ available or enabled, certain internal apps need
to be able to get this information. Currently these are limited to the
GetHelp and the demo app.

These are fields we'd like to eventually just expose to all apps but currently
security is not comfortable with that yet, so for now, we'll set these flags
only for the apps that currently need it.

Reviews requested,
xiyuan@ - General review.
asargent@ - //apps and extension parts
lhchavez@ - ARC++ parts
sky@ - //chrome/browser/ui

R=asargent@chromium.org, lhchavez@chromium.org, sky@chromium.org, xiyuan@chromium.org
BUG=640330

Review-Url: https://codereview.chromium.org/2272813003
Cr-Commit-Position: refs/heads/master@{#414348}

BUG=

Review-Url: https://codereview.chromium.org/2140103002
Cr-Commit-Position: refs/heads/master@{#414347}

This patch converts "editing/deleting/delete-all-text-in-text-field-assertion.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2276563005
Cr-Commit-Position: refs/heads/master@{#414346}

This patch converts "editing/deleting/delete-at-paragraph-boundaries-008.html"
to use w3c test harness to simplify test script and consolidates into
"delete_at_paragraph_boundaries.html", since there are similar test cases,
for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2280473004
Cr-Commit-Position: refs/heads/master@{#414345}

A constructor of PassRefPtr makes a reference be convertible to PassRefPtr,
which is not make sense and is not used.

Review-Url: https://codereview.chromium.org/2272133003
Cr-Commit-Position: refs/heads/master@{#414344}

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2255123002
Cr-Commit-Position: refs/heads/master@{#414343}

Disables the SGI_video_sync extension and assumes a
vsync interval of 59.9Hz on Linux.

Also adds an --enable-sgi-video-sync command line flag to
re-enable the extension.

Use of the extension on a thread other than the main GPU
thread is encountering issues with Chrome's sandbox for
certain combinations of Linux window managers and NVIDIA
drivers.

Before this patch, we were assuming a frequency of 60Hz
on Linux and re-aligning the phase every 5 seconds.
Since we can no longer align the phase, we assume a
frequency of 59.9 Hz. On a 60Hz monitor, this avoids
driver backpressure on the GPU thread at the cost of
skipping a frame every 10 seconds.

BUG=636644

Review-Url: https://codereview.chromium.org/2277883003
Cr-Commit-Position: refs/heads/master@{#414342}

BUG=551728
TEST=For all tests below, first open DevTools to the Security panel overview.

1) Visit google.com and check that there is a green bullet point with
   the following summary and description:
  - Secure Connection
  - The connection to this site is encrypted and authenticated using a strong protocol (QUIC), a strong key exchange (ECDHE_RSA), and a strong cipher (AES_128_GCM).

2) Visit cbc.badssl.com and check that there is a gray info bullet
   point with the following summary and description:
  - Obsolete Connection Settings
  - The connection to this site uses a strong protocol (TLS 1.2), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_256_CBC with HMAC-SHA1).

3) Visit cbc.badssl.com/mixed/script/ and check that there are two gray
   info bullet points: "Obsolete TLS cipher suite" and
   "Blocked mixed content".

4) Visit static-rsa.badssl.com and check that there is a gray info bullet point
   with the following summary and description:
  - Obsolete Connection Settings
  - The connection to this site uses a strong protocol (TLS 1.2), an obsolete key exchange (RSA), and a strong cipher (AES_256_GCM).

5) Visit https://tls-v1-0.badssl.com:1010/ and check that there is a gray info
   bullet point with the following summary and description:
  - Obsolete Connection Settings
  - The connection to this site uses an obsolete protocol (TLS 1.0), a strong key exchange (ECDHE_RSA), and an obsolete cipher (AES_128_CBC with HMAC-SHA1).

Review-Url: https://codereview.chromium.org/1727133002
Cr-Commit-Position: refs/heads/master@{#414341}

Adds total number of render calls, similar to what's logged in AudioInputSyncWriter. This makes it easier to see the proportion of glitches.

Review-Url: https://codereview.chromium.org/2270863002
Cr-Commit-Position: refs/heads/master@{#414340}

This patch converts "editing/execCommand/format-block-multiple-paragraphs-in-pre.html"
to use w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2277673002
Cr-Commit-Position: refs/heads/master@{#414339}

TBR=hiroshige@chromium.org
BUG=640886
NOTRY=true

Review-Url: https://codereview.chromium.org/2275213002
Cr-Commit-Position: refs/heads/master@{#414338}

Revert of Roll src/third_party/catapult/ 06af11370..956b57099 (2 commits). (patchset #1 id:1 of https://codereview.chromium.org/2280473003/ )

Reason for revert:
The Chromium autoroller thinks this patch failed and is trying to re-commit it. All subsequent rolls are failing to patch as a result.

Original issue's description:
> Roll src/third_party/catapult/ 06af11370..956b57099 (2 commits).
>
> https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/06af1137071d..956b570999cf
>
> $ git log 06af11370..956b57099 --date=short --no-merges --format='%ad %ae %s'
> 2016-08-24 nednguyen [tracing] Fix implementation of TTI when new nav is detected
> 2016-08-24 benjhayden Migrate sampleMetric from ScalarNumeric to Histogram
>
> BUG=630300
>
> TBR=catapult-sheriff@chromium.org
>
> Committed: https://crrev.com/0ed4e89d70b8d462237dbf592bfa8fdd990d4ecc
> Cr-Commit-Position: refs/heads/master@{#414320}

TBR=catapult-sheriff@chromium.org,catapult-deps-roller@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630300

Review-Url: https://codereview.chromium.org/2281433002
Cr-Commit-Position: refs/heads/master@{#414337}

This CL...

1) introduces ThreadState enum that represents a state of the worker thread,
2) stops accessing |m_globalScope| from the main thread for detecting worker
   thread initialization and instead checks ThreadState,
3) renames |m_started| and |m_terminated| with |m_requestedToStart| and
   |m_requestedToTerminate| in order to emphasize that these fields represent
   not a state of the worker thread but facts that the worker thread has been
   requested to start/terminate from the main thread, and
4) removes mention of |m_microtaskRunner| from a comment about
   |m_threadStateMutex| because the member is accessed only from the worker
   thread.

BUG=638877, 640843

Review-Url: https://codereview.chromium.org/2268183005
Cr-Commit-Position: refs/heads/master@{#414336}

R=davidcadrian@gmail.com
TBR=palmer@chromium.org
BUG=638031, 639031, 638953

Review URL: https://codereview.chromium.org/2129543003 .

Cr-Commit-Position: refs/heads/master@{#414335}

The CL adds a new wayland request 'pin_with_trusted_flag' that replaces the
existing request 'pin'. The new request takes a trusted flag so that trusted
apps can be allowed to enforce users to stay in pinned mode.

The CL also adds new window state 'trusted_pinned' which will be used in further implementation to specify pinned state invoked by trusted apps.

BUG=b/29325086
TEST=None

Review-Url: https://codereview.chromium.org/2276443002
Cr-Commit-Position: refs/heads/master@{#414334}

This patch cleans up the two overloads of the function as follows:

SpellChecker::isSpellCheckingEnabledFor(const VisibleSelection&) is changed
into a static function in SpellChecker.cpp since it does not have call site
outside SpellChecker.

SpellChecker::isSpellCheckingEnabledFor(const Node*) is absorbed by is wrapper
SpellChecker::isSpellCheckingEnabledInFocusedNode().

BUG=n/a
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2273253002
Cr-Commit-Position: refs/heads/master@{#414333}

Currently, V4L2VEA assumes that the first H264 bitstream buffer coming from
the hardware encoder will contain exactly an SPS+PPS pair. It then caches
that buffer and prepends its contents before each keyframe. It also uses it
for the remainder of the session, even if additional/new SPS+PPS pairs are
provided later on.

However, the first buffer may contain additional NALUs, and only SPS+PPS
should be extracted and used. Moreover, the SPS+PPS pair may change later
on. Finally, some hardware encoders may support prepending each IDR with
the header, without the need for V4L2VEA to handle this.

This CL adds support for the V4L2_CID_MPEG_VIDEO_H264_SPS_PPS_BEFORE_IDR
V4L2 control, which instructs the HW encoder to inject SPS+PPS pair before
each IDR in the stream. If that control is supported, we do not have to
inject the header ourselves.

If the control is not supported, we need to keep injecting, however -
instead of making the above assumptions - we parse the stream, cache the
latest SPS and PPS, and inject them before any found IDR, if possible.

The VEA unittest is also modified, to verify that the stream includes an
SPS+PPS pair before each IDR.

Also, remove usage of linked_ptr for clearer ownership management of
buffers.

BUG=639238
TEST=veatest on various ARM platforms

Review-Url: https://codereview.chromium.org/2274493002
Cr-Commit-Position: refs/heads/master@{#414332}

Add spellcheck functionality to webview. Spellchecking
feature will be enabled if the kEnableAndroidSpellChecker
flag is present.

Historical note:
Blink used to have unified_textchecker_enabled setting
which was false by default in android webview and
needed to be enabled in order for spellchecking to work.
It was recently removed in
https://codereview.chromium.org/2235643002/ though.

BUG=583616, 629609

Review-Url: https://codereview.chromium.org/2264633002
Cr-Commit-Position: refs/heads/master@{#414331}

The size of the list can be read from the m_values vector, no need to
store the size separately.

Review-Url: https://codereview.chromium.org/2273233002
Cr-Commit-Position: refs/heads/master@{#414330}

When the IME refreshes, we need to update the view of the list in IME menu.
Saves the created ImeListView and updates it when get IME refreshing event.
Add ImeMenuTrayTest.RefreshImeWithListViewCreated test.

BUG=640432
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2271483003
Cr-Commit-Position: refs/heads/master@{#414329}

SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar() does not really need
a TextCheckingParagraph as its parameter; an EphemeralRange of text to check is
sufficient.

Hence, this patch changes its parameter from a TextCheckingParagraph to an
EphemeralRange, simplifying code and improving performance by eliminating the
overhead for finding the paragraph containing the text to be checked.

BUG=n/a
TEST=n/a; no visible change

Review-Url: https://codereview.chromium.org/2273453003
Cr-Commit-Position: refs/heads/master@{#414328}

This patch converts "editing/execCommand/indent-empty-root.html" to use w3c test
harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2264283004
Cr-Commit-Position: refs/heads/master@{#414327}

The spec was changed for discussion at github issue:
https://github.com/w3c/webcomponents/issues/548

BUG=640236

Review-Url: https://codereview.chromium.org/2277713002
Cr-Commit-Position: refs/heads/master@{#414326}

Currently the BlimpCompositor is the compositor that owns the
cc::Display and delegated frames from it are directed to the display
by the BlimpDelegatingOutputSurface. The lifetime of the display and
the surfaces system is tied to the lifetime of the cc::OutputSurface,
which is tied to the lifetime of the native widget.

This diverges from the behavior expected when Blimp is embedded in
Clank, which owns the Surfaces system and holds the UI compositor,
which is the parent compositor that will embed content from the
BlimpCompositor.

This patch adds a BrowserCompositor to the blimp app, which performs
the work of the UI compositor in Chrome. This ensures that Blimp always
shares its content using a cc::SurfaceLayer, and the embedder is
expected to own the cc::Surfaces system and push this content to the
cc::Display.

BUG=639950

Review-Url: https://codereview.chromium.org/2266863003
Cr-Commit-Position: refs/heads/master@{#414325}

The Swiftshader component is 32-bit only and doesn't work there
(though it shouldn't really hurt to have it around).

Review-Url: https://codereview.chromium.org/2273703004
Cr-Commit-Position: refs/heads/master@{#414324}

BUG=639145
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2277603005
Cr-Commit-Position: refs/heads/master@{#414323}

BUG=314403

Review-Url: https://codereview.chromium.org/2278813002
Cr-Commit-Position: refs/heads/master@{#414322}

When there is no download item available, there should be a View telling
the user that the list is empty. Currently the download manger ui only
shows a blank screen if there are no items. This CL fixes this.

BUG=616324

Review-Url: https://codereview.chromium.org/2270233003
Cr-Commit-Position: refs/heads/master@{#414321}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/06af1137071d..956b570999cf

$ git log 06af11370..956b57099 --date=short --no-merges --format='%ad %ae %s'
2016-08-24 nednguyen [tracing] Fix implementation of TTI when new nav is detected
2016-08-24 benjhayden Migrate sampleMetric from ScalarNumeric to Histogram

BUG=630300

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2280473003
Cr-Commit-Position: refs/heads/master@{#414320}

BUG=638394

Review-Url: https://codereview.chromium.org/2274003002
Cr-Commit-Position: refs/heads/master@{#414319}

BUG=640734

Review-Url: https://codereview.chromium.org/2272863004
Cr-Commit-Position: refs/heads/master@{#414318}