- 15 Feb, 2018 40 commits
-
-
David Bokan authored
This test started failing as a result of turning on --root-layer-scrolls. This flag is now on in ToT so this CL disables the test to get the waterfall green while a fix is landed. TBR=dgozman@chromium.org, skobes@chromium.org Bug: 811406 Change-Id: I6fe244ffa4953ac51e145d9073e0134a6aaa3d68 Reviewed-on: https://chromium-review.googlesource.com/920886 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#536996}
-
Tim Schumann authored
TBR=alph Bug: 812417 Change-Id: I620e5cf3455b0d40efe1044820cece66e202c670 Reviewed-on: https://chromium-review.googlesource.com/921225Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#536995}
-
Matthew Cary authored
Checking for the parse histogram is causing flakes for PrerenderBrowserTest.PageLoadMetricsPrerender. I don't know what's causing it to flake, but it is definitely hanging in the ParseStartMetricsWaiter. As (1) prerender is deprecated and being removed, and (2) this histogram check was a subtle way to verify prerender behavior and so not necessarily reliable anyway, it seems most expedient to remove it and keep the bots green. Bug: 812158 Change-Id: I334a81fd554fdec7eef4567e662194e45fc012fe Reviewed-on: https://chromium-review.googlesource.com/918664Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#536994}
-
Michael Lippautz authored
Remove ScriptString which is a scoped object keeping a strong handle. Using wrapper tracing implies that the retaining path for DevTools shows up properly. Bug: chromium:810194 Change-Id: Ia5126fdca8d270a9f5700af335735210e4062d61 Reviewed-on: https://chromium-review.googlesource.com/911969 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#536993}
-
Harald Alvestrand authored
This exposes counters for what kind of SDP semantic is requested and used to UMA. Part of the WebRTC transition to Unified Plan. Bug: chromium:811683 Change-Id: Idd306454e9ca2424612dc2fe5196e1ee77539df2 Reviewed-on: https://chromium-review.googlesource.com/918502Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#536992}
-
Maxim Kolosovskiy authored
|render_frame()| may be null. So, |PasswordAutofillAgent::GetPasswordFormFromUnownedInputElements| may crash. See the bug for details. Bug: 808366 Change-Id: If1e53e5bd11305cdafba165aff755d6f6f88075c Reviewed-on: https://chromium-review.googlesource.com/921122Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#536991}
-
Gabriel Charette authored
This reverts commit 2453e479. Reason for revert: causing MSAN failures on https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests [ RUN ] NavigationControllerTest.PurgeScreenshot ==7007==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x8a3a26f in round ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:462:41 #1 0x8a3a26f in to_unorm ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:905:0 #2 0x8a3a26f in store_a8_k ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:1584:0 #3 0x8a3a26f in sk_store_a8 ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:1581:0 #4 0x8a234d9 in sk_start_pipeline ./../../third_party/skia/src/jumper/SkJumper_stages.cpp:755:13 #5 0x86a6c88 in operator() ./../../buildtools/third_party/libc++/trunk/include/functional:1916:12 #6 0x86a6c88 in SkRasterPipelineBlitter::blitRect(int, int, int, int) ./../../third_party/skia/src/core/SkRasterPipelineBlitter.cpp:352:0 #7 0x873337f in blitrect ./../../third_party/skia/src/core/SkScan.cpp:25:14 #8 0x873337f in SkScan::FillIRect(SkIRect const&, SkRegion const*, SkBlitter*) ./../../third_party/skia/src/core/SkScan.cpp:36:0 #9 0x873497d in FillRect ./../../third_party/skia/src/core/SkScan.cpp:71:5 #10 0x873497d in SkScan::FillRect(SkRect const&, SkRasterClip const&, SkBlitter*) ./../../third_party/skia/src/core/SkScan.cpp:113:0 #11 0x849775d in SkDraw::drawRect(SkRect const&, SkPaint const&, SkMatrix const*, SkRect const*) const ./../../third_party/skia/src/core/SkDraw.cpp:814:21 #12 0x849ee7b in SkDraw::drawBitmap(SkBitmap const&, SkMatrix const&, SkRect const*, SkPaint const&) const ./../../third_party/skia/src/core/SkDraw.h:0:15 #13 0x836e327 in SkBitmapDevice::drawBitmap(SkBitmap const&, float, float, SkPaint const&) ./../../third_party/skia/src/core/SkBitmapDevice.cpp:233:18 #14 0x83fb1fe in SkCanvas::onDrawBitmap(SkBitmap const&, float, float, SkPaint const*) ./../../third_party/skia/src/core/SkCanvas.cpp:2309:27 #15 0x83ea9fa in SkCanvas::drawBitmap(SkBitmap const&, float, float, SkPaint const*) ./../../third_party/skia/src/core/SkCanvas.cpp:1837:11 #16 0xd832b25 in content::ScreenshotData::EncodeOnWorker(SkBitmap const&) ./../../content/browser/frame_host/navigation_entry_screenshot_manager.cc:60:14 #17 0x1151efaf in Run ./../../base/callback.h:65:12 #18 0x1151efaf in base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() ./../../base/threading/post_task_and_reply_impl.cc:45:0 #19 0x1132685a in Run ./../../base/callback.h:65:12 #20 0x1132685a in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:55:0 #21 0x114ee940 in base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker.cc:441:23 #22 0x114f5b30 in base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker_posix.cc:25:16 #23 0xf099880 in base::test::ScopedTaskEnvironment::TestTaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/test/scoped_task_environment.cc:280:49 #24 0x114ec1e0 in base::internal::TaskTracker::RunNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) ./../../base/task_scheduler/task_tracker.cc:343:3 #25 0x114dece1 in base::internal::SchedulerWorker::Thread::ThreadMain() ./../../base/task_scheduler/scheduler_worker.cc:81:41 #26 0x1151e887 in base::(anonymous namespace)::ThreadFunc(void*) ./../../base/threading/platform_thread_posix.cc:75:13 #27 0x7fe34df7e183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312:0 #28 0x7fe346aceffc in clone /build/eglibc-SvCtMH/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111:0 Uninitialized value was created by a heap allocation #0 0x16e48ed in __interceptor_malloc /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:944:3 #1 0x11448cb9 in base::UncheckedMalloc(unsigned long, void**) ./../../base/process/memory_linux.cc:105:13 #2 0xfeb9235 in malloc_nothrow ./../../skia/ext/SkMemory_new_handler.cpp:76:19 #3 0xfeb9235 in sk_malloc_flags(unsigned long, unsigned int) ./../../skia/ext/SkMemory_new_handler.cpp:115:0 #4 0x853330b in sk_malloc_canfail ./../../third_party/skia/include/private/SkMalloc.h:93:12 #5 0x853330b in MakeUsing ./../../third_party/skia/src/core/SkMallocPixelRef.cpp:76:0 #6 0x853330b in SkMallocPixelRef::MakeAllocate(SkImageInfo const&, unsigned long) ./../../third_party/skia/src/core/SkMallocPixelRef.cpp:86:0 #7 0x835ead5 in SkBitmap::tryAllocPixels(SkImageInfo const&, unsigned long) ./../../third_party/skia/src/core/SkBitmap.cpp:235:28 #8 0xd8328df in tryAllocPixels ./../../third_party/skia/include/core/SkBitmap.h:517:22 #9 0xd8328df in content::ScreenshotData::EncodeOnWorker(SkBitmap const&) ./../../content/browser/frame_host/navigation_entry_screenshot_manager.cc:55:0 #10 0x1151efaf in Run ./../../base/callback.h:65:12 #11 0x1151efaf in base::(anonymous namespace)::PostTaskAndReplyRelay::RunTaskAndPostReply() ./../../base/threading/post_task_and_reply_impl.cc:45:0 #12 0x1132685a in Run ./../../base/callback.h:65:12 #13 0x1132685a in base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) ./../../base/debug/task_annotator.cc:55:0 #14 0x114ee940 in base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker.cc:441:23 #15 0x114f5b30 in base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/task_scheduler/task_tracker_posix.cc:25:16 #16 0xf099880 in base::test::ScopedTaskEnvironment::TestTaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) ./../../base/test/scoped_task_environment.cc:280:49 #17 0x114ec1e0 in base::internal::TaskTracker::RunNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) ./../../base/task_scheduler/task_tracker.cc:343:3 #18 0x114dece1 in base::internal::SchedulerWorker::Thread::ThreadMain() ./../../base/task_scheduler/scheduler_worker.cc:81:41 #19 0x1151e887 in base::(anonymous namespace)::ThreadFunc(void*) ./../../base/threading/platform_thread_posix.cc:75:13 #20 0x7fe34df7e183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312:0 Original change's description: > Move grayscale conversion into NavigationEntryScreenshotManager. > > Changes the location of the RGB→Grayscale conversion of the > CopyFromSurface() result SkBitmap to be in > NavigationEntryScreenshotManager, as it is the only use case. This > unblocks a massive clean-up effort for bug 759310. > > For reference, the following was the code that was doing the conversion > before (and is a part of a major chunk of code that we want to delete): > https://cs.chromium.org/chromium/src/content/browser/compositor/surface_utils.cc?rcl=2fe7073e23caa42cbd01575ab206ba8928ccd645&l=146 > > Bug: 759310 > Change-Id: I2687e69b284d5c24ead10b05b49f678cf8375651 > Reviewed-on: https://chromium-review.googlesource.com/919603 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536929} TBR=miu@chromium.org,nick@chromium.org Change-Id: I3de0c04ca25b20ed2322f76834d19e7a7fae4737 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 759310 Reviewed-on: https://chromium-review.googlesource.com/921243Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#536990}
-
Yutaka Hirano authored
This change adds an extra limit on the number of requests initiated by fetch() with keepalive set. Bug: 764589 Change-Id: Id030f46fadceebb07b606824c420dab5f1791472 Reviewed-on: https://chromium-review.googlesource.com/895218 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Cr-Commit-Position: refs/heads/master@{#536989}
-
Dale Curtis authored
This reverts commit b0ec93f6. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=812423 Original change's description: > Remove kHaveFutureData restriction from play state notifications. > > This reland marks media-src-suspend-after-have-future-data and > media-src-suspend-after-have-metadata as SlowTest(s) now that they no > longer permanently time out. Each takes ~2ish seconds in release build > and so meets the criteria for being a SlowTest. > > This also changes WMPI to not try and get the current time value prior > to the HaveCurrentData state (which Blink already respects). > > ========= [ Original Description Follows ] =============== > > HTMLMediaElement should tell WebMediaPlayer about play state changes > as soon as the kHaveMetaData state is reached. > > This will eventually allow us to delete a bunch of guessing-game type > code for idle suspension and instead rely on actually getting a play() > call from Blink to wake up when needed. > > We can't stop WMPI from reaching the future data state quite yet though, > because it has implications on the delivery of 'canplay' and 'canplaythrough' > events that need to be part of a larger preload=metadata experiment. See old > discussion on this here: > > https://lists.w3.org/Archives/Public/public-whatwg-archive/2015Jul/0007.html > > Note: This change exposed some bugs in how the ready state maximum is used > and the states at which a video frame is expected. These issues are fixed > in the HTMLVideoElement. > > BUG=694855, 756897, 809998 > TEST=existing suspend tests no longer flake. > > Change-Id: Ie6297df474c1f5da56ca6c0e81efa636fbc349bf > Reviewed-on: https://chromium-review.googlesource.com/915081 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536487} TBR=dalecurtis@chromium.org,mlamouri@chromium.org,liberato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 694855, 756897, 809998 Change-Id: I176b5116682851853ff2773e6e4a77a9ac2664b2 Reviewed-on: https://chromium-review.googlesource.com/920481Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#536988}
-
Daniel Bratell authored
Recent additions created duplicate symbols in content/browser of the variable g_url_loader_factory_callback_for_test and of the method BlobStorageContextGetter. BlobStorageContextGetter is a duplicate method but small enough that it's probably ok. This renames one BlobStorageContextGetter to BlobStorageContextGetterForStorage (lacking a suitable place for sharing the method) and one of the g_url_loader_factory_callback_for_test variables to g_create_network_factory_callback_for_test to better describe what it contains. These errors don't appear in the jumbo configurations covered by the bots because the files are far enough apart in file lists to normally not be grouped with each other. Change-Id: I17ecc36d2271c71f6b7affcc41ef4935b107743f Reviewed-on: https://chromium-review.googlesource.com/915367 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536987}
-
Marc Treib authored
Followup to https://crrev.com/c/899004. This removes a bunch of helper functions that I missed the first time around, and deprecates the proto fields. attachments.proto itself is not removed yet. Bug: 758319 Change-Id: Ie3eb5db0ce39c48e38ac1244f77c05a0515df714 Reviewed-on: https://chromium-review.googlesource.com/919081 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#536986}
-
Pavol Marko authored
Extend the enterprise.deviceAttributes API to provide the device serial number, the administrator-annotated Asset ID and the administrator-set annotated location. The new functions are only available to force-installed extensions running in an affiliated user profile. API proposal: https://docs.google.com/a/chromium.org/document/d/1NDt1enxSbKrbwo-BH4qgCbg2M5EWB6igkpe1le0Egk0 Bug: 803974 Test: browser_tests --gtest_filter=*EnterpriseDeviceAttributes* Change-Id: I48b3e070a953efe01491e8b9de2700758e158d26 Reviewed-on: https://chromium-review.googlesource.com/876365 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#536985}
-
Takayoshi Kochi authored
This is a reland of 0b952628. The original CL was once reverted due to potential cause for Mac bot's flakiness: crbug.com/805383 Original change's description: > Remove dead code after multiple shadow removal [5/5] > > Remove window.internals.{youngest/oldest/younger}ShadowRoot > Adjust layout tests. > > Bug: 795221 > Change-Id: I75024668007771c87ddd9598fbd1728859d7f9e9 > Reviewed-on: https://chromium-review.googlesource.com/831815 > Commit-Queue: Takayoshi Kochi <kochi@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531490} Bug: 795221 Change-Id: I854ed889f811f3768ac95653b74ddd3f30ce6b5a Reviewed-on: https://chromium-review.googlesource.com/919923Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536984}
-
Mikel Astiz authored
This makes SessionsSyncManager smaller, which I believe justifies the change. But actually, it is motivated by upcoming changes in sessions sync code, where a new implementation will be introduced for USS. We anticipate the need for the very same logic to track global ID mappings for user events. Bug: 681921 Change-Id: I0dcd1858c602a2cc167ca3ac0e2e9d55d072c291 Reviewed-on: https://chromium-review.googlesource.com/916763 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The enum got exposed in the API in some of the functions and ModelError was used in others. The original rationale to introduce this Result enum no longer holds true and we don't actually treat the values differently, so let's make the API more homogeneous by always adopting ModelError as the standard way to report error cases. Change-Id: I6b07d7fec618a44abc776250dfbf70db1a598941 Reviewed-on: https://chromium-review.googlesource.com/907569Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#536982}
-
Kent Tamura authored
The name is redundant. - There are no non-'Raw' version of the function any longer. - 'Foo' is repeated. - 'Element' is repeated So the function name should be just 'Create.' This CL has no behavior changes. Change-Id: I5635a39e987dddbdb122bb68958278bab6f852f3 Reviewed-on: https://chromium-review.googlesource.com/920722Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#536981}
-
Naoki Fukino authored
Due to a Chrome policy change, autoplaying videos does not work in quick view. Instead, we introduce muted autoplay to help users preview video files. Bug: 804273 Test: Manually tested. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I07768b04ff3994f53811d22fd33613291dd5b896 Reviewed-on: https://chromium-review.googlesource.com/920049Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#536980}
-
Christos Froussios authored
The reauth challenge mentions "showing" a password. This does not correctly describe the intention of exporting the passwords. I introduced an enum for the purpose of the reauth and made the authentication util select the appropriate messaging according to the purpose. Bug: 789561 Change-Id: I64e50f49bb87b41db3dbbfe7e3be50f9395f0985 Reviewed-on: https://chromium-review.googlesource.com/916606 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#536979}
-
Daniel Bratell authored
People put lots of files in gn's sources lists. Rather than being upset, jumbo should just live with it. They do no harm and can be safely ignored. Change-Id: I15c3930cfeb50e5bd7ce121ca7b7c17db088b63f Reviewed-on: https://chromium-review.googlesource.com/916246Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#536978}
-
Harald Alvestrand authored
The test was failing because passing a null ("end of candidates") candidate to addIceCandidate is not permitted. Spec link: https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-addicecandidate https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addicecandidate Bug: none Change-Id: I1f22d27393a482a882ebe9735488d8cb723b6e75 Reviewed-on: https://chromium-review.googlesource.com/918662Reviewed-by: -
https://chromium.googlesource.com/angle/angle.git/+log/f3803d4f74a5..710aa5c7040b $ git log f3803d4f7..710aa5c70 --date=short --no-merges --format='%ad %ae %s' 2018-02-08 lfy GLES1: Mat4 transform library Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: If83ba652e14b38c50582f529e2246d8208e8ef9f Reviewed-on: https://chromium-review.googlesource.com/920750Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536976}
-
Kent Tamura authored
<template>'s extra cloning step [1] needs "clone children flag." So this CL adds it to CloneDataFromElement() and CopyNonAttributePropertiesFromElement(). This CL has no behavior changes. [1] https://html.spec.whatwg.org/multipage/scripting.html#the-template-element:concept-node-clone-ext Bug: 812089 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: If87da26b9ef46f18d69129ee5b956159d392c471 Reviewed-on: https://chromium-review.googlesource.com/920942Reviewed-by:
-
Hikaru Nishida authored
This patch removes declaration of RootEditableElementOf which is not used at all and has no definition to improve readability. TEST: No change in behavior. Change-Id: I0dd1fce23a2cad0939e205bc67ef61ea2540f104 Reviewed-on: https://chromium-review.googlesource.com/920567Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Christos Froussios authored
The "busy exporting" dialog is shown for at least 2 seconds, to avoid flashing when exporting happens fast. We reduce this time to 1 seconds, as suggested by UX. Bug: 789561 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibeb1c3736d914ee1d83814dfdc9d3a902fed1796 Reviewed-on: https://chromium-review.googlesource.com/918562Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#536973}
-
Yuichiro Hanada authored
To use the same value as used in Android side. Bug: 807545 Test: Manual on a device. Added unit tests. Change-Id: I04c54e047884a42b019e2d1de69343ce2b89ce60 Reviewed-on: https://chromium-review.googlesource.com/895127 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Cr-Commit-Position: refs/heads/master@{#536972}
-
Mostyn Bramley-Moore authored
Fixes jumbo builds after https://chromium-review.googlesource.com/c/chromium/src/+/919199 Change-Id: I350604ae19b68859b622568b0d1ac78b223900a5 Reviewed-on: https://chromium-review.googlesource.com/920982Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#536971}
-
Xiaocheng Hu authored
This patch allows dumping LayoutObject to ostream to ease debugging. Change-Id: I4cf438808b503503ad12055dac6610d2c794739c Reviewed-on: https://chromium-review.googlesource.com/920884Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
Currently, TranslateHelper caputres page innerText to decide the page language. The text capturing is done in RenderFrame::DidMeaningfulLayout(), in which we normally have the clean layout, which is necessary for computing innerText. However, due to some layout bug [1], we don't always have clean layout at the call site. As fixing the layout bug is hard, this patch changes the text capture algorithm to return a string similar to textContent [2] instead, which doesn't require clean layout. The difference between the new and old text capture is subtle: - textContent may include invisible text nodes, while innerText never does that. However, this patch uses a slightly modified textContent that doesn't include text nodes in STYLE or SCRIPT elements. Other invisible text may still be included. - textContent is a simple concatenation of all text nodes. innerText does some "formatting" by inserting/deleting some whitespace characters, including: - Insertion of '\n' between blocks of text (e.g., between <div>) - Insertion of '\t' between table cells - This patch uses a custom dump algorithm that still collapses consecutive whitespaces; however, the collapsing happens regardless of style [1] crbug.com/803403 and crbug.com/585164. The crash happens in the wild, but we haven't even found a stable repro case yet. Bug: 803403 Change-Id: I7e108d368cbcaccbbb60582323a9e9e041d95269 Reviewed-on: https://chromium-review.googlesource.com/891582Reviewed-by:Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#536969}
-
Peter Kasting authored
The ownership wrappers (Owned, Passed, etc.) move from bind_helpers.h to bind.h. Most other content of bind_helpers.h was really only necessary to implement the code in bind_internals.h, and moves there. BUG=717138 TEST=none TBR=jri Change-Id: Ib6d468e58930529dbee587d331b177b93da2f13a Reviewed-on: https://chromium-review.googlesource.com/915282 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Jana Iyengar <jri@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#536968}
-
Yutaka Hirano authored
Requests with keepalive set (including requests initiated by sendBeacon()) are leaky by design; they are kept alive even when the frame is detached. This change makes it explicit in LeakExpectations. Bug: 755625 Change-Id: I9c708e7f492bb2859bad007faa201e79517f03a2 Reviewed-on: https://chromium-review.googlesource.com/920123 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536967}
-
Naina Raisinghani authored
We used to have some inline style map layout tests for a subset of properties. This patch moves them to WPT using the new test harness. Properties added: - white-space - vertical-align - visibility - z-index Bug: 774887 Change-Id: Icce056c4d7f56eed3da05834b1c561fddec53a15 Reviewed-on: https://chromium-review.googlesource.com/918203 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536966}
-
Gauthier Ambard authored
This CL adds Earl Grey tests for the adaptive toolbar, testing the different buttons displayed in the toolbars. Bug: 804726 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If878383cfe8847bddaab251716680bd1d1f9ac6b Reviewed-on: https://chromium-review.googlesource.com/915347 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
We should implement operator(ostream, Node) with Node::ToString(), but are doing the reverse way. This patch swaps their implementation to make the implementation order correct. Change-Id: Ifeea2608b2e94758de1e82ea39dbe6d6155dcdd1 Reviewed-on: https://chromium-review.googlesource.com/920776 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Ken Rockot authored
Wires up URLLoaderFactory proxying support for content embedders and uses this in Chrome to hook in a proxying URLLoaderFactory implementation provided by the WebRequest API implementation. This provides basic support for *non-blocking* WebRequest event listeners, satisfying a subset of practical use cases. Some new browser_tests pass as a result. Bug: 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I9f15d474fc952deddd1c8fe422065b5b63249a1c Reviewed-on: https://chromium-review.googlesource.com/911872 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#536963}
-
Patti authored
When positioning its internal ImageSkia for painting, CENTER-aligned ImageViews currently assume that any insets it may have are symmetrical (i.e. the left and right or top and bottom insets are the same value). This causes the image to be drawn in the incorrect position (e.g. it may cross the boundaries set by the ImageView insets) when the insets are not symmetrical. Fix by accounting for the inset width and height during positioning. Bug: 801583 Change-Id: I65766fbea4c088ca45781a6a69cbae7b52178625 Reviewed-on: https://chromium-review.googlesource.com/917843 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#536962}
-
Gauthier Ambard authored
This CL adds an util to know when the toolbar is split. Bug: 804748 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7d6accb32de848ff2b3e0ff8aef68d7c278aeb9a Reviewed-on: https://chromium-review.googlesource.com/916194Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#536961}
-
Koji Ishii authored
Following bot results are included. 3759 3760 3761 3763 3770 50 lines were removed and 72 lines were deflaked by consecutive results since 3723. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ifce72d0c37323b2fcd22713b5e8e1414493967a7 Reviewed-on: https://chromium-review.googlesource.com/919641 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Christopher Cameron authored
It is necessary to be precise about the ScreenInfo that is to be sent to a RenderWidget, because failing to be consistent will result in violations of surface invarients (size and scale factor of the surface). The RenderWidgetHostView is the source of truth about the surface id and size, but it is not consistently the source of truth about the device scale factor. The device scale factor comes from the ScreenInfo which comes from RenderWidgetHostDelegate->WebContentsImpl->WebContentsView, which may or may not match the RenderWidgetHostView surface info. Remove the GetScreenInfo method from WebContents and WebContentsView, and restore RenderWidgetHostView as the one true source of ScreenInfo. Bug: 805774 Change-Id: Id0d962a49ceb9ad91de783faf3fb1215c1333083 Reviewed-on: https://chromium-review.googlesource.com/917202Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#536959}
-
Kunihiko Sakamoto authored
This introduces LinkLoadParameters, which is a parameter object for LinkLoader::LoadLink() and groups the parameters originated from a <link> element or a Link: header. Pure refactoring, no behavioral changes. Change-Id: I32c86f5b7097f3f0540ae84906614ff8d30199ee Reviewed-on: https://chromium-review.googlesource.com/918224Reviewed-by:
-
wutao authored
Overview mode is one of the complex areas for improving animation speed. This cl implements a new proposal to tone down the animations. Changes: 1. Enter animation: only animate currently visible windows and put the rest of the windows in place. 2. Exit animation: animate all of the Most Recently Used (MRU) windows up to and including the MRU maximized/fullscreen window, with the other windows behind not moving until the maximized/fullscreen window finishes animation. Bug: 801465, 795988 Test: Tested new animations in different modes: normal, tablet, and splitview. Change-Id: Ia7046c670bb484447752b8e5545fa81e981256d2 Reviewed-on: https://chromium-review.googlesource.com/882008 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#536957}
-
