- 17 Dec, 2020 40 commits
-
-
Rachel Wong authored
UMA logging checks that enum values are strictly less than the specified max value. Bug: 1159285 Change-Id: I94b12b272c51d3c73285446807ab5aa57b07d9b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596729 Commit-Queue: Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#837935}
-
Luciano Pacheco authored
Generate JS modules for: //ui/file_manager/externs/background/import_history.js //ui/file_manager/file_manager/background/js/import_history.js //ui/file_manager/file_manager/background/js/test_import_history.js Because Closure doesn't deal well importing the same namespace from different files, I started splitting the "importer" namespace so each file will have its own namespace. Files in the "externs" directory will have the suffix "Interface" on their namespace. I'll use this logic for all files related to "importer" namespace. Bug: 1133186 Change-Id: Iec2851ea28cdf8b4b079a997e74d99b2dfbf92f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592854 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837934}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72c5b04f..ee505470 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I26ad972495a951ddf3ddafb30436331e99d282dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596064Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837933}
-
Azeem Arshad authored
This CL adds search tags for all nearby share settings except high visibility toggle which will be added in a follow up CL. Screenshots: http://screen/7ivEuHq5iZZGnhh.png http://screen/8k9mkJdoxknCQ3J.png http://screen/3NanmU9yZfJiPuy.png http://screen/3sELmriX9NPpqpy.png http://screen/AdkakugUwh548Qm.png Bug: 1158648 Change-Id: I5f7cc7132f5573a5f3bfb31012fa659e155278c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594647 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837932}
-
Wei Lee authored
This CL tweaks the logic in CameraAppDeviceImpl a bit to make sure the calls which need to be run on Mojo thread actually run on it. Bug: b/175185495 Test: Manually Change-Id: I2480d43fec56667741cb096f39f1a189e0326757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592182Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#837931}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I915f3519867095c9b06177124122e1e8b1e7eebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596430Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837930}
-
tby authored
There are some edge cases where we still show duplicate results. Until we remove the old logic that does this, we should continue de-duping. Bug: 1156846 Change-Id: I4366467ebf645c3b957bea6916be90be71bbcdc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596456 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837929}
-
Richard Li authored
Some latest Intel platforms(Icelake, Tigerlake) support two yuv MPO planes. This CL add a workaround to promote two video quads to overlays on Intel platforms. Previous test has showed this will benefit power consumption when playing two videos simultaneously. Bug: 1105618 Change-Id: I5fc44a5064d371a2fdad97dc63068c328ed55a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592629Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#837928}
-
Rafael Cintron authored
This CL establishes a connection between the XR and GPU processes when the XR process gets created for the OpenXR runtime. Context lost callbacks from viz::ContextProvider are handled by recreating the GPU process connection. A future change will use the connection to open a shared image for the WebXR backbuffer. The shared image will allow the GPU process to render directly into the XR backbuffer and avoid the copy + flip operation we perform today. Bug: 1131616 Change-Id: I46262927ce116f043c04828bed0299537f250e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567411 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#837927}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Ibf708111708cca3df426ef80421e3421c3d68a7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593801 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Removes expectations for the screenshot_sync suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 599776, 639489, 978492, 648369, 986939 Bug: 1006045, 1155766 Change-Id: I00b3aec492004c9bbb474d42667fcde5fb51b976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593970Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837925}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/508bcddc99e4..85d4952bb4fa 2020-12-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic9c61e93302228a7571b980cbc64de70e5d889ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596877Reviewed-by:
-
Xiaocheng Hu authored
The computed value of list-style-type should always be tree-scoped, so this patch marks the non-tree-scoped version not-reached for sanity. Bug: 687225 Change-Id: I06e671caf4dced6a92cba90ad6e585aa1c0df2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596032 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#837923}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba158b9daf08..7839f66540b6 2020-12-17 michaelludwig@google.com Reland "Rename getTopDevice/getDevice to topDevice/baseDevice" 2020-12-17 herb@google.com extract fibonacci allocator block code 2020-12-16 brianosman@google.com SkSL IR normalization: Convert while loops to for loops If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ie21fd60324763cc1ac45bfcdec8cf48a0d2f23c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596431Reviewed-by:
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.121. TBR=sky@chromium.org Bug: 1041619 Change-Id: I167b3eb99bebc9c6a30005e9e6746967605eccf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596824 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#837921}
-
Luciano Pacheco authored
Generate JS modules for: //ui/file_manager/externs/background/task_queue.js //ui/file_manager/file_manager/background/js/task_queue.js Because Closure doesn't deal well importing the same namespace from different files, I started splitting the "importer" namespace so each file will have its own namespace. Files in the "externs" directory will have the suffix "Interface" on their namespace. I'll use this logic for all files related to "importer" namespace. The "importer" namespace will remain for the file "importer_common.js" Move the `UpdateType` our of the TaskQueue namespace to remove the reference of importer.TaskQueue from importer_common.js because it was causing a circular dependency between externs/b/task_queue.js and importer_common.js. Bug: 1133186 Change-Id: I53af2ceb7f75e463702fdfbb3f2c4758f1fbc540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592578 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Shane Fitzpatrick authored
Fixed: 1152626 Change-Id: Ia7afc348d46595522a6ab027c12e70771db1fb44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595512Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#837919}
-
Melissa Zhang authored
This CL adds the following metrics collection: - Specifies which ShareAction was selected. - Whether user cancelled through escape key or by clicking outside the bubble. - Whether the device was in clamshell or tablet form when the sharesheet was invoked. Bug: 1154555 Change-Id: Ib34520276213d76beace52285554c10c00cfaedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567848Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837918}
-
Bartek Nowierski authored
The |defined(ARCH_CPU_64_BITS)| check is a remnant of the CheckedPtr2/MTECheckedPtr era, which worked only with 64-bit pointers. BackupRefPtr doesn't have this limitation. Bug: 1073933 Change-Id: I8e3dc79291b6bd2b118cb34b0b564f58e4ccc785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571143 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
Begins relaxation with a narrow case: addSourceBuffer("video/mp4") and changeType("video/mp4") may now succeed, though any actual media appended to them later must be encrypted HEVC content, and even then, only on ChromeOS. Later changes will expand the relaxation of codec-specificity further beyond this. Specifically, this change: 1) Updates MediaSource and SourceBuffer to continue to require codec-specificity for MediaSource.isTypeSupported(), but includes a short-term special casing for addSourceBuffer and changeType to support just "video/mp4" on ChromeOS with HEVC EME support. 2) Updates Chromium StreamParserFactory to let parser creation occur with assumed eventual HEVC codec track when just "video/mp4" is used as addSourceBuffer() or changeType() parameter, but only on ChromeOS with HEVC EME support. 3) Updates Chromium SourceBufferState to require an HEVC track reported by the StreamParser to be disallowed with DCHECK failure if BUILDFLAG(ENABLE_PLATFORM_HEVC) is not true, as a protection against possible regression later in StreamParser function. 4) Updates Chromium SourceBufferState to require an HEVC track reported by the StreamParser to be encrypted (otherwise parse failure) if BUILDFLAG(USE_CHROMEOS_PROTECTED_MEDIA) is true. 5) Until wider relaxation is done, this change inserts a hardcoded hevc codec string in SourceBufferState's |expected_codecs| when just "video/mp4" is used for addSourceBuffer or changeType on ChromeOS+HEVC, enabling re-use of existing codec-specificity checks in SourceBufferState. BUG=chromium:535738,b:153111783 Change-Id: I353cdbdb3c1fdafbeacacc6b7c8c39430be7d798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587494Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837916}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I38f3e70a86c31b79f1009b90c0b92ed1c6a55486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595936Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837915}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.52. TBR=sky@chromium.org Bug: 1041619 Change-Id: Ibeea12fb2d96a3941bb514d54bc01ac9d79e3c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596821 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. There is a section about the renaming on http://go/lacros-macros. Bug: 1052397 Change-Id: I10ddaf5a25fcfbcd37fe762ea4035f5495aed247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594831 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837913}
-
David Tseng authored
Content scripts are injected by the extension system when a page first loads. This unfortunately, does not cover cases where with a page is already open, then STS is toggled on. The code to trigger this manually hard coded the script path. Generalize this by reading the script path from the manifest. R=dmazzoni@chromium.org, joelriley@google.com AX-Relnotes: n/a Change-Id: If8fcc8f87bc6088472209f332e42fdd597f16581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595855 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#837912}
-
Shannon Chen authored
Horizontal range lines will be hidden after the horizontal point is selected and vertical range lines will be hidden after the vertical point is selected. All point scanning lines will be hidden after the action is performed on the point. Signed-off-by:
Shannon Chen <shannc@chromium.org> Bug: 1061537 Change-Id: Icc2562a1cd23ffda8c7282912946efec6a4b6f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587577 Commit-Queue: Shannon Chen <shannc@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837911}
-
Wei Lee authored
Bug: b/172343942 Test: CCA is shown under guest mode Change-Id: If3c39c52c81287d7493783d2d1e8ae352821b22b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592213Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#837910}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/307ece163070..b31cd871ad10 2020-12-17 bajones@chromium.org Update majority of tests to use new BindGroupLayoutEntry format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I4db149720d68a2e6043f7124a31a61563df3f938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596743Reviewed-by:
-
Prabir Pradhan authored
This reverts commit 43be36f0. Reason for revert: Multiple CTS failures Bug: b:175379280 Bug: b:175514308 Bug: b:175829322 Original change's description: > exo: Allow Pointer Capture when window is active > > Pointer Capture was being rejected by chrome when an app came into > focus using keyboard shortcuts (Alt-Tab), but was working as intended > when an app came into focus using the mouse or touchscreen. It was being > rejected because the capture_surface was the sub-surface of the current > focused surface. > > Since the client is responsible for providing the capture surface > through the wayland pointer constraints protocol, it is possible > for the client to request capture on a sub-surface of the current > active surface. Requesting capture on a sub-surface is a valid request > for capture. Rather than ensuring that the capture surface is focused > (used for directing key events), we verify that the active window > contains the window of the capture surface in its hierarchy before we > allow the pointer to be constrained to the surface. > > This also allows the client to change the cursor while the client has > capture, even when the mouse cursor is not currently over a client > window. > > BUG=b:153973515 > TEST=manual: request pointer capture, leave app, return to app using > Alt+Tab, verify app has pointer capture. > TEST=exo_unittests > > Change-Id: I56e76469f35ea43100748ebe27966464e32805fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559255 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> > Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832613} TBR=oshima@chromium.org,tetsui@chromium.org,prabirmsp@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:153973515 Change-Id: I582f775f37c34149fb7f0c2a6b9162b5e72cbf78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596065 Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#837908}
-
Xing Liu authored
Add two metrics for read later feature. 1. Total number of reading list items. 2. Three action button entry point action. Bug: 1140277 Change-Id: If704fb6a5258d4e0aaa58973ae0bb1a5fb3c21dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592392 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#837907}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsSwitchAccessActionAssignmentDialog* Change-Id: Id346d80dba4eefd7cda822db567bbbc45304a43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587561 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
Oriol Brufau authored
Bug 1155342 was already fixed by r837219, but I didn't add a unit test for SelectionModifier since the testcase that I had wasn't trivial. However, turns out that bug 1155309 is a duplicate, but with a simpler testcase which does seem a good fit for a unit test. This new unit test would have crashed before r837219. Bug: 1155342, 1155309 Change-Id: I52def532cf8eda92d6009e473d3a28ac4960cc2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596297Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#837905}
-
Eric Willigers authored
If an Intent is received that has a blank title, we don't include the title in the generated GET or POST request. Current Intent instances are created with either non-empty strings or with nullopt. This CL protects against any future Intent sources that might create share_title with empty string. Bug: 1125880 Change-Id: I5b5a854eb8b849d1d07877f46e3855cf29c6109e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592544 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#837904}
-
Louise Brett authored
This hooks up the existing web badging API to the UI so that a PWA will show an attention badge if the PWA has called the web badging API. - When the flag "enable-desktop-pwas-attention-badging-cros" is set to "notifications-only", a badge will only show when a notification is showing. - When the flag is set to "api-only" a badge will only show if the web badging api has a badge set. - When the flag is set to "api-and-notifications" a badge will show either if a notification is showing or if the web badging api has a badge set. This is the default behaviour. Bug: 1157273 Change-Id: Ic0275e5e2d023f13554ed6ca001665b69f49f58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589055 Commit-Queue: Louise Brett <loubrett@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#837903}
-
Brian Sheedy authored
Removes expectations for the hardware_accelerated_feature suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 254724, 1155766 Change-Id: I99f8dff856308e072114e3d4d416f99faa48dc8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592327Reviewed-by:
-
Bruce Dawson authored
This change (based on crrev.com/c/2576881) is a temporary workaround for a bug in the x86 emulator on ARM64 Windows. The bug is that movvdup reads sixteen bytes instead of eight and this makes Chrome unusably crashy. The fix is to add eight bytes to allocations so that the over-reads aren't fatal. This change will make x86 Chrome on ARM64 Windows use slightly more memory. On normal x86 builds the only difference should be an extra add in the allocation path. The emulator bug has been reported and fixed. This change will be reverted some time after the fix has shipped. See the bug for details. This has been manually tested on ARM64 hardware to confirm that the crash is avoided with this change. This has been more extensively tested with a modified version of this change (crrev.com/c/2590684) which always adds the eight bytes. This change will be reverted when the emulator fix has shipped. Bug: 1151455 Change-Id: I2fcd9fb5169239b9957e9e8838f441f5780e2610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577893 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#837901}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ic17f054e6ff0cd22b66b80cbdd370dd1d9ac47fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595297 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#837900}
-
Jeroen Dhollander authored
This will allow us to easier move this class to the Libassistant mojm service. All dependencies have been moved to the new class |AudioInputHost|. This class currently talks directly to |AudioInputImpl|, but later it will instead talk to the mojom APIs. Some notes: - |AudioInputImpl| still depends on |AssistantClient::Get()->RequestAudioStreamFactory()|, because the Libassistant mojom service will also use an audio stream factory to open/close its audio input. In a follow up CL I will introduce a delegate to sever this dependency. - There is one behavior change: |power_manager_client_->NotifyWakeNotification()| was previously only called when DSP was enabled, and it is now always called (when Libassistant starts a conversation). I can think of no reason why this would be an issue. This is a reland of crrev.com/c/2582537, with the added fix that we no longer crash when we get a request to set an empty DSP hotword locale. Bug: b/171748795 Test: chromeos_unittests, deployed on real hardware with and without DSP. Change-Id: I9ace389ad27e44cafe422d668946bf29ac7f56a9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596238 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837899}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/91beff4e632a..4a33b7b19905 2020-12-17 jophba@chromium.org Bikeshed: fix spelling mistakes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ic90c565a3bfba6c476ee4a47a0e49a3a1a814683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596636Reviewed-by:
-
Xiqi Ruan authored
Records the device and account statistics metrics for Chrome OS family user. Those metric will be reported either on the user session started or on the first session each day. Bug: 1133856 Change-Id: Iabe9cbaf36de6036817d7744ac73246b091089a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466394 Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837897}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2af92c98. With Chromium commits locally applied on WPT: ef476588 "Canvas-WCG: Update names to reflect the specification" e1e1bb4a "Ignore layout shift under opacity:0" 845edb23 "Avoid double relpos offset in NGSimplifiedOOFLayoutAlgorithm." 370de89c "[AspectRatio] Correctly detect indefinite percentages" 58aad48a "Handle inner floated multicol at outer boundary." 9d15ff73 "Handle inner fieldset / legend multicol at outer boundary." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio mustaq@chromium.org: external/wpt/html/interaction/focus NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I603ba35d1b49b0f9f78bdda71e3ec7f713011c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595732Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837896}
-
