- 18 Jun, 2020 40 commits
-
-
Ana Salazar authored
This cl is intended to implement some of the recommendations extended by UX for the Launcher app paging. - Fix vertical spacing between pages, should be 12px - Border radius for background cards should be 12px - Peeking pages on top and bottom should have the same height - Focused page's background card should be Grey100 @ 20% - Non focused pages' background card should be Grey100 @ 10% - Add gradient mask in cardified state Bug: 996822 Change-Id: I602952f5776cdb6d28521546f2479d709240105a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250713 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779917}
-
Stephen McGruer authored
This reverts commit e7be6d6b. Reason for revert: Being reverted as part of a chain of CLs suspected of causing problems - see https://chromium-review.googlesource.com/c/chromium/src/+/2252612 Original change's description: > Add missing flush() calls to passwords_section_test > > crrev.com/c/2246157 is suspect of causing failures in > CrSettingsPasswordsSectionV3Test. This could be caused by click events > in the new tests not being flushed, so this CL adds missing flush() > calls. > > Bug: None > Change-Id: I3abff7ddb894aa4a3cb3f7cf0dd2a06c7f05ec73 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252138 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779837} TBR=treib@chromium.org,fhorschig@chromium.org,victorvianna@google.com Change-Id: Id52fe41ab407b18dd154470832ba6d7798239653 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252613Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779916}
-
Jihwan Marc Kim authored
with Play Billing. Whenever an app-store payment method is one of the payment methods being supported and any of the "requestShipping", "requestPayerName", "requestPayerEmail", and "requestPayerPhone" is true, then payment_request.cc should print an error message in developer console. Bug: 1095812 Change-Id: Icd1c0d1f43d1525591d701458afee1a8a828c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249206Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779915}
-
Mustaq Ahmed authored
FullscreenControllerTest contains more than just fullscreen tests. This CL renames this into ExclusiveAccessTest, gives some methods a generic name to represent their correct functionalities, and moves mouse lock tests into a separate file. Change-Id: I3507a7cbb8a6e76928e1e6f86358bea2525f2ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239302Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#779914}
-
Doug Arnett authored
Adds new parameter within the TranslateSubFrames feature to control whether language detection occurs over sub frames or just the main frame. This will be used in a 3 arm Dev/Canary experiment that will look at language detection latency. Bug: 1096121 Change-Id: I4cb3fa997c070a4345584bbe8cfde29b25098d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250339Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#779913}
-
Xida Chen authored
Right now, the |frames_expected| for the aggregated throughput is simply the same as the |frames_expected| of the impl throughput. However, there are some edge cases where this could be wrong, such as the newly added test. In this case, we add jank in the script, the jank is long enough such that exactly half of the expected main frames gets presented on screen. In this case, half of the impl frames reports no damage, and thus the |frames_expected| for the aggregated throughput is only half of what it should be. This CL fixes the problem and add a test case. It could causes some changes to UMA for the: Graphics.Smoothness.PercentDroppedFrame.* TBR=sadrul@chromium.org Bug: None Change-Id: I3040a2db8a90e7d35ea2785204039b7c764e5435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234063 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779912}
-
Mustafa Emre Acer authored
The iOS interstitial has its own flag. Change-Id: Ib101bde967802a0ecdf071c5cc819a23ca3517e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250672Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779911}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I69311dafdbf632c0315d08e2746e91a6d89d4129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779910}
-
Teresa Kang authored
In Canvas2DLayerBridge::ShouldAccelerate, the hint in the parameter is never used. Furthermore, in GetOrCreateResourceProvider, the hint is used to decide whether the creation should happen through restore or not. The logic should be to use restore if the canvas is accelerated, or create a new one otherwise. With a previous change to ShouldAccelerate that preserves the acceleration mode, if the canvas is currently using gpu and if the hint given is kPreferCPU, it would still create a GPU canvas, in which case we could try to restore an old one first. Therefore, the usage of the hint parameter can be replaced by ShouldAccelerate(), and the parameter itself is not useful after all. All unused usages of RasterModeHint are cleaned up accordingly. Bug: 1090180 Change-Id: If93cae51a567f7110085fa4514d0e60c56b07541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244115Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#779909}
-
Tom Anderson authored
In [1], I replaced: field.for_list = getattr(field, 'for_list', None) field.for_switch = getattr(field, 'for_switch', None) with: field.for_list = None field.for_switch = None However, getattr() is still necessary because these variables may be set when processing later fields from the same structure, so we need to know if they've already been set. This is compounded by the fields getting thrown into a dictionary, so when we're iterating over the keys, we get them in an unspecified order. [1] cd1129d8 BUG=1066670 R=msisov Change-Id: I84a9128b0b0403f543cbe905d37ebd4151cc0521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250510Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#779908}
-
Oriol Brufau authored
The logic for legacy list markers is in the LayoutListMarker class. It used to be the only class for legacy list markers, but in r748730 I added the subclasses LayoutInsideListMarker and LayoutOutsideListMarker. My plan was to end up changing them to inherit from LayoutInline and LayoutBlockFlow, and then remove LayoutListMarker. However, the new plan is to keep the old logic for legacy markers with 'content: normal'. Then, this patch - Switches ::marker back to creating a LayoutListMarker instead of a LayoutInsideListMarker or LayoutOutsideListMarker. - Changes LayoutInsideListMarker to inherit from LayoutInline. - Changes LayoutOutsideListMarker to inherit from LayoutBlockFlow. - LayoutInsideListMarker and LayoutOutsideListMarker become unused for now, but they will be used for non-normal legacy markers in following patches. LayoutListMarker will be used for normal legacy markers, inside or outside. - Renames and adds new LayoutObject methods to distinguish the various kinds of markers. Bug: 457718 TEST=blink/web_tests/editing/execCommand/create-list-1.html TEST=editing/selection/drag-to-contenteditable-iframe.html TEST=editing/selection/selectNode.html TEST=editing/selection/selectNodeContents.html Change-Id: I7b95ca991ae791642ea8aac41f71d3586b362dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246514Reviewed-by:Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#779907}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592481559-cd0ac58705eebf31c71fdcab35041388ee8d8f2d.profdata to chrome-win32-master-1592492320-3ab827aecaa4186da1d1047a6b75e711e06263db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie66f053b5dce6821202ee32283183bc7f48ffab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252034Reviewed-by:
-
Elly Fong-Jones authored
This change: * Migrates AppBlockDialogView to use SetTitle * Migrates AppDialogView to use SetIcon, SetShowCloseButton, and SetShowIcon * Migrates AppPauseDialogView to use SetTitle and SetAcceptCallback * Migrates AppUninstallDialogView to use SetTitle * Removes many now-unneeded member variables from these classes Bug: 1075649 Change-Id: Ifd8df11b87f77a3b337394c20a7c2b6dd638f7dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250508 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779905}
-
Jeffrey Cohen authored
https://hsv.googleplex.com/4770250551721984 Bug: 1093374 Change-Id: I7405ba988173d0266ea122572419b7a028680fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236470Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779904}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I892ab5d05fe410447fa61541a32285dcb535db0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249798 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779903}
-
Akira Baruah authored
Adds new graceful RebootReasons sent over FIDL. Bug: b/157594010 Test: cast_reboot_unittests (with target_os="fuchsia") Change-Id: Iea2f9d49414b2bfbd0a31671f402d458523bb392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246948Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Akira Baruah <akirabaruah@google.com> Cr-Commit-Position: refs/heads/master@{#779902}
-
Miriam Zimmerman authored
The title was previously set to "Feedback" because of the untranslatable manifest.json. Instead, use a translatable title string. BUG=chromium:977523 TEST=set IDS_FEEDBACK_REPORT_APP_TITLE to a unique string, deployed to \ a VM, opened feedback window, verified that: <title> was expected \ string; mouseover text in system tray was expected string; name \ of app in chrome://inspect was expected string Change-Id: Iecaf57e704c49dbab499de2cd7404cba5cfdb122 Fixed: chromium:977523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248465Reviewed-by:Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#779901}
-
Chong Gu authored
Filter tests that fail/flake. Adds about ~10 bot and total run time per build. Bug: 1058255 Change-Id: I5fe248ba77fadba4c150221248a0404bc0fd60e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251739Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#779900}
-
Mehran Mahmoudi authored
This re-enables PaintPreviewPlayerTest#overscrollRefreshTest. The failure cannot be reproduces locally and the bot on which this test was flaking has been killed recently [1]. [1]: https://chromium-swarm.appspot.com/bot?id=luci-chromium-ci-xenial-us-central1-b-8-76-mhb1 Bug: 1093083 Change-Id: Ifacf72e3373fbcfa513d5f8bc87afec03c0c086e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252578Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779899}
-
Sylvain Defresne authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/db55efd4..7d7e8dee 7d7e8dee Use correct path to generated binary for EXECUTABLE target 4cb80972 Omit stamp when inputs are only used by a single build rule Bug: gn:158 Change-Id: I62b722418a3d015da4011381e8ea225297d3f3e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252080 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Maria Kazinova authored
Submitted forms in iframes can be removed from DOM by detaching parent iframes. The moment if detachment is caught by the PasswordController and the PasswordManager checks if it has any submitted PasswordFormManagers related to this frame. Bug: 1042196 Change-Id: Ia02fc946477202768c80b84532a08c20f00538f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237933 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#779897}
-
Lorne Mitchell authored
TestPendingAppManagerImpl caches the install and uninstall requests, which is needed by the system_web_app_manager_unittests.cc. There is a follow up CL that is in work that will consume this class (https://chromium-review.googlesource.com/c/chromium/src/+/2223978). Bug: 1088399 Change-Id: Ide90f3be50109b4f7d5794b27b98042e6c23b649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251101 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#779896}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I40892eb0ca8d17f4b2aa1d231c0806001aeb235c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249760 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
Remove unnecessary security check for uint32_t variable as it will never less than 0. Change-Id: I1c8efcc98c618c2955ed372275c970f8627ff19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249247 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
-
Xiaohui Chen authored
This CL removes one of the internal dependency on the public mojom type. Bug: b:154268518 Change-Id: I68d87c91331cb0347ff0fa23fbb02fe22500f490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250167Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779893}
-
Jonah Ryan-Davis authored
Mac DefaultPassthroughCommandDecoder is ready to be finched, so we need test coverage for both command decoders. This CL adds passthrough test coverage for context_lost, screenshot_sync, pixel_skia_gold, and maps_pixel_test. Bug: chromium:982292 Bug: chromium:1090853 Change-Id: Ib264875dc22cf15efe3a9395424da8e30554a8a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246630 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#779892}
-
Xi Han authored
ScreenShot: https://drive.google.com/file/d/1jxjCXSdR_Wnz5Wu2HKu6gDiaOF0who1Q/view?usp=sharing Bug: 1016952 Change-Id: Ib3c840794aa9c527540ddbe3f0ada8b1ac66a1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250899Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779891}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: I4785f465efb51cb7d2c63cc3df5ed86c8e53362d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248620Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#779890}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b621a997903..9c7a8fbc5977 2020-06-18 fmayer@google.com Document vfork known issue. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:153893612 Tbr: perfetto-bugs@google.com Change-Id: I3efb52a66d1cb9a7a87420a06364a8328a1505f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252024Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d70c25298bc8..d438a6023a21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1096383 Tbr: smcgruer@google.com Change-Id: Ibf9f6115bce930d5ed508aa9e116e96f49a2ad96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252027Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779888}
-
Jochen Eisinger authored
This is a reland of ba58fd11 Original change's description: > Add logging to external intent handling > > I will revert this CL after a few canaries. > > Bug: 839751 > Change-Id: I823ec7c2eb47df905869d3f4f74c89e59a1433be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246596 > Auto-Submit: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779391} Bug: 839751 Change-Id: I620626407acbc482c7a7f6eee595dac57ee4ecf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252039 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#779887}
-
Sébastien Séguin-Gagnon authored
Bug: 1092180 Change-Id: Ib274cb26a85aa9ebc9de34793338c67b935b5cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248135Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779886}
-
Katie D authored
Flakes are only occurring in M84 because a flake fix landed after the 84 branch: crrev.com/c/2209281. This change will be cherry-picked to M84 and then reverted in M85. Bug: 1064776 Change-Id: I6518458ac57f268b8c762097877b077e8852d833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250159Reviewed-by:
-
Stephen McGruer authored
This reverts commit 359f3700. Reason for revert: Broke build due to dependent CLs existing. Original change's description: > Revert "Desktop PWAs: Unit test helper method InstallWebApp" > > This reverts commit 7db3de6c. > > Reason for revert: MSAN failure, crbug.com/1096592 > > Original change's description: > > Desktop PWAs: Unit test helper method InstallWebApp > > > > Extract unit test helper method InstallWebApp from unit tests to > > web_app_unittest_util.h/cc and retire duplicate implementations. > > > > Drive-by: retire unused method FinalizeInstall > > in web_app_install_manager_unittest.cc > > > > TBR=agawronska@chromium.org > > > > Change-Id: I5f7574ef89dfe1543727c2376d8002e2e6fce822 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247991 > > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#779607} > > TBR=ericwilligers@chromium.org,loyso@chromium.org,dominickn@chromium.org > > Change-Id: I1b50d2ed80fbe29b9e742c7a533d3a0b65e0df7e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252561 > Reviewed-by: Aleks Totic <atotic@chromium.org> > Commit-Queue: Aleks Totic <atotic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779872} TBR=ericwilligers@chromium.org,loyso@chromium.org,atotic@chromium.org,dominickn@chromium.org No-Presubmit: true No-Try: true No-Tree-Checks: true Change-Id: I73d0c4893bd9f1f3dd397818faeaa743b0c9a97e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252643 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Erik Chen authored
Bug: 1094461 Change-Id: I40ab98e429dc8d9cbec78fab2eb8ee8865b2facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244011 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779883}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iefd84e6173721d15d2ce6abc51cc16349c7c92b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250791Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 78a17a82. With Chromium commits locally applied on WPT: d4954632 "wpt: fix webrtc simulcast rids" 78a17a82 "Fix timeout on RTCRtpTransceiver test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I4cd3acf78e00850589a038d55d8f4d797d42a5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252278Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779881}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I07587081f287085f218b8a1cf2f341751c919dfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251404Reviewed-by:
-
Daniel Libby authored
In CAP, compositing state/group mapping is not known until after painting, so this information can't be used to isolate NeedsRepaint operations in MarkCompositingContainerChainForNeedsRepaint. Scope the querying to a non-CAP codepath. This was the last assert disabler in CAP codepaths, so add a DCHECK to the DisableCompositingQueryAsserts constructor so no further ones are added. Bug: 1007989 Change-Id: I72e4a82ccf856c9ace3f3714d5e3bd0c6ccc7b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247322Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#779879}
-
gogerald authored
This CL also solves the scroll issue of the incognito description. Screen records: Resume: https://drive.google.com/file/d/1jPFCAEwTDzI4PO-Ef-HdvRV6KeZoW4fD/view?usp=sharing Scroll: https://drive.google.com/file/d/1C2lFMBKmdTaipWcHBG9mAYCJNuhoiYK_/view?usp=sharing Bug: 1093506 Change-Id: I5d7365daa530b23f897a19665076cbc32238224f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243334 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
-
