1. 28 Oct, 2014 13 commits
    • wez's avatar
      Use cpuused=6 for lossy VP9 mode · b17047cc
      wez authored
      BUG=260879
      
      Review URL: https://codereview.chromium.org/678073007
      
      Cr-Commit-Position: refs/heads/master@{#301503}
      b17047cc
    • davidben's avatar
      Log SSL_READ_ERROR and SSL_WRITE_ERROR in SSLClientSocketOpenSSL. · b8c23215
      davidben authored
      The equivalent logs in SSLClientSocketNSS were never implemented here. This
      will help in debugging problems which occur after the handshake.
      
      BUG=425834
      
      Review URL: https://codereview.chromium.org/651183004
      
      Cr-Commit-Position: refs/heads/master@{#301502}
      b8c23215
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 2dec45fb
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=varkha@chromium.org
      
      Review URL: https://codereview.chromium.org/681913002
      
      Cr-Commit-Position: refs/heads/master@{#301501}
      2dec45fb
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 3f5cbabd
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=sadrul@chromium.org
      
      Review URL: https://codereview.chromium.org/681883002
      
      Cr-Commit-Position: refs/heads/master@{#301500}
      3f5cbabd
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · b1c24b60
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=sadrul@chromium.org
      
      Review URL: https://codereview.chromium.org/683553002
      
      Cr-Commit-Position: refs/heads/master@{#301499}
      b1c24b60
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · d002275e
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=thestig@chromium.org
      
      Review URL: https://codereview.chromium.org/679273002
      
      Cr-Commit-Position: refs/heads/master@{#301498}
      d002275e
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 5e6a48d3
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=skuhne@chromium.org
      
      Review URL: https://codereview.chromium.org/685483004
      
      Cr-Commit-Position: refs/heads/master@{#301497}
      5e6a48d3
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · fbf9696f
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=skuhne@chromium.org
      
      Review URL: https://codereview.chromium.org/686593002
      
      Cr-Commit-Position: refs/heads/master@{#301496}
      fbf9696f
    • dalecurtis's avatar
      Revert unintended prevention of seeks on infinite duration media. · 56359cbf
      dalecurtis authored
      Preserves the looping behavior for 200-type sources, while reverting
      the disabling of seeks for "non-streaming" type sources which report
      an infinite duration. This reverts the unintended behavior change
      from http://crrev.com/298565
      
      BUG=412562,427412
      TEST=live player works again. LayoutTest forthcoming.
      
      Review URL: https://codereview.chromium.org/684473002
      
      Cr-Commit-Position: refs/heads/master@{#301495}
      56359cbf
    • Mitsuru Oshima's avatar
      Temporarily excluding failing test on valgrind/drmemory bots · d68b1649
      Mitsuru Oshima authored
      BUG=427729
      TBR=lanwei@chromium.org
      
      Review URL: https://codereview.chromium.org/680183003
      
      Cr-Commit-Position: refs/heads/master@{#301494}
      d68b1649
    • ben's avatar
      Update a bunch of OWNERS files. · 0ee290d0
      ben authored
      Remove v2.
      
      R=sky@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/682713003
      
      Cr-Commit-Position: refs/heads/master@{#301493}
      0ee290d0
    • jackhou's avatar
      Move app_installer into chromium. · 511a873f
      jackhou authored
      This code was previously in
      https://chrome-internal.googlesource.com/chrome-app-installer.git
      
      We're moving it to chromium with the goal of having it
      eventually built as part of Chrome releases.
      
      The third_party code is used to extract the tags added
      by dl.google.com. Omaha uses this mechanism to tag their
      meta-installers.
      
      BUG=341353
      
      Review URL: https://codereview.chromium.org/423293004
      
      Cr-Commit-Position: refs/heads/master@{#301492}
      511a873f
    • dcheng's avatar
      Standardize usage of virtual/override/final specifiers. · 4c112747
      dcheng authored
      The Google C++ style guide states:
      
        Explicitly annotate overrides of virtual functions or virtual
        destructors with an override or (less frequently) final specifier.
        Older (pre-C++11) code will use the virtual keyword as an inferior
        alternative annotation. For clarity, use exactly one of override,
        final, or virtual when declaring an override.
      
      To better conform to these guidelines, the following constructs have
      been rewritten:
      
      - if a base class has a virtual destructor, then:
          virtual ~Foo();                   ->  ~Foo() override;
      - virtual void Foo() override;        ->  void Foo() override;
      - virtual void Foo() override final;  ->  void Foo() final;
      
      This patch was automatically generated. The clang plugin can generate
      fixit hints, which are suggested edits when it is 100% sure it knows how
      to fix a problem. The hints from the clang plugin were applied to the
      source tree using the tool in https://codereview.chromium.org/598073004.
      
      BUG=417463
      R=asvitkine@chromium.org
      
      Review URL: https://codereview.chromium.org/679243002
      
      Cr-Commit-Position: refs/heads/master@{#301491}
      4c112747
  2. 27 Oct, 2014 27 commits