- 14 Nov, 2019 40 commits
-
-
Chih-Yu Huang authored
In VideoDecodePipeline, we set frame metadata POWER_EFFICIENT twice. This CL remove the one at OnFrameDecoded(). Bug: none Test: Play video at crosvideo.appspot.com on kevin Change-Id: I3ef4b45e72d9d1ec52621b993cec12e7a0e65057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914598Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715188}
-
Fergus Dall authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9734c36f2aa6..ce25839e00e5 $ git log 9734c36f2..ce25839e0 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 sidereal crash_reporter: Add new parser to anomaly_detector 2019-11-07 xzhou system_api: add proto definition for fido protocol 2019-11-11 igorcov system_api: Define new constant for StopSessionWithReason Created with: roll-dep src/third_party/cros_system_api Bug: 1018093 Change-Id: Ia8f15eb4141c85958aef92b0df8a6b18dd8c9bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914594 Commit-Queue: Fergus Dall <sidereal@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715187}
-
Keith Lee authored
Changes were based on the call chain of setCompositionRange. Modify setSelectionRange and setCompositionRange to throw an error if the arguments were invalid uint32 values. Changes to third_party/closure_compiler/externs/input_method_private.js were auto generated by running: ``` python tools/json_schema_compiler/compiler.py /usr/local/google/home/keithlee/chromium/src/chrome/common/extensions/api/input_method_private.json --root=. --generator=externs > /usr/local/google/home/keithlee/chromium/src/third_party/closure_compiler/externs/input_method_private.js ``` b/134473433 CRBUG=1024657 Change-Id: I5dfb398bb1ff7a4c3a246c64759437efbc33782b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903227 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#715186}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa6d4dc30478..f520568b0e6a git log fa6d4dc30478..f520568b0e6a --date=short --no-merges --format='%ad %ae %s' 2019-11-14 dproy@chromium.org Reland "Add origin trial token for vulcanizer" 2019-11-14 agable@chromium.org Reland "Nearly-whitespace change to check mirroring" Created with: gclient setdep -r src/third_party/catapult@f520568b0e6a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1021137,chromium:1023392 Change-Id: I2f862620a46aaa5cab8b8ba5ede3c7c57a4647f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914756Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715185}
-
Xianzhu Wang authored
LayoutNG allows an inline to contain floating objects, so the original logic for floating objects escaping inline containers doesn't apply. Bug: 922645 Change-Id: Id736d7051a6356325be92cb7fa25949a21304c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913027Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715184}
-
Michael Spang authored
Chromecast uses views, but does not set toolkit_views=true. Set this to true & remove desktop-oriented code that breaks in this case. This replaces !defined(OS_CHROMEOS) with a new BUILDFLAG(ENABLE_DESKTOP_AURA) flag as necessary throughout views. This is needed because Chromecast doesn't use desktop_aura and uses aura similarly to Chrome OS by creating one WindowTreeHost for the display [alternative suggestions on how to handle this distinction welcome]. This does not enable views in content(_shell) yet. That's left to the next patch as it changes the UI. As of this change, views_unittests passes in Chromecast Linux builds. Bug: 1021770 Test: views_unittests, content_browsertests on is_chromecast=true build Change-Id: I54e79402a761572feb76f122ed846558e84210b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907559Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715183}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8bc4fa870170..32f02045f037 git log 8bc4fa870170..32f02045f037 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 cjmcdonald@chromium.org Stabilize parallel_emerge_new 2019-11-13 rrangel@chromium.org cros_branch: Sync all groups by default Created with: gclient setdep -r src/third_party/chromite@32f02045f037 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4075a3fc1a711c6e743b42a5da43aa634fa5982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915228Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715182}
-
shrekshao authored
These bindings are needed to implement GL_WEBGL_draw_instanced_base_vertex_base_instance and GL_WEBGL_multi_draw_instanced_base_vertex_base_instance in the passthrough cmd decoder. Bug: chromium:891861, angleproject:3402 Change-Id: I5db6b10509c2e3ddd8e0c41dee585485e162370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747865 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715181}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic6fba3dc87e048262261f634209f2726db787185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715180}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/088977a7a7fb..e6e5db55004d git log 088977a7a7fb..e6e5db55004d --date=short --no-merges --format='%ad %ae %s' 2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-14 brucedawson@chromium.org Randomize results of git cl owners Created with: gclient setdep -r src/third_party/depot_tools@e6e5db55004d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1024083 Change-Id: I3ec903f5b57bb3c7f9aad7413821ea66252da033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915062Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715179}
-
Stephen Chenney authored
Implements a new Blink.PageLoad UKM event with metrics for the existing Rendering Core components tracked on a per frame bases by Blink.UpdateTime. The new event is emitted once per navigation when First Contentful Paint (FCP) is signaled, and records the total time spent to that point by each component. Corresponding UMA is also added. Bug: 1001199 Change-Id: I361999782416ce32999e0595d03cbc8ab99eccde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904349 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#715178}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I15bf0d7a72238fda1ccdefb8d189e4dd71ebe435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915020Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715177}
-
Noel Gordon authored
- rename the input files to match names of the existing filetype PNG icon files used in Files app - optimize their SVG using SVGOMG, and also add them to the 20px files-ng icon-set for <iron-icon> use in the file list Bug: 992821, 1002393 Change-Id: Ib08928d16bd0e59f596ec0c7dfc48671bf9921ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914587 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715176}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f533355b4140..1b52f05868c9 git log f533355b4140..1b52f05868c9 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 ianelliott@google.com Vulkan: Update bug numbers for GLES 3.1 "debug" expected failures Created with: gclient setdep -r src/third_party/angle@1b52f05868c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I6bac3e69aedf6203520e0d4e61585c8083040831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715175}
-
Eric Willigers authored
minimal-ui desktop PWAs behave similarly to standalone PWAs, but with Back and Reload buttons at the left end of the title bar. https://www.w3.org/TR/appmanifest/#dom-displaymodetype-minimal-ui Bug: 1007151 Change-Id: I86920c20a5af89aefdabfdaba89996ab267e0f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914588 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#715174}
-
Steven Bennetts authored
This CL adds support for compressing .pak files, and adds compression for locales/*.pak on chromeos. Note: We keep the extension for compressed .pak files to avoid dependency complexity in tests. Bug: 1017864 Change-Id: Ifee472b7e15673fcb835ae75aca768265592460b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912621 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715173}
-
Sammie Quon authored
These will help with improving performance of these animations, and for writing a performance test. Test: manual Bug: 1023586 Change-Id: I5eb4eaa8d22128bf1cd5217761cac6b9886a69e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910806 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#715172}
-
Yuta Kasai authored
This CL starts to implement FetchEvent WorkerTiming. This feature enables a service worker to attach PerformanceMark/PerformanceMeasure timings to a request during the fetch event handler. The timings will then be exposed to the page using PerformanceResourceTiming. This patch extends PerformanceMark/Measure by PerformanceEntry::toMojoPerformanceMarkOrMeasure() to pass them via Mojo pipe. A pair of Mojo endpoints for FetchEventWorkerTiming is made in ServiceWorkerSubresourceLoader::DispatchFetchEvent() and Mojo remote will be moved to FetchEvent. Mojo remote is null for navigation and subresources because it is unsupported yet. This feature won't work after this patch is merged because Mojo receiver and remote aren't be connected anywhere. These will be connected in the other patch. Explainer : https://github.com/wanderview/fetchevent-worker-timing/blob/master/explainer.md Design doc: https://docs.google.com/document/d/1-ebnv7OFiVd3k2-jbtQGO5s3BKHIp7lRx3ujhgNKvB0 Bug: 900700 Change-Id: Ie6c870faf0309990ccf8dbd986091fb2f1597dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903115 Commit-Queue: Yuta Kasai <yutakasai@google.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#715171}
-
Findit authored
This reverts commit ff41c36d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 715133 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZmNDFjMzZkY2UzZTUzYmZjYWQ2Y2VkZGMxZmMyOWU2MjBhNGYxMTcM Sample Failed Build: https://ci.chromium.org/b/8896853113607982064 Sample Failed Step: unit_tests Original change's description: > WebApp: Improve WebAppSyncBridge::UpdateSync to use both app states. > > Improve WebAppSyncBridge::UpdateSync to use both current_state (before commit) > and new_state (to be commit). > > In the future, it will help to skip local updates which don't touch sync data. > > Add WebAppSyncBridge::CommitUpdate unit tests (a.k.a. Local Changes). > > These tests is a promised follow up for this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1830494 > > This code is disabled by default behind kDesktopPWAsWithoutExtensions and > kDesktopPWAsUSS base features. > > Bug: 860583 > Change-Id: I51dfda8b6364e15f9b5eb398321d6010241b0ae9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914005 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715133} Change-Id: Ia74c5f3586de10d9931ae8e23cd8deda44230508 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915545 Cr-Commit-Position: refs/heads/master@{#715170}
-
Peter Kotwicz authored
BUG=1020911 Change-Id: Ife359e136de30b71e829bfadb2f35eb7b9968734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907714 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#715169}
-
Anastasia Helfinstein authored
Currently, when a user launches Switch Access, they cannot control it because they have to configure their switches. This change has Switch Access check if the configured settings allow for navigation, and if not opens the Switch Access settings page. Bug: 996387 Change-Id: I7c85841e7511eb96726187a4db8b127d6f4820bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902233 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715168}
-
Kyle Ju authored
Design doc: https://docs.google.com/document/d/1MtdbUcWBDZyvmV0FOdsTWw_Jv16YtE6KW5BnnCVYX4c/edit#heading=h.7nki9mck5t64 Running Command: python third_party/blink/tools/wpt_export.py --dry-run --credentials <your credentials> --surface-failures-to-gerrit Tested on a mock CL https://chromium-review.googlesource.com/c/chromium/src/+/1784803 Change-Id: I368d6fc5b0f7f3e5364fca1fe26cef3514585f96 Bug: 996383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749720 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#715167}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9254941c7a..2685ecce9083 Created with: gclient setdep -r src-internal@2685ecce9083 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1019994 Change-Id: Iadf5dca9810cb841aada0ddba57a8b751cb8e79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915403Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715166}
-
Alan Screen authored
During print preview when the PDF compositor is used, individual PDFs for each page are made for the preview. Prior art has the full document PDF used for printing being generated by sending a separate metafile blob for all the pages, which is overly large for long documents. This alters that to have the full document PDF get composited using the same individual page metafile objects as they are sent to the utility process for the composition. This effectively halves the amount of IPC traffic for Skia metafile data and eliminates potential huge metafile messages that can overwhelm IPC limits. This is only applicable for print preview scenarios that pass Skia metafile into PDF compositor. Non-modifiable content and basic printing are unaffected in behavior. Bug: 872935 Change-Id: I1101846a00498956b18c208ada656e65e4f175a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616461 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#715165}
-
Azeem Arshad authored
This CL fixes issue with manual proxy config exception list items being read out incorrectly in ChromveVOX and removes unnecessary tab stop. Fixed: 1024355 Change-Id: Ie2a24f36c072a7b451135a274d0ec15320a924c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915319Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715164}
-
khmel@chromium.org authored
This reverts commit 3c419198. Reason for revert: This is important feature and should not be reverted. It is possible to mark flaky test as Disabled, flakiness is just from test environment. TBR=xiyuan@chromium.org,isherman@chromium.org BUG:1013148 BUG=b:142251935 Original change's description: > Revert "arc: Provide replacement for deprecated PlayStoreShown UMA" > > This reverts commit dcdf3924. > > Reason for revert: Flaky on linux-chromeos-rel, see https://crbug.com/1013148 > > Original change's description: > > arc: Provide replacement for deprecated PlayStoreShown UMA > > > > This rolls new set of UMA that replaces derpecated PlayStoreShown UMA > > DD: > > https://docs.google.com/document/d/1vfJMzoYsXtH-HWYydbb5VJvpT6WeJrfvaO81RHI5v2M/edit > > > > BUG=b:142251935 > > TEST=Locally + unit tests. > > > > Change-Id: Ie2ec139b41e702dda604d92324b426782ed494ce > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845935 > > Commit-Queue: Yury Khmel <khmel@chromium.org> > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#704384} > > TBR=xiyuan@chromium.org,yusukes@chromium.org,isherman@chromium.org,khmel@chromium.org > > Change-Id: Ie870309e4d2b879679e79d3b468736e51bab096f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:142251935, 1013148 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852785 > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704615} TBR=xiyuan@chromium.org,yusukes@chromium.org,isherman@chromium.org,drott@chromium.org,khmel@chromium.org Bug: b:142251935, 1013148 Change-Id: Ie22a50f720b4e1a90a8072e32267f089e7862ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913419Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715163}
-
Lambros Lambrou authored
The remoting_me2me_host binary supports 2 command-line options, for checking Accessibility and Screen Recording permissions on MacOS. This CL adds the same options to the IT2Me native-messaging host. Bug: 1013446 Change-Id: I4727e5f58f70580f8f31c551968238a4d49457f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914834Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#715162}
-
Demetrios Papadopoulos authored
This is in preparation of migrating to Polymer3. There is no clear benefit of keeping these scripts separated anymore, and it does get in the way of making the optimized Polymer3 version from working correctly. Bug: 1022215 Change-Id: I40e29c2f22b687e8ba9bad076bc6f6a16ce95731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914833Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715161}
-
Kyle Horimoto authored
When configuring networks, the networking UI compiles a dictionary of properties describing the new network to configure. In this particular case, the "clientCertPkcs11Id" field of the dictionary was misspelled using capital letters: "clientCertPKCS11Id". This CL corrects the spelling and fixes this connection flow. Bug: 1019936 Change-Id: I421c340a36c3a8b9404b07e76aa86f6cffae9829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915279 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715160}
-
Benoît Lizé authored
Large chunks are suspected to be the cause for the linked bug (address space fragmentation). Speculatively use a smaller chunk size to confirm the theory. Only use a smaller size on Windows 32, as this increases the number of file descriptors on all platforms, and the underlying issue (address space fragmentation) is almost impossible on 64 bit architectures, and very unlikely on Android. Bug: 983348 Change-Id: Ic3ecc0a37f712be3fa6d45dfb01326b651f3f470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915379Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715159}
-
Joshua Peraza authored
https://chromium.googlesource.com/linux-syscall-support.git/+log/8048ece6c16c..726d71ec08d1 $ git log 8048ece6c..726d71ec0 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 jperaza Add sigtimedwait and sigprocmask wrappers Created with: roll-dep src/third_party/lss Change-Id: I4dbbeaf72f432caab2315779e0305a60b78a1ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915182 Commit-Queue: Mike Frysinger <vapier@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#715158}
-
Etienne Bergeron authored
This CL is refactoring the way codepoints are rewritten for the conversion between text to layout_text. There is an invariant that must hold: * Same amount of codepoint The text size may differ and text indexes are not the same. This CL is proposing to use a map function to replace codepoints. This avoid error-prone custom codepoints replacement. Bug: 1022893 Change-Id: Ic1fcdfe6b34a1bf1dd47f0ee6a5e157bd131d0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908447 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715157}
-
Darren Shen authored
Delaying expiry of enable-cros-ime-input-logic-fst to M85, to match enable-cros-ime-native-decoder. Change-Id: I6dc14a97b702b959924a178b35bd3d197aaab252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914585 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715156}
-
Yue Li authored
Bug: b/144383302 Test: Manual Test Change-Id: I738416312657739686b7a303cc3aa79355695e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915286 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715155}
-
Lin Sun authored
Extract driver vendor from ANGLE's renderer description according to the format implemented in OpenGL and Vulkan backend. Bug: 994852 Change-Id: I0b72166b504f1a83762a12f1d574c8cd20bf9df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903404Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#715154}
-
Matt Reynolds authored
SCUF Vantage gamepads are designed to work with Playstation 4 consoles and behave mostly the same as genuine Sony DualShock 4 gamepads, but expose a different vendor and product ID. Both SCUF Vantage and SCUF Vantage 2 expose the same IDs (2e95:7725). This CL enables Dualshock4Controller to recognize the SCUF Vantage and Vantage 2 as PS4-compatible devices and applies the mapping functions used for DualShock 4. BUG=1017414 Change-Id: Ic55dc5d2b36c456061eb8bb76b0d0c9f0b85a1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880635Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#715153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6006105f67c3..37be7715fdd1 git log 6006105f67c3..37be7715fdd1 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 mtklein@google.com implement assert_true on ARM 2019-11-13 brianosman@google.com Move the persistent GrMemoryPool to the heap Created with: gclient setdep -r src/third_party/skia@37be7715fdd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I8ab9e73dfaee4712a2c8c67132ba8ad4204fc233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914549Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715152}
-
Sammie Quon authored
This reverts commit 851088cf. Reason for revert: This is wrong fix. Original change's description: > overview: Close button is not layouted properly. > > Gave the parent a rect that has x-bounds, but still using the parent's > parent width, resulting in a overflow. > > Test: manual > Bug: 1020539 > Change-Id: I983cf0813c6b99a74960761c8c8fd241b2995e0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914942 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715105} TBR=afakhry@chromium.org,sammiequon@chromium.org Change-Id: Iea026b292493d8c9ca0931d6a40606e053bda2b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1020539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914796Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715151}
-
Mohammad Refaat authored
The feature was launched in stable for some time. Bug: 850760, 774736 Change-Id: I763ddbd5a83d3686cb1cff7336041fd5c729847d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913183Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#715150}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d85c18b05dcf..8bc4fa870170 git log d85c18b05dcf..8bc4fa870170 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 achuith@chromium.org OWNERS: Add Amin to devserver-related files. 2019-11-13 ahassani@chromium.org paygen: Fix UnofficialSignerPayloadClient with python3 2019-11-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8bc4fa870170 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia8f9ce607b56ba36e8206fedf06aced0a0d7a1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715149}
-