GitLab

This is the same as the container builder's layout object, so use that
instead.

Also moves where we set the margins to the "post-layout" site along
with other copy-back calls.

There should be no behaviour change.

Change-Id: I198dc1548592ccb26553438cab6a2488d395b144
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554792Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648367}

Now that mdns resolutions is supported in CUPS, we don't need to hold
the resolved uri in the printer object anymore.

BUG=758018,936251
TEST=Able to configure and print using mdns resolution in CUPS

Change-Id: I2f149e6558be4689e7b13122a5853feba7ea6b8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551683
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648366}

This is from current origin/stable label.
commit 2cacdff921fb067d93cf476a10f7decb1a9fb766 (tag: v81.0.0, origin/stable)

Bug: 947496
Change-Id: I50b84317caf2fdb9ef8e68d56d6cc6c691986880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554133Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648365}

The //fuchsia/engine:test_support target was depended upon by multiple
targets while it was only actually used by the
//fuchsia/engine:web_engine_unittests target.

Bug: 922635
Change-Id: I5b943e30629c934c7bdfdb8db0894933d66c7d50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555373Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648364}

The cause is TabModel#setIndex() event is fired when undoing the first
tab, before the tab actually undo in TabGroupModelFilter.

This CL is a band-aid fix for M74. We cache the selected tab that is not
exist in the TabGroupFilterModel. And try to select that tab on the
next addTab()/undo call. This will fix the current crash and will not
causing any side effects on TabGroupModelFilter normal usage.

Bug: 948518
Change-Id: Ic65e521baebe65c54b1033f6be35dd2dbdd1a676
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552281Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648363}

Web Share now rejects share attempts if a file with a
non-approved MIME type is being shared.

Design doc:
https://docs.google.com/document/d/1wfcy-hVjEbSuxlBjj_2azqmov8s9ECG1Fm7XoS_XUus/edit?usp=sharing

Also, ensure temporary files are created with "." before the extension.

Bug: 903010
Change-Id: I318e9c908bd9816df35d1d2d64679c984f6bdff9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554465Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648362}

Revert https://crrev.com/c/1504434 since it is not an app list
only problem. Fix it in MoveWindowToEnsureCaretNotInRect so that
it does not move a window beyond work area top.

Bug: 936381
Test: Additionally test with a browser window using the repo steps.
Change-Id: I4be2ee7173748af10acefb7ed880514424644ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555245
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648361}

Bug: 899386
Change-Id: I5e9157be89a2965bb5261898ed03d843bfbf189b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536685Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648360}

Bug: 781257
Change-Id: I4fbebdd57a03ca5329d7020dcaf47150fd3ec928
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551728
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648359}

Removed the use of std::map and checked all Blink accessibility code for any usage of std containers.
R=dmazzoni@chromium.org

Change-Id: I9a285b1aa018d973b3d75d738ab6f2b492a3df2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554144
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648358}

This is a reland of 402ea29b

Original change was reverted due to msan failures. Indeed it
didn't take care of the case of window destruction during
move. This CL includes its fix.

Original change's description:
> Process touch events during the tab-dragging window move
>
> When the touch events move very quickly on detaching, some
> touch events are already queued, those queued touch events
> aren't processed properly.
>
> - Detach() aren't releasing the capture on the source widget.
>   This means those queued touch events are targeted to the
>   source widget instead of the moving widget, but the touch
>   history is already transferred to the moving widget, which
>   makes troubles on gesture recognition. We can release the
>   capture on the detach on this specific situation.
> - the recognized gestures are sent to the root window of
>   the moving widget and nobody can handle. The new class
>   RemainingGestureEventHandler handles them.
> - RemainingGestureEventHandler should not handle events
>   originated from ET_TOUCH_CANCELLED -- some test cases
>   actually fail if so. ET_TOUCH_CANCELLED can happen internally
>   within the browser (like Window::CleanupGestureState()),
>   but that's not the intention of this class.
>
> Bug: 943316
> Test: the new test case in interactive_ui_tests
> Change-Id: I679562d7707342874960dd7ff4d70d749f1ad437
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545113
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#647789}

Bug: 943316
Change-Id: Ice077b4e53309a2a59b254581da7e6dd0f3b409c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553171
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648357}

Bug: 877147
Change-Id: I9bd31a9f9731e3cd50f43e246f9d0565f107bd9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546058Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648356}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dbc721d65f0d..9198ef8ede66


git log dbc721d65f0d..9198ef8ede66 --date=short --no-merges --format='%ad %ae %s'
2019-04-05 nodir@google.com [bot_update] Default to refs/heads/master
2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-04-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@9198ef8ede66

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:940214
TBR=agable@chromium.org

Change-Id: I30e05bb762b0cbb9c78c4cf47c5aecfd16ad45bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553455Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#648355}

Currently, the test pages only check once (on page load) if the specific
session type is supported. If a device is disconnected while a user is
on the page, the "Enter VR" button does not update with that change.
This change enables support within the button to listen to device change
events and update it's state based on whether the specified session
types are supported, and changes all of the pages to consume this new
option.

Given the nature of xr-barebones, it implements this directly as well
rather than relying on the button.

Bug: 873409
Change-Id: I4be8a50f88f796b2e4d7d9f0834d4d77cda7d586
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554643Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648354}

This slipped through the cracks earlier. Our approved
strings include a string to use when no description is
available. We decided to use the same string if the
result was empty, and if there was a server failure.

Bug: 905419

Change-Id: I7c8692f550999428ba2f08ecbc14e3fed6b05a14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552444Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648353}

Bug: 950081
Change-Id: I6a2fb232edaa4f04f761d64e5d223f5fc0471176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555044
Auto-Submit: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648352}

This mostly entailed running clang-format -i * followed by git cl
format. I also manually edited some if statements to reduce nesting.

Change-Id: Ibfd24d1d763435e590a93a7fc5d05572e7fa35d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548068Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#648351}

This experiment has been defaulted to true for a while now.
Simplified the code.

Bug: 884724
Change-Id: I47fb608b703f292ad8edfe8a91ab9a446fe4d6ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554295Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648350}

The padding should alwas be the height of the tab strip, as set in XML.

BUG=946991

Change-Id: Ifd701988a90ec4289979df4632b2999ae4f14d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553827Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648349}

isolate: isolate …/out/Release/browser_tests.isolate:
  partitioning deps: lstat …/out/Release/gen/ui/login/login_resources.pak:
  no such file or directory
https://ci.chromium.org/p/chrome/builders/try/linux-chromeos-chrome/676

Remove test references to login_resources.pak. It was
deleted in I66ea89bd1f240933c9053da5a722b848df79ce40.

Tbr: rsorokin@chromium.org
Bug: 934224
Change-Id: Id5f84da2a0b1d01fdcafda7480a1e29ab336d442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554781Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648348}

Add the whole team to the watch list.

Bug: None
Change-Id: I810a37552ab73ab0a128e36879da2847084d2199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554314Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648347}

This CL removes preempted sequences from TaskTracker,
removing need for CanScheduleSequenceObserver and
simplifying shutdown.
A CanRunPolicy enum is used instead, specifying whether
or not tasks at a given priority can run.
When CanRunPolicy is updated, wakeup workers needs
to be done as appropriate.

In addition, Shutdown was split in 2 phases start + complete
to allow caller (TaskScheduler) to update CanRunPolicy after
shutdown was started.

This CL was recycled from:
https://chromium-review.googlesource.com/c/chromium/src/+/1478007
I took ownership because simplifying Sequence lifecycle
will simplify implementation of job API.

TBR=gab@chromium.org

Bug: 889029
Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648346}

This patch adds a new setting to the Elements category which toggles
showing the styles information on the overlay tooltip when the user is
in inspect mode.

You can see the difference enabled by the new setting in the following
screenshot:
https://imgur.com/a/BjQPwe9

This fixes #948417

Bug: 948417
Change-Id: If15bc5d73fb1571079697bfccd9e5a74e975bd59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553465
Commit-Queue: James Lissiak <jalissia@microsoft.com>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648345}

Bug: 931902
Change-Id: I5fdb90494bbe719f1310f88f9426323edaf4f341
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1471269
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648344}

Update the status sync logic: we used to do the status
sync on hotword change, but it triggers the flow at some
unexpected cases. Thus now we only do the sync on service
start and hotword change from settings menu.

Bug: b/128603723, 941566
Test: Manual Test
Change-Id: I078ae442fe173a00c6d6808fadc621a4e1052c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497199
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648343}

Bug: b/129157032
Test: Manual Test
Change-Id: I2745579fbc1ed6e3d7316d046b53eea145e12130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542778
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648342}

The WebLayerTreeView is a shortcut past the WebWidgetClient that is
not needed now that we always composite. This works toward eliminating
this extra API layer.

More importantly this helps us Close/Restart the WebWidget parts of
WebViewImpl by not requiring plumbing 2 pointers with slightly different
lifetimes (WebLayerTreeView is created inside the Init of the
WebWidgetClient). This will help avoid a bunch of complexity in
creating WebFrameWidgets and other WebWidgets.

The RequestNewLayerTreeFrameSink() method is added to
CompositorDependencies so that RenderWidget unittests can run the
compositor without needing a real RenderThreadImpl.

R=pdr@chromium.org, piman@chromium.org

Bug: 912193
Change-Id: Ieae414387f347e065ab48f536c770e7c55f4d337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546148
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648341}

In preparation for the removal of the effective_uri field, this change
updates the HandleAddDiscoveredPrinter function to perform mDNS
resolution on the printer before attempting to query it for ipp
attributes.

This resolution will be redundant for the time being, but a future
change will remove the effective_uri field so that this is necessary.

BUG=758018

Change-Id: Ie899fd55cd7742e948660ecd19daa0054bc965b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551931
Commit-Queue: Sean Kau <skau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648340}

This updates reset_browsertests to use views based login instead of
deprecated web UI login. Portion of the tests check that reset screen is
shown on restart if local state suggests that reset was requested in the
previous session - web UI account picker UI is not expected to show up
in that scenario, so there is no value in testing it.

BUG=944345

Change-Id: I3953472130878b048ea5b86caaafb1962e1bef96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553874
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648339}

Bug: 949888
Change-Id: I585d327b117aea4fe67d30c590db54e399d5d8d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555050
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648338}

This CL creates the interface ImageDecodeAcceleratorWorker::DecodeResult
which allows ImageDecodeAcceleratorWorker implementations to output the
result of a decode and manage the resources associated with the result.
Specifically, in the case of VAAPI, the result of a JPEG decode is
obtained as a VAImage. This image should be destroyed using
vaDestroyImage() after we're done using the decode result. Therefore, to
avoid copying the VAImage data into a std::vector, we can wrap the
VAImage in an implementation of
ImageDecodeAcceleratorWorker::DecodeResult and destroy the VAImage in
the destructor.

Note that we now allow the size of the decoded data to be greater than
SkImageInfo::computeByteSize(). This is to allow the data to include
padding in the last row.

Test: None.
Bug: 868400
Change-Id: I9f3d82dab3cd75d5c10c1f73b3ebef7a2808299d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549879
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648337}

No change to logic.

This simplifies aw_cookie_access_policy.cc:

 - Inline AwStaticCookiePolicy's body into AwCookieAccessPolicy
 - Rename AwStaticCookiePolicyTest to AwStaticCookiePolicyTest and
   rewrite the tests
 - Consolidate AwCookieAccessPolicy's SetCookie+GetCookie methods into
   AllowCookies() overrides, since we don't distinguish between setting
   and getting
 - Add DCHECKs for threading and to mark the legacy code path
 - Update callsites to use the AllowCookies() methods

This also adds unit test coverage for WebView's special handling of
file:// scheme cookies.

Bug: 932535
Test: run_webview_instrumentation_test_apk -f CookieManagerTest#*
Test: run_android_webview_unittests -f AwStaticCookiePolicyTest.*
Cq-Include-Trybots: luci.chromium.try:android_mojo
Change-Id: I457279d089c347f286f939e2cdcec9e371803730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548511Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648336}

Sending the DevTools request ID through the URLLoader interface allows
us to emit DevTools events from the browser process which refer to
specific requests.

Right now, this will allow us to add request IDs to the
requestIntercepted DevTools event (Bug 899386) and add request IDs to
the new cookie information DevTools events (Bug 856777)

In order to move the rest of our network events to the browser
(Bug 849483), I am planning on extending this new optional request ID to
include other DevTools request metadata, such as the initiator chain.

Bug: 899386, 849483, 856777
Change-Id: Ib92fcbd6da3b418a635cdef164dc1fad98d8ce26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535292Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648335}

RasterBufferProvider instance set by test was used after it was
destroyed. Fix is doing same as in the other tests in TileManager
unit tests: cleanup the reference before with TakeHostImpl() call.

Change-Id: Iaadf91d80686093cd3fc69a40cbfd22f3d45e9d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554668
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648334}

This is the 6th refactoring CL aimed at reducing duplication and
inconsistency for classifying omnibox results.

The historyUrl, zeroSuggest, and clipboard providers can provide
"url-what-you-typed" suggestions; e.g. the input text 'google.com' can
trigger a historyUrl suggestion with contents 'google.com' and URL
'http://google.com/'. The zeroSuggest and clipboard providers explicitly
clear the classifications of their suggestions (probably because there's
no user text associated with the suggestions). The historyUrl
"url-what-you-typed" suggestions classify their descriptions as other
historyUrl suggestions (which was cleaned up in the 5th CL
crrev.com/c/1552140). Therefore, this CL only addresses historyUrl
"url-what-you-typed" suggestions' contents' classifications.

Previously, the contents were classified using
AutocompleteMatch::ClassifyMatchInString and
AutocompleteMatch::ClassifyLocationInString. Specifically, if the user
input began with 'view-source:' and the colon was not followed by a
protocol (e.g. 'http'), then ClassifyMatchInString was used and the
first occurrence of the (slightly modified to be a valid URL) user input
was bolded. Otherwise, if the input did not begin with 'view-source:' or
the input began with 'view-source:<protocal>', then
ClassifyLocationInString was used to bold a number of characters equal
to the length of the user input, offset by the length of the prefix
(e.g. 'http://www.') in the destination URL but not the user input (e.g.
if the user typed 'google.com', the URL would be 'http://google.com/',
and the missing prefix length would be 5) minus the length of the prefix
trimmed from the URL when setting the contents text.

This CL simplifies "url-what-you-typed" classifications to simply bold
from the start of the contents text for the length of the user input. In
most scenarios, this is effectively the same as before. In the few cases
where the new behavior differs from the old, the new behavior is the
more desirable:

1) Typing 'chrome:', 'chrome:/' or 'chrome:// will suggest
'chrome://version. Previously, 'chrome://' would not bold the
suggestion, though the other inputs would bold the entire suggestion;
this was because the URL would be fixed to chrome://. With this CL, all
3 inputs bold the entire suggestion.

2) Typing 'view-source:x' or 'view-source:x/' will suggest
'view-source:x'. Previously, 'view-source:x/' would not bold the
suggestion, even though 'view-source:x', 'view-source:x/y', and 'x.com/'
would. With this CL, all those examples will bold their suggestions.

The reason these cases failed previously was because they have

Worth noting, the "url-what-you-typed" classification could be further
simplified to simply bold the entire suggestion. However, this would
produce less desirable bolding for inputs such as 'file:/' or
'view-source:/'. Both before this CL and with this CL, those inputs bold
only the typed number of '/'s, i.e., '[file:/]//' and
'[view-source:file:/]//' respectively.

Bug: 366623
Change-Id: I5df1b55db8d76408b0d3fb4d6017c6497b17a59b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554058
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648333}

EG1 and EG2 do not share a common set of headers,
so any file that directly includes EarlGrey.h cannot be compiled under EG2.
Scrubbing the headers will enable us (in a future CL)
to share these helpers between EG1 and EG2.

Files that need to change was found by:
git grep --files-with-matches ios/chrome/test/earl_grey/chrome_earl_grey_ui.h . | grep .m | xargs grep -L '<EarlGrey/EarlGrey.h>'

All *.mm file that have chrome_earl_grey_ui.h also have chrome_earl_grey.h
So it means that after http://crrev/c/1554188 only 2 files need to be changed.

Bug: 922813
Change-Id: Ia8f740f30071797ea91c1047dcef582d59c05c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552161
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648332}

Restoring |pending_state_map_| and the code that posts a task to the IO
thread to destroy the SecurityState because we get a lot of
RenderFrameMessageFilter::GetCookies() and
RenderFrameMessageFilter::SetCookies() crashes without this.

Change-Id: Ia6d483f91eda89f38779e88bf8cb17565870bfbb
Bug: 943887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554407
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648331}

This is a follow-on to crrev.com/c/1542177 where we split
CacheStorage/CacheStorageCache into separate interface and
implementation classes.  This CL moves the new LegacyCacheStorage and
LegacyCacheStorageCache classes into separate files in a new "legacy"
directory.

This CL only moves code and updates include paths.  It does not modify
any functional code.

Bug: 940449
Change-Id: I41059a3545f716042ed55a03a011264684054d73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548298Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648330}

Bug: 947115
Change-Id: I2629dc9b057697613857c9d27deb29b01a581e9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545708
Auto-Submit: Misha Efimov <mef@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648329}

Historically, we used [NoInterfaceObject] and 'implements'
to make interface mixins.
Now interface mixin was supported. So let's replace them.
All interfaces updated in this CL are defined to be mixins
in specs.

This CL also disables to 'impelemnt' [NoInterfaceObject]
interfaces.


Note: We are still using 'implements' which needs to be
replaced with 'includes'.


Bug: 781257
Change-Id: I754ec1047b8e4944d95dcc0103d0afafb1cabf67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552206
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648328}