- 20 Jul, 2020 40 commits
-
-
Lei Zhang authored
OutOfProcessInstance requires PPAPI dependencies. So split it away from the "internal" target, which is migrating away from PPAPI. Bug: 1103478 Change-Id: Id17208b497b4f2e45c015fc702b82d1c16282771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293326 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789974}
-
Darwin Huang authored
|plain_text| was added in https://crrev.com/c/2243532/. It was used in earlier patchsets of the CL, but not by the time it was submitted. Change-Id: Ica681acb88455d9c29f8e0189dd8c4c88569e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296480 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789973}
-
Dave Tapuska authored
- Move cc::BrowserControlParams into CC - Move definition of VisualProperties into blink and use a typemap - Add typemapping for LocalSurfaceIdAllocation for blink too. - Add mojom_traits for ScreenInfo and VisualProperties. BUG=1097816 Change-Id: I8e0742d74438ef489020aecbb03cb6b5bbb55763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299525Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789972}
-
Kramer Ge authored
gl_tests_passthrough are failing on Linux FYI Release (AMD R7 240) because both use_virtualized_gl_contexts and use_passthrough_cmd_decoder are true. Bug: 41017049 Change-Id: I03ac645a90db613adb53b254fdf7729bcdeac30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307171Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#789971}
-
Majid Valipour authored
Currently the sms_service_unittests only exercises the verification backend which is not actually active by default since we are currently using User Consent backend. More than half the tests (10 out of 10) seems to apply to both backends. This patch refactors the logic so that the backend specific part of sms service are well encapsulated. It then updates the test so these common tests are exercised with both backends. Changes: - Introduce UserConsentHandler with two specific implementation 1. Noop: which does not show any UI to user and is used with user consent backend. 2. PromptBased: which prompts user to give consent and is used with verification backend. This encapsulates previous OpenInfoBar, OnCancel, OnConfirm methods from sms service. - The consent handler is created on construction of the service and is used for its lifetime. This makes it possible to easily inject mock consent handlers for testing. - Update mock Service to use a simple Noop consent handler for common tests which don't involve consent. - Introduce a more specialized ServiceWithPrompt that uses a prompt based consent handler for tests specific to prompt based logic. - Add unit tests for consent handlers. - Minor renaming, comments to clarify the code further. There is not expected to be any functional changes in this CL. Change-Id: I411bf9d12cb7a2051e545ce6dd8a50fe37204326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254447Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789970}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b12cba1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id42e40844442630aa6da2992273855da753cb83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305920Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789969}
-
Carlos Caballero authored
This will allow us to make sure that the frame is current before showing any UI prompt to users. E.g. we do not what to show prompts for pages that are in the bfcache. The actual checks will be added in https://crrev.com/c/2307212 Change-Id: I0ba28d8ef089e3deec0e89cc2239ee8bd1890a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236437 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#789968}
-
Jun Mukai authored
This CL introduces specific views_delegate implementation and screen, a window tree host, and some aura clients to make the views_examples working with target_os="chromeos". Bug: 1106480 Test: manually checking views_examples Change-Id: I25a8fc26d35e91452bd1bcee98f4b3bcecbd5021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304098 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#789967}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ba1777cebcd..16fbc2477205 2020-07-20 jlavrova@google.com Reland "ICU API: only in SkParagraph, simplified (relanding reverted)." 2020-07-20 adlai@google.com Remove more GrContext imports & usage 2020-07-20 brianosman@google.com SkVertices: Fix calculation of size needed for attr marker names 2020-07-20 kjlubick@google.com [canvaskit] Make effect deserialization on for everything but npm. 2020-07-20 kjlubick@google.com [canvaskit] Enable some options on npm build 2020-07-20 egdaniel@google.com Fix vulkan unmapping of buffers during release. 2020-07-20 kjlubick@google.com [pathkit] Publish 0.7.0 to npm 2020-07-20 kjlubick@google.com [canvaskit] Publish 0.17.0 to npm 2020-07-20 johnstiles@google.com Move test code out of header into CPP file. 2020-07-20 kjlubick@google.com Fix more swiftshader links 2020-07-20 michaelludwig@google.com Respect SK_FORCE_8_BYTE_ALIGNMENT in GrBlockAllocator 2020-07-20 robertphillips@google.com Clean up some GrContext in tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106889,chromium:1107173 Tbr: robertphillips@google.com Change-Id: I4277e2203f85140166cd06bea19cb3614987f9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789966}
-
Jarryd authored
Bug: 1089336 Change-Id: I46edfeea4c7774ed73b7e1c78a394d0e906e8848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281204 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#789965}
-
Mugdha Lakhani authored
PrerenderHttpAuthentication has been deleted from Prerender browsertests, and an equivalent test added to NoStatePrefetch tests. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I539097682d2b842519538cb417c2e31ca1613f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297563 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789964}
-
Gang Wu authored
This is a reland of 5d52e576 Original change's description: > Reland "Reland "[Omnibox] Use ActivityState to check if we are in browser mode"" > > This is a reland of 5ae112d1 > > Original change's description: > > Reland "[Omnibox] Use ActivityState to check if we are in browser mode" > > > > This is a reland of be1e9636 > > > > Update the test to run on UI thread. > > > > Original change's description: > > > [Omnibox] Use ActivityState to check if we are in browser mode > > > > > > > > > In multi windows mode, check if we are in browser mode by WindowAndroid > > > is not working, should check ActivityState instead. > > > > > > Bug: 1102640 > > > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786636} > > > > Bug: 1102640 > > Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074 > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788816} > > Bug: 1102640 > Change-Id: I6da3c7ad8402cef83083a53f7ffc517f975720f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301285 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789727} Bug: 1102640 Change-Id: Ib1a0f38d107df76dd0b6e7f3595c57f3fb066a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789963}
-
Maksim Moskvitin authored
The test is constantly failing on linux-chromeos builders. TBR=emaxx@chromium.org,cylai@google.com Bug: 1107426 Change-Id: I2ec9626bb2076d9382d8186578628a621b127bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307334Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789962}
-
Michael Spang authored
This is necessary to remove uses of the deprecated TaskEnvironment::DeprecatedGetMockClock function in tests. Change-Id: I56425b2bcc81b21d93c69c683b4134ee389704cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306374Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789961}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/13480cb0ab94..6af6e625573f 2020-07-20 bclayton@google.com Update license-checker.cfg with simplified rules (#1107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ieb80823dfd03930eb879d200914a8fe6b1e4eab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789960}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd5df6887258..fa504e744f9b 2020-07-20 dminor@webrtc.org Check that capture time is valid before adjusting it. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5cdb06394e116ab0e81f8b08bb6c177d13e94524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789959}
-
Boris Sazonov authored
Replaces ChromeSigninController usage in AndroidSyncSettings ctor with IdentityManager. Bug: 1093998 Change-Id: I56fc23be5f2849288d2aa425ccb90a7a5a385263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289972 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#789958}
-
Meera Srinivasan authored
Change-Id: Ifb0e6255745bf0e25919e53c5c463ad30de9a4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304964 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789957}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4181.3-1594638142-benchmark-86.0.4204.0-r1 to 86-4181.3-1594638142-benchmark-86.0.4205.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7488e9f082f4da2c707f809575440885fe8d2e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789956}
-
chrome://flagsTommy Steimel authored
Bug: 1107363 Change-Id: Ie97662d5f9a81ce10ffb568a9ed573a75282d4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307471Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789955}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=wjmaclean@chromium.org Change-Id: I53ed23666357b69f6f5b071ccafba3fd9f35e35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298763 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#789954}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/343030c9..562c3f95 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29816df57a3d78f1753e5ac182d5c2838510376d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789953}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I08c4cf62e138007e8946196eeadf1bcb00b74e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789952}
-
bttk authored
Documentation of RuntimeEnvironment#application says: Deprecated. Please migrate to androidx.test.core.app.ApplicationProvider#getApplicationContext Change-Id: I5f5b71e29edf99f4b6ee692247ea6910a0eb692c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305369Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789951}
-
Michael Ludwig authored
Bug: 1097104 Bug: 1098743 Change-Id: I71af4756efb3d3f030e3e61913e71a0b1c4f6148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303670 Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#789950}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I44f63e4c8913862c70b9817dac349751ad53d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307368Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789949}
-
Peng Huang authored
There are many errors like: Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x395107e6050, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xe92b452d | vkQueuePresentKHR() called even though the VK_KHR_incremental_present extension was not enabled. Suppose vulkan should ignore unsupported or not enabled structures in structures chain, but vulkan validation reports it. It is annoying. So fix it by not passing unsupported VkPresentRegionsKHR in VkPresentInfoKHR. Bug: None Change-Id: I7cfff50ccc3f42a08a5b0ade481e297f129f6e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305512 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789948}
-
Alexander Dunaev authored
A recent improvement of memory usage in ozone/x11 clipboard [1] introduced a regression: copying the text stopped working because the standard MIME type for the UTF-8 encoding was not inserted into the map. This CL fixes that. [1] https://crrev.com.com/c/2292396 Change-Id: I5cedb36253a4f2be392e937f62781417eead8ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306252 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789947}
-
Sebastien Marchand authored
This NetworkServiceClient owns a MemoryPressureListener and it's necessary to ensure that this listener gets destructed at shutdown to avoid UAFs in tests (see crbug.com/1081151). Bug: 1081151 Change-Id: Ia72a4fd35e17effe00f71018f032f2bd62118182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293162Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789946}
-
Yann Dago authored
Bug: 1095206 Change-Id: I12d69fa120c1114700e947c4f56e39c0e39c13c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300401Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#789945}
-
Mugdha Lakhani authored
Move prerender_util to components so WebLayer code can eventually use it. Bug: 1057771 Change-Id: I3b608212c12f951ae5b0a79986dd3f19e9432ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235619Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#789944}
-
Maksim Moskvitin authored
This reverts commit 9b0c684e. Reason for revert: likely the culprit for unit_tests failures on multiple builders (see crbug.com/1106339). Original change's description: > Reland "Reland "Turn on Media History by default"" > > This is a reland of c670ba45 > > Original change's description: > > Reland "Turn on Media History by default" > > > > This is a reland of ccf0e2f9 > > > > Fixes TSAN issue in the constructor of sql::Database > > by moving it to the main thread. > > > > Original change's description: > > > Turn on Media History by default > > > > > > BUG=1024351 > > > > > > Change-Id: Id01595e63f5f776a226087741ef602ba30b80328 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224 > > > Auto-Submit: Becca Hughes <beccahughes@chromium.org> > > > Commit-Queue: Tommy Steimel <steimel@chromium.org> > > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#787954} > > > > Bug: 1024351 > > Change-Id: I19be665637f5c28261f7197547ddc5fe6671127e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296884 > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788312} > > Bug: 1024351 > Change-Id: Ie371d56df987c19a10017050ead02922a530f2ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300224 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788721} TBR=beccahughes@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024351 Change-Id: Ie255e6d2b0a88efa130e15019c2d6e5e4049b869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306095Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789943}
-
Victor Hugo Vianna Silva authored
Before this CL, no SyncPrefs[1] were sent via the sync-prefs-changed WebUI event if the user was signed-in but had Sync disabled. This CL changes this, relaxing the early exit checks in PushSyncPrefs(). The change is safe because checking IsEngineInitialized() is enough to guarantee the existence of the SyncUserSettings used to fill the JS object. The CL also fixes an aspect overlooked in crrev.com/c/1718425. PushSyncPrefs() had the undocumented side-effect of setting the configuring_sync_ member, which makes no sense when the method is called in HandleSyncPrefsDispatch(). So the assignment is now moved out of PushSyncPrefs() and copied to the other callsites. [1] https://source.chromium.org/chromium/chromium/src/+/9cff09c426fb0436ce35f7c571f555e576534aaf:chrome/browser/resources/settings/people_page/sync_browser_proxy.js;l=94 Bug: 1106350 Change-Id: I9d3167d534957f10dcd878eda918bdd1510c2973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302852Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#789942}
-
Philip Rogers authored
Change-Id: Ifd72366f13def1a12c2f16392ff378c58b23b907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307366 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789941}
-
Jose Dapena Paz authored
For certain cases where a div with RTL direction is set to be LTR, the algorithm for determining if bidi runs should be recalculated and reshaped was not properly ran. This is a regression introduced by https://chromium.googlesource.com/chromium/src/+/25d80f4bead925c2d9071b59a4f32146432d3e9e The solution is merging the two conditions introduced in the original patch (NeedsReshape and NeedsCollectInlines) in one that has been named NeedsReshape. Bug: 1009654, 1104827 Change-Id: I32fceb75f83b9cf2aac3ef982675a96a3ef4d3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297432Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#789940}
-
Tina Wang authored
This reverts commit 4977ba83. Reason for revert: Cause tree closure: https://ci.chromium.org/p/chromium/builders/ci/GPU%20Win%20x64%20Builder/16259? Original change's description: > Roll Skia from 3ba1777cebcd to 0c5bb2f776a5 (1 revision) > > https://skia.googlesource.com/skia.git/+log/3ba1777cebcd..0c5bb2f776a5 > > 2020-07-20 robertphillips@google.com Clean up some GrContext in tests > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/skia-autoroll > Please CC robertphillips@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Bug: None > Tbr: robertphillips@google.com > Change-Id: Iffb5c6989a63db91bae17759a4db4ce058212eb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307365 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789930} TBR=robertphillips@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I0bd1f105862dc551470c72d009d320e7697568ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307411Reviewed-by:
Tina Wang <tinazwang@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789939}
-
Bartek Nowierski authored
It should've been part of https://crrev.com/c/2306131 Bug: 1092288 Change-Id: I873c8cc804ad15e6970fb00ed0b083c490c10d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307390 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789938}
-
Eric Seckler authored
Bug: 1105001 Change-Id: Ifbd9d8c16d7cf9f9571125207e9543d9f3705e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304749 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789937}
-
Francois Doray authored
This feature no longer exists and is not needed for tests. Change-Id: I5f5bb7e6ae3a4b90c0ea5638737e13eb4b20c5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305513Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#789936}
-
Sylvain Defresne authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/d585128c..3028c6a4 3028c6a4 [apple] Remove support for frameworks in libs 1e3fd10c [rust] Write {{sources}} ninja variable for Rust targets 46ad4c45 [xcode] Fix running XCTests and XCUITests with New Build System Change-Id: Idf49e9d103835214bd51775ed706ca8f65e952e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307213 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#789935}
-