- 03 Jun, 2020 40 commits
-
-
Nicolas Boichat authored
The metrics is still in use and unlikely to be dropped before end of 2023. Bug: 1089269 Change-Id: Ic4d9e7fa54044b15ffb771455f0940c46b8e0378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226098Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774781}
-
Robert Sesek authored
Bug: 1052560 Change-Id: Id7546c72f246c9910eadd6edcb49b71bb9ec8d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227858Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#774780}
-
Robert Liao authored
Interest in this metrics will exist as long as there are tabs and windows. Fixed: 1089571 Change-Id: Ib9f0d92471c0fc8842270ec2155a40203ffd6b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225492 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7bb7115d07b9226145f7e6a15aff51953b0dbb84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227908Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774778}
-
Francois Doray authored
TBR=fdoray@chromium.org Bug: 1090937 Change-Id: Ie0db29a4028ce87458ca16c32509ac9e56b9001e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229017Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774777}
-
Fletcher Woodruff authored
Push back the expiration date 5 releases. Bug: 1088720 Change-Id: If9ebf9dd252f01e75d17c6d91508a999b0f6404e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224972 Auto-Submit: Fletcher Woodruff <fletcherw@chromium.org> Reviewed-by:
-
Nate Chapin authored
This reverts commit 46c7d082. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1090597#c4 Original change's description: > Remove all non-DocumentLoader uses of LocalDOMWindow::InstallNewDocument > > LocalFrame::ForceSynchronousDocumentInstall and a few unit tests > manually replace the Document of a LocalDOMWindow. They can be switched > to go through the static-response navigation commit path relatively > easily. This establishes the rule that only DocumentLoader is allowed > to create a LocalDOMWindow or replace its Document. > > Bug: 1029822 > Change-Id: I84b37f35be5387556999f9bc24f7ba5fa74b4ff8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222776 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773720} TBR=dcheng@chromium.org,haraken@chromium.org,japhet@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029822 Change-Id: I58b897f7bb5327765c86f907a5179bb76fcccf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229104Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#774775}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia13e5a77a126b0f4ee14365a938501ddbf26cdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229300Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#774774}
-
Chris Lu authored
Change-Id: I22d295b2e3f014b2d279ef6729e405399dd15349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227394Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#774773}
-
Ali Juma authored
This changes PolicyDecisionStateTracker's destructor to invoke the state tracker's callback if it hasn't already been invoked. Destroying the callback without ever invoking it can result in a WKWebView-provided callback never getting invoked, which triggers an NSException causing a crash. In the linked bug, the PolicyDecisionStateTracker is destroyed as a result of MainFrameUrlQuery::operator= implicitly releasing its old response_callback, which owns the state tracker. An alternative fix would be to change that method to invoke the old response_callback. However, the change made by this CL is a more general fix for the problem, and should prevent similar issues in the future. Bug: 1079471 Change-Id: Ib8782b2278cace0f24692dbe951d498792111095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229201 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#774772}
-
Juanmi Huertas authored
This reverts commit 69917e2b. Reason for revert: Removing the fallback broke Android tests. Original change's description: > Removing CPU fallback in webgl::getImage > > According to comment below in line 787, this method > expects the canvas resource provider to provide > always GPU resources. > > This also currently passes all the existing tests, > so it's probably safe to remove this fallback. > > Bug: 1035589 > Change-Id: I82a426d29a8a37755ee36d2a14f006bd62fa5bb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225479 > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774683} TBR=jdarpinian@chromium.org,juanmihd@chromium.org Change-Id: I6dcffe3cbeb3389509f4b4abcd14f3e681a6357a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1035589, 1090962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227884Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#774771}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/341434e4da2c..a4dfe24d7696 2020-06-03 titovartem@webrtc.org Add missing deps for android libs to unblock chromium roll 2020-06-03 danilchap@webrtc.org in libaom decoder use public control function instead of internal one 2020-06-03 handellm@webrtc.org AudioDeviceMac, AudioMixerManagerMac: remove lock recursions. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I81d1470b2e70fb3174f58a3f737cdf4b01fc45f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229262Reviewed-by:
-
Matt Wolenetz authored
Previous fragmented mux of this test file marked nonkeyframes in input as keyframes in output. Remux fixes that, though the MOOV's duration and creation date are cleared, so test is updated to expect the stream to appear to be "live". The test is also updated to expect the correct sequence of emitted key and nonkeyframes. TEST=MP4StreamParserTest.MPEG_XHE_AAC BUG=1079034 Change-Id: I9c7fd981fe4cea92e1ff0a90058ea1f10905d996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225244 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#774769}
-
Sebastien Marchand authored
Bug: 1030399 Change-Id: I5a6bea720e63716033d1e8a4bd22acfcfed4e643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225382 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
-
Mirko Bonadei authored
As compression_utils_portable is been used by client code instead of only internally in zlib helpers, there is the need to properly export the right flags (i.e. header include paths) as some OSes (e.g. Fuchsia) may have issues properly building/linking with zlib. Bug: 1076580, 1087999 Change-Id: Ic54a55db40301dead92402e05c5da5613eb29c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228311Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774767}
-
OlivierLi authored
Change-Id: I2a5238aae826071fef5e03e7938fc483e073be5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227033 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#774766}
-
Leonard Grey authored
Bug: 1089252, 1089782, 1089254 Change-Id: I4ec3271390108a408dfb00818348251787a0d3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229200 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774765}
-
Alex Ilin authored
This reverts commit 2d660071. Reason for revert: fixed the tests by increasing the dialog interaction timeouts Original change's description: > Revert "[signin] Add reauth browser tests with a fake Gaia page" > > This reverts commit 62ff616d. > > Reason for revert: > Both of these are failing on MSAN: > SigninReauthViewControllerBrowserTest.CancelReauthDialog > SigninReauthViewControllerBrowserTest.ConfirmReauthDialog > > Original change's description: > > [signin] Add reauth browser tests with a fake Gaia page > > > > This CL adds a new set of tests for the reauth dialog. These tests > > check interactions with a Gaia Reauth endpoint that is imitated through > > an EmbeddedTestServer. > > > > The main "embedded/xreauth/chrome" endpoint operates in two modes: > > - In the default mode, the endpoint redirects to the "challenge" URL > > whose response can be controlled within the test by a > > ControllableHttpResponse. > > - If the "?done" query is present, the endpoint returns the > > HTTP_NO_CONTENT response that signifies a successful reauth. > > > > The CL also extracts common test code into test suite functions to > > reduce the code duplication and make the tests code more readable. > > > > Bug: 1045515 > > Change-Id: I89d4aac57ef25168def1341fb63b1a7498dcfa0f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225396 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#774205} > > TBR=droger@chromium.org,alexilin@chromium.org > > Change-Id: I9e322b00bb98f9394b81fda2a0e62bf5db5cd9e9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1045515, 1090451 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225852 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774265} TBR=dmazzoni@chromium.org,droger@chromium.org,alexilin@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1045515, 1090451 Change-Id: I733694fb5790290fe6ae1e661708ddce4a7988c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228540Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774764}
-
yilkal authored
This cl adds back buttons on some EDU coexistence screens which were missing. Screenshots can be found here: 1. 1. https://drive.google.com/file/d/1xGMbc2pSrJuHs-IETtOOvdWC0Ftis4-4/view?usp=sharing Bug: 1082336 Change-Id: I516bbdb23d5b5b3327cbb9587532bcf9b876c438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227259Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#774763}
-
David Black authored
Previously, AssistantPageView would not update app list state when being shown. With the Better Onboarding feature, AssistantPageView is too tall to render in peeking state w/o being clipped off screen. Now, AssistantPageView will check if it needs to update app list state when being shown. This should have no effect on existing behavior as only the Better Onboarding feature should cause this to happen. The Better Onboarding feature is disabled by default. Bug: b:157689497 Change-Id: I662eea9c181674d2af88790ac86daa6cd24a4f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225513Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#774762}
-
James Cook authored
Several tests use a test helper method that contains both logic and expectations, as well as conditionals on the feature SplitSettingsSync. Eliminate the test helper and put the expectations directly in the tests. This involves a bit of copy/paste, but follows the spirit of DAMP not DRY testing. go/tott/598 Only expect conditions relevant to the test (e.g. don't check for metrics histograms again in the language switch tests). Force branded builds once in the test suite, which makes the tests more concise. The existing tests that un-force branded builds continue to work fine due to AutoReset. Bug: 1074436 Change-Id: I41865cf2e8df15fed0c78a6b5b8ea761d29a9495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228354 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
David Bertoni authored
The DownloadExtensionTest_FileIcon_Active test was disabled for flakiness on Windows and Linux. It passed 3000 iterations on the trybots with only one flake on the Linux debug trybot. Bug: 678967 Change-Id: Ic126abed0972ff7b04496a73760a7bdcf93c6e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226917Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774760}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/78eb17fc53a8..ebc6d0a4b9ec 2020-06-03 nguyenmh@google.com Presubmit script to enforce commit message formatting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Ibcb680390bc23d12747ee80b440aac4357979851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229106Reviewed-by:
-
Gabriel Charette authored
No TaskTraits implcitly meant base::ThreadPool. The migration away from this paradigm is complete (task APIs v3 is bringing explicit API-as-destination). Remove this right away before we're ready to completely remove post_task.h to avoid the addition of new callers without an explicit destination. Bug: 968047, 1026641 Change-Id: I54d04872498d340cfd8ec02aa88b3e9cba1a7547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225541 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#774758}
-
Ilya Nikolaevskiy authored
[Viz, capture] Fix corruption bug: Invalidate marked buffer on reuse and remark frames on size change The marked buffer must be invalidated, because otherwise it might be used as if it had a correct latest version of the image, while it was overwritten by a smaller image. The second part of the CL is an optimization: If the capture size was reduced due to pool overuse, but content is static, previously it was impossible to cache the result and unnecessary CopyOutputRequests were constantly made. The drawback of the change is that if captured size is changed very rapidly, more copyOutputRequests would be made than before. In all other cases it is optimization. Bug: chromium:1090301 Change-Id: Ia3e6f3dd8901110e5dc07ef1398fb8478717ef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225766 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Cr-Commit-Position: refs/heads/master@{#774757}
-
David Benjamin authored
Net.SSLSignatureAlgorithm is in the same category as Net.SSL_CipherSuite and Net.SSL_KeyExchange.ECDHE. It's monitoring a core TLS parameter to aid deprecations, etc. Net.SSLHandshake{Details,EarlyDataReason} are a bit newer, so for now I've bumped them by a year. They probably should be in the same category, but since we haven't launched 0-RTT yet, let's double-check in a year that we still care about this. Bug: 1089025, 1089024 Change-Id: I448278e0e72e99d24880020b75458758250b6a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227060Reviewed-by:Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#774756}
-
evliu authored
Bug: 1088519 Change-Id: Ia753ac36e399583d162856c15d9f4d330610c7ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224871Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#774755}
-
Lukasz Anforowicz authored
CheckedPtr requires C++11 - including checked_ptr.h will cause compilation errors when compiling C-only sources. This CL suppresses rewrites if the clang::CompilerInstance indicates that it is compiling a C-only source file. Additionally, the CL excludes from the rewrite fields declared under a |extern "C"| declaration context - such context is a strong hint that 1) the struct might need to be used from a C-only source and 2) the struct needs strict ABI compatibility (not guaranteed by the CheckedPtr which might repurpose some bits of the pointer). Bug: 1069567 Change-Id: Ib146acbf1f5ae075c2498c000104cebe9cc36b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181527Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#774754}
-
Xing Liu authored
ImageFetcher.fetchGif now uses ImageFetcher.Params, same as the fetchImage() API. TBR=mcarlen@chromium.org Bug: 1076515 Change-Id: I62f2ecd48ea00ffb430da66efa1a9d30f019eaf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226778 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#774753}
-
Maggie Chen authored
GPU.WatchdogThread.WaitTime.NumOfUsers GPU.WatchdogThread.WaitTime.ProgressAfterWait Bug: 1086208 Change-Id: I78cdadc502a4a353857a473810a388e19af67a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227392Reviewed-by:
-
Marc Treib authored
Extended: - Signin.InvestigatedScenario - Sync.Preferences.ClearedLocalPrefOnTypeMismatch - Sync.PeakAnalysis.* - Sync.CustomSync2 Expired: - Sync.Preferences.RemotePrefTypeMismatch While I'm here, I'm also adding a second owner to some histograms that had only a single owner before. Bug: 1089541, 1077810, 1089545, 1089515 Change-Id: I51304706a8e6fc414c6617daae7e6b4d764a6bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228655 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Mike Frysinger authored
If we're appending content and the line is too long, do not split words in the middle. In some cases, like JSDoc, the generated comments are structured data we need to keep intact. Instead, we wrap the entire line. Bug: 1086375 Change-Id: I84087e1586a2837dead61e2d3f6a5689d3bb10d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222148 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774750}
-
Li Lin authored
Quick Answers query might get rewritten based on the intent generated on device. Some cases, the backend might not be able to fulfill the query, We would like to use the title instead of the rewritten query in this case. Bug: b/158040239 Test: manual test Change-Id: I5e9efc363498f535b6fb03e8f7743b4db613e223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227689Reviewed-by:
-
Zhaoyang Li authored
This reverts commit c8232e7f. Reason for revert: A current spike in iOS cq resource. This revert can help a bit. Can reland when resource gets better. Original change's description: > [code coverage] Enable 3% CQ experiment for ios-simulator-code-coverage > > Will observe if there are issues from the experiment then set code > coverage as default in iOS CQ builders. > > Bug: 1090188 > Change-Id: I77e58aefbfc4964f63de61cef7bd7a351d11bfc7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227236 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774443} TBR=gbeaty@chromium.org,zhaoyangli@chromium.org Change-Id: Ifb20a8271a3f0ccc5b7830bbcfb2374d72848553 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229328Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774748}
-
Brian Liu Xu authored
This changelist modifies accessibilityHitTest in AXPlatformNodeCocoa so that it only recurses on child accessibility elements with frames that contain the specified point for hit testing. Per the Apple Developer Documentation for accessibilityHitTest, the method should only be called when the specified point has already been determined to lie within the accessibility element's frame. Previously, the lack of child bounds checking sometimes resulted in web content being unexpectedly returned by the hit test, even if the point was actually over the browser chrome, e.g. a toolbar button. AX-Relnotes: macOS accessibility feature Hover Text now works in the tab strip, toolbar, and bookmark bar. Bug: 1090845 Change-Id: I649d902f8214387fe6e0930b637f2b0e85cc0649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227865Reviewed-by:Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Brian Liu Xu <brx@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774747}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/84515482ba9a..6049cc3934c0 2020-06-03 treehugger-gerrit@google.com Merge "tp: switch merged metrics script to python3" am: 7d9cafd0df 2020-06-03 treehugger-gerrit@google.com Merge "tp: metatrace parser: fix counter track names" am: 84515482ba 2020-06-03 fmayer@google.com Merge "Do not associate incorrect symbol_set_id." am: 6279824654 2020-06-03 simonmacm@google.com Merge "Determine an overall view of when any wakelock was held by merging slices." am: c155bd14e3 2020-06-03 fmayer@google.com Do not use id as row number. am: fb2bd34e2d 2020-06-03 treehugger-gerrit@google.com Merge "Frame lifecycle MVP updates" am: d4d88908b1 2020-06-03 fmayer@google.com Fix RssHWM -> VmHWM in docs. am: 890735b8c8 2020-06-02 taylori@google.com Fix thread state UI bug am: 9d83693a5a 2020-06-02 treehugger-gerrit@google.com Merge "trace_processor_shell: don't quit on CTRL-C" am: a40746d976 2020-06-02 primiano@google.com Merge "ui/tp: fix race in trace-processor --httpd and improve performance" am: fc0efae149 2020-06-02 ddrone@google.com Fix a bunch of typos am: dad4850e5d 2020-06-02 simonmacm@google.com Merge "Fix time-in-state annotations." am: 09fe6260ed 2020-06-02 rslawik@google.com Merge "Handle exhaustive time_in_state snapshots" am: e6dfb1ad40 2020-06-02 treehugger-gerrit@google.com Merge "Add reached code trigger name metadata for chrome" am: 9f846603b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2390f7f25ce49fc0463cac834ae48fb1105cc1da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229109Reviewed-by:
-
Hazim Mohamed authored
In https://github.com/WICG/native-file-system/pull/174 the spec for how sandboxed FS is exposed was change, this updates to implementation to match the spec. R=mek@chromium.org Bug: 1081287 Change-Id: I0e381c873db98e30baed6679be048031b385cc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220685 Commit-Queue: Hazim Mohamed <hazimmohamed@google.com> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774745}
-
Nnamdi Theodore Johnson-Kanu authored
References to assertNotReached() cause closure compilation to fail for code using JS modules. This CL removes these generated calls at the top of the files, and replace the calls serving as placeholders with empty implementations. Updates were generated using a script ./tools/json_schema_compiler/compiler.py extensions/common/api/bluetooth_private.idl --generator=interface > third_party/closure_compiler/interfaces/bluetooth_private_interface.js and ./tools/json_schema_compiler/compiler.py extensions/common/api/bluetooth.idl --generator=interface > third_party/closure_compiler/interfaces/bluetooth_interface.js Bug: 1045266 Change-Id: I339d41278d7390d457c94325b5be3eb9021ad2ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225816 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774744}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I02efd374b4157d332b359f821be7cee09db7dca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229115Reviewed-by:
-
Rafael Cintron authored
D3D12 requires that we use flip model swap chains. Flip swap chains require that the swap chain be connected with DWM. DWM requires that the rendering windows are owned by the process that's currently doing the rendering. To workaround this problem, we use gl::ChildWindowWin to create a window that is reparented by the browser to be a child of its window. Bug: 1071458 Change-Id: I212df12ec21f3fbc00e08b63a741b05b14771c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223371 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#774742}
-
