GitLab

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/6293008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64877
TEST=Existing unittests; manual testing.

Review URL: http://codereview.chromium.org/6079012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71656 0039d316-1c4b-4281-b951-d872f2087c98

The GPU process cannot be placed on a UI thread in --single-process mode because glib is not thread safe. This patch moves it onto a IO thread instead.

Connections to the X server are not thread safe. I've made changes so that each thread gets it's own connection.

Finally, GpuHostMsg_GetViewXID needed to be needed to be sent from the thread added to GpuChannel instead of ChildThread::current().

BUG=69674
TEST=try --single-process with --enable-accelerated-layers on http://webkit.org/blog/386/3d-transforms/

Review URL: http://codereview.chromium.org/6340004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71655 0039d316-1c4b-4281-b951-d872f2087c98

Failing browser_tests on some platforms with JavaScript ReferenceError.

BUG=none
TEST=none

TBR=ager@chromium.org
Review URL: http://codereview.chromium.org/6309006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71654 0039d316-1c4b-4281-b951-d872f2087c98

TEST=`./tools/valgrind/waterfall.sh fetch` then `./tools/valgrind/waterfall.sh match`
Review URL: http://codereview.chromium.org/6057006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69941
TEST=None
TBR=isherman

Review URL: http://codereview.chromium.org/6336006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66414
TEST=none
TBR=dtu

Review URL: http://codereview.chromium.org/6289008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71650 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6296008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71649 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses all the memory errors in LayoutPluginTester.FLAKY_SelfDeletePluginInvoke started since r71589 <http://crrev.com/71589>. I'm wondering if these suppressions are good ones, though.

TBR=thestig,timurrrr
BUG=69934
TEST=make the "Linux Tests (valgrind)(4)" bot green.
Review URL: http://codereview.chromium.org/6320006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71648 0039d316-1c4b-4281-b951-d872f2087c98

For ChromeOS: when starting session: if locale was changed (as a result of sync or because user preference differs from login locale): show notification.

BUG=chromium-os:9164
TEST=Manual

Review URL: http://codereview.chromium.org/6249009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiles with use_openssl=1 flag.

Review URL: http://codereview.chromium.org/6338004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71645 0039d316-1c4b-4281-b951-d872f2087c98

This change just re-adds SpeexEncoder::~SpeexEncoder(), which has been deleted by r71599 <http://crrev.com/71599> to delete the speex resources allocated in SpeexEncoder::SpeexEncoder().

BUG=69906
TEST=make the "Linux Tests (valgrind)" bot and green.
Review URL: http://codereview.chromium.org/6294005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71641 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71639 0039d316-1c4b-4281-b951-d872f2087c98

Deleted kEnableLoginImages flag.

BUG=chromium-os:7214
TEST=Old login screen should not show up even under automation tests for login.

Review URL: http://codereview.chromium.org/5809001

TBR=avayvod@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69193
TEST=No direct test; watch crash reports to see if the crash that's supposed to be fixed by this still occurs.

Review URL: http://codereview.chromium.org/6316003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71636 0039d316-1c4b-4281-b951-d872f2087c98

The former members of the dict are now included directly in the policy definitions.

BUG=64898
TEST=existing unit tests in tools/grit/grit/format/policy_templates/

Review URL: http://codereview.chromium.org/6360002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71635 0039d316-1c4b-4281-b951-d872f2087c98

TopSites has been enabed since r64072. It's now time to remove
the dead code.

BUG=69492
TEST=Make sure thumbnails are correctly updated as before. try bots.

Review URL: http://codereview.chromium.org/6283001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71634 0039d316-1c4b-4281-b951-d872f2087c98

This change suppresses occasional leaks for Bug 69919. (Even though these leak do not happen always, they happen pretty often.)

TBR=thestig,timurrrr
BUG=69919
TEST=make the "Linux Tests (valgrind)(1)" bot green.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71633 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam

BUG=69918
TEST=browser_tests
Review URL: http://codereview.chromium.org/6304008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71632 0039d316-1c4b-4281-b951-d872f2087c98

This change temporarily suppresses the leaks caused by r71599 <http://crrev.com/71599>.

TBR=thestig,timurrrr
BUG=69906
TEST=make the valgrind bots green.
Review URL: http://codereview.chromium.org/6260008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71631 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6312004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71629 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6368002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71628 0039d316-1c4b-4281-b951-d872f2087c98

twice if we have previously received payment notification.

BUG=chromium-os:10075, chromium-os:10428
TEST=tough one to test - requires OTA-SP activation of number of devices until reproduces. we should make sure that we 1) don't get stuck in 'Conneting...' phase after payment and 2) we never see the payment portal twice for the same device once the payment is processed. 

Review URL: http://codereview.chromium.org/5861001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71627 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6348005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71626 0039d316-1c4b-4281-b951-d872f2087c98

dataType has been required for <select pref=...> since
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284

BUG=to be filed
TEST=confirmed that the punctuation style setting worked for mozc.
also confirmed that all <select> elements with 'pref' attribute have dataType:
% perl -n0e 's/(<select[^>]*pref.*?>)/print "$ARGV:$1\n"/gse' *.html > all_select_prefs
% perl -n0e 's/(<select[^>]*dataType.*?>)/print "$ARGV:$1\n"/gse' *.html > select_prefs_with_datatype
% diff all_select_prefs select_prefs_with_datatype

Review URL: http://codereview.chromium.org/6286002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71625 0039d316-1c4b-4281-b951-d872f2087c98

The issue was probably introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=71284
that made undefined dataType to be an error.

BUG=chromium-os:10878
TEST=manually on the netbook

Review URL: http://codereview.chromium.org/6246005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71624 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bulach
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6307005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71623 0039d316-1c4b-4281-b951-d872f2087c98

Fix PRESUBMIT.py to exclude Makefile.

BUG=none
TEST=presubmit check is less noisy

Review URL: http://codereview.chromium.org/5976009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.

TBR=abarth
TEST=
BUG=

Review URL: http://codereview.chromium.org/6310010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71618 0039d316-1c4b-4281-b951-d872f2087c98

Since C++ supports covariant return types, a subclass of Value can return its
own pointer type for Value::DeepCopy().

Also made signatures of Value::Create*Value() more specific.

Removed now-unnecessary casts.

Added test for covariant return types.

BUG=None
TEST=Compile

Review URL: http://codereview.chromium.org/6324004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69145
TEST=manual

Review URL: http://codereview.chromium.org/6307004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71616 0039d316-1c4b-4281-b951-d872f2087c98

(This was a TODO for jhawkins).

BUG=None
TEST=manual

Review URL: http://codereview.chromium.org/6344004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69704
TEST=bookmark folder icons are blue in the WEBUI bookmark manager

Review URL: http://codereview.chromium.org/6331003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71611 0039d316-1c4b-4281-b951-d872f2087c98

the comments to reflect this.

I'll clean up when I hear back from dmaclach and the Nacl team.

BUG= None
TEST= None
Review URL: http://codereview.chromium.org/6266005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71610 0039d316-1c4b-4281-b951-d872f2087c98

motivated by a discussion with Ben and Scott in the process of fixing a z-order
issue in http://codereview.chromium.org/5700003/

BUG=none
TEST=manually on both touch and non-touch builds, trybots

Review URL: http://codereview.chromium.org/6024007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71608 0039d316-1c4b-4281-b951-d872f2087c98

r692 fixes a valgrind error. r691 brings in optional gradient dithering code for 32bit pixels. Disable this in chrome for now.

BUG=41756,69531,69452
TEST=none
TBR=reed

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71607 0039d316-1c4b-4281-b951-d872f2087c98

The http method is broken, and having this in here means `git try` takes 60 seconds just to discover that it should retry using svn.

Removing this == developer_productivity++

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6312005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71606 0039d316-1c4b-4281-b951-d872f2087c98

TBR=satish


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71603 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile
Review URL: http://codereview.chromium.org/6269009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71600 0039d316-1c4b-4281-b951-d872f2087c98

In the process, added a generic AudioEncoder interface which could create the requested codec.
Right now the codec is set to FLAC. In a future CL, we'll determine the codec to use dynamically
based on bandwidth considerations.

This CL depends on http://codereview.chromium.org/6205006/ going in first.

BUG=61677
TEST=none

Review URL: http://codereview.chromium.org/6111009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71599 0039d316-1c4b-4281-b951-d872f2087c98