GitLab

The device module is a "higher level flags" target, which dictates if
broader features should be turned on or off based on the device,
command line, and some feature flags.

Change-Id: I9842eb8236966af5308bcc29c0ca0ccd1315d812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382670Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809576}

Clip the surface damage rect before adding it to
|damage_rects_union_of_surfaces_on_top_|. This is how we produce
|root_damage_rect_|.

Bug: 1117235
Change-Id: I83b11d2b79490fd072c3bc5484f7cb38a43f2037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412634
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809575}

(Fixing accessibilityPrivate.on* names to only be used for events 2/3)

No functional changes - should be mechanical only.

AX-Relnotes: N/A
Change-Id: Ie31e44e0cdcce932865f2039c4cac5f9b6f9cb38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422651
Auto-Submit: Josiah Krutz <josiahk@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809574}

Change-Id: Ic21b4ca4f360c391e28d15251a325468f8c4a815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424686
Auto-Submit: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809573}

This CL updates the lookalike interstitial to use the safety tip
allowlist instead of its own allowlist. The original allowlist was
tab-specific, versus the safety tip one, which is profile-wide. This
paves the way to also possibly persist the allowlist in the future, too.

This is a very minor change on the interstitial, but required some minor
rewiring for Safety Tips. All on-close metrics are now recorded by the
OnSafetyTipClosed callback. This is probably better anyway (or at least
more uniform).

Bug: 1122139
Change-Id: I91a4aa8f03dea3a65b74b389cb216c35511fd23a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422471
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809572}

https://skia.googlesource.com/skia.git/+log/187b04b35777..a5f3c3149033

2020-09-22 johnstiles@google.com Create VariableExpression struct for referencing inlined variables.
2020-09-22 robertphillips@google.com Fix a GrThreadSafeUniquelyKeyedProxyViewCache test
2020-09-22 johnstiles@google.com Fix crash when swizzling a bvec with constant 0/1s.
2020-09-22 johnstiles@google.com Add unit test for swizzling booleans.
2020-09-22 jvanverth@google.com Make sure we release all refs in GrD3DTextureResource::releaseResource.
2020-09-22 nifong@google.com Reland "include freetype in wasm build, see cl/332073924 for complete change"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408
Tbr: csmartdalton@google.com
Change-Id: I29fcd563fd7a41cad16def0f695978fe4039bc28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424971Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809571}

This metric was used to validate the feature when it was added but are
not required to be monitored long term. There is still a UserAction in
place for the opening of chrome://inspect.

Bug: 1088882
Change-Id: I09808825c3a43f54829e620a95ba5246ca0ee1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421432Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809570}

Remove dialog based on UX review feedback
(see question 4 in http://go/cros-lang-settings-ui-review-reply)
Current view: http://screen/BV97nrhiu94mME6

Bug: 1113439
Change-Id: I0865a9d6385661e99c1d560db446904b47c9d31c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423824Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809569}

This test was disabled a long time ago, with a comment that
it was broken by a related change. This test seems to work now,
so I've enabled it. The related bugs seem to indicate the
feature is no longer planned, so perhaps this test be removed,
per the comment, if it's not really testing anything worthwhile.

Bug: 159932
Change-Id: I36950024b8448c56e669c371380a3daf450e96f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414772Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809568}

There exist separate tolerances for desktop ARM64 (Windows and Fuchsia)
already. They are needed for macOS as well.

Bug: 1128443
Change-Id: I93b14ea6acf26c1d1aea6748134988690fa9990f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424712Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809567}

Bug: 1131200
Change-Id: I04b3fce954c66a2e7299d1e7cfa102754f1dc459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425126
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809566}

Refactors the stub device sync to fix a conflict with the fake device
sync (used in testing). Renames SetForTesting method to reflect it being
used in non-testing code. Enables the use of stub device sync when in
Linux CrOS, i.e. while running on emulator.

Fixed: 1085459
Change-Id: Ib075405e39d323a9e04954f0dfb7a6259136da87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406855
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809565}

This reverts commit a099d2db.

Reason for revert: NewTabPageModulesDummyModuleTest.All failing. bot failures on linux-chromeos-chrome: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome

First failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8711

Original change's description:
> [ntp][modules] Disable dummy modules in NTP for official build
>
> Bug: 1130814
> Change-Id: If8d93fb7c134637f399735637ff031abbe31ebc2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411671
> Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809463}

TBR=tiborg@chromium.org,aee@chromium.org,yuezhanggg@chromium.org

Change-Id: I4537af0a34a5cc61a1f7b228a5047127862e2a0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1130814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425207Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809564}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/679e180840fc..efa0f60c03cb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC huangdarwin@google.com,lgrey@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1099917,chromium:1130885
Tbr: huangdarwin@google.com,lgrey@google.com
Change-Id: Ief9da4602418d30a7ccd77316e12700370225861
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424726Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809563}

SetNextFocusableView() doesn't update previous_focusable_view_ on the
pre-existing next view in the focus list. As a result, it is easy to
run into situations where
v->GetPreviousFocusableView()->GetNextFocusableView() doesn't return
v, which is clearly wrong.

SetNextFocusableView() is inherently unsafe since all callers must
ensure they don't break the list.

This CL replaces it with safe routines.

Bug: 928905, 942478
Change-Id: I26338ad592225b1a3ea04b3d1368288e0dc56bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033665
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809562}

Per change in product requirements, the "Copy to clipboard" context menu
command is now "Copy image" and will only be shown for holding space
items which are backed by an image file.

When executed, "copy image" will read, decode, and write the backing
file's image contents to the clipboard buffer so as to be available to
the user for pasting.

Bug: 1126274
Change-Id: I4575589c01fd5702cbefae0d5830362269df7e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419920Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#809561}

Reland as 3-sided patch to avoid downstream break.

Original change's description:
> Migrate NavigationHandle from String URLs to GURL
>
> Migrates NavigationHandle to use GURL internally and adds getUrlString
> for callsites that still need URLs to be a string (to be fixed in
> followups).
>
> Some unit tests needed to be moved to Instrumentation tests, one
> requiring a change to CriteriaHelper to allow checking for a condition
> after every task.
>
> QualityEnforcerUnitTest was too difficult to migrate to Instrumentation
> tests, so it now uses JUnitTestGURLs to use GURL in junit tests.
>
> Bug: 783819

Bug: 783819
Change-Id: Ic2043b8e871a4cb8a6d59ed7d6334486bd7ebe59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424986Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809560}

RunArcExternalProtocolDialog takes a callback rather than creating the
ExternalProtocolDialog directly.  This is to allow further logic to be
added consistently in the case where arc does not handle the URL.

Bug: b/168506505
Change-Id: I82e74112870cb727e46b0a3ab987e7117a4ac7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423067
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809559}

Fixed: 1131119
Change-Id: I9ce8308f5c5832c7156cc60ff55a6b5c561161d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424650
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809558}

Fix the behavior of the "Remove fingerprint" search tag so that it
dynamically changes based on the number of registered fingerprints.

Bug: 1116553
Change-Id: Ifd109dbf6757bede7b079eb7a31d7db3b45b27b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424507
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809557}

Design Doc: https://docs.google.com/document/d/1yf_88IrTCNbrfMaZnU4gwUu_Fi9f6q7ngacWc7-d4zg/edit?usp=sharing

Bug: 1130078
Change-Id: I4a2c51f80f8d484e64c67312cdae2a57a3e0faa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268338Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809556}

Bug: 813093
Change-Id: I384979ae9a027b4961adefe2e906a2f0cb2176e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424551Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809555}

It's only called for client versions <=83, which are no longer
supported. Hence the calling code can be deleted, and the
method removed from the aidl.

The public-facing NewTabCallback method is only made concrete as
removing it would break client compilation.

Also change MAX_SKEW to 3, restoring it to the value that was used
before we missed shipping version 82.

Bug: 1110811
Change-Id: I8c3eaaedd59f546c60a41b37e4e2bc070b7da0c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414991
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809554}

The strings in this change are from UX.

Bug: 1126056
Change-Id: I72393fbfec457d80f07f5d44dc457e29bcc42d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422479Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809553}

TBR=bbudge@chromium.org

Bug: 1129846
Change-Id: Ia00bb034ea0f4f0071c11b0c3d4dd43edf73d699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425166Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809552}

Also make some UI adjustments to match specs.
Screenshots: http://dr/corp/drive/folders/1ga0FKZujvJKfSy3SG7zQ5ZwYxOSYZBNx

Bug: 1120093
Change-Id: Ic464538f1e99654ae5018bd0d51c8025fb1fd69a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417463
Commit-Queue: Sophey Dong <sophey@chromium.org>
Reviewed-by: Tanya Gupta <tgupta@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809551}

The default thread size for Chrome on 32-bit Windows is 1.5 MiB which is
overkill for the BrokerServicesBase thread. Address-space exhaustion can
be an issue for 32-bit Chrome, especially on 32-bit Windows, so this
change reduces the size to 0.5 MiB.

Bug: 981238, 1023804
Change-Id: I8cc90b506f3a14895f8e7a84fc0138c0e1d0775e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422685
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809550}

The legacy fragmentation engine may fragment line boxes in some cases,
but this is wrong, since lines are monolithic.

Bug: 829028
Change-Id: I58c70487c16f9f14fdd3ae7698b5f8e0c255758e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425044Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809549}

- Mocks changed and this functionality is now all combined
  in the battery status card
- This reverts commit a407643d.

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I0a8f9356039885bba84a2df3a3eb3771893995c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422818Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809548}

It's 12px in figma but the icon has some space by itself, so reduce
it to 8px. UX approved (http://screen/wRVCzrD4gDoQvmo) and seems
consistent with http://go/cros-ux-text-button-inner-layout

View of Add Input Methods: http://screen/3ESJMTZJkJuf5zy
View of Add Languages: http://screen/7FrqMDeEtWG6pds
Spec: http://go/cros-lang-settings-figma

Bug: 1113439
Change-Id: Id381b58ac38ecffac6896b34bc1572f7d95e483b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423751Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809547}

Two fields were given the ordinal @21. Due to a bug in the bindings
generator, this was allowed. In practice this meant the ordinal for the
second @21 field was actually @22, and all subsequent ordinals should be
bumped by one.

This CL corrects the assigned ordinals to reflect the reality of the
generated code. The stable format of this structure is unaffected by
this change.

NOPRESUBMIT=True

Bug: None
Change-Id: I82591eb4f36fa8e1121d5c0edfbfaa1656f57e31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422482
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809546}

SMB shares are now implemented by a FUSE filesystem that natively
supports statvfs(). Allow the available space on an SMB share to be
displayed in Files.app's gear menu.

Test: browser_tests --gtest_filter="*showAvailableStorage*"
Bug: 1082035
Change-Id: I144f2f7ff0cb3106ec33d3a5e9bff6a87d367c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423125
Commit-Queue: Josh Simmons <simmonsjosh@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809545}

Removes large libraries that were pulled in as a result of an indirect
but necessary dep on Blink.

The exclusions can be removed along with the Blink MessagePort
dependency, once a fix for crbug.com/1126571 lands and is
integrated with NamedMessagePortConnector.

Bug: 1131102
Bug: 1126571
Change-Id: I7b25d50470d667f44424b925d3982efa268c24ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424512
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809544}

Roll Chrome Win32 PGO profile from chrome-win32-master-1600754349-faa1edece0f28695a43c5cb3d7e6ca8a741e4346.profdata to chrome-win32-master-1600775907-34bfad4572405dae937638ebe3b1eeb7936a17be.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Id2efa8cde75209a04b77414b6c39703745487806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424405Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#809543}

Test: none
Bug: 1111445
Change-Id: I8ee9546149c0c052677f897efedd7f950cd95c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417370Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809542}

We weren't properly checking for backward-compatibility (but were rather
checking for strict equality) of types nested within generics. So if a
stable structure S has a field of type `array<T>` and T is changing in
a backward-compatible way, S would trigger a presubmit failure.

This change corrects the logic here to properly nest such
backward-compatibility checks.

Fixed: 1130671
Change-Id: If739bac2440927fbaf24f7feae5bbd04f9b29c09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422189Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#809541}

Bug: 1112539
Change-Id: I4cd0774d2728b14559d7f45cab221b0c809713d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425103Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809540}

https://chrome-internal.googlesource.com/chrome/deps/barhopper.git/+log/47934f2c634c..d5422b6ec462

$ git log 47934f2c6..d5422b6ec --date=short --no-merges --format='%ad %ae %s'
2020-09-21 azeemarshad [Barhopper] Fix tezcode build issues.

Created with:
  roll-dep src/third_party/barhopper

Change-Id: Id3113e08277cce3e34f0ba9da4528c93dae7c635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424683Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809539}

This cl causes the bindings generator to automatically collect UKM when
these attributes are accessed. This will be used to analyze how much
entropy leaked by this API can be used for cross-site tracking.

Bug: 973801
Change-Id: Id53fa88b0181ec746d37d00677f2eeef045e300d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424847
Commit-Queue: Chris Fredrickson <cfredric@google.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809538}

This CL changes BrowserURLHandlerImpl::RewriteURLIfNecessary so that it
returns early(and doesn't mutate the |url| in the in-out argument) if
|url| is invalid.  This helps avoid scenarios where
RewriteUrlForNavigation (in navigation_controller_impl.cc) ends up
generating a NavigationEntry with an invalid virtual URL that
(accidentally/incorrectly) gets rewritten into a valid URL.

Bug: 1116280
Change-Id: I114cf8c8d9459b6931ae659f62a100679b994d5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385921Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809537}