- 28 Sep, 2020 40 commits
-
-
Johann Koenig authored
This reverts commit 67468f66. Reason for revert: causes win-chrome builds to fail: [10171/23886] CXX obj/device/vr/vr/oculus_device.obj FAILED: obj/device/vr/vr/oculus_device.obj c:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../device/vr/oculus/oculus_device.cc(65,17): error: no member named 'id' in 'device::mojom::VRDisplayInfo' display_info->id = id; ~~~~~~~~~~~~~~^ 1 error generated. https://ci.chromium.org/p/chrome/builders/ci/win-chrome Original change's description: > Stop sending XRDeviceId with VRDisplayInfo > > This value is not used by Blink, and does not need to be communicated > over the mojo interface. The XRDeviceId enum should not be removed > because it is used for usage stats. > > Bug: 1017477 > Change-Id: I5e8cfff00c374f48495290c5dfb8911a1824a2de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424684 > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Auto-Submit: Brandon Jones <bajones@chromium.org> > Commit-Queue: Brandon Jones <bajones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810958} TBR=palmer@chromium.org,bajones@chromium.org,bialpio@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017477 Change-Id: Ic5db77eb272086c7e51c900e8f23f722209dedb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434019 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#811183}
-
Joel Klinghed authored
Add support for handling an accept filter such as "image/*, image/png" as if it was just "image/*". The Android file selector dialog can only set one type filter so the accept filter contains multiple filters we have to fallback to a generic filter for the selector. However, we can detect overlap, for example "image/*, image/png" can still use "image/*" as a filter without any problems. "image/png, image/jpeg" is handled as before, only when at least one generic type is involved is overlap considered. Bug: 1106651 Change-Id: I9bc74ed18e253b139f7fb7eb456dbc64fba7c3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302751 Commit-Queue: Joel Klinghed <the_jk@opera.com> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#811182}
-
Maxim Kolosovskiy authored
(in CompromisedCredential*) has_script is going to be divided into |has_script| and |has_auto_change_button|. It will be done in several steps for easier reviewing: 1. The existing |has_script| will be renamed to |has_auto_change_button| (this CL) 2. A "new" |has_script| will be introduced, where |has_script|== |has_auto_change_button|. 3. Implement special logic for the new |has_script|. Bug: 1132230 Change-Id: I684921dc2e4aedaea20ac467c67512915dfa3590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429409 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#811181}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6f521921351e..d2f6cc6f606c 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1ba024ed to 30cee4f4 (638 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I02e79dc49f30a26e13ddb7b5c458d04ddd1cf1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434505Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811180}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40640de5f50e..77397c4f2930 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I0412c0f8d22f8b614caff4a363f433f02d6de626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435248Reviewed-by:
-
Swapnil authored
We have several install creation stage that the force installed extension must go through. We want to add install creation stage event to the existing events for the event based reporting for force installed extensions. This is added to investigate the extensions stuck in CREATED stage. Bug: 1124808 Change-Id: Ifa20a96f6da2078639e98c85362eb51db707cd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421675Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#811178}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2426564, not having a sources assignments filter is the default. No behavior change. Bug: 1018739 Change-Id: Ia0f215c50d4381f74e3a5ae8db539312b7f391b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434084Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#811177}
-
Alan Cutter authored
This CL updates the preinstalled web app to exclude configs that want to uninstall_and_replace preinstalled Chrome apps that have been uninstalled by the user. Bug: 1123435 Change-Id: I5522523680d4a5a20fa3f1f615bd6b2824692e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425604 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#811176}
-
Leo Lai authored
The comment used to points readers to a deprecated cryptohome client API; corrected it to the right one. BUG=b:158955123 TEST=build ok. Change-Id: I31e99fb8c0b466e04584911ada227af06eaca96f Change-Id: I5e7657d7f02abb7398b639206c0830792de857b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430685Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#811175}
-
Alan Cutter authored
This is a reland of 02f9f701 The original change uncovered an incompatibility with the test profile generated by AccountManagerUIHandlerTest and chromeos::ProfileHelper::IsPrimaryProfile(). This change uncovered it by changing the timing of when it gets called resulting in flaky failures. The AccountManagerUIHandlerTest tests were disabled in the meantime due to flakiness. A follow up CL re-enables the tests and disables the ExternalWebAppManager start up flow such that it doesn't trigger the incompatibility with the custom test profile: https://chromium-review.googlesource.com/c/chromium/src/+/2434412 Original change's description: > Refactor ExternalWebAppManager config loading flow > > This CL splits ExternalWebAppManager's config loading flow into discrete > steps and removes the various testing entry points that omit or > duplicate logic used by the real thing. > > Tests can now inject data (file_utils, config_dir, configs) into the > config loading pipeline instead of having separate mini pipelines just > for them. > > This change is in preparation for adding a new "FilterExtensionIds" step > to the config loading flow. Without this refactor there would be > duplication of logic between real and test code code paths that would be > prone to bitrot and missing real coverage. > > Bug: 1128801 > Change-Id: Ie5e87b26ab47782fab6589a4127df3ea5e876fec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423823 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810025} Bug: 1128801 Change-Id: I345ea879861dd62ee38f4e04a72b968f38e2bb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428539Reviewed-by:
-
Matthias Körber authored
This CL adapts import related tests to work with structured addresses. Change-Id: I6c851d4a4a15714f633eaa4d33f997fd82348a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431946 Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#811173}
-
Asami Doi authored
Previously, the frame only stores the map of ServiceWorkerContainerHosts keyed by uuids. This CL adds a weak pointer of ServiceWorkerContainerHost so that we can keep track of the latest one without uuid. Bug: 1017034 Change-Id: Ifbc31f5f9d26d2d6079cf593a60e6638b8ec771d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409013 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#811172}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/296dd3b4062e..79c5fa7eebcb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I35399b06b2cc7e7ce4e589866efa2ede22c003f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434702Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811171}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6444c825797..131d306fc1d9 2020-09-28 janscheffler@chromium.org [WebAuthn] Disable invalid options If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131055 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idb542b0b59b2edfcc6a091d55141d6bbdce52f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434700Reviewed-by:
-
Mitsuru Oshima authored
Bug: None Change-Id: Id6f5ba3f7db83bc7b59e2ca393448c1447ea150a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432086Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#811169}
-
Mitsuru Oshima authored
Bug: None Change-Id: Icdadb57d7a6c9b4ac952dbb68aa6b79f6d9b9484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432425Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the trait collection of the View/ViewController is used instead of the key window as the key window could be wrong with multi window. Bug: None Change-Id: I6704bccc7245e10b30892f88f355505a227a6f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424303 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#811167}
-
Noel Gordon authored
◦ Emscripten has a core github these days: — update links to point to the core github and the .org docs ◦ Document which emscripten version built the piex-wasm release: — builder of last piex-wasm release was emscripten 1.38.27 Bug: 1132695 No-try: true Change-Id: I703e1e7652ddebe98fb4328996fe6835f808f7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435128Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811166}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26fef59eda82..40640de5f50e 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I38f43fed760646416c8f679ad0a3f11e67286868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434698Reviewed-by:
-
Nohemi Fernandez authored
Following crrev.com/c/2418576 the CHROME_CONNECTED cookie is added when navigating to accounts.google.com. Chrome previously only sent domain names to the ChromeConnectedHeaderHelper (e.g. google.com) meaning that the URL would never be accounts.google.com. This patch ensures that we send full URLs instead of domain names to ChromeConnectedHeaderHelper so that we can benefit from crrev.com/c/2418576. Bug: 1125631 Change-Id: Ic020cb90cee8764d6d56c72f3143d058d5d5f4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426488 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811164}
-
Ramin Halavati authored
"EnableEphemeralGuestProfilesOnDesktop" feature and flag are added to control the ephemeral Guest profiles on Windows, Linux, and Mac. Bug: 1125474 Change-Id: Ie297617f4f2c965c6b90b8cb2ff4f2ff91579c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424153 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#811163}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0e7fe4d35baf..4b07d50cd9a0 2020-09-26 antonikarp@google.com spirv-fuzz: Fix bug in TransformationDuplicateRegionWithSelection (#3819) 2020-09-26 andreperezmaselco.developer@gmail.com spirv-fuzz: Support OpNot bit instruction case (#3841) 2020-09-25 afdx@google.com spirv-fuzz: Return IR and transformation context after replay (#3846) 2020-09-24 paulthomson@users.noreply.github.com spirv-fuzz: fix test (#3845) 2020-09-24 afdx@google.com spirv-fuzz: Use unique_ptr<FactManager> in TransformationContext (#3844) 2020-09-24 ehsannas@gmail.com Start SPIRV-Tools v2020.6 2020-09-24 ehsannas@gmail.com Finalize SPIRV-Tools v2020.5 2020-09-24 ehsannas@gmail.com Update CHANGES 2020-09-24 vasniktel@gmail.com spirv-fuzz: Support dead blocks in TransformationAddSynonym (#3832) 2020-09-24 vasniktel@gmail.com spirv-fuzz: Move IRContext parameter into constructor (#3837) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ide53bd1a7338602ee3a5bcbf08a75c210dead45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434425Reviewed-by:
-
Yuki Shiino authored
Supports stopping the old bindings generation of IDL callback functions so that we can enable the new bindings generator. Bug: 839389 Change-Id: Ic84f8b6630d2f77983e551083a93c2de3423f954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434184Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#811161}
-
Noel Gordon authored
The global object could be window, self or global, depending on the JS environment piex-wasm runs in (Web Page, Web Worker, NodeJS, etc). The |globalThis| object points to the global object in all cases. No change in behavior (for files app), no new tests. Bug: 1132695 Change-Id: I8c6f3d21de29bce63f88352fbe89364d8a76c6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434077Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811160}
-
Raymes Khoury authored
Previously we weren't actually recording launches of Google Photos as we were for other apps. Change-Id: I39deebdf470d91cc787936d15b2f90e18303cd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434123Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#811159}
-
Yuki Shiino authored
Implements the new bindings generator of IDL callback functions and IDL callback interfaces. Bug: 839389 Change-Id: I49af9220f63ff86f1d166408cfb79c6531d71f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434004Reviewed-by:
-
Alice Wang authored
This is a reland of adc862b0 Original change's description: > [Android] Show signed in account in sync promo > > Sync promo always shows the first account returned by AccountManagerFacade > which might not be signed in. This cl makes sure that the account that > is shown is the first signed in account. > > This cl also refactors some of the tests regrading sync promos. The > behavior of the tests are not changed. > > Bug: 1131465 > Change-Id: I46f2e607494c68d3b0608543095da4b22471f710 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426485 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810545} Bug: 1131465 Change-Id: I26bfac6b772f37371c1953af8bbefacbf66364ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435104Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811157}
-
Matthew Denton authored
...to support the SECCOMP_RET_USER_NOTIF return code for seccomp bpf programs. Bug: 1117351 Change-Id: I55dfcb4169a4b434cb5cc8894534e1d1e0e7782e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407035 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#811156}
-
Shakti Sahu authored
Bug: 1117157 Change-Id: I31a744b44c4cdb418b2ba11956d2eb54479ba579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429516 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811155}
-
Kushagra Sinha authored
Add a Mojo interface - AccountManager - for lacros-chrome to talk to Chrome OS Account Manager residing in ash-chrome. Implement a method in this interface: - |IsInitialized@0() => (bool is_initialized);| which returns |true| when Chrome OS Account Manager has been fully initialized, and |false| otherwise. Bug: 1117478 Test: unit_tests --gtest_filter="*AccountManagerAshTest*" Change-Id: Ia67a51f0d9051af6c0bd311ff5a63155385741a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363748Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#811154}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I79b6010eb70f4209261273ea37d2069ce1b72195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418674 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#811153}
-
Shakti Sahu authored
This is a reland of 26e5926b Original change's description: > Video Tutorials : Moved language to a server side concept > > This CL > 1 - Adds language struct to the proto consisting of name, native text, > and locale. > 2 - VideoTutorialService will still store the preferred locale in a > pref which will be used as a key when iterating through the > supporting languages. > 3 - Removes the checked in strings for languages > > TODO : Change server side proto > > Bug: 1132161 > Change-Id: I1483903e0615714aa790b6af1fbfaa4c6637c802 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429979 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811131} TBR=qinmin@chromium.org Bug: 1132161 Change-Id: I999557826e4171c49ca7fa24e6599520718982ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434890Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811152}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601250178-9224448c4ec6426aeb7b75620d909f898b369921.profdata to chrome-linux-master-1601272286-5f5720137a0694fa0bfa67350ff5844644ba53c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org Change-Id: I5b9660562f8b84a0ab6b9e7fb4e894216de81269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434377Reviewed-by:
-
Paula Vidas authored
SubscribeForSyncInvalidations flag is removed, and mostly replaced by the new flag SyncSendInterestedDataTypes. If that flag is enabled, SyncInvalidationsService is created, and the set of interested data types is sent to the server (as part of DeviceInfo). New flag UseSyncInvalidations is introduced. If both SyncSendInterestedDataTypes and this flag are enabled, FCMHandler can register with FCM and listen to new invalidations. Also, FCM token will be included in DeviceInfo. Unsubscribing from old invalidations behind these flags will be added in a separate CL. Bug: 1082115 Change-Id: I66eb2f254473d2f897cc15f054dcd6dafdc76708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429008Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#811150}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601250178-2f977882900933eb8f19c7762bd76dadbd9f342f.profdata to chrome-mac-master-1601272286-d5061451d97ba33a632a304f531ce91f70d7428a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I7c81fca55e9f7f8f5b24fef87d883eafc8d13cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434375Reviewed-by:
-
Johann Koenig authored
This reverts commit a18b4f05. Reason for revert: causing errors on linux-chromeos-chrome https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/8820 interactive_ui_tests failed because of: OmniboxFocusInteractiveTest.TabFocusStealingFromOopif storage_service_interactive_ui_tests failed because of: OmniboxFocusInteractiveTest.TabFocusStealingFromOopif Original change's description: > Avoid focusing the omnibox when handling a navigation in a focused tab. > > 1. In navigation-related cases //chrome layer is able to focus the > Omnibox itself, without relying on the //content layer. In > particular, //chrome layer can trigger focus changes from > Browser::UpdateUIForNavigationInTab or FocusTabAfterNavigationHelper. > > This assertion is reinforced by extra tests added in this CL, > where both of the new test cases provide secondary verification > that pressing the Home button ends up focusing the omnibox. > > 2. Controlling the focus from within the //content layer might lead to > incorrectly focusing the Omnibox. In particular, when (before this > CL) content::RenderFrameHostManager::CommitPending used to call > SetFocusToLocationBar it might get incorrect result from > RenderFrameHostManager::FocusLocationBarByDefault because of > A) unfortunate timing (last committed entry is not yet updated at the > time of RFHM::CommitPending) > B) fact that pending entry is missing in navigations initiated via > RenderFrameProxyHost > See https://crbug.com/1127220#c1 (and c2) for more details. > > Based on 1+2 above, this CL removes the call to SetFocusToLocationBar > from content::RenderFrameHostManager::CommitPending. > > In the future CLs we might want to explore whether the 2 other remaining > calls of WebContentsDelegate::SetFocusToLocationBar are necessary and > whether WebContentsDelegate::FocusLocationBarByDefault is necessary. > This exploration is not needed for fixing the immediate bug at hand. > > Fixed: 1127220 > Change-Id: I25793ee7eaaa409274c568c35de06c15cd3ad343 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425189 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810877} TBR=avi@chromium.org,pkasting@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie7885008f72f017710f2e82810a2ec8402a64e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434598Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/68998788dee4..f6444c825797 2020-09-28 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from sources/SourcesNavigator.js 2020-09-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieabffddef28151097347a6b524791bb2f9a78db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434372Reviewed-by:
-
Johann Koenig authored
This reverts commit 71953034. Reason for revert: tools/run-swarmed.py out/Win content_browsertests --swarming-os Windows-10 --gtest_filter "All/DumpAccessibilityEventsTest.AccessibilityEventsVisibilityHiddenChanged/uia" Original change's description: > Reland: Improve name calc handling of hidden objects, relation traversal > > - Display: none objects should not get an accessible name. > - EnsureComputedStyle() should not be called during a potentially unsafe > time. This is fixed by calling it during Init(), in cases where it > will likely be needed (inside a display:none subtree). > - Remove unnecessary and often incorrect heuristic for determining when > inside an aria-labelledby or aria-describedy calculation. This flag is > already passed in via recursion when following that kind of relation. > - Do not recurse into children that are explicitly hidden > - Improve explicitly hidden computation for CSS visibility. Explicitly > hidden means that the element was specifically hidden, and that it > didn't just inherit the fact that it's hidden. > - Improve results in name-calc-visibility, where an element explicitly > referenced by aria-labelledby wasn't included in the name because it > was visibility:hidden element. Elements that are explicitly referenced > must be included in a name or description even if they are hidden. > > TBR: dmazzoni@chromium.org > Bug: 1130436 > Change-Id: I52d11208a9658a53bf0af7313a41f4bb8eafc24e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431448 > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810683} TBR=dmazzoni@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1130436 Change-Id: I24a6949799f55a96318e29253670735359181014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434018Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0081a12803bf..26fef59eda82 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic3e2ab658d1d7877c26669595e35619943cec891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435004Reviewed-by:
-
Jason Lin authored
This reverts commit 4d4f20fc. Reason for revert: https://crbug.com/1132535 Original change's description: > Use standard ExternalProtocolDialog in Chrome OS for Guest OS apps > > Screenshots: > http://go/chrome-ss/0a0bc6ca1f1985c5c25a726a8ef123c27c33c7e1 > http://go/chrome-ss/bd6f5d9d4ef33bd9ae8addb575c88dd2a1d04818 > http://go/chrome-ss/d4b444ab2d88cb4bd11e21e52b7246de60c8bf71 > > When Chrome OS did not support external protocol handlers, it > replaced browser/ui/views/external_protocol_dialog with > browser/chromeos/external_protocol_dialog which states that no > handlers are available. ARC has added a dialog which is shown > when any android apps can handle a link. This CL uses the > standard ExternalProtocolDialog for Guest OS apps when ARC does > not handle a link, but Guest OS can. > > * Renamed CrOS version of ExternalProtocolDialog to > ExternalProtocolNoHandlersDialog. It is still used when no handlers > are found. > > * Changed ui/views/external_protocol_dialog to now be compiled into > CrOS, but leaving out > ExternalProtocolHandler::RunExternalProtocolDialog which is provided > in the CrOS version: chromeos/external_protocol_dialog.cc. > > * Replaced platform_util_chromeos OpenExternal to Launch the registered > Guest OS app. This function was previously not ever called in CrOS. > > Bug: b/168506505 > Change-Id: I89ffd84b9308cb2ce4b7e0691183e0da3402a4cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423675 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jason Lin <lxj@google.com> > Cr-Commit-Position: refs/heads/master@{#810381} TBR=ellyjones@chromium.org,xiyuan@chromium.org,thestig@chromium.org,joelhockey@chromium.org,lxj@google.com Bug: b/168506505,1132535 Skip-Translation-Screenshots-Check: True Change-Id: I52bfc2a8169a018076790df8a63c253c29ded64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434014 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#811144}
-
