- 15 Dec, 2020 40 commits
-
-
Jeffrey Kardatzke authored
This early exits from CanHandleCandidate which does checks to ensure composited quads match up with overlay quads. If we are requiring the use of an overlay, then skip those checks since we will never be compositing that quad. BUG=b:153111783,b:155511837 TEST=Required overlays render correctly, unit tests pass Change-Id: Iad5d5eabd33cdc6bf2c4a3ba315b154eddaee3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593522 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#837305}
-
Jesse Schettler authored
Update the styling of the select elements to match the spec. Before and after: http://shortn/_5kxnLLqx7m Bug: 1059779 Change-Id: I44a6fd3a2978b2e66a202fd4f1c21906fcf30a06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591067Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#837304}
-
Peter Kasting authored
This prevents recoloring the favicon in the default (light) theme. It also seems more theoretically correct, since an icon is not text, and we've generally been using distinct contrast thresholds for the two. Bug: 1158748 Change-Id: I36448d69986e93e49693b5f02cced05e9646468f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593517 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837303}
-
François Doray authored
This reverts commit e66dcc06. Reason for revert: Thread handle != thread id on Linux crbug.com/1158103 Original change's description: > [blink scheduler] Add blink::Thread::ThreadHandle. > > The thread handle should be used instead of the thread id for thread > manipulations. It is available immediately after thread creation, > unlike the thread id which is available only after the main function > is entered. Also, on Windows, the thread handle remains valid after the > thread has exited. > > This is a prerequisite to remove the wait after compositor thread > initialization > https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/scheduler/common/thread.cc;l=96;drc=5b1ca7b1087e13d963bc4058d9406a838fb7f9ca > > Bug: 1080709 > Change-Id: Ia0b72aa1b3a86454cffa774131944db87ced0843 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578172 > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Kentaro Hara <haraken@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835544} TBR=gab@chromium.org,fdoray@chromium.org,haraken@chromium.org,altimin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1080709, 1158103 Change-Id: Ib4bd9113ad8a72fe4e9215989e07986d3b357c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593833Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#837302}
-
Jamie Madill authored
This replaces several grouped dependencies with one meta-repo. Bug: angleproject:5390 Bug: 1153258 Change-Id: Ifd7a8d5b2903d141d9029fe803c981bdffdedda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590264Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#837301}
-
Will Harris authored
There are two copies of base in a non-component Windows build, one inside chrome.exe and one inside chrome.dll. This will cause two copies of the base::FeatureList singleton to be created. However, only one of those is correctly initialized from command-line and server-side variations. Attempting to use a base::Feature from chrome.exe code (e.g. sandbox or base) will silently result in default behavior of the feature and never correctly respect command-line or variations state. This CL prevents the accidental use of the base::FeatureList in chrome.exe by marking it as forbidden. BUG=1154449 Change-Id: I7c32037b1930e3474e52eecd44b82dcbd9dbeef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568810Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Carlos Pizano <cpu@chromium.org> Commit-Queue: Carlos Pizano <cpu@chromium.org> Auto-Submit: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837300}
-
Josiah K authored
Screenshot: https://screenshot.googleplex.com/4miZFhDoWjqF5j6 Fixed: 1158097 AX-Relnotes: N/A. Change-Id: I13e25d67528f66df200bddae6b90daf1dd424b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588032Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#837299}
-
Chris Palmer authored
Bug: 1159070 Change-Id: Iac9fd2741a4617e2dffa5add06497319a57795a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594113 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#837298}
-
Leonard Grey authored
Bug: 1152274 Change-Id: Ib89ea29db416df0a1fbaa1383d741e2f67fcd265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591668 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#837297}
-
Hui Yingst authored
Similar to OutOfProcessInstance, this CL makes PdfViewWebPlugin a derived class from PaintManager::Client, and adds an attribute |paint_manager_| to it, so that PdfViewWebPlugin can use the current PaintManager in the future. Bug: 1099020 Change-Id: If0ec99e02a4e82a6ada049e499387e5d3df41a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580523 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#837296}
-
Pavel Yatsuk authored
This reverts commit 012b87aa. Reason for revert: The CL causes test crashes. See crbug.com/1159148 Original change's description: > aw: Switch instrumentation shell to SurfaceView > > Also refactor the fake draw_fn implementation. This is to prepare for > adding a vulkan draw_fn implementation. > > Split draw_fn implementation into: > allocator.cc/h: Controls functor data lifetime > context_manager: Effectively global. Responsible for owning the surface > and EGL context. Calls sync/draw/context_destroyed on > functor and responsible for owning the "impl reference" > to functor data. > > context_manager uses EGL bindings from ui/gl, but nothing else > to avoid conflicting with chromium side implementations, and to avoid > initializing a TaskRunner on render thread. Only GLES call is > glReadPixels after draw, which relies on chromium implementation not > releasing its bindings after draw. > > Refactor and simplify the java side by explicitly adding a thread to > post tasks and a WaitableEvent; this avoids saving state and using > a Lock object. > > Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-android-m-nexus-5x-64 > Bug: 1141687 > Change-Id: I71752b31f401fdb277062fe1347dfa826a20bb81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587238 > Auto-Submit: Bo <boliu@chromium.org> > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837094} TBR=backer@chromium.org,boliu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,vasilyt@chromium.org Change-Id: Ibd5bd67c758b1c807cbc9bbd78007c72fe092958 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141687 Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-android-m-nexus-5x-64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593921Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#837295}
-
Mike Reed authored
Part of larger change: https://chromium-review.googlesource.com/c/chromium/src/+/2593832 Bug: skia:7650 Change-Id: Icad623c1a1b58c7f4f3e082457b3353b686ed4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593830Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#837294}
-
Mason Freed authored
On HTMLSlotElement, this name makes more sense. From a comment at [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019/12/third_party/blink/renderer/core/html/html_slot_element.cc#684 Fixed: 1158844 Change-Id: I4d561071868f8db89a91c2a8d0d285c857cfb375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593284 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837293}
-
Olivier Li authored
This supports cases where the HangWatcher is not started and adding code to start it would be unnecessary. For example : android_browsertests Bug: 1157943 Change-Id: I9fdc2905a25f67acd6c0e5608eb2c3d5fac19fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593551Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Nick Czajka authored
Updates the text on Settings > Device > Displays > Arrangement to include keyboard instructions, when keyboard-based display alignment is enabled. Screenshot: http://screen/6iBtZF5bP7YoJTY Bug: 1077365 Change-Id: I6a1599cc2185fda0487e184c68b0c50625318b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593173Reviewed-by:
-
Michael Crouse authored
This is a reland of ffac4483 Original change's description: > [LanguageDetection] SimpleKeyedService and optimization guide. > > > This change converts the translate model service to a > SimpleKeyedService and moves it to components which will enable > easier support beyond just browser use cases. > > This change also registers the translate model service to > the optimization guide for provided necessary model files. > > A future change will add loading and service the model files > to consumers of the translate model service. > > Bug: 1151407 > Change-Id: I4e903115c82a30757d46d75ed8d733874726d830 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580339 > Commit-Queue: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Trevor Perrier <perrier@chromium.org> > Reviewed-by: Scott Little <sclittle@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836656} Bug: 1151407 Change-Id: I3606aa9a1292a4a61828e9be9ec91714bb8d7575 TBR: blundell@chromium.org, sclittle@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592167 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#837290}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1d06a4d0549..f1c7d0dd2ddc 2020-12-15 vapier@chromium.org gerrit_util: move changes: enable keep_all_votes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I56e5f28ce65f0b0172b5b40c3e6b1217ac317110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593996Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837289}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I20328d6027e0c870437f786fea2bea7aa3a75388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593754Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#837288}
-
Yao Xiao authored
Bug: 1156543 Change-Id: Ie148e7f191d4148c697059ce3bdfd430c84b1411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578478Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#837287}
-
Toni Barzic authored
Makes the previews animation better match the speced behavior. More fundamental change is the way the list of items to be shown in the icon is calculated - instead of having HoldingSpaceTrayIcon track the holding space model changes and update itself on each change, the HoldingSpaceTrayIcon now does not depend directly on the holding space state. Instead, HoldingSpaceTray calculates the list of items to display in the icon, and passes it on to HoldingSpaceTrayIcon. The icon calculates and runs transitions needed to update the icon to match the new state. Unifying the API to update the set of items in the icon makes batching the holding space items easier - it's sufficient to schedule an async task to calculate the list of items in the model, and pass it on to the icon when the time is right. Other changes: HoldingSpaceTrayIconPreview now tracks its current and pending index in the item list, which simplifies calculating transitions, and simplifies logic for determining whether the preview needs a layout. Also, the indices can be used to distinguish new from existing items when updating the icon (new items will not have the current index set). Unifies AnimateShift and AnimateUnshift into a single method - the method now uses pending preview index to calculate the target transform, which makes the distinction between shift and unshift irrelevant. BUG=1142572 Change-Id: Id614c39838d0aa10dc2652d4a23b8e934d67bdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582431 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#837286}
-
Anne Lim authored
Changed return type of GetExpiryTimeMicros() to base::Optional<int_64>. Bug: 1061639 Change-Id: Ic5dd406a6dbbf7dea4725f546cdfd9dc129bf163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587525Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#837285}
-
Mike Dougherty authored
CRWJSInjectionManager is deprecated and language_detection is one of the few remaining features using it. Migrating it off of this dependency will help to cleanup existing JavaScript feature code in preparation for new JavaScript features. Note that although language_detection_controller_unittest is removed here, it was previously testing private API sand the JS still has tests in language_detection_javascript_unittest. Bug: 949178 Change-Id: I9834ca60f8e8d4d75c324a5f93337ed04b997da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580902 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#837284}
-
Angus L. M. McLean IV authored
Bug: 1135270 Change-Id: I7573ec1adf7b0623f3d60716a2d0e575cd31cac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590015 Commit-Queue: Angus McLean <angusmclean@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837283}
-
Will Harris authored
reddit.com has migrated to a mobile design but old.reddit.com retains the old design which does not play well with DOM distiller. BUG=957667 Change-Id: Idc892fe13ff57d05422521c6c4dbb0db3f45e98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594208Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837282}
-
Vladimir Levin authored
This patch ensures that we unlock the auto locks when printing, since that makes the whole page essentially visible. R=chrishtr@chromium.org Change-Id: Ia49d20d6885e1391d4db633df08db8f41caf1441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593873Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#837281}
-
ckitagawa authored
It looks like the PaintPreviewCompositorClientImpl very rarely gets deleted before the mojo channel is established on a different sequence (for bitmap IO reasons). The mojo remote is already deleted on this other sequence (see its initialization using a TaskRunnerDeleter in PaintPreviewCompositorClientImpl) so instead of passing PaintPreviewCompositorClientImpl* into the post task (which could be deleted at any time), we should pass the mojo remote. The remote is guaranteed to be deleted on the same sequence as the task binding it and we know it exists before the bind task is posted so by definition of a sequence it will now be deleted only after the binding task is executed thus avoiding the race. Before this fix it was possible the PaintPreviewCompositorClientImpl* would be deleted so calling the BindPipeAndPassReceiver proxy method on it was unsafe. I was able to repro locally with a hack that deleted the PaintPreviewCompositorClientImpl right after the PostTask and based on that I'm reasonably confident this fix resolves the issue. Bug: 1157019 Change-Id: I85b2daf36260cc8a9dbd8515e45624b4effe1379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593875 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837280}
-
James Cook authored
For lacros, both browser and OS share a single consent for metrics reporting. The main pref is in ash. It is policy controlled by the DeviceMetricsReportingEnabled policy. For policy-controlled devices, lacros always has the right value for metrics reporting (it dynamically tracks the value in ash). However, we need to tell lacros whether or not the ash-side pref is managed, so lacros can show the correct "managed" icon in browser settings. Device policy is synced before signin, and is therefore available before lacros starts, so pass the managed state as part of LacrosInitParams. Long-term we'll need a more sophisticated solution. This device policy is "dynamic", meaning it could change from managed to unmanaged during a user session, so we'll need some kind of observer mechanism for whether it is managed or not. However, there's some general purpose policy work underway for lacros, so this should hold us until that work is done. Test: enroll device in managedchrome.com, disable metrics via device policy, ensure managed icon shows up in browser prefs Bug: 1148604 Change-Id: Ifd6818b6bf2565e987d62b28f9826d612b4b04a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591774Reviewed-by:
-
Yulun Wu authored
Bug: 1134433 Change-Id: I69ba2d06d2d99d3295b71449a33db1adc863c429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594114Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837278}
-
Kelvin Jiang authored
This CL replaces the int UserScript id with string. This is necessary for dynamic content scripts which have ids that are specified by the extension. To distinguish generated ids from future user defined ones, generated ids are prefixed with "_". Bug: 1054624 Change-Id: I3d439d6f52b1ec2edb0d847847684ed19046a7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570856Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837277}
-
Meilin Wang authored
This CL adds two histograms: * Nearby.Connections.Bluetooth.Socket.Read.Result * Nearby.Connections.Bluetooth.Socket.Write.Result to track the result of socket operations. Bug: b/163064897 Change-Id: If5a4cce7133d1aee41d6d5c33a3581bbe3fcca39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587580 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#837276}
-
Yi Gu authored
Bug: None Change-Id: I0584cbdbf6b0dc47e3b7a0dc6a98c4839a2105d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593556Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837275}
-
Sophie Chang authored
This is a reland of 84f1c409 TBR=droger@chromium.org,mcrouse@chromium.org Original change's description: > Implement read-only mode for Optimization Guide when in incognito > > Bug: 1151087 > Change-Id: I4a6074a01793c5a97de7f07e14ccbd133ef6cb51 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586246 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836442} Bug: 1151087 Change-Id: I0586433a365540bdc99a82a22061f8c9ffc65064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593811 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#837274}
-
Brian Sheedy authored
Fixes the unexpected pass finder not working with the power suite due to a mismatch between the suite name and the expectation file name. Bug: 998329 Change-Id: I7133347683870c6db15dc81ae66d809d5c8beba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592388 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#837273}
-
Keith Lee authored
All functionality related to InputMethodKeyboard* were designed to handle the onscreen / virtual keyboard. The class is not directly related to InputMethods. Hence, should be renamed to VirtualKeyboard*. Bug: 1158633 Change-Id: I06569bcae62755826bfc7dcf479a29dd90db7175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592207Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#837272}
-
Michael Thiessen authored
Other ContextMenuParams getters to follow. Bug: 783819 Change-Id: I6612d31f3c62d5434ce29420d6b36b3718b7b2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592010 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837271}
-
Hongbo Song authored
Change-Id: I5e67d5c916b46a6dda381c3bf05d37dcc2f7172e Bug: 1152552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594008Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Hongbo Song <hbsong@google.com> Cr-Commit-Position: refs/heads/master@{#837270}
-
Aaron Krajeski authored
Part of the greater effort to migrate cc and the paint_op_buffer away from SkMatrix, which is 3x3 and relatively slow, compared to SkM44. SetMatrix(SkM44) was added. Once concat(SkM44) is added we can make the PaintCanvas version of these functions that use SkMatrixs just call these functions and remove the SkMatrix versions within the paint op buffer. Bug: 1155544 Change-Id: Id0a866cba2ea8eb44822d9632bd890980ab707c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577704Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#837269}
-
Elly Fong-Jones authored
They are no longer on the project and email to them bounces. Bug: 1148873 Change-Id: Ib235c178f61a58ae34176558ad99acc56b9452a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593932Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#837268}
-
Zhiyuan Cai authored
Make the menu item "Track prices on tabs" invisible if user isn't signed in or is in incognito mode. Bug: 1144742, 1155688 Change-Id: Id124ed77289246d1b2e4ddcbe245c3be84fcebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575578 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
David Maunder <davidjm@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#837267}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/41545839b323..ae8efc5c4e6a 2020-12-15 chrche@microsoft.com [Loc] Migrate persistence to localization V2 2020-12-15 jacktfranklin@chromium.org Tests and fix for data grid resizing with hidden column If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35a5335478b7701873bc17c7ba320b1ba1617539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594109Reviewed-by:
-
