- 27 Oct, 2020 40 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If9e50e0e4d33509c0758f8e16e43fa464ffa1264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500364Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821076}
-
Koji Ishii authored
Currently the infinite rewind loop does not frequently occur, but it exists, and recent issues indicated that minor changes may hit it. This patch enables the rewind-loop detector added for DCHECK-builds in r696740 crrev.com/c/1801474 for non- DCHECK-builds. When it hits, it fires |NOTREACHED| and end the line breaker. This patch also fixes the detector not to misfire when rewinding to index 0 by using |Optional|. Bug: 1132811 Change-Id: Idc4a8de5484b8f2df90b7f8525139ae99be6b9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498983Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821075}
-
Kunihiko Sakamoto authored
This reverts commit f6a05301. Reason for revert: virtual/layout-ng-grid/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-*.html are failing in multiple bots. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/75331 https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9841 https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/17342 Original change's description: > [GridNG] Implement alignment within grid-areas. > > This patch implements alignment within a grid-item's grid-area. > When creating the GridItemData we read of the containers, and > grid-item's style, or determine its alignment axis-edge, and if it > should be stretched, saving this information on the GridItemData. > > When placing the grid-item it will use this to adjust the offset. > > This doesn't implement baseline alignment which requires a secondary > pass to correctly determine the baseline for the column/row. > > The other TODO relates to the constraint-space API, and how grid will > need a slightly new concept in order to do block-axis stretching > easily. By default non-replaced grid-items will stretch to the available > space. A new bit on the space can indicate that we should stretch to > the available space (if possible), this is similar to the shrink-to-fit > bit we have today. > > This adds a self-start/self-end test as after implementing this now new > tests passed immediately, and I don't believe we had good test > coverage for inflow content with these keywords. > > Bug: 1045599 > Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#821043} TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,kschmi@microsoft.com,ansollan@microsoft.com Change-Id: I0a9398ce4bf339a632c3baed7374754f3c664496 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500969Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821074}
-
Martin Kreichgauer authored
When processing a MakeCredential request with ResidentKeyRequirement "preferred", authenticators can fail creation of the discoverable credential with CTAP2_ERR_KEY_STORE_FULL if their internal storage is exhausted. Chrome will then try to make a non-discoverable credential; however both of these requests will consume a user presence touch. This change plumbs the authenticatorGetInfo response remainingDiscoverableCredentials field into MakeCredentialRequestHandler, so that we can first check whether internal storage is exhausted and only request a non-discoverable credential in that case, reducing the number of required touches to one. Because remainingDiscoverableCredentials is only supported in CTAP 2.1, those authenticators can still fail with CTAP2_ERR_KEY_STORE_FULL, and users will have to tap them twice. Bug: 1117630 Change-Id: I5c5b432e3cce80c20654fa2588cf72ffaceeca61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493782 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#821073}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=ksakamoto@chromium.org Bug: 1142671 Change-Id: I58ff750aed0569b77cac8e1001fa1672437eb1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501127 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Bo Majewski authored
Use modules to load main class and browser proxy. Actually calls browser proxy. Bug: 1113981 Change-Id: Ia5df25c26c8e2131cab9663382680156e1304b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497901 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#821071}
-
Noel Gordon authored
Create the element content the way we do with the <bread-crumb> custom element (which came latter). No change in behavior: covered by FilesMessage unittest. Bug: code-health Change-Id: Id568aa6b5644a712db88ba5f4fa8d3d13f323b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500685 Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#821070}
-
Meilin Wang authored
This CL fixes the bottom padding of the quick action view when there are no continue browsing chips shown below. Screenshots: https://screenshot.googleplex.com/3L2rq3Z2WPYhNgN.png (before) https://screenshot.googleplex.com/8TxuihZsi4TZobu.png (after) BUG=1106937,1126208 Change-Id: I8cfd9d60d72951ef1341f69e910f4b4e46285297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495676 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821069}
-
Kunihiko Sakamoto authored
Bug: 1142682 Tbr: weili@chromium.org Change-Id: I94bd69c6f92713cf4db529e385c28067413f4d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500965Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 1142671 Change-Id: Idf1a6a3c792f968c39a3f22eea057d58b35f6c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501126 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#821067}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 88-4280.20-1603104419-benchmark-88.0.4300.0-r1 to 88-4280.20-1603104419-benchmark-88.0.4303.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icb778adc45b65f1a07df0a63b1a593276303dc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500365Reviewed-by:
-
Avi Drissman authored
As promised, the policy to allow popups during page unload is being removed for Chromium 88. Bug: 937569 Change-Id: I1064da7d5debc640c6179b87775afa20d92d74be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491120 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#821065}
-
Victor Costan authored
Change-Id: I1a94ca367a960989747bbf611558b1b1efc295a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344655 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#821064}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=tapted@chromium.org Bug: 1142671 Change-Id: I28c30536bc396847389eb4a3ad7b6c3f6d93529d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500560 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#821063}
-
Minoru Chikamune authored
Context: For MBI, per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for AgentSchedulingGroup's mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I67b6e21e353808ea2b922a1bb1480f62f73feae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497868Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#821062}
-
Kent Tamura authored
This CL ports LayoutTextControlSingleLine::UpdateLayout() to LayoutNG by * Adding "-internal-align-self-block" CSS property * Implementing centering behavior in NGBlockLayoutAlgorithm * Apply the property to text field's InnerEditor boxes and decoration container boxes "-internal-align-self-block" will be applied to button's anonymous block and slider's track box too. This CL has no behavior changes for now, but it fixes dozens of web test failures with LayoutNGTextFields flag. Bug: 1040826, 1131352 Change-Id: Iaa75fdd53ce428c90b12fd695f49752da0ea9247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491766Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#821061}
-
Ken Rockot authored
Application code may call mojom structs' generated Serialize() method to produce a local array of bytes representing the serialized object. These methods ultimately use the same message serialization logic that applies to IPC messages. Soft size limit checks are done during the serialization process, and so manual Serialize calls can still trigger crash dumps when serializing very large objects. Since the intent of the checks is to reveal oversized IPC messages for performance reasons, there's no reason to apply them on these Serialize calls. This CL modifies the common path used by all generated Serialize() methods to ensure that the size checks are bypassed. Bug: 1141987 Change-Id: I936ba58cf682c4b63310f746cd19a933c82a70b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495835Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#821060}
-
Kenichi Ishibashi authored
Bug: 1055677 Change-Id: I3d91b8a72ef19c3577663d0dd84c0579b7f33fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500963 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821059}
-
Kenichi Ishibashi authored
We removed AppCache dependencies from service worker as of crrev.com/c/2452029. Remove unused includes. Bug: 1117369 Change-Id: If5133261a88ae47229d37826d14816a46b35e7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500386 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821058}
-
Noel Gordon authored
Add new test Option for media_swa and use it in enable and load SWA in test from file_manager_browsertest_base.cc. Remove the SWAsFilesAppBrowserTest fixture: move its media SWA test to the FileManagerBrowserTest fixture. Bug: 1122379 Change-Id: Ifbe75220777d0115a8e81c61ff2bb7fea447dcf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500683Reviewed-by:
-
John Palmer authored
This reverts commit d2fd3739. Reason for revert: Changing this to a private API as it is only going to be for private usage as part of a core chrome OS feature. Original change's description: > Add JS API for chrome.input.ime.autocorrect > > BUG=1138092, 1111135 > > Change-Id: I35366c90794f9e26917360464ec3553798073a65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483719 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Keith Lee <keithlee@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: John Palmer <jopalmer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820993} TBR=xiyuan@chromium.org,mpearson@chromium.org,mlippautz@chromium.org,tranbaoduy@chromium.org,keithlee@chromium.org,jopalmer@chromium.org Change-Id: I77c44b870eeca0cee4f23c04d806bb985d300c1e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1138092 Bug: 1111135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500682 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#821056}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6b0ecd8197ff..8d0801430595 2020-10-26 changhaohan@chromium.org Angle component style fixes 2020-10-26 anthonyxie64@gmail.com Fix search index for JSON sources when no match found If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126178,chromium:838311 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5fb39ed304aa03dd0dbfc518faeecd7f3a42bffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500549Reviewed-by:
-
Jenny Zhang authored
Adds crosapi GetHistograms to allow ash pull the lacros histograms from lacros and attach it in the unified feedback report as a zipped file lacros_histograms.zip. TEST: 1. Start Lacros chrome, send a feedback report. Verify on listnr that the feedback report contains lacros_histograms.zip. Download and unzip the file and verify the histogram data in unzipped file looks good. 2. Don't launch Lacros chrome, send a feedback report from ash. Verify on listnr that the feedback report does not contain lacros_histograms.zip. Bug: 1119925 Change-Id: I91f5f05270d28ec038fcb5f9ea5002191ebd7f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493363Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821054}
-
Dominic Mazzoni authored
To replace "master", I chose outputVolume for masterVolume because it's applied as a final factor, and then basePan and baseReverb because individual earcons use those values as a starting point for further adjustments. Bug: 842296 Change-Id: I5b36205b6dcafd1351daf3b66d2686618804007a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487882Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821053}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36af02d2efd7..0e13db707ff3 2020-10-26 csmartdalton@google.com Clean up GrPathUtils 2020-10-26 csmartdalton@google.com Optimize SkChopCubicAt to chop at two points at once If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I3cb1f18d75c5f4e7da3f231f040a9992448c524e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500901Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I77d4b8545a7d47ada444bc4660610250c7550c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500705Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821051}
-
James Hollyer authored
The Permission UI for getting location permission from mac is completely separate from the actual Core Location backend. Furthermore, once we have location permission from macOS our Network Location Provider works as intended. This CL separates those 2 independent workflows and allows the Network Location Provider to monitor permission and act accordingly. Bug: 1112630 Change-Id: I4e3141f756eadcb3d7ecc66c347fc24148505edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454307 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#821050}
-
Daniel Hosseinian authored
The Chai dependency prohibits the util from being used in WebUI tests that are not configured to use Chai, like the PDF Viewer's. Change the assertion to be part of a condition. The assertion was already strong and unlikely to fail. Change-Id: I008a6b6ccb1cd8c83d3ec2dcea3476243e89cb0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495506 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821049}
-
Minoru Chikamune authored
Context: Per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for RenderFrameImpl's mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I8bb485e6d1ca97cdbf9f5dd0f32719f1d0ad2202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498024Reviewed-by:
-
John Abd-El-Malek authored
WebLayer: add support for navigating to a URL when the data is already available in a WebResourceResponse. Bug: 1117626 Change-Id: I6d3bd9f4ec71a5e16390f072182a76fe36aca4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369617 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821047}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //content/public. Bug: 1113033 Change-Id: I4fc946e09255a6d8971a375c1da169233db53ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472420Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#821046}
-
Caroline Rising authored
This is setup work for enabling cross device sync for the read later feature. Bug: 1109316 Change-Id: I172633ba826b8f520aa6f25273bd530b38782257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492920Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#821045}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //content/browser/resources. Bug: 1113033 Change-Id: Ic84b891c4f67830b63e3dad1dde6f5cdd5f26429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472590Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#821044}
-
Ian Kilpatrick authored
This patch implements alignment within a grid-item's grid-area. When creating the GridItemData we read of the containers, and grid-item's style, or determine its alignment axis-edge, and if it should be stretched, saving this information on the GridItemData. When placing the grid-item it will use this to adjust the offset. This doesn't implement baseline alignment which requires a secondary pass to correctly determine the baseline for the column/row. The other TODO relates to the constraint-space API, and how grid will need a slightly new concept in order to do block-axis stretching easily. By default non-replaced grid-items will stretch to the available space. A new bit on the space can indicate that we should stretch to the available space (if possible), this is similar to the shrink-to-fit bit we have today. This adds a self-start/self-end test as after implementing this now new tests passed immediately, and I don't believe we had good test coverage for inflow content with these keywords. Bug: 1045599 Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821043}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603735176-b32fad2c4d9cbe478f3c31f23cbc72f28c88ba53.profdata to chrome-linux-master-1603756748-18fcc653ee73e42ac2d8e9952f1488ef428e6efa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id7a2ec7c00e1a1c10058431e795cc300e14b4b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500903Reviewed-by:
-
Peter Kotwicz authored
This CL: - Makes BuildConfigGenerator.groovy and fetch_all.py agree with the expected directory of the generated DEPS file - Fixes cipd_path computation in ParseDeps() in fetch_all.py BUG=None Change-Id: I13375cdec9478f196a3e026e2fc2e21197c03c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500564Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821041}
-
Thomas Lukaszewicz authored
Adds an UnhandledKeyboardEventHandler member to the BubbleWebView to allow the WebView and embedder to deal with key events that were not handled by the WebContents. Sets allow_accelerators_ to true to ensure that embedders of the BubbleWebView are able to capture and respond to accelerators. Bug: 1138967 Change-Id: Ib629de2dbb0f1b6e41f4116fcff6d1413fc3061c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496504Reviewed-by:
-
Victor Costan authored
The QuotaClient interface now guarantees that clients only get called with StorageTypes that they were registered for. In particular, AppCacheQuotaClient is only called with kTemporary. This precondition has been covered by a DCHECK for a while. This CL removes a check that cannot be true under the current QuotaClient interface. Change-Id: I2057935df768f657f13a7f4297864ab62cc7ce1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500767 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#821039}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603735176-39200681b7df83b17975b9debf912df318fc5920.profdata to chrome-mac-master-1603756748-67e6d78aa0117f6752ad92f968b3a41dbb1fa16d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I08d06fa72160d4f6f8a9745bf99bb639a4e50846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500902Reviewed-by:
-
Amanda Baker authored
This change enables future UI changes based on the 'window-controls-overlay' display override by adding a new method, `IsWindowControlsOverlayEnabled()`,to the web app controller that indicates whether or not the WCO should be shown. Explainer: https://github.com/WICG/window-controls-overlay/blob/master/explainer.md Design Doc: https://docs.google.com/document/d/1k0YL_-VMLIfjYCgJ2v6cMvuUv2qMKg4BgLI2tJ4qtyo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/cper6nNLFRQ/hU91kfCWBQAJ Bug: 937121 Change-Id: Ibe5615393e50edc09e2464abe9eaa09e52559be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486780Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Amanda Baker <ambake@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821037}
-
