GitLab

Adjust the chrome.permissions API for use with withheld permissions as
a result of the RuntimeHostPermissions feature. This patch allows the
permissions API to be used to request withheld or optional host
permissions, rather than just optional host permissions.

This is important for extensions that want to be able to request
permissions at runtime using the chrome.permissions API as a workaround
to having required permisssions withheld.

Additionally, move requesting optional permissions to looking at the
runtime granted permission set, rather than the granted permission set.
This greatly simplifies the logic, as now all permission requests are
compared to the same permissions set, and we don't need to isolate host
permission requests versus API permission requests. This also ensures
we avoid granting a permission that was explicitly revoked by the user
(as could happen if we just checked granted permissions).

As of Chrome 70, all permissions granted through the permissions API
are added to the runtime granted set. However, this does mean that
optional permissions that were granted prior to M70, and then later
removed via permissions.remove(), will re-prompt the user. In practice,
this is very rare. This also means that optional permissions will not be
granted automatically for permissions that were used by previous versions
of the extension (similarly, very rare in practice).

This does *not* address the issue of scriptable hosts in requested
permissions; that is still an issue.

Bug: 889654

Change-Id: I8c20f03ec7b402cd61ae1db04b782447dc39414e
Reviewed-on: https://chromium-review.googlesource.com/c/1301851
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607474}

Android IMEs can be disabled in Android side by using 'ime' command.
This CL ensures that disabled IMEs are also disabled in Chrome OS's
InputMethodManager.

Bug: b/119274469
Change-Id: I46c2996a41327221470d69b778da2b7270c73cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1331294Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607473}

To avoid PRESUBMIT check for InvocationHandler annotation check. Should
be no logic change.

Bug: None
Change-Id: I91680e54c5b0f0cc692b841a57f7f5b68f724d9b
Reviewed-on: https://chromium-review.googlesource.com/c/1323624
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607472}

https://chromium.googlesource.com/catapult.git/+log/0cf6ee7f1acb..84f62b6f08e8


git log 0cf6ee7f1acb..84f62b6f08e8 --date=short --no-merges --format='%ad %ae %s'
2018-11-12 cbruni@chromium.org [wprgo] Implement httparchive.go add and addAll command
2018-11-12 erikchen@chromium.org Update computation of load bias to handle CrOS edge cases.


Created with:
  gclient setdep -r src/third_party/catapult@84f62b6f08e8

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:904492
TBR=sullivan@chromium.org

Change-Id: Ic4a8c9f0258bf1183c0f78bb2d996dd2ad94e423
Reviewed-on: https://chromium-review.googlesource.com/c/1333049Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607471}

FilesApp provides the innards of the extension file dialog. Add a test
to open the file dialog by clicking on an <input type=file> element in
a web page.

Bug: 895703
Change-Id: Id6f56e2df4034af66a57f888195bc841a55da2b4
Reviewed-on: https://chromium-review.googlesource.com/c/1331099
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607470}

This Cl disables pin input field whan it is displayed in incognito UI.

Bug: 900351
Change-Id: I7aae9f08403933f12cae5345075e5e94e775e3a4
Reviewed-on: https://chromium-review.googlesource.com/c/1332929
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607469}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f1ac04ec34e..f1ff631c9f6c


git log 7f1ac04ec34e..f1ff631c9f6c --date=short --no-merges --format='%ad %ae %s'
2018-11-12 weidongg@chromium.org Mark four pfq boards as important
2018-11-12 dgarrett@google.com chromeos_config: Adjust postsubmit configs.


Created with:
  gclient setdep -r src/third_party/chromite@f1ff631c9f6c

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If4b876c7a0b6136dc6a1fd1b682bee26972e4627
Reviewed-on: https://chromium-review.googlesource.com/c/1333048Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607468}

Rather than load chrome://newtab internally and eventually load an error page,
internally track the NTP with about://newtab (which is a blank page).

Bug: 826369
Change-Id: I2af53f90088ce4f376a4d0d0107eb667d5aa5d48
Reviewed-on: https://chromium-review.googlesource.com/c/1328185
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607467}

This CL moves onPageStarted to page commit for browser navigations.
However the old code path is not removed since we still do not want to
enable this for old versions of GMSCore. Add a kill switch feature
that's disabled by default and a test finch config to enable it for
testing.

Bug: 896022
Change-Id: I7cd0777687ca4be096209a3a0cfed8dba4e5bd13
Reviewed-on: https://chromium-review.googlesource.com/c/1327170Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607466}

We want to know when during the installation process users are canceling

This CL adds a new bucket to the histogram for each cancelable state
of the installation process. Currently, it maps from install state to
reporting bucket by doing arithmetic on enum values. I'm not sure this
is the best way to do this, since it's vulnerable to us changing the
numbering of install states in the future. The alternative would be to
add a static map to the class from State to SetupResult.

Bug: 703927
Change-Id: I7ac2fd19b3370f2c46a7cd4bfe9be78b63f31612
Reviewed-on: https://chromium-review.googlesource.com/c/1331094Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#607465}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/332c9ff5a98e..ef71a5f047da


git log 332c9ff5a98e..ef71a5f047da --date=short --no-merges --format='%ad %ae %s'
2018-11-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@ef71a5f047da

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I0d5a1624b7358f39f5379281d803758d40cc297f
Reviewed-on: https://chromium-review.googlesource.com/c/1333051Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607464}

This changes the return values of
FidoAuthenticator::AuthenticatorTransport() and
AuthenticatorMakeCredentialResponse::transport_used() to
base::Optional<FidoTransportProtocol>.

This accommodates the Windows API integration use case where (a) the
FidoAuthenticator subclass cannot guarantee any particular transport
type and (b) the response we receive from the API contains no hints
about which transports were used.

Bug: 898718
Change-Id: Iadb83310f03d5f54ad50babb73e0963bdd21e3c2
Reviewed-on: https://chromium-review.googlesource.com/c/1325220Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607463}

In order to setup origin trial need to make the feature & origin trial
dependent on a new runtime enabled feature that is dynamically set if
the translation service is available.

BUG=872777

Change-Id: Ic6fc5947a50c4e2a5ac659c83d75a972c31b0c12
Reviewed-on: https://chromium-review.googlesource.com/c/1332780Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607462}

As we try to add new e2e tethering tests, we need a way to make the
host scan occur normally even when there is an ethernet connection
because there's always an ethernet connection to deploy the test.

This CL creates the infrastructure necessary to create a flag to
override the prohibition against searching for a tethering host with an
ethernet connection by gating it on booleans called
ignore_wired_networks_

-----

Testing:

I manually tested that this change causes the tethering notification to
appear when the user logs in with an ethernet connection but no wifi
connection. For comparison, I also tested that logging in with a wifi
network does not cause the notification to appear.

Bug: 904609
Change-Id: I7406274cd159ae2b18ad6a22ca90cba76b98dbad
Reviewed-on: https://chromium-review.googlesource.com/c/1332693
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607461}

This CL adds a metric which measures the time it takes to create a secure
connection to a remote device, from the moment a SecureChannelService client
asks for a new connection (start scanning), to the moment that an authenticated
channel is established with the remote device.

Note that this CL creates latency_metrics_util.h/cc files to fine-tune
the bucket size for this metric. It's created as standalone files because the
same buckets will be used for future metrics.

Bug: 870139
Change-Id: I62600f9ef0cb1888c9fd4643c89221c5736bfaee
Reviewed-on: https://chromium-review.googlesource.com/c/1327466Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607460}

Change-Id: Ia96ee91c0097b2f5dac45c7a83d10643481f9ed5
Reviewed-on: https://chromium-review.googlesource.com/c/1332188Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607459}

The metrics recording was previously enabled via Finch. It's now ready to be enabled for everyone. This CL enables it by default for all clients.

However, the UI is still not ready to be enabled for everyone. Guard the UI behind a new feature name, so as to avoid confusion from past Finch configs.

In short,
- Old clients which receive the Finch config for LookalikeUrlNavigationSuggestions will record metrics.
- All new clients will record metrics.

Bug: 878153
Change-Id: Ief99afec48d879431ec33e4e74e8722478b45ddd
Reviewed-on: https://chromium-review.googlesource.com/c/1317926
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607458}

This is a reland of 756ebd67

Original change's description:
> Start arc data removal directly from Chrome
> 
> Chrome had to proxy through session_manager to start the arc-remove-data
> Upstart job, but now it calls it directly.
> 
> BUG=b:115779632
> TEST=Disable ARC++ and ensure arc data removal occurs
> 
> Change-Id: I0f30570c665efc85538b9de4bcd63bb158b37417
> Reviewed-on: https://chromium-review.googlesource.com/c/1311124
> Reviewed-by: Yusuke Sato <yusukes@chromium.org>
> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
> Commit-Queue: Christopher Morin <cmtm@google.com>
> Cr-Commit-Position: refs/heads/master@{#604724}

Bug: b:115779632
Change-Id: I8ce85de68c88bea372ce7c864a741546bd6695f8
Reviewed-on: https://chromium-review.googlesource.com/c/1330749Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607457}

This CL simplifies the logic that determines what text is displayed in
the HTTPS UI indicator. It explicitly merges the logic for determining
what text is visually displayed with that of the accessibility label
into one function.

Bug: 812447
Change-Id: I72125b81003223ecd00d290a6900533dfb424d10
Reviewed-on: https://chromium-review.googlesource.com/c/1331569
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607456}

Origins set to "clear on exit" need to get wiped when the storage
partition is shutting down. This was wired into the context's
destructor, but needed to be triggered earlier. Introduce an explicit
Shutdown() call invoked by the storage partition, similar to other
storage backends.

Bug: 750452, 824533
Change-Id: I353c183f842da0016fa35f7d48c462c5e85b67ab
Reviewed-on: https://chromium-review.googlesource.com/c/1289435Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607455}

Bug: 882513
Change-Id: I7643ae90356a4a98f57cb5e14691af4362ad9b83
Reviewed-on: https://chromium-review.googlesource.com/c/1323719
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607454}

NavigationBarColorController#updateNavigationBarColor is only called on
newer versions of Android so the lint warning can be safely suppressed.

BUG=

Change-Id: I98a6063e53b4976c82e04fb376fea58b84d10b51
Reviewed-on: https://chromium-review.googlesource.com/c/1332292Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607453}

Fix a bug where clicking "edit" on a host permission directly after
switching to "on specific sites" would fail. This was because we weren't
clearing the oldHostAccess_ bit in runtime_host_permissions.js, which
then transferred through to the runtime_hosts_dialog. When this is set,
editing is forbidden.

Properly clear the bit on dialog close, and add a test for the same.

Bug: 903082

Change-Id: I2c5c610fe9c9819f749cf4bd112266bd537c0f31
Reviewed-on: https://chromium-review.googlesource.com/c/1327467Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607452}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6374fa323c0e..3d56676303ac


Created with:
  gclient setdep -r src-internal@3d56676303ac

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ice5623fcd1939b65d42d150bf1f9217fcc98b918
Reviewed-on: https://chromium-review.googlesource.com/c/1333047Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607451}

StackSamplingProfiler.ProfileDeserializationTime is recorded for every
profile to deserialize, which can be expensive when a lot of profiles
are pending upload. Since we have already got enough data for these
metrics, we should retire them.

Bug: 851163
Change-Id: I703e8b01752832d9574e804b1a28c2a2bfd0058e
Reviewed-on: https://chromium-review.googlesource.com/c/1332772
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607450}

Bug: 883480
Change-Id: I38f816ee918c597b4f4020fa79a6ce2f0785d947
Reviewed-on: https://chromium-review.googlesource.com/c/1257679
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607449}

Example: https://screenshot.googleplex.com/tHOgDdVn6aj

R=riajiang@chromium.org

Bug: 895600
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I41affc1da88425ae8284bc0eef7d54aeefa124c9
Reviewed-on: https://chromium-review.googlesource.com/c/1289072
Commit-Queue: Alexander Shah <zandershah@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607448}

With this CL, backdrop-filter will continue to work when the
--enable-blink-gen-property-trees flag is enabled. Behavior should be
identical to behavior without the flag.

Also, I added a number of layout/WPT tests for backdrop-filter,
some of which currently pass, and some of which need fixing. The ones
that need fixing have been added to TestExpectations. These new tests
should reproduce (at least) these issues:
 - https://crbug.com/314867 - respecting isolation
 - https://crbug.com/525099 - respecting isolation
 - https://crbug.com/547937 - border radius
 - https://crbug.com/524689 - filter plus backdrop-filter
 - https://crbug.com/745012 - boundary effect problems

I also moved the existing tests out of external/wpt/css/css-filter
into external/wpt/css/filter-effects, where they really should be,
now that filter-effects is being pulled into the tree.

Bug: 497522,314867,525099,547937,524689,745012
Change-Id: I2be33fbc0e17dec2cd138f9796971fb4a9a57216
Reviewed-on: https://chromium-review.googlesource.com/c/1316661
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607447}

Bug: 891734
Change-Id: Ib51e5300c9bcde61e331431999a00dbe1e645618
Reviewed-on: https://chromium-review.googlesource.com/c/1332729
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607446}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ic436c38a119e8da25f7c1fb9bee7e7b036f0f43d
Reviewed-on: https://chromium-review.googlesource.com/c/1333050Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607445}

This patch reduces the size of:
* NGPhysicalBoxFragment by a pointer, by removing |style_|
  from NGPhysicalFragment. This field is used only for line
  box and for ellipsis, and thus it is moved to each
  subclasses.
* NGPhysicalTextFragment by 16 bytes, by moving
  |self_ink_overflow_| and |style_| to RareData. Quick
  investigation shows that |self_ink_overflow_| is different
  from |LocalRect()| in 10-20% of the time (on Linux,
  google.com and a few other sites.)

Change-Id: I225edd42d6d9488611ffe2fa7ef9b11b7e9da4a1
Bug: 635619, 636993
Reviewed-on: https://chromium-review.googlesource.com/c/1331102Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607444}

Fixed a bug in the onItemUpdated of the mutator which was not
propagating the updated item to its internal data structure.

Bug: 904548
Change-Id: I64298c1aa591709edcf73736e207474fb3b8b062
Reviewed-on: https://chromium-review.googlesource.com/c/1332408Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607443}

Turns out that when a video is tagged as RGB,
they really mean that the Y channel contains green,
Cr contains red, and Cb contains blue.
(According to ISO 23001-8:2016)

Bug: 901664
Change-Id: I468327252389dc2468020f23a912129fdc55574a
Reviewed-on: https://chromium-review.googlesource.com/c/1321582Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607442}

JS_SCROLL_TEXT_ONLY and JS_SCROLL_200_LAYER_GRID both add event listeners
to the document that preventDefault wheel/touch events and call JS scrolling.
The tests regressed after landing the following cl:
https://chromium-review.googlesource.com/1183538

This is because with passive document level event listeners interventions
the wheel/mousewheel and touchstart/touchmove event listeners on a document
level target are treated as passive if not requested otherwise. This cl changes
the event listeners in both tests to passive:false to make sure that they
actually prevent scrolling.

Bug: 877586
Change-Id: I25fb5c0563534b1d67f124bd43272d02d849fa23
Reviewed-on: https://chromium-review.googlesource.com/c/1329447
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607441}

The Captured Sites Autofill tests start with a default saved credit
card. Individual test recipes may overwrite this default with a specified
credit card. Today, there is a bug that prevents a recipe from
overwriting the default card owner by first name and last name. When
doing an override, the framework triggers a DCHECK in the saved credit
card code that asserts the credit card name is empty.

This fix address the DCHECK by setting the default credit card owner
name to an empty string before overwriting it.

Fixing an autofill profile setup bug in test.

The Captured Sites Autofill Tests starts with a default saved credit
card. A test recipe may override the default card with its own credit
card info. Today, a bug exists in the framework that prevents the recipe
from overriding the credit card owner by first name and last name. The
bug breaks a DCHECK assertion in the saved credit card code. This fix addresses the assertion by setting the credit card owner name to empty before overriding the recipe specified credit card name.

Bug: 902492
Change-Id: Iec86496bf408400b60c2a7183b15ef0bd7dfc14f
Reviewed-on: https://chromium-review.googlesource.com/c/1332694
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607440}

TBR=jbudorick

Bug: 880623
Change-Id: Ibcda8cadf0e6b00f1f50ade12c06922a2f5f3bda
Reviewed-on: https://chromium-review.googlesource.com/c/1332610Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607439}

This CL adds a method to ClientTransferCache that allows the client to
get a ClientDiscardableHandle without
ClientTransferCache::Client::IssueCreateTransferCacheEntry getting
called so that the client can essentially start a locked entry but
trigger the creation of the service-side entry using some other
mechanism, e.g., an IPC message.

This is needed for hardware-accelerated image decodes because the decode
will be started by sending an IPC message, and the service-side cache
entry shouldn't be created until the decode is done, so the usual flow
of triggering the cache entry creation using the command buffer won't
do.

Additionally, some documentation is updated.

Bug: 868400
Change-Id: I24cf9b921b8a0ea2e7038c1801f2b7c36fda1927
Reviewed-on: https://chromium-review.googlesource.com/c/1328184Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607438}

UserTiming L3 will change the L2 API in certain cases. These cases are described
in http://bit.ly/2SZqAKz.

We want to investigate which and how much various use cases will be impacted by
the introduction of L3 API. So we write this CL to do the investigation.

In particular, we will have two UMA histograms to count the input types of
the performance.measure method in the wild. The input types are to be divided
into the following groups:
1. number
2. sub-groups defined by navigation timing names
3. object
4. unprovided
5. undefined or null
6. others

We used to have a similar histogram before (CL/769932), which we used to collected
2,3,6. Though we had removed it, it defined some of the enums that we reuse.


Change-Id: Idfb1d7fc761189563f55e5f5ba7c493e94e5e83a
Reviewed-on: https://chromium-review.googlesource.com/c/1320012
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607437}

Bug: 899324
Test: none

Original change description:

> CryptAuth: Remove unused ConnectionFinder.
>
> Bug: 899324
> Test: none
> Change-Id: I30f07136ac7c3ed3ac49b678e5f45d250fcbe65f
> Reviewed-on: https://chromium-review.googlesource.com/c/1331573
> Reviewed-by: Jeremy Klein <jlklein@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607302}

R=hansberry@chromium.org

Change-Id: Ia14bbe45b5b76a94c79aea5c4b687695df843163
Reviewed-on: https://chromium-review.googlesource.com/c/1333109
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607436}

The rule should just match simple hostnames, and previously was confused (both in implementation and consumers) into acting like a bypass for localhost.

The compatibility risk of changing its meaning (given this may be serialized in preferences or used by extensions) is low, since a previous change added implicit bypass on localhost. Hence the overall impact of fixing <local> now is just that IPv6 IP addresses are no longer bypassed. That IPv6 literals were being bypassed by the check was unexpected and a bug.

Bug: 902579, 902418
Change-Id: I5937048e3f927c66668e39e4ceb589ef8516e874
Reviewed-on: https://chromium-review.googlesource.com/c/1320849
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607435}