GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496

Review URL: https://codereview.chromium.org/126433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243569 0039d316-1c4b-4281-b951-d872f2087c98

DoCreateStream time in the HttpNetworkTransaction. This hook allows
for experimentation with the ResourceScheduler so that it can defer
after first checking the cache, gathering the cookies, and starting
the WebRequest but before going to the network.

BUG=328741

Review URL: https://codereview.chromium.org/122453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243568 0039d316-1c4b-4281-b951-d872f2087c98

The dependency path is
  src/chrome/chrome.gyp:common ->
  src/components/components.gyp:policy_component ->
  src/components/components.gyp:user_prefs ->
  src/content/content.gyp:content_browser

This was introduced in https://codereview.chromium.org/102973005. The issue is
that URLBlacklistManager::RegisterProfilePrefs() uses a PrefServiceSyncable
which comes from user_prefs, and user_prefs depends on content::BrowserContext.

This fix splits the policy/common files into a policy_component_common target
that does not depend on user_prefs. chrome.gyp:common now depends on
policy_component_common, and chrome.gyp:browser depends on policy_component.

BUG=332030

Review URL: https://codereview.chromium.org/124393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243567 0039d316-1c4b-4281-b951-d872f2087c98

Update PowerPolicyController to not send an empty policy to
powerd when Chrome starts or exits. Empty policies were
originally sent to ensure the system wouldn't be stuck with
an old policy, but they also mean that powerd could briefly
revert to its default settings with undesireable results
when the system first boots or the user logs out (e.g. an
enterprise policy has disabled the lid-closed action, but
powerd reverts to its default settings and shuts down
automatically when the user logs out).

BUG=329930
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/116983008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243566 0039d316-1c4b-4281-b951-d872f2087c98

This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
  instead of TokenWebData::FromBrowserContext.

BUG=332107
TBR=thakis

Review URL: https://codereview.chromium.org/109783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243564 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243563 0039d316-1c4b-4281-b951-d872f2087c98

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/127983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243562 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243561 0039d316-1c4b-4281-b951-d872f2087c98

r1830 - generator output should be relative to depth
r1829 - win msvs: make express editions not use x64-x64 compiler

BUG=none
TBR=joi@chromium.org

Review URL: https://codereview.chromium.org/127953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243560 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332237

Review URL: https://codereview.chromium.org/127113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243559 0039d316-1c4b-4281-b951-d872f2087c98

Quite a few changes were made downstream, keep them in sync:
- specify the #include files.
- inject the common DCHECKs for class and native pointers.
- inject the check exception call.

BUG=

Review URL: https://codereview.chromium.org/115103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243558 0039d316-1c4b-4281-b951-d872f2087c98

We already load chrome.pak and en-US.pak which includes all the necessary
strings and images for the tests.

This also fixes the following errors I'm seeing in ui_unittests target.

[18617:18617:0104/164229:7580537011:ERROR:memory_mapped_file.cc(23)] Couldn't open /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
[18617:18617:0104/164229:7580537130:ERROR:data_pack.cc(78)] Failed to mmap datapack
[18617:18617:0104/164229:7580537189:ERROR:resource_bundle.cc(607)] Failed to load /home/tfarina/chromium/src/out_cros/Debug/ui_unittests_strings/chrome_100_percent.pak
Some features may not be available.

BUG=144345
TEST=ui_unittests, app_list_unittests, message_center_unittests
R=tony@chromium.org
TBR=ben

Review URL: https://codereview.chromium.org/104783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=194304

Review URL: https://codereview.chromium.org/100963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243556 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org
TBR=eroman@chromium.org
BUG=324225

Review URL: https://codereview.chromium.org/127923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243555 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/121673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243554 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=thakis@chromium.org
BUG=162825,293049,332271,332328,332329,332330,332335

Review URL: https://codereview.chromium.org/127933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243553 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243552 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164656:164662&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/127913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243551 0039d316-1c4b-4281-b951-d872f2087c98

Actual implementation will come later. This CL just addes the interface.

BUG=324166

Review URL: https://codereview.chromium.org/127463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243550 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=checkdeps passes
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/126893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243549 0039d316-1c4b-4281-b951-d872f2087c98

Most X DRI2 drivers return TRUE for GetSyncValues with a MSC value of 0
if they cannot deduce on which CRTC the Drawable is being displayed, or
that CRTC is currently disabled.

This can happen if the associated CRTC is powered off, or if its
framebuffer is being rotated, etc.  Once the driver is in this situation,
all MSC == 0 values will be returned until the CRTC can be found again.

Currently, we spam the log every time we receive msc==0, which fills up
the disk, makes the GPU log unusable, and causes lots of confusion when
devs are trying to debug other issues.  Instead, let's just log exactly
once every time this situation is detected.
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG=231945
TEST=Manual on chromeos:
  # Enable some slowly updating page on each monitor, for example:
    http://www.24webclock.com/
  tail -F /var/log/chrome/chrome | grep glXGetSyncValuesOML &
  set_short_timeouts
  # Let the displays turn off (~35 seconds)
  => This message should be printed exactly once per attached display:
 glXGetSyncValuesOML should not return TRUE with a media stream counter of 0.
  # Turn displays back on (tap a key), and let them idle off again.
  => The same message should be printed exactly once per attached display.
R=marcheu@chromium.org
R=piman@chromium.org
R=backer@chromium.org

Review URL: https://codereview.chromium.org/126823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243548 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243547 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/110413009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243546 0039d316-1c4b-4281-b951-d872f2087c98

This CL causes Chrome to freeze on e.g. jsfiddle.net/r8dx9/1/embedded/result
See crbug.com/331534 for details.

> cc: Simplify raster task completion notification logic
>
> Previously the pixel buffer raster worker pool used a combination of
> polling and explicit notifications from the raster worker pool to decide
> when to tell the client about the completion of 1) all tasks or 2) the
> subset of tasks required for activation. This patch simplifies the logic
> by only triggering the notification based on the OnRasterTasksFinished
> and OnRasterTasksRequiredForActivationFinished calls from the worker
> pool.
>
> BUG=307841
>
> Review URL: https://codereview.chromium.org/99873007

R=reveman@chromium.org,skyostil@chromium.org
BUG=331534

Review URL: https://codereview.chromium.org/126143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243545 0039d316-1c4b-4281-b951-d872f2087c98

This one got left out of the mass icon switch.

BUG=323658

Review URL: https://codereview.chromium.org/125853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243544 0039d316-1c4b-4281-b951-d872f2087c98

Needed for theme and many extension startup tests.

* Add benchmarks/startup_with_extensions.py - new theme and many_profile startup tests.
* Teach test.py to use .sha1 files for profile directories, these are downloaded from cloud storage, unzipped and then used as the profile directory by the browser.
* Add a function to browser_finder to allow querying the target OS.

BUG=None

Review URL: https://codereview.chromium.org/124733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243543 0039d316-1c4b-4281-b951-d872f2087c98

Rebooting s3 devices causes device to be flaky during the deploy step. This is
likely because WaitForPackageManager() does not wait long enough on the s3
devices. I've verified locally on the bot that without the reboot in the
provision step, the devices are more reliable (i.e. deploy step passes).

BUG=321063
TBR=frankf@chromium.org

Review URL: https://codereview.chromium.org/122313008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243542 0039d316-1c4b-4281-b951-d872f2087c98

Also, re-arrange a bit of code in the implementation file for slightly clearer
structuring.

BUG=none
TEST=none
R=estade@chromium.org
TBR=joi@chromium.org,zea@chromium.org

Review URL: https://codereview.chromium.org/122313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243541 0039d316-1c4b-4281-b951-d872f2087c98

Adding parameters to Cast Streaming Extensions API to configure
AES encryption key and IV mask to CastSender.

BUG=315931

Review URL: https://codereview.chromium.org/121543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243540 0039d316-1c4b-4281-b951-d872f2087c98

Keep resource ID of these entries empty.
Remove IsSpecialResourceID().

BUG=324717
TEST=unit_tests

Review URL: https://codereview.chromium.org/118953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243539 0039d316-1c4b-4281-b951-d872f2087c98

When opened selected a USB volume in Files app, and crashed, the Files app is tried to be restored with the previous path. However, the volume may not yet be available. In such case, parent is considered. However, parent is /removable, which resolving causes an error, resulting in throwing an exception and going into a wrong state.

In such situation, we should fallback, and this is what this patch does. If the parent is not resolvable, then the fallback is used as the next current directory instead.

Moreover, after recent refactoring a regression has been introduced. When resolving a parent of the initial directory fails, then a wrong variable name was used, what caused a JS error.

TEST=Tested manually on Pixel.
BUG=331587

Review URL: https://codereview.chromium.org/124933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243538 0039d316-1c4b-4281-b951-d872f2087c98

First, turning on JS, which is disabled by default.

Also, no one guarantees that onload + writeln + onPageFinished must work as
you'd expect, so there is no point in testing this scenario. So just change this
test to verify that the title updated via JS is reported by GetTitle.

BUG=151012

Review URL: https://codereview.chromium.org/117993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243537 0039d316-1c4b-4281-b951-d872f2087c98

This avoids showing a double title bar on browser windows without a tab
strip, such as popups, Developer Tools and V1 app windows.

BUG=330090
TEST=On Unity, maximize Developer Tools window. There should be only the
Unity title and caption buttons, no blue custom title bar.

Review URL: https://codereview.chromium.org/117233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243536 0039d316-1c4b-4281-b951-d872f2087c98

No functional changes.

BUG=309578

Review URL: https://codereview.chromium.org/115013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243535 0039d316-1c4b-4281-b951-d872f2087c98

This CL addresses the remaining comments at http://crrev.com/121183002 .

TEST=none

Review URL: https://codereview.chromium.org/114033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243534 0039d316-1c4b-4281-b951-d872f2087c98

Page.disable clears all scripts to evaluate on commit. There is no way
to detect client side redirects because linkedin, for example, performs
its client side redirect after the page has fully loaded.

In order for the page_cyclers to work on pages with client side
redirects, the script to evaluate on commit must execute on the
redirected page.

So to workaround this, we avoid ever calling Page.disable. we don't
expect continuing to listen for notifications here to impact
performance, but if we do see any performance reduction on the bots we
should revert and search for another approach.

This is a reland of https://codereview.chromium.org/103373003 fixing failures
on the bots.

BUG=253604
R=pdr@chromium.org
TEST=tools/perf/run_measurement --browser=canary page_cycler tools/perf/page_sets/top_10_mobile.json --pageset-repeat=2

Review URL: https://codereview.chromium.org/112413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243533 0039d316-1c4b-4281-b951-d872f2087c98

This adds a DiscardableMemoryType enum and a function that
can be used to select what type of discardable memory to
use. This is generally useful for debugging purposes and
when evaluating the performance of one implementation vs
another.

The unit test framework for discardable memory is improved
slightly by testing every supported type on each platform
rather then just the one specific type.

Furthermore, it allows us to expose ashmem based
discardable memory on ChromeOS in about:flags before we
make it default.

No change in behavior unless the new
--use-discardable-memory=type switch is used.

BUG=327516
TEST=base_unitttest --gtest_filter=DiscardableMemory*
TBR=tomhudson@google.com

Review URL: https://codereview.chromium.org/114923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243532 0039d316-1c4b-4281-b951-d872f2087c98

To fix use-after-free

BUG=331822
TEST=See no crash after following the repro steps described in the BUG.

Review URL: https://codereview.chromium.org/127613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243531 0039d316-1c4b-4281-b951-d872f2087c98

Implements ash::internal::LogoutConfirmationDialogView which is supposed
to be used by ash::internal::LogoutButtonTray.

BUG=223846
TEST=new unit test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242286

Review URL: https://codereview.chromium.org/40053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243530 0039d316-1c4b-4281-b951-d872f2087c98