GitLab

This converts the V1 unit test, checking pasteboard access in sandboxed
processes, to the V2 sandbox.

Bug: 902597
Change-Id: Id11e2c597a55f9e66f45d1edf6b7c7bcb8396f57
Reviewed-on: https://chromium-review.googlesource.com/c/1327545
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611202}

Update BaseSetOperators::insert() (and the related method
APIpermissionSet::insert()) accept a unique_ptr as a parameter rather
than a raw pointer. This makes it significantly more clear that
ownership is taken as a result of the method call.

Update all call sites appropriately.

Bug: 907661
Change-Id: I08568711a01d7a371343dc9137aefedf86d43c7a
Reviewed-on: https://chromium-review.googlesource.com/c/1347621
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611201}

Change-Id: Ic9bbedc769612b720ea6667a3736a29bc8b0c7c7
Reviewed-on: https://chromium-review.googlesource.com/c/1345412Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611200}

Bug: 842548
Change-Id: I42a81f539d57ec244f2583bbc8bda9126b11256e
Reviewed-on: https://chromium-review.googlesource.com/c/1351197
Commit-Queue: Shu Chen <shuchen@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611199}

This CL removes macro usage from /ios/chrome/browser/passwords.

This CL was uploaded by git cl split.

R=vabr@chromium.org

Bug: 589840
Change-Id: I4269a5dcd85ae4e00d275c30fd40b622cc03a1ba
Reviewed-on: https://chromium-review.googlesource.com/c/1351951Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611198}

Somehow Animatable2.AnimationCallback#onAnimationEnd is being called on
a background thread.  This then tries to hit the compat version of
LazyInstanceCompat#AutoRestartCompat to reduce code duplication and
restart the animation.  In this case we're building the
AutoRestartCompat here, which has a local Handler variable that gets
created.  This causes a crash because Looper#prepare() wasn't called for
this thread.

I'm not quite sure why this is being called on the background, but we
definitely should be creating the Handler for the main looper.  Fixing
that here.

Adding NOTRY due to mac_chromium_rel_ng failure which is delaying this Android/Java only patch that needs to land for 71.  All other try bots are passing without issue.

BUG=905256
NOTRY=true

Change-Id: I523dc9a2cb06a0d26d1acdba3106c93aa272cfd3
Reviewed-on: https://chromium-review.googlesource.com/c/1351894
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611197}

Boolean histograms that capture the success rate for Smart Lock
unlock during authentication and connection phase, and enum
histograms that breaks down the failure reasons when Smart Lock
fails to unlock during authentication and connection phase.

Bug: 905438
Change-Id: I4aa35101949931bdd859f886d31e3a78c1412814
Reviewed-on: https://chromium-review.googlesource.com/c/1334227
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611196}

Bug: 906483
Change-Id: I3da2cd45f2ab6e2d88e42c97f0de48208f210ad6
Reviewed-on: https://chromium-review.googlesource.com/c/1350966Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611195}

https://chromium.googlesource.com/infra/luci/client-py.git/+log/b6e9e23e4e79..157bec8a25cc

$ git log b6e9e23e4..157bec8a2 --date=short --no-merges --format='%ad %ae %s'
2018-11-26 bradhall Make sure to setup_googletest on all slices
2018-11-26 maruel [client] Add warning about variable flags
2018-11-21 maruel [client] Stop leaking dir 'cache' when running isolateserver_test.py
2018-11-20 maruel [client] internal refactoring adding ServerRef

Created with:
  roll-dep src/tools/swarming_client

R=bradhall@google.com

Bug: 871453, 908551
Change-Id: Ia0d51cc0584d6df90b71722fbbc9a17bbbceb563
Reviewed-on: https://chromium-review.googlesource.com/c/1351743Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611194}

This fixes potential race conditions in AudioServiceListener resulting
from the fact that a service instance can become unreachable (and may
therefore be replaced with a new one) before it is officially designated
as "stopped" by the Service Manager, even in the case of singleton
services.

The ServiceManagerListener API is augmented to convey a service
instance's current running state via RunningServiceInfo. This is used
by AudioServiceListener to more accurately track the running audio
service instance.

The listener now tracks the Identity of the most recently created
audio service instance and responds to events accordingly.

This also updates the logic and comments in resource_coordinator's
ProcessMap to accurately reflect current guarantees of the
ServiceManagerListener API, since these have changed slightly.

NOTRY=true

Bug: 818593,907898,908319
Change-Id: If3e8a35aa90db72a34c8f5f2d458f0f24c3447eb
Reviewed-on: https://chromium-review.googlesource.com/c/1350649
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611193}

I manually changed only following files:

 - external/wpt/referrer-policy/generic/common.js
 - external/wpt/referrer-policy/generic/referrer-policy-test-case.js
 - external/wpt/referrer-policy/generic/subresource/shared-worker.py
 - external/wpt/referrer-policy/generic/template/shared-worker.js.template
 - external/wpt/referrer-policy/spec.src.json
 - TestExpectations

Others were auto-generated.

Bug: 835717, 906959
Change-Id: Ib0a84710fe94ba0893d9609bb708a3f5e8fd4091
Reviewed-on: https://chromium-review.googlesource.com/c/1343582
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611192}

This reverts commit 336bb21b.

Reason for revert: From the comment on the bug, these failures were a red herring and the underlying issue was an auth one.  If you have explicit failure logs that were these tests failing then please add them to the bug.

Original change's description:
> Sheriff: mark a few omnibox.UrlBarTest as flaky as the test suite flakes a lot.
> 
> Bug: 908542
> Change-Id: Ibf9b8f2ac2c5bcdd14dcf65483d576fe61a3bf8d
> TBR: tedchoc@chromium.org
> Reviewed-on: https://chromium-review.googlesource.com/c/1351428
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610958}

TBR=mlamouri@chromium.org,tedchoc@chromium.org

Change-Id: I9df39181033b11a2ac8e3b0e8e395bdb0a626e1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908542
Reviewed-on: https://chromium-review.googlesource.com/c/1352336Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611191}

As explained in crbug.com/908121, we can't fix SigninManager::Initialize() to
require a non-null local_state just yet as that would require manually fixing
thousands of tests, so we're adding this transitional function to unblock work
on crbug.com/906085 allowing to migrate from SigninManager::IsAllowedUsername
right away without depending on those other changes.

So, this patch implements a new helper function that will behave more similar
to SigninManager::IsAllowedUsername on that it will only check the username
against the specified pattern if (1) there's a non-null local state passed
and (2) the pattern is registered and a value for it has been set, returning
true otherwise.

We also include an unit test for this helper function, to help with future
refactorings if they happen.

Bug: 906085
Change-Id: Idef663d07354fb086a5bc00b1ab447f1811c344d
Reviewed-on: https://chromium-review.googlesource.com/c/1350895
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611190}

Currently there is only one non-standardized statistics "jitterBufferFlushes which will be exposed under the following origin trial:
https://docs.google.com/document/d/1stYIZhEmDZ7NJF9gjjsM66eLFJUdc-14a3QutrFbIwI/edit?ts=5bf5535c#

However, note that any other non-standardized statistics added later would be also exposed under this origin trial.

Bug: chromium:907113
Change-Id: I4036dd1fceae3b68d33f9ae2666a0e2d942fb345
Reviewed-on: https://chromium-review.googlesource.com/c/1344433
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611189}

Because provider hosts can be for workers as well as documents.

Also rename UpdateURLs to UpdateUrls for typing ease and alignment
with the style guide (acronyms are treated as a normal word).

Bug: 908311
Change-Id: Ie4c7edaed41f8d89315a2ae4514880e8b3fdd2b0
TBR: kinuko
Reviewed-on: https://chromium-review.googlesource.com/c/1350422
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611188}

- Implements crashpad support for GCPW installer
- Implements crashpad support for the actual credential provider dll
and runs the crashpad handler directly in the dll as an entry point

Bug: 890348
Change-Id: I5b256b4d6ad8ee7153fd22e4d13f1a1791fa6d65
Reviewed-on: https://chromium-review.googlesource.com/c/1344210
Commit-Queue: Tien Mai <tienmai@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611187}

API was using 64 bit integers which caused narrowing to access the arrays.
Adjust the paint chunk API to use the correct type.

BUG=879657

Change-Id: Ibbe16bd43937788fe3a706773826570e0626eb80
Reviewed-on: https://chromium-review.googlesource.com/c/1348989Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611186}

This is a small cleanup of the TraceEvent class performed
which is part of a larget bug allowing cleaning up and
reducing the generated machine code for TRACE_EVENTXXX()
macro calls (see related bug).

A first CL to perform this refactor was submitted as [1], but
later reverted because it made some tests fail mysteriously
(see http://crbug.com/899813). So the original CL was split into
several independent ones.

A first CL was submitted as [2], which actually fixed some
potential dangling pointer issues that were created from the
Initialize() and MoveFrom() methods.

This second CL removes this methods by making TraceEvent a
proper C++11 movable type, which should prevent (or at least
make it more difficult) introducing invalid states for its
instances. The goal is to see if this introduces new unexpected
test failures (which would indicate that there are still invalid
instance states used in the code base).

The third CL is [3] and re-introduces the TraceArguments helper
class on top of this one.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1318919
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1340308
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1318919

BUG=898794
R=primiano@chromium.org,oysteine@chromium.org,alexilin@chromium.org,chiniforooshan@chromium.org

Change-Id: I2b36885e2485d23cca199c48b2bd07d5745b00c5
Reviewed-on: https://chromium-review.googlesource.com/c/1346305
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611185}

https://webrtc.googlesource.com/src.git/+log/f1c194decd51..6b3d18164b4a


git log f1c194decd51..6b3d18164b4a --date=short --no-merges --format='%ad %ae %s'
2018-11-27 terelius@webrtc.org Remove unused BWE field trial strings.
2018-11-27 kron@webrtc.org Add setters to ColorSpace class
2018-11-27 crodbro@webrtc.org Specific pacing configuration.
2018-11-27 ilnik@webrtc.org Various VP9 high fps fixes
2018-11-27 danilchap@webrtc.org Populate VideoSendTime extension network2 field when configured
2018-11-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 208bb982..81c26a09 (610939:611047)
2018-11-27 mbonadei@webrtc.org Fix wrong forward declaration namespace.
2018-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 00f78b5b..208bb982 (610831:610939)
2018-11-26 michel.promonet.1@gmail.com add cstring include need for strncmp
2018-11-26 steveanton@webrtc.org Small cleanup to mediasession_unittest.cc
2018-11-26 ouj@fb.com Rebase std::is_trivially_* with absl::is_trivially_*
2018-11-26 jonasolsson@webrtc.org Bump variable sizes in response to fuzzer bug
2018-11-26 saza@webrtc.org Add AudioProcessingCaptureStats and a level estimator replacement
2018-11-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7579fcbc..00f78b5b (610728:610831)
2018-11-26 nisse@webrtc.org Delete ChannelSend::RegisterTransport, replacing by construction argument
2018-11-26 phoglund@webrtc.org Add magjed as owner of rtc_tools.
2018-11-26 danilchap@webrtc.org In ReceiveStatistics use monotonic clock instead of ntp clock
2018-11-26 robin@opticaltone.com Add a new Task Queue for WinUWP.
2018-11-26 saza@webrtc.org Delete the WebRTC.Call.TimeSendingAudioRtpPacketsInSeconds metric
2018-11-26 danilchap@webrtc.org In ReceiveStatistic require callbacks during construction
2018-11-26 emircan@webrtc.org Reland Profile 2 to default profiles


Created with:
  gclient setdep -r src/third_party/webrtc@6b3d18164b4a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:904909,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1848d2b4a6fc7fd65655128454244ec7f0916727
Reviewed-on: https://chromium-review.googlesource.com/c/1352235Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611184}

These are about to expire, and we will probably want to collect data for
a little longer.

Bug: 904568
Change-Id: I9ebe814cd5ebe5de3dec10eca3efedb2c7bb94bb
Reviewed-on: https://chromium-review.googlesource.com/c/1351586Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611183}

Bug: 903972
Change-Id: Ib70702de4cda80970454fd5d8c296855673698cb
Reviewed-on: https://chromium-review.googlesource.com/c/1347145Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611182}

Reporting has been enabled at 100% server-side for ages. This flips the
client default so we can avoid sending the experiment state.

Change-Id: I2c88ce73fbf23c83e4572d9db3c72bbda28a8243
Reviewed-on: https://chromium-review.googlesource.com/c/1351379Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611181}

- Work around pushState changes that overwrite the navigation item
title on pushState.  The root cause of the bug is crbug.com/908173.

- Correctly set navigation item titles on restore.

Bug: 854174, 872211
Change-Id: Ife407429d7f2723fc9dac6458bf81bdb1ae64ff8
Reviewed-on: https://chromium-review.googlesource.com/c/1349776
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611180}

Change-Id: I58a6a878b511e9ab2c27088ffc0c8069cf39b473
Reviewed-on: https://chromium-review.googlesource.com/c/1347311Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611179}

Enable re-use of these helpers across different test suites, by putting
them in their own header & cc.

Bug: 893229
Change-Id: I1d239baf708226d08a25a0aa741e8c5f6d0cf1a8
Reviewed-on: https://chromium-review.googlesource.com/c/1334559
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611178}

This CL fixes a condition that triggers clearing the primary account
when the SigninManager initializes if there is no primary account set.

Bug: 907114
Change-Id: I0f6c515b53cad2e6c12804469fd5b952bd05ca68
Reviewed-on: https://chromium-review.googlesource.com/c/1345079Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611177}

Based on java@ discussion:
https://groups.google.com/a/chromium.org/d/topic/java/9WZLCc14oss/discussion

Bug: 149440
Change-Id: Ie36166fe2282af564daafb13fbcb91af1a4ab6c1
Reviewed-on: https://chromium-review.googlesource.com/c/1344889Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611176}

All methods that have a parameter with the FlexibleArrayBufferView
extended attribute support AllowShared. In other words, it is possible
to use them with an ArrayBufferView backed by an ArrayBuffer or a
SharedArrayBuffer. This CL makes this an explicit requirement in the IDL
file.

Currently only WebGL APIs use the FlexibleArrayBufferView extended
attribute.

Bug: chromium:905449
Change-Id: I52f23d4ee07c169a525243f00dd8a96a58ce7075
Reviewed-on: https://chromium-review.googlesource.com/c/1345125
Commit-Queue: Ben Smith <binji@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611175}

This change implements the processing model from PR 168[1], when
it comes to setResourceTimingBufferSize(), clearResourceTimings()
and the firing of the resourcetimingbufferfull event.

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/1345269
(but with nicer tests).

[1] https://github.com/w3c/resource-timing/pull/168

Change-Id: I10431bfda7f79b484c7ee5c608bb8a360d905339
Bug: 908181, 908414
Reviewed-on: https://chromium-review.googlesource.com/c/1350950Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611174}

On release builds, GCC complains that |slot_size| is set but never used, and
rightfully so. Move the code setting |slot_size| and |raw_size| within the
DCHECK_IS_ON() block, which is the only part that actually uses it.

Change-Id: Icfa5b7814685ebc6d66e42e27cc8e01f0878cdd8
Reviewed-on: https://chromium-review.googlesource.com/c/1352178Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#611173}

Without this patch, the browser was never available when talkback was
on, because the web view detected the presence of the overlay and
assumed that the page was not available.

With this patch, the overlay is fully disabled when talkback is
activated if either:
- partial overlay is on (there is a touchable area, a portion of the
  page is available)
- the full overlay is off (the full page is available)
In these two cases, the page can be accessed via talkback.

Limitations:
- Controls are not available to talkback when full overlay is on.
- There is no filtering of the elements available to talkback when
partial overlay is on yet.

Bug: 806868
Change-Id: I77f88c8b4ba784a02306f14adf7e68d776e789ef
Reviewed-on: https://chromium-review.googlesource.com/c/1352171Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611172}

Also adds AutofillManualFallbackPhaseTwo to test bots.

Bug: 845472
Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
Reviewed-on: https://chromium-review.googlesource.com/c/1337347Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611171}

ViewHostMsg_DidCommitAndDrawCompositorFrame and
ViewHostMsg_DidFirstVisuallyNonEmptyPaint don't seem
to be used anywhere ... removing them.

Likely these got orphaned by
https://chromium-review.googlesource.com/c/chromium/src/+/1278285 .

Bug: none
Change-Id: Id58e93c97ca66761238a874afcac3e04c6df09b8
Reviewed-on: https://chromium-review.googlesource.com/c/1351576
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611170}

This CL removes macro usage from /ios/chrome/browser/voice.

This CL was uploaded by git cl split.

R=kkhorimoto@chromium.org

Bug: 589840
Change-Id: I23e975d07b48897c6c10949a9fde8f9053356f87
Reviewed-on: https://chromium-review.googlesource.com/c/1351077Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611169}

This CL removes macro usage from /ios/chrome/browser/store_kit.

This CL was uploaded by git cl split.

R=pkl@chromium.org

Bug: 589840
Change-Id: I3eb75e5a3316c7da05abab6e99b3a727c4f92ce4
Reviewed-on: https://chromium-review.googlesource.com/c/1351958Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611168}

The test was enabled here:
https://chromium-review.googlesource.com/c/chromium/src/+/1258249/

The test deterministically fails when run by itself. This failure is
reproducible on both trybots and a local device.

This CL reverts the change made by the CL mentioned above. It intentionally sets
a super broad set of TestExpectations as I have not investigated the behavior of
the test on platforms other than Windows. The test was observed to be flaky on
Linux -- this CL removes that TestExpectation. The test was observed by Find-It
to be flaky on macOS. See
https://bugs.chromium.org/p/chromium/issues/detail?id=908517#c3.

Bug: 908517, 789139
Change-Id: Idfa9603b093c9abc4c337c33a4a3e061482d9dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1351491Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611167}

When the GPU process restarts we need to re-send the cursor bitmap since
all GPU process display state is lost.

It looks like it may have been broken all the way back to d818104f
("[Ozone-Drm] Notify cursor of channel established last"), which fixed a
different issue but also caused the message that was intended to restore
the cursor (in CommitBoundsChange) to not get delivered.

Bug: 908682
Test: kill $(pgrep -f type=gpu-process), cursor restored

Change-Id: Ibacab25807995d9402c46f88a7d51b68fe8dfbfc
Reviewed-on: https://chromium-review.googlesource.com/c/1351903Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611166}

https://skia.googlesource.com/skia.git/+log/98cb15912130..4f83c59eea19


git log 98cb15912130..4f83c59eea19 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5552cdf032dd..471b8d4c7383 (1 commits)
2018-11-27 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
2018-11-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
2018-11-27 reed@google.com migrate to passing paint/ctm for bounds
2018-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 573f76b3eebf..5552cdf032dd (7 commits)
2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-26 bungeman@google.com Use width instead of weight for width on mac.
2018-11-26 csmartdalton@google.com Fix AA outset in GrAAFillRRectOp lower left corner
2018-11-26 halcanary@google.com tests: do not crash with missing resources.
2018-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d689d1c05272..4ad2322aa9cf (1 commits)
2018-11-26 brianosman@google.com Add tiled rendering option to viewer
2018-11-26 bsalomon@google.com Remove SkCanvas::experimental_drawImageSetV0
2018-11-26 csmartdalton@google.com Disable instanced rendering on Skylake
2018-11-26 jvanverth@google.com Reland Reland "Remove use of integers for atlas indexing"
2018-11-26 brianosman@google.com Remove xform canvas mode from Viewer, simplify color management
2018-11-26 kjlubick@google.com Fix multiplication of maxIterations in PolyUtils
2018-11-26 scroggo@google.com Update libwebp to v1.0.1
2018-11-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-26 rmistry@google.com Make lunch/mmma targets configurable and add new Android compile bot


Created with:
  gclient setdep -r src/third_party/skia@4f83c59eea19

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: I8c7d4833f4c7fad3672dac38b947c39d139476e8
Reviewed-on: https://chromium-review.googlesource.com/c/1352232Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611165}

Address the edge case where when a CL no longer has exportable changes, the PR should
be closed and the branch should be deleted.


Bug: 852014, 750942
Change-Id: I86adf85a3dcec7a9fac088fa42e2e357bbf1285a
Reviewed-on: https://chromium-review.googlesource.com/c/1349471
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611164}

Bug: 901864
Change-Id: I5d86a6017d4d3fd45169af7daf58899158d7a1a7
Reviewed-on: https://chromium-review.googlesource.com/c/1351384
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611163}