- 27 Nov, 2019 26 commits
-
-
Caleb Rouleau authored
This will allow us to switch over the chromium_perf.py recipe to add :telemetry_weblayer_apks as a compile target so that we can change what telemetry_weblayer_apks contains without needing to edit the recipe each time. Recipe change is here https://chromium-review.googlesource.com/c/chromium/tools/build/+/1938127 Bug: 1028125 Change-Id: I016b126f3f5bd6d3d42f06738cdad4868da2a3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938069 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719448}
-
Nicholas Verne authored
This disabmiguates the case where a component load fails due to no internet, versus a component load being blocked behind a continuing update. Bug: 1010796 Change-Id: I9cf6956a86f5f342f7b1bea61666575212e65712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930279 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#719447}
-
Maksim Ivanov authored
As per the updated UX feedback, we're bringing the letters ("ABC", "DEF", etc.) in the SAML smart card PIN dialog back. The makes the UI uniform with the other contexts where the PIN keyboard is used, and also automatically resolves the issue with the vertical alignment of buttons in the SAML smart card dialog keypad. Before this CL, the letters were intentionally hidden (by not specifying the "enable-letters" attribute of <pin-keyboard>), which was conforming to the original UX design. Bug: 1024251 Change-Id: I12b450fd57b94f68da958b6606d9b4c85c90989e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932666Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#719446}
-
Jun Mukai authored
This is to address comments in crrev.com/c/1896385. Bug: 1019000 Test: none Change-Id: Ie106c0c03908638d95bf94f1c7b3409fefd3f69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919783 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO - back on Dec 2nd) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#719445}
-
Ayu Ishii authored
Bug: 1007734 Change-Id: Iebe785c8d0cb8e694d41beb5648920434aee95ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937358Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#719444}
-
Wez authored
Rules are temporarily provided under the processed names, to allow deps to be migrated gradually. Bug: fuchsia:42135 Change-Id: I774cd6de87fcc2a01536e09af288cfb3e859399b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937847 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719443}
-
Kelvin Jiang authored
Bug: 983761 Change-Id: Ic3dd22708d8d20ce2a1cb9a1228835a81681f2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935718 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719442}
-
Ayu Ishii authored
Bug: 1007723 Change-Id: I833820b7f1175799464efb63684d680c7825ff95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937573Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#719441}
-
khmel@chromium.org authored
This handles the case when in case new account on device and first login, tracing start notification is delivered with delay ~2+ seconds. That makes it possible that tracing could be stopped before tracing start notification is delivered. TEST=Locally, no crash reproduced. BUG=b:143532713 Change-Id: I9129f6b9df44d33aa1e5d7bdaf86ceac2e318e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937706Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719440}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5604ce9f20cd..5e94b80c348b git log 5604ce9f20cd..5e94b80c348b --date=short --first-parent --format='%ad %ae %s' 2019-11-26 ehmaldonado@google.com git-hyper-blame: Fix unicode handling. Created with: gclient setdep -r src/third_party/depot_tools@5e94b80c348b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028709 Tbr: agable@chromium.org Change-Id: Ic8d713e04101b3699125038aa6076484a4a401ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937701Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719439}
-
Kunihiko Sakamoto authored
crrev.com/c/1903166 introduced a new testing API for data_decoder_service which allows tests to inject WebBundleParserFactory for testing. This patch migrates existing unit tests to use it, and removes SetWebBundleParserFactoryForTesting() from WebBundleReader and SafeWebBundleParser. Bug: 969596 Change-Id: I3e0da13a2202c25c177a24a16c2208fff27683b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935778Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#719438}
-
Xiaohui Chen authored
Test: unittests and local test Bug: b:139438276 Change-Id: Ia17fe0126a7f400553e0954ffc471629b4884fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935153 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719437}
-
nancy authored
AppService has been enabled for a few releases and a few months, and it will be enabled as default. So we don't need a function just 'return true' to reduce the function call for the chromebook start up process. BUG=1016159 Change-Id: I9aa30926267ae146802283fd9a2390a7724c407f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933669Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#719436}
-
Esmael El-Moslimany authored
Change-Id: I0f745eed2a39b74b5925a97e00891d148f8321bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935930Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#719435}
-
Avery Musbach authored
Bug: 1024309, 1024325 Change-Id: Idbbdcd0d6c79ce2feb3a6ed58a2436896d413840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931542Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#719434}
-
Elly Fong-Jones authored
This particular notion of overscroll only applies to Aura platforms anyway, so the test fails on Mac. Bug: 1028239 Change-Id: I96a1b0b0591da81deac5e1e7441e86fdc04946e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937467 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719433}
-
Chromium WPT Sync authored
Using wpt-import in Chromium de5ca861. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache." 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I0ddb6e56e9c2e2348713ecd89f886ce2a52ccdc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937252Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719432}
-
Archana Simha authored
Users in the experiment will be shown the extensions page alongside the NTP upon startup once. Design Doc: go/extensionscheckup Bug: 1019296 Change-Id: Ia9fd02ece790643b320ee3f68d7544349967f6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864828 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719431}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f2f095be2853..1ef02beb6e51 git log f2f095be2853..1ef02beb6e51 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 bsheedy@chromium.org Add CollectDebugData to FakeBrowser Created with: gclient setdep -r src/third_party/catapult@1ef02beb6e51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1025034 Tbr: skyostil@google.com Change-Id: I083bf23ababaad8ae19f2079fe64205076a34b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719430}
-
Nate Fischer authored
This moves the package name sampling result into a boolean member variable (which slightly improves performance, and is more consistent with is_in_sample_), and rephrases a comment. This fixes some tests to mock the IsInPackageNameSample() value prior to MaybeStartMetrics, rather than after, since the value is cached during that method. This is a follow up to feedback on https://crrev.com/c/1898711. Test: run_android_webview_unittests --gtest_filter=AwMetricsServiceClientTest.* Change-Id: I824540aa7362ab34f9cb4981b88cc446338bdff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937704Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719429}
-
Daniel Murphy authored
R=enne@chromium.org Bug: 1024966 Change-Id: I88d3d38ff608277ec64c2c134affd3d4704ea9e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925225 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#719428}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4df91c4a821..0f6ef7e793d5 Created with: gclient setdep -r src-internal@0f6ef7e793d5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Ib74354d7a0f6a3b78e6d1e86b1c66c8a5588c7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937688Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719427}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1a596b35f973..09fcacb87950 git log 1a596b35f973..09fcacb87950 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 chshrest@microsoft.com DevTools [Element]: Fix tab order of color format switcher in color-picker Created with: gclient setdep -r src/third_party/devtools-frontend/src@09fcacb87950 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic993aaa373e28f3c28b7e4895e16f317a1316f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937694Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719426}
-
Wez authored
Migrate all FIDL library target dependencies from their short names to fully-qualified ones, e.g fuchsia.mem was: //third_party/fuchsia-sdk/sdk:mem and is now //third_party/fuchsia-sdk/sdk:fuchsia-mem TBR=sky,dcheng,dalecurtis,agl,sergeyu,tsepez,yucliu Bug: fuchsia:42135 Change-Id: I3e4632fef22887f9f68ddd2b9d3e34dbb9bc7eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937578Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719425}
-
Oystein Eftevaag authored
The PickleWriter version is not needed outside of tests now, and generates conflicts when the TraceLog is first enabled by ETW (or etrace), which means 1) Initially, tracing client code which creates TracedValues, will get a PickleWriter. 2) After tracing is started normally, the tracing service client library installs the hooks into //base which causes ProtoWriters to be created instead. 3) Trace events which try to merge TracedValues, might then get into the unsupported scenario of trying to add a PickleWriter (created before pt 2) as a child of a ProtoWriter (created after pt 2). As part of this, changed a couple of callsites in cc/ which uses TracedValues purely for ToString() debugging and need to be able to generate JSON still. Change-Id: I0dbd145450fc34584d2034638931c424500863d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888271Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#719424}
-
Daniel Murphy authored
This change is the first one in a series to start removing blob-specific code from the IndexedDBBackingStore class into its own file. This will eventually hold the blob storage integration separately with its own tests, etc. Work planning doc: https://docs.google.com/document/d/18suNOOzuEJbqgRJF0MB2VqdTyYqS4cvI2PGaCpyPXSw/edit?pli=1#heading=h.ilyrswbua4hv Bug: 1024966 Change-Id: I3a468f79720344437973b175b098ad60389079fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918199Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#719423}
-
- 26 Nov, 2019 14 commits
-
-
Dan Harrington authored
Moves the source code. Updates imports. Feed tests remain under third_party for now, as they do not yet run or meet the style guide. ActionTypeConverter was renamed ActionTypesConverter to avoid being flagged as a TypeConverter which requires security review. Bug: 1024945 Change-Id: I34a2e9057d43e6542d35438b321aeb66cf1fa55b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928303 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719422}
-
Matthew Denton authored
To support glibc 2.30, allow clock_nanosleep in the baseline BPF policy, with the same clock_id restrictions as clock_gettime and other clock_* syscalls. Bug: 1025739 Change-Id: Ic53a782fef01049bc61c535b50735a4a7d4c23c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935715 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719421}
-
Yun Liu authored
Original configs seem causing some suite failed, e.g.: weblayer_instrumentation_test_apk Bug: 1027689 Change-Id: I8b08c87fd22081906ce0333a5cbdaf62a08fba7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937567 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719420}
-
Malay Keshav authored
This patch changes the float precision from 'mediump' to 'highp'. This is needed for android. Bug: 1009322 Test: Manually tested various websites that were reported on the bug Change-Id: I87b57d57c43093b590741393dfef3c75c151c1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913708 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#719419}
-
Sarthak Shah authored
This CL will enable Chromium on Windows to have a touch fling inertia that behaves more like Edge and other native applications. This CL is third phase in the series of CL's for new fling animation curve. Phase 1: https://crrev.com/c/chromium/src/+/1884752 Phase 2: https://crrev.com/c/chromium/src/+/1884758 Note that this implementation does not tune the curve depending on the scroller’s size for non-root scrollers, something that may be desired. User feedback will be used to determine the importance of bringing that behavior to Chromium. Bug: 647137 Change-Id: Ie893a5b8309ffb0c68c2f638651433402cd4f316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906299 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719418}
-
Sergey Ulanov authored
Previously FilteredServiceDirectory was taking service names as char* and then retaining that pointer to use it later. This didn't work correctly when AddService() was called with name that's not stored in a static buffer. Updated it to take StringPiece and then copy it to std::string internally. Change-Id: I382e3929eabb9806f4a74664ed355da886dcc61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935723Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719417}
-
siyua authored
Adding a separate file for some the util functions in credit_card.h. These functions will be shared with the newly added CreditCardCloudTokenData file in CL crrev.com/c/1897317. Split this refactoring into a single CL as suggested. TBR=rouslan@chromium.org,edchin@chromium.org for a simple name change. Bug: 1020740 Change-Id: I4a046eb1294e8ee07b96ca07584e4e5c1f6598aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928011 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#719416}
-
Johannes Henkel authored
Looks like it's not used. Also fix typo (protocl) and simplify dispatcher_ field. Change-Id: I7e61571eecb56f3a89c0636b7ea44e8afcc9187a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937769Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#719415}
-
Owen Min authored
Bug: 1028778 Tbr: lazyboy@chromium.org Change-Id: I992baf4cac7f05577ab3fea86b0d78aa3670f67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937777Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719414}
-
Ben Wagner authored
Support for variable fonts on macOS earlier than 10.12 was incomplete. CGFonts supported variations fairly well by themselves, but hid the tag name of the axes. CTFonts only supported named variations of system fonts (which meant only Skia). It is possible to create a CTFont from a CGFont, but this can into various bugs (because the CTFont didn't really know about the variations in the CGFont). Beginning in 10.12 it is possible to create a CTFont from data and set a variation on it directly, allowing for much simpler code, a path forward for better and faster API, and a possible reduction in font data leaking. The only real observable affect of this change will be that the Skia system font on macOS 10.11 will stop varying. Blink will still use FreeType to render variable webfonts on macOS 10.10 and 10.11. Change-Id: I7c188f4245af1b36c6e258a17935710a1ac02076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937778 Commit-Queue: Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#719413}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/9b73e21c0df8..b8549ed88953 $ git log 9b73e21c0..b8549ed88 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 angiebird Make GetCodingFrameNum const function 2019-11-22 angiebird Add missing includes to simple_encode.h 2019-11-21 angiebird Correct typo in simple_encode.h 2019-11-21 angiebird Cosmetic change of GetBitrateInKbps 2019-11-25 johannkoenig fix __has_attribute in visual studio 2019-11-20 vitalybuka Disable -ftrivial-auto-var-init= for hot code 2019-11-15 vitalybuka Disable -ftrivial-auto-var-init= for hot code 2019-11-20 angiebird Change vp9_get_encoder_config. 2019-11-20 angiebird Add trailing underscore to members of SimpleEncode 2019-11-20 angiebird Rename impl by EncodeImpl (...) 2019-10-25 angiebird Make [min/max]_gf_interval static under rate_ctrl 2019-10-24 angiebird Add rate_ctrl flag 2019-10-29 johannkoenig always use lf for shell scripts 2019-10-29 johannkoenig remove .gitattributes 2019-10-29 johannkoenig remove .gitattributes filters 2019-10-29 johannkoenig support visual studio 2019 (vs16) 2019-10-29 johannkoenig remove old visual studio remnants 2019-10-23 angiebird Add get_arf_layers() 2019-10-23 angiebird Use RANGE in get_gop_coding_frame_num 2019-10-23 angiebird Add get_gf_interval_active_range() Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Bug: 1020220 Change-Id: I1549581f59fef928bf02fca77bcd542eb77475aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937135Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#719412}
-
Noel Gordon authored
CL:1924341 limited the horizontal scroll of the directorytree to 0, to resolve issue 1025581, and needs a test of this behavior. Test: create a nested set of test folders, and use keyboard arrow-left (provided by expandSelectedFolderInTree, note) to navigate to the last of those folders. Post navigation, verify the navigation, and that the directory tree is not horizontally scrolled. This new test passes with CL:1924341, and fails before that CL (good). The CL used requestAnimationFrame (rAF) to limit the scroll. Add async test rAF helper and call it to ensure the scroll rAF is done, and that expandSelectedFolderInTree events have been processed. Test: browser_tests --gtest_filter="*TreeKeyboardHorizontalScroll*" Bug: 1025581 Change-Id: Iff79b963559d282841f1d2045aadcee7e5840cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936579Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719411}
-
Andrei Polushin authored
Currently base::ReplaceChars() accepts std::string for the 3rd parameter, and immediately converts it to base::StringPiece. To avoid string copies on the caller side, it should accept base::StringPiece instead. This change became possible after r504430. BUG=760330 TEST=base_unittests --gtest_filter=StringUtilTest.ReplaceChars Change-Id: I9a3a4cc02cfbfb8c8a258dc077612dd5146b9592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930799 Auto-Submit: Andrei Polushin <anpol@yandex-team.ru> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#719410}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f1fce1f..f1c7d33e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia075ef59363e2e993415199109e0953772976764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937251Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719409}
-