- 23 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3ea49ac23f8..5aa803aa2d84 git log c3ea49ac23f8..5aa803aa2d84 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 vapier@chromium.org portage_util: use encoding=utf-8 for commands 2019-10-23 vapier@chromium.org cleanup: use bytes for pipes 2019-10-23 vapier@chromium.org run_tests: turn on more python3 coverage Created with: gclient setdep -r src/third_party/chromite@5aa803aa2d84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib8ca878174d0244329fbcfc197f6bea1c7f3fffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708523}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/401b25c878da..b1ae481f7fe3 git log 401b25c878da..b1ae481f7fe3 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 ehmaldonado@chromium.org git-cl: Remove hack to ask for random mirrors when querying Gerrit. Created with: gclient setdep -r src/third_party/depot_tools@b1ae481f7fe3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:881860 Change-Id: I0e6d97ef98750a426859872f53e39dc0a8c23fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875370Reviewed-by:
-
Jacobo Aragunde Pérez authored
Convert the implementation and all users of content::mojom::FonctCacheWin. Bug: 955171 Change-Id: I434383bf5ef0b036eaca6e005b5f389348344a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827012Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#708521}
-
Jason Lin authored
Currently, the WebUI installer dialog can be closed directly in the overview mode, and the web page will not notice it. We want to prevent this from happening for a few reasons: * The web page should have an opportunity to clean up before closing (e.g. call cancel()). * In some installation states, we want to keep the dialog open. This CL blocks closing requests to the dialog unless the web page proactively request it. bug: 929571 Test: Enable CrostiniWebUIInstaller flag, try closing installer dialog in different ways Change-Id: I8f5643c42b807d2a3fcebdd5c56e7648a46ab86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872084 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#708520}
-
Hajime Hoshi authored
Mark virtual/disable-deferred-rendering/fast/canvas/OffscreenCanvas-MessageChannel-transfer.html flaky This is flaky on Mac10.10 test bots TBR=kinuko@chromium.org No-Try: true Bug: 971612 Change-Id: Id09c9410405fb73d21ad2a80ce7bb6f1f8d60ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874418 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708519}
-
David Tseng authored
This is part of the effort to fork ChromeVox Classic. ChromeVox Classic has been in deprecated status since early 2017 and effectively deprecated even earlier, but due to the need to continue some support, we have forked the project. ChromeVox Classic was based on the ChromeVox source repo quite some time ago, so the need arises to cherry-pick code from the ChromeVox codebase today (as we cannot simply use it as is). This change pulls in updates from the mainline ChromeVox source for script installation. The eventual plan is to: 1. do an official release of ChromeVox Classic from ui/accessibility/extensions/chromevoxclassic (this has *not* occurred yet) 2. remove all ChromeVox Classic files from ChromeVox (chrome/browser/resources/chromeos/chromevox/) Bug: 1016543 Change-Id: Iedd7cef6a09d733328bb8cf5827c388667eb6540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872300Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#708518}
-
Hiroki Nakagawa authored
ClientImpl is only used from WorkletModuleResponsesMapTest. Originally this was in the anonymous namespace in worklet_module_responses_map_test.cc, but it was moved out because of Jumbo build breakage (see https://crrev.com/c/968363/). Bug: n/a Change-Id: If39397b7320af6228591f61dfad1acb511faf961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874991Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#708517}
-
Xianzhu Wang authored
This forbids production code depending on these targets, and enables these targets to depend on other testonly targets in the future. The only dependency prevented core:testing from being testonly was from BlinkLeakDetector. Add Page::SetInternalSettingsPrepareForLeakDetectionCallback() to reverse the dependency. Change-Id: I64cba73f0c4d1383a192e468220f3d55e926a8f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864720 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708516}
-
Maggie Cai authored
This CL makes the new implementation of intent picker to set and query the preferred apps in App Service Proxy. This will only work for this one subscriber and doesn't not sync anything in the disk or publishers yet. BUG=853604 Change-Id: Iedf1886a162151cc5990aed965849058432875d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866094 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#708515}
-
nancy authored
BUG=1009248 Change-Id: I659067359fbdb5fb430f9dcb60a0dbee1fcf6184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864496 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708514}
-
Ken MacKay authored
Bug: internal b/127963522 Bug: internal b/138938216 Change-Id: Ibb583fe884ca06efd6d04ef130a39dc3f5304746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869563 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#708513}
-
Eric Willigers authored
In guest mode, the off-the-record profile is used to launch apps. This way, we avoid failing a check in Browser's constructor: !profile_->IsGuestSession() || profile_->IsOffTheRecord(). Only off the record browser may be opened in guest mode. Bug: 1016256 Change-Id: I09241ca66b1103a83128426d06cfe6e966dc9470 Fixed: 1016256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874750 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#708512}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/db1e79c1c5de..401b25c878da git log db1e79c1c5de..401b25c878da --date=short --no-merges --format='%ad %ae %s' 2019-10-23 ehmaldonado@google.com presubmit: Convert literals to strings before setting env variables. Created with: gclient setdep -r src/third_party/depot_tools@401b25c878da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I7ebdf8e859fd9cc530e2b678422e72b24583e84c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875189Reviewed-by:
-
Emil A Eklund authored
Change-Id: I57ed457b1077b3a9e9bcb6e0d3b3b7080296d431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874590 Auto-Submit: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#708510}
-
Roman Sorokin authored
Bug: 1001458 Test: tried in oobe and in the session Change-Id: I521f02673e8f8bc5fe2f2be7141d03dbe3063e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866517 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#708509}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b779a7c4e88..b307010280b7 git log 0b779a7c4e88..b307010280b7 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 jie.a.chen@intel.com Add SH_REMOVE_DYNAMIC_INDEXING_OF_SWIZZLED_VECTOR Created with: gclient setdep -r src/third_party/angle@b307010280b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:709351 Change-Id: I8af584a99dc7411203df174a12a99601b6799478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874965Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/29a49c28458d..c3ea49ac23f8 git log 29a49c28458d..c3ea49ac23f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 chrome-bot@chromium.org Update config settings by config-updater. 2019-10-23 saklein@chromium.org sysroot_lib: Remove deprecated PARALLEL_POSTSUBMIT_BINHOST Created with: gclient setdep -r src/third_party/chromite@c3ea49ac23f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3791770ebc0f930081008882d351a4782119eb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874966Reviewed-by:
-
Tsuyoshi Horo authored
Before NavigationLoaderOnUI, SXG related code are executed on IO thread. So we need to use PostTask() to UI thread to get FrameTreeNode. But now they are executed on UI thread. We don't need to use PostTask(). Bug: 824854 Change-Id: I5bff6782ec0ba9bda0d9f930d13f92d009711cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873814Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#708506}
-
Kevin Qin authored
Currently OpenXR tests are flaky because XrInstance is created and destroyed multiple times. There is also a performance issue because every time XrCreateInstance called, it will load dlls. The solution is create a OpenXrStatic class to host the xr instance and static methods. And have one copy of OpenXrStatic in render process another in where static functions getting called. Bug: 1011871 Change-Id: I69843cebaeee9e4b7f30806f431b4ea93182ebca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865727 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#708505}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e13e6ed3dfb..261fc5197ea8 git log 8e13e6ed3dfb..261fc5197ea8 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 83bb172f..c0cca6e4 (708314:708426) Created with: gclient setdep -r src/third_party/webrtc@261fc5197ea8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib577d0265c40eccbff0e9e7595c7127c1a43aa4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875187Reviewed-by:
-
Hajime Hoshi authored
This reverts commit b225359b. Reason for revert: test failing on mac crbug.com/1017037 Original change's description: > css-flexbox: special cases for deprecated rtl horizontal box > > Two special cases that carry over from the old code: > . LayoutDeprecatedFlexibleBox always started layout at an origin of 0, > even when rtl. This gives the same behavior. > . End is treated as start when rtl. > > BUG=1014884 > TEST=fast/deprecated-flexbox/017.html > > Change-Id: I2d232efd0b84ab997e6262253869828d5a758eac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872566 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708446} TBR=sky@chromium.org,cbiesinger@chromium.org,ikilpatrick@chromium.org Change-Id: Ia5cc9c33afe17f5a8e429c39e60365f38963d17e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874990Reviewed-by:
-
Dan Beam authored
Bug: 1010815 Change-Id: I6554af5a5b6449d4c3eb298f42ce63d7f9ae127c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868653 Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
We plan to support ImageProcessor (IP) inside VideoDecoderPipeline (VDPipeline) in the future. When VDPipeline creates IP, there are 2 components (VD and IP) that need frame pool instances. In this case, VDPipeline needs to create one more frame pool. Then passes the original one to IP, and passes the new created frame pool to VD. This CL passes one GpuMemoryBufferFactory to VDPipeline, which is necessary to create one more PlatformVideoFramePool instance in the future. BUG=chromium:1004727 TEST=Run video_decode_accelerator_tests on Kevin and Eve TEST=play crosvideo.appspot.com on Kevin and Eve Change-Id: Ib370b693a99acd0df1d2a9fa57c38d77a6d7beb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868573Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708501}
-
Yuta Kasai authored
This CL removes these functions because it's no longer used. - Resource::ReportResourceTimingToClients() - ThreadableLoader::DidReceiveResourceTiming() Bug: N/A Change-Id: I9a56a0bdde93fb798de63430d0329c2c7d9e6aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869052Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yuta Kasai <yutakasai@google.com> Cr-Commit-Position: refs/heads/master@{#708500}
-
Roman Sorokin authored
Bug: 890457 Change-Id: I73bcf6af092e99d77fc1c28322737408acbc9446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871672Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6207efbf4c2..0f707697f70a git log e6207efbf4c2..0f707697f70a --date=short --no-merges --format='%ad %ae %s' 2019-10-23 primiano@google.com Merge "Add TCP/IP support to UnixSocket" Created with: gclient setdep -r src/third_party/perfetto@0f707697f70a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2b3dce7ba7a2478d19ea62a15183b3aebdb12795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875069Reviewed-by:
-
Hajime Hoshi authored
This reverts commit 953678c5. Reason for revert: test failures: crbug.com/1017035 Original change's description: > Add WebGPU to about:flags on Windows > > Now that all of the work on the Chromium and Dawn side to support > Windows has been complete, we need to add WebGPU to about:flags > on Windows. > > Bug: 966580 > Change-Id: I41d9f892be0d849c5ece1d5569f98344a7a92a1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873383 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#708405} TBR=cwallez@chromium.org,sunnyps@chromium.org,rafael.cintron@microsoft.com Change-Id: I3ee918a6073ea6244381ff497b078f424e179dfa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875013Reviewed-by:
-
Yun Liu authored
Fix compile issue on android-code-coverage: https://ci.chromium.org/p/chromium/builders/ci/android-code-coverage Example failure: https://ci.chromium.org/p/chromium/builders/ci/android-code-coverage/2756 Bug: 985574 Change-Id: I1d67e20f85b3908d646e30ab3c5faf700f7209ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874016 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#708496}
-
nancy authored
BUG=1009248 TBR=xiyuan@chromium.org Change-Id: Id3e58d5672a33eea47df518c97a56d35527c1683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872074 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
Currently kValidValues is defined as a const char* array. Somehow on ChromeOS ARM the IsValidEnum() call got passed in kValidValues for an unrelated type, e.g. in V8MediaKeySystemConfiguration::ToImpl(), kValidValues from PaymentShippingType is passed in, causing TypeErrors. This CL declares kValidValues as const char* const [] which seems to work around the issue. I'll land this to unblock the release, and at the same time keep investigating the root cause. Bug: 1011161 Test: Manually tested on kevin Change-Id: I49ddc9668cf2ef90e674b9b7efe13466f60a24a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873388 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#708494}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f6271e66386..61a1e81e89bd git log 9f6271e66386..61a1e81e89bd --date=short --no-merges --format='%ad %ae %s' 2019-10-23 bsheedy@chromium.org Force IPv4 for Telemetry proxy server Created with: gclient setdep -r src/third_party/catapult@61a1e81e89bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1005971 Change-Id: I6c01eaa5f8eb5961564bb1ab3b979cd2124239a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874621Reviewed-by:
-
Jay Harris authored
Previously, OnShortcutBehaviorDestroyed was behaving as OnShortcutManagerShutdown. Now this has been fixed observers are guaranteed a chance to remove themselves before the shortcut manager is destroyed. This was causing tests in https://crrev.com/c/1833027 to fail, as observers would only be removed if shutdown was called. This more closely follows the pattern of AppRegistrarObserver. Bug: 860581 Change-Id: Ieee68721c088c9e800b9832cc50d21b0a2dda504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873812Reviewed-by:
-
Roman Sorokin authored
Bug: 890464 Change-Id: I8fe561d676089b2cb873b846314042e109913a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872223Reviewed-by:
-
Maggie Cai authored
This CL adds preferred apps class that contains preferred apps storage struct, and add and find methods for the struct. Unit tests are also included. BUG=853604 Change-Id: I0c2c6c219720da5b56b1f1ed5e3818c760566487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864495 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Chris Hall authored
Fixes outstanding TODO for M59. R=aboxhall CC=dmazzoni BUG=672205 Change-Id: I197e8db4374185b80bc8fc91ad1208e9c7609380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689919Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
Use RenderProcessHostCreationObserver and RenderProcessHostObserver APIs, instead of using NotificationService. BUG=357627 Change-Id: Ia3755cd64056484c9b703b31d5a79489785f0e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842556Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#708488}
-
Antonio Gomes authored
This is a preparation CL to Onion souping //content/renderer/media/webrtc, and is part of phase 8 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/edit?ts=5d5c1757 BUG=787254 R=dominickg@chromium.org, guidou@chromium.org, haraken@chromium.org Change-Id: Idaf36f81139f56402febc2493a30050c76e7fac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835802Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Koji Ishii authored
TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I7a87e1b36eb5e3658cb33bbe2648d49b5d1e843e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868776Reviewed-by:
-
Nigel Tao authored
Skia (https://skia.googlesource.com/skia) is a 2-D graphics library, already in use by Chromium as third_party/skia. Wuffs (https://github.com/google/wuffs) is a memory-safe programming language whose standard library includes a GIF image decoder. Wuffs' standard library is also available as transpiled C code. From Skia's (and Chromium's) point of view, Wuffs' standard library is just another C library. It's just not hand-written C. Upstream Skia is moving to use Wuffs for GIF image decoding (https://bugs.chromium.org/p/skia/issues/detail?id=8235). For Chromium, this commit (adding third_party/wuffs, but no change in the generated binaries yet) is the first in a series of commits (see crbug.com/1014044) to have Skia-in-Chromium also use Wuffs. Wuffs is released under the Apache License 2.0: https://github.com/google/wuffs/blob/master/LICENSE Bug: 1014044 Change-Id: I6b41794af09b07aacc48d519651bc397e761ad71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859536Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708485}
-
Ahmed Fakhry authored
- Now auto-rotation is on, when the device is in a physical tablet state, regardless of the UI mode (tablet or clamshell). - Apps' requested orientation locks are only applied while in UI tablet mode, and ignored in UI clamshell mode even if the device is in a physical tablet state. A follow-up CL will handle changes needed for display settings. BUG=925087 TEST=Manually, Added new tests Change-Id: I265dd80563b4532b72ed11aa53206bdc8bfa7dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861049 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#708484}
-
