- 07 Feb, 2020 40 commits
-
-
Gyuyoung Kim authored
This reverts commit ec6127ba. Reason for revert: Caused flaky test failure on WebKit Linux Leak. Original change's description: > Convert WebTestHostMsg_InitiateCaptureDump to Mojo > > This CL migrates the legacy InitiateCaptureDump IPC message > to the new Mojo defined in WebTestClient interface. > > Bug: 1039247 > Change-Id: Idd38ecf67d10593f3bfc6f3c48d9832514cec595 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032634 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739222} TBR=dtapuska@chromium.org,mkwst@chromium.org,gyuyoung@igalia.com Change-Id: Ie0bc76b7d3c8dd67481d67d0ee22b0338d87334f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1039247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043531Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#739357}
-
Swapnil authored
When we manually install an extension and then add it to force installed list, it should get updated. If the extension gets corrupted before the Manifest::Location of the extension is updated, the extension does not get reinstalled. This was because after updating the location, the function OnExternalExtensionUpdateUrlFound return false in each case. It should add the corrupted extension to pending extensions list instead. Bug: 1045371 Change-Id: I9af45488b64d6a7ecde89921023bd35941e1ed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023525Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#739356}
-
David Jean authored
CRWWebViewScrollViewProxy passes itself to its delegate, CRWWebViewScrollViewDelegateProxy, and both were keeping strong pointers to each other. Change-Id: Icb13eddcbb4cce14a2691c8b25fe5708cde6f699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041628Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#739355}
-
Fredrik Söderquist authored
Now with <script> elements in the HTML namespace. Because reasons. Change-Id: Ia3eba0f7856f265ed6fa601272a2d7c577b07c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043450 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#739354}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8052d2973b2a..ea794b87a8c5 git log 8052d2973b2a..ea794b87a8c5 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 phoglund@google.com Teaching histograms to deserialize from protos. Created with: gclient setdep -r src/third_party/catapult@ea794b87a8c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: nuskos@google.com Change-Id: Ia0257890aee53e8947bf076c5207d0f0c64ac571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043397Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739353}
-
Roman Sorokin authored
* Added userActed function to the LoginScreenBehavior * Migrated existing usages of 'userActed' actions * Refactored screens with LoginScreenBehavior to use new mechanism Bug: 1049083 Change-Id: Ie5a8b7cb750008d34c651233a14b696e601d97b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041610Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#739352}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8a7efb5da88a..3fc2c56b0cd5 git log 8a7efb5da88a..3fc2c56b0cd5 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 rharrison@google.com Reduce amount of duplicated code in API implementations (#984) Created with: gclient setdep -r src/third_party/shaderc/src@3fc2c56b0cd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I2fc334ffae2d48f2bb75564fe87baa82dedf8d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043401Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7b3e6babed7..716a808922fb Created with: gclient setdep -r src-internal@716a808922fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic7554d408575ac6ff6dd386d700b64880770f6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739350}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6737082f1029..c43516c5f8a8 git log 6737082f1029..c43516c5f8a8 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 leese@chromium.org e2e test for wasm raw debugging Created with: gclient setdep -r src/third_party/devtools-frontend/src@c43516c5f8a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1045573 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie178d5faa2576c47738c155d7414320ee3e17c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043392Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/492af9a453f4..ea7d67030546 git log 492af9a453f4..ea7d67030546 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 fmayer@google.com Merge "Use "should" that could be confusing." Created with: gclient setdep -r src/third_party/perfetto@ea7d67030546 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I650cfec1be83b0894939e1749325207c05766875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043395Reviewed-by:
-
Friedrich Horschig authored
Relying on GetWindowAndroid() returning a non-null value causes crashes in various instances. With this CL, the window is null-checked before use an creation is deferred to when it's actually used. If creation doesn't succeed on first try (e.g. because the window isn't yet attached), a consecutive call might succeed. This approach also has the advantage that the interface remains clean and doesn't require handling the rare Android failure explicitly. This is acceptable since failing to create the surface means, that the UI isn't ready to show any information anyway or anymore. Bug: 1049090 Change-Id: Iebc556e33226151cbc4fb8060653290ae0e22dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037573 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#739347}
-
Morten Stenshorne authored
This adds support for hit-testing by traversing the fragment tree, rather than traversing the LayoutObject tree. All behind the LayoutNGFragmentTraversal runtime flag. Testing: virtual/layout_ng_fragment_traversal/ contain some hit-testing tests, and will now run with the new code. (Adding fast/events/ to the virtual testuite would increase coverage by a lot, but the tests there are so flaky I decided against it.) Bug: 1043787 Change-Id: Id1e1d524afa071c80098274b2c61a3339c8032e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041597 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#739346}
-
Anna Malova authored
Thread pool is required for correct work of V8. A new added method is called during initialization. Check whether pac_resolver is created when proxy request comes. Bug: 1045049 Change-Id: I5cb2bd6abfb1872b1d73f4f3e7a1daf0a6491682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038736 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#739345}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/730ee40e..ab71334c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I38a990fc1cd04af8a2bd672665032307f5005453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043490Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#739344}
-
Kent Tamura authored
options_width_ is updated at the beginning of ComputeIntrinsicLogicalWidths(), and referred only in it. It doesn't need to be a data member of LayoutMenuList. This CL renames UpdateOptionsWidth() to MeasureOptionsWidth(), and it returns the measured value, and removes LayoutMenuList::options_width_. This CL has no behavior changes. Bug: 1040828 Change-Id: Ic33faffa74ede63444e150914541ed4985f70243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043340Reviewed-by:
-
Benoît Lizé authored
ScriptLoader doesn't keep the ScriptResource instances for async scripts alive, which artificially decreases memory cache hit rates (see the attached bug for details and analysis). Add a feature to tie the lifetime of ScriptResource to the one of ScriptLoader. Bug: 1043679 Change-Id: I3dc46d778f2c601fbde0daf18aa47b4b1ed2cc56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033260Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#739342}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<MouseEvent> and DynamicTo<MouseEvent> as new downcast helper 2. Use IsA<MouseEvent>(element) in place of IsMouseEvent(element) Bug: 891908 Change-Id: I843cc27220eb903eefa01e04c857d19904b26b54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019146 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#739341}
-
Shakti Sahu authored
This CL moves NativeBackgroundTask to components. The chrome specific code is moved to a NativeBackgroundTaskDelegate class which will be injected from a factory. Bug: 1045765 Change-Id: I53c0e9c73947f9f939e953096d98a2a2412ae4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024165 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#739340}
-
Leon Han authored
In js, "enum_value ? x : y;" will get y if enum_value is 0, but x is what we actually want to get in such a case. The correct code should be "enum_value != null ? x : y". BUG=520391 Change-Id: Ibe3771d0dc0ece3cd6659aec298306f694a8f0e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037106 Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#739339}
-
Rune Lillesveen authored
When the XML parser is paused, we temporarily store pending callbacks to call the XML parser hooks when the parser resumes. For error reporting we used the line/column number for the current position of the parser input which is not correct when handling errors for the invoked callbacks. This CL adds these source positions to the callbacks to have correct positions for error reporting. The test below will fail without this CL when the BlockHTMLParserOnStyleSheets flag is enabled. TEST=svg/hixie/error/013.xml Bug: 891767 Change-Id: Ie3e6c608253dfa355b9947433c79ef21d912cbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041443Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#739338}
-
Shakti Sahu authored
This is a reland of f8a4ba13 Original change's description: > Background task scheduler : Split code into public and internal > > This CL separates the public interfaces from the internal code of background > task scheduler's Java code. > > 1 - The public classes/interfaces are left at top level components/background_task_scheduler > while the implementation code is moved to internal/ > 2 - Internal code is moved to a separate package as well. > 3 - The factory will be a separate target that depends on public and internal. > 4 - Some classes need to be referenced from both chrome/ and internal code, > e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this, > have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal > > We should probably move the NativeBackgroundTask as well to components/ which > will greatly help the dependent code to live in components/. Will think about it in a future CL. > > Bug: 1045765 > Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738560} TBR=nyquist@chromium.org,dtrainor@chromium.org,shaktisahu@chromium.org Bug: 1045765 Change-Id: I89e333ec32071458fb76af298b935eb227daac92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040433Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#739337}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580726817-benchmark-81.0.4044.11-r1 to 82-4028.0-1580728925-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I429cf7be647af704ba0ac0670f0eb642f458b5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043399Reviewed-by:
-
Wei Lee authored
This CL allows users to enable/disable performance logging in console via expert mode. Bug: b/141518806 Test: Run CCA and toggle the button in expert mode and see performance logs in console. Change-Id: I67cdc2db8151ea07282b0b5e9891d68cb51bee44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035478 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#739335}
-
Gauthier Ambard authored
Failing on iOS 12. TBR=sczs@chromium.org Bug: 1049972 Change-Id: Id88efad29ed9d8299deee541c7370614629a4212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043473Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-4028.0-1580727432-benchmark-81.0.4044.11-r1 to 82-4028.0-1580727110-benchmark-81.0.4044.11-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2fc84b9ea7a1f489722e830b7fea096698f2c2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043396Reviewed-by:
-
Eric Seckler authored
To reduce flakiness on win. Bug: 1048948 Change-Id: I538a26f97f73c413b8310918db2c86523f9f6ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043570Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#739332}
-
Stephen Nusko authored
NOTRY=true TBR=crouleau@chromium.org CC=pasko@chromium.org,crouleau@chromium.org,chrome-android-perf-status@chromium.org BUG=1049984 Change-Id: I613e3807344ab7953d687db1ef905fe99a43c816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041486Reviewed-by:
-
Alexandre Courbot authored
These methods do not change the state of the V4L2Device and should thus be const. They will eventually disappear once GL imports are not required anymore, but in the meantime let's make it clear that they can be called from any thread. BUG=None TEST=Chromium builds for arm-generic. Change-Id: I51a58847083165e49f57e75a79650edeb49dc8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043530 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#739330}
-
Maksim Ivanov authored
Reenabling the ExistingUserControllerPublicSessionTest.AutoLoginNoDelay browsertest - the test didn't fail after 15'000 local executions under stress, so presumably the flakiness has been fixed elsewhere. Bug: 516015, 644205 Change-Id: I17645f1d61ffc7e4ba772e75436dd9c6e6e471be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042092Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e02f4996c6e9..55de83afeec7 git log e02f4996c6e9..55de83afeec7 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 656650f461c8..95c414ffee64 (2 commits) Created with: gclient setdep -r src/third_party/angle@55de83afeec7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iafd3feff737d3cf0027ae9ae2e649c86c2065f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043029Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6a829e67854..492af9a453f4 git log e6a829e67854..492af9a453f4 --date=short --first-parent --format='%ad %ae %s' 2020-02-07 ddrone@google.com Merge "Update devserver port in documentation" Created with: gclient setdep -r src/third_party/perfetto@492af9a453f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I62ffe7349965061ae787d694d77b3b57bf33dbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043391Reviewed-by:
-
Alexandre Courbot authored
http://crrev.com/c/2026852 fixed a race condition when passing the visible size of the buffers we import into GL. However since I cannot do a proper copy/paste, the new code calls decoder_->GetPicSize() instead of the original decoder_->GetVisibleRect().size(). This results in a size larger than expected sometimes being passed to CreateGLImageFor(), and an EGL_BAD_ALLOC failure happening, leaving the video area entirely black. Fix this by using decoder_->GetVisibleRect().size() as it should have been in the original CL. BUG=b:149067939 BUG=b:148421581 TEST=Youtube video resolution switch on Krane without black screen. TEST=tast run video.Seek.switch_* on kevin64 TEST=tast run video.Seek.switch_h264 on krane Change-Id: I97147421ac271143b74f267bbcb7627e607a19bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043264 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6534ac6e3763..a7b3e6babed7 Created with: gclient setdep -r src-internal@a7b3e6babed7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I58b1a579096e1d496436ca51bfb9016b24f475d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043390Reviewed-by:
-
Finnur Thorarinsson authored
This reverts commit e8b29536. Reason for revert: Fails consistently on the bots. See errors in build where CL was introduced... https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/99608 Original change's description: > Add more System Information collection via WMI > > This CL adds code to collect metrics regarding the processor that the > user is running on. > > R=rockot@chromium.org > > Bug: 1032858 > Change-Id: I38628c722849071c8d0219ce942a257fc0623424 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982237 > Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> > Auto-Submit: Rahul Chaturvedi <rkc@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#739252} TBR=rkc@chromium.org,thestig@chromium.org,isherman@chromium.org,rockot@google.com,asvitkine@chromium.org,wfh@chromium.org,sebmarchand@chromium.org Change-Id: I0e6cb122d9df1c246e1b8ff35e845d5798537104 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1032858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043472Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#739324}
-
Monica Basta authored
This CL contributes to changing the API to get the primary account from the identity manager to be consent-aware. |GetUnconsentedPrimaryAccountId| is replaced with |GetPrimaryAccountId(ConsentLevel::kNotRequired)| Bug: 1046746 Change-Id: I4c2638f57dd92f089b41eda590c3c6c2f0b4d4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041762Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#739323}
-
Finnur Thorarinsson authored
This reverts commit 78be82a7. Reason for revert: This CL looks a likely culprit in persistent failures on bot (the failures started with the build where this was checked in): https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel For example, browser_tests failed because of: ArcAppDeferredLauncherWithParamsBrowserTestInstance/ArcAppDeferredLauncherWithParamsBrowserTest.StartAppDeferred/2 [13339:13339:0206/193410.483101:ERROR:arc_app_list_prefs.cc(1348)] App instance is not connected. Delaying app list refresh. See b/70566216. ../../chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc:187: Failure Value of: app_info Actual: false Expected: true Stack trace: #0 0x5598ac547445 ArcAppLauncherBrowserTest::InstallTestApps() #1 0x5598ac547a5c ArcAppDeferredLauncherWithParamsBrowserTest_StartAppDeferred_Test::RunTestOnMainThread() #2 0x5598afd61adf content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #3 0x5598af8dcc3f ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #4 0x5598af8dbdc9 ChromeBrowserMainParts::PreMainMessageLoopRun() #5 0x5598acb81fca chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #6 0x5598add3bb44 content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x5598ae10e453 content::StartupTaskRunner::RunAllTasksNow() #8 0x5598add3ab6a content::BrowserMainLoop::CreateStartupTasks() #9 0x5598add3d301 content::BrowserMainRunnerImpl::Initialize() #10 0x5598add3910d content::BrowserMain() #11 0x5598af3b30a9 content::ContentMainRunnerImpl::RunServiceManager() #12 0x5598af3b2d77 content::ContentMainRunnerImpl::Run() #13 0x5598b19ae967 service_manager::Main() #14 0x5598ae7c37a4 content::ContentMain() #15 0x5598afd61620 content::BrowserTestBase::SetUp() #16 0x5598af7b91b8 InProcessBrowserTest::SetUp() Original change's description: > Synchronize ARC a11y tree on enableFrame > > Currently, if Android app starts before ChromeVox or S2S starts, ARC > AXTrees are not recognized from these ATs. > This is because: > - AXChildTreeID is not attached to the parent surface at that moment. > - ARC AXTrees are not triggered to update on > automationInternal.enableFrame. > > This CL fixes these issues. > Android side change is http://ag/10167029. > > Bug: b:129681889 > Test: manual. Open any Android app, then enable ChromeVox. Confirm that Android app gets focus. > Change-Id: I38cb372f706817f5e305c4a10a1ac84176275397 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018624 > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Randy Rossi <rmrossi@chromium.org> > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Hiroki Sato <hirokisato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739233} TBR=jorgelo@chromium.org,oshima@chromium.org,dtseng@chromium.org,achaulk@chromium.org,hidehiko@chromium.org,seantopping@chromium.org,rmrossi@chromium.org,sarakato@chromium.org,hirokisato@chromium.org Change-Id: Ib505b1ffd8ff0b9e425a8ded1e3378493c807801 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:129681889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043471Reviewed-by:
-
Rune Lillesveen authored
In [1] we introduced pausing the XML parser for parser blocking stylesheets. The HTML parser did this by setting a flag in DidAddPendingParserBlockingStylesheet() without actually pausing the parser in order to not pause the parser for style and link elements which finishes synchronously by calling DidLoadAllPendingParserBlockingStylesheets() immediately. In addition to unnecessarily pausing the parser, this caused a problem with LocalFrame::ForceSynchronousDocumentInstall() which is not able to handle pausing of the parser. The method is used for loading SVG images via the image tag, and also for generating popup content like for select element dropdowns. The forced sychronous html parsing also works in the cases where we have external resources because external resources are being blocked so that link, style, and xml-stylesheets always finishes sychronously. Hence, the parser will not be paused with this change. The test in the TEST line below fails without this change and with the BlockHTMLParserOnStyleSheet runtime flag enabled. [1] https://crrev.com/6f828b7c947e4ef81401924cde65429d246f0225 TEST=svg/as-image/img-zoom-svg-stylesheet.html Bug: 1043944 Change-Id: I7f31fffd7da385f411d68cbc9ec77d0eb25f41c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039411 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/624f9f49..730ee40e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I05cef209af1dde00675e07c9ea4db6a796467f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042551Reviewed-by:
-
Boris Sazonov authored
Removes unused mChromeSigninController field from SyncController. Bug: 1046412 Change-Id: Ie7f77000e075bf0dcb3c80b33533ac49a52cd52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041608 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#739319}
-
Dominik Röttsches authored
Now that we have scope helpers defined in a shared location for typical HarfBuzz types, use those in Blink. In order to be able to do that for HarfBuzzFontCache, FontGlobalContext needs to forward-declare and isolate HarfBuzzFontCache from leaking outside the header, otherwise all clients need to be made aware of HarfBuzz types. Bug: 1049527 Change-Id: Ic2e6a3fec01a4a6f22eb879d77615a986dc4b987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041471 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
