GitLab

[Chromedriver] Add ability to merge capabilities to make chromedriver closer to being w3c compliant.

This is built on yash's previous work.
w3c standard: https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities

Change-Id: I9b2f49c0f2ebff59fd5b053c2d8b9b99a95aabe5

BUG=chromedriver:1740

Change-Id: I9b2f49c0f2ebff59fd5b053c2d8b9b99a95aabe5
Reviewed-on: https://chromium-review.googlesource.com/562377Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488663}

This CL makes it possible to verify the addition/removal of static
initializers using diagnose_bloat.py.

Also changes resource_sizes.py to not automatically skip functions
that require a proper output directory to be set when one isn't
(instead of using --no-output-dir).

BUG=None

Change-Id: I061dd3d3624550888458cc97b8d6b8324f7a6183
Reviewed-on: https://chromium-review.googlesource.com/580546
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488662}

This reverts commit 9608749b.

Reason for revert: Failures on Lollipop Phone Tester, eg:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13630
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13631
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13632
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/13633

Original change's description:
> 📷 Enable Render Tests.
> 
> Make the render tests fail if the rendered bitmap does not match the
> golden.
> 
> Bug: 641973
> Change-Id: I432111296893bafab18dc65bfb62b12a8212d68e
> Reviewed-on: https://chromium-review.googlesource.com/565399
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488631}

TBR=bauerb@chromium.org,mikecase@chromium.org,peconn@chromium.org,jbudorick@chromium.org

Change-Id: I17ba42053f6679098f176c6ec7fdfb5e14984a39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 641973
Reviewed-on: https://chromium-review.googlesource.com/581527Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488661}

Revert of Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode. (patchset #28 id:540001 of https://codereview.chromium.org/2946113002/ )

Reason for revert:
This CL has caused crashes reported in https://crbug.com/747403

Original issue's description:
> Use FrameIsAd to decide whether to isolate a frame in TopDocumentIsolation mode.
>
> FrameIsAd heuristics
> ====================
>
> After this CL, TopDocumentIsolation will by default only isolate
> cross-site frames that also match FrameIsAd heuristics.  This behavior
> is controllable via Finch, via chrome://flags and via command line
> (see below for details).
>
> Impact on browser tests
> =======================
>
> Browser tests should not depend on the FrameIsAd heuristics.  This is
> taken care of by EnableTopDocumentIsolationForTesting, which enables
> the mode that isolates all frames that are cross-site from the main
> frame.
>
> chrome://flags changes
> ======================
>
> This CL tweaks TopDocumentIsolation's entry in chrome://flags, so that the
> following variations are present (3. and 4. are introduced by this CL):
> 1. Default
> 2. Enabled
> 3. Enabled (CrossSite - isolate all frames from sites other than
>             the top-level frame)
> 4. Enabled (Ads - isolate only cross-site ads detected by heuristics)
> 5. Disabled
>
> Today variations 1 and 5 turn off TDI mode (because the default for
> kTopDocumentIsolation base::Feature is to be disabled).  Variation 3
> enables TDI and isolates all cross-site frames (this is what browser
> tests use when enabling TDI via EnableTopDocumentIsolationForTesting).
> Variations 2 and 4 enable TDI and use FrameIsAd heuristics.  Probably a
> better name for variation 2 would be "Enabled (unspecified isolation
> mode)", but the "Enabled" string is hardcoded in the chrome://flags
> code.
>
> I've manually tested that if a user enabled TDI in chrome://flags before
> this CL, then it will stay enabled after this CL (variation 2).
>
> Command line
> ============
>
> After this CL, the user can control TDI with the following command line
> switches:
>
> - When no extra cmdline switches are present, then TDI is controlled via
>   chrome://flags and/or Finch experiments.
>
> - Cmdline flags to disable TDI:
>   --disable-features=top-document-isolation
>
> - Cmdline flags to enable TDI using unspecified / default isolation mode:
>   --enable-features=top-document-isolation
>
> - Cmdline flags to enable TDI using specific isolation mode (1 for
>   cross-site, 2 for ads;  see the TopDocumentIsolationMode enum for all
>   possible values):
>   --enable-features="top-document-isolation<TopDocumentIsolation" \
>   --force-fieldtrials=TopDocumentIsolation/Cmdline \
>   --force-fieldtrial-params=TopDocumentIsolation.Cmdline:mode/1
>
> BUG=733303
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2946113002
> Cr-Commit-Position: refs/heads/master@{#488372}
> Committed: https://chromium.googlesource.com/chromium/src/+/c1dd61f01ced0c94ccc2efe373a93c696bb98c2f

TBR=creis@chromium.org,jam@chromium.org,asvitkine@chromium.org,jkarlin@chromium.org,csharrison@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=733303

Review-Url: https://codereview.chromium.org/2987563004
Cr-Commit-Position: refs/heads/master@{#488660}

R=thakis@chromium.org

Bug: 689520
Change-Id: I5ea04e1c89cf5694071aa1c7d0d6ff5caaca4f88
Reviewed-on: https://chromium-review.googlesource.com/580505Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488659}

Bug: 689520
Change-Id: I2bd06d69cb54fc81edb8a462caa6458effb5bdfe
Reviewed-on: https://chromium-review.googlesource.com/580397Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488658}

For more on JUnit4 migration, please check src/testing/android/docs/junit4.md

Bug: 640116
Change-Id: Ied8a563ee6833b76beeaa0b4141aa6e0e74a2abd
Reviewed-on: https://chromium-review.googlesource.com/567627Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488657}

Change-Id: Ie84d4af16c6d9a0a59e321f300fa1228c55b8799
Reviewed-on: https://chromium-review.googlesource.com/576430
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Reviewed-by: Brian Anderson <brianderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488656}

Having non-translated strings in .pak files is quite inefficient since
they are copied into each locale .pak file.

Changing this one string decreases apk size by 3,641 bytes.

BUG=703134

Change-Id: I7b64c2d7a48544a7e780e3c300044fdba33b3920
Reviewed-on: https://chromium-review.googlesource.com/578214Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488655}

Both JSONParser and JSONValues use constants for the strings
"null", "true" and "false". That is probably no problem since the
linker will merge identical strings, but since the constants had
the same names as well they caused collisions in jumbo builds.

This patch makes JSONParser use the JSONValues constants.

Change-Id: I27b01b354aa9cfeab0f8c636f22ecfbc2762a6bc
Reviewed-on: https://chromium-review.googlesource.com/577552Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#488654}

Renamed TaskRunner::RunsTasksOnCurrentThread() to
TaskRunner::RunsTasksInCurrentSequence() in //service

Bug: 665062
Change-Id: Id5de459e44ff12c2f8d0ac64270c135ee902912e
Reviewed-on: https://chromium-review.googlesource.com/579317Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488653}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/f9e1294920ec..3668235f8a91

$ git log f9e129492..3668235f8 --date=short --no-merges --format='%ad %ae %s'
2017-07-21 loloangela Fixed errors related to bad-continuation.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib129ee6ee29e7ceb87ab2b0875c135eda86c447e
Reviewed-on: https://chromium-review.googlesource.com/581269
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488652}

Conversion script is based on directory_owners_extractor.py, and can be found at
https://gist.github.com/Hexcles/ce7110a8d07bf81378e254914ae8cbb2

Verification:
git show HEAD --name-only | sed 's|third_party/WebKit/LayoutTests/||' | sed 's|/OWNERS||' | sort > list1
grep 'external.*\[ Pass \]' W3CImportExpectations | grep -o -E 'external[^ ]+' | sort > list2
diff list1 list2

The diff output:
5a6
> external/wpt/common
51a53
> external/wpt/fonts
61a64
> external/wpt/images
64a68
> external/wpt/interfaces
65a70
> external/wpt/media

All five directories are explicitly marked as "Owners: none; No tests in the directory." in W3CImportExpectations.

Bug: 713987
Change-Id: Ic00f2eb971ed2ba3cc1a44aef59e2a32586a5e24
Reviewed-on: https://chromium-review.googlesource.com/580535Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488651}

I was debugging some strangness from these classes and didn't readily
know who was creating the windows.

BUG=none
TEST=none

Change-Id: I698070c53a90ca9f5e01225ba96fcbd3a77ed892
Reviewed-on: https://chromium-review.googlesource.com/580695Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488650}

The current timeout for page load (0.1s) is a bit short and leads to
flakyness on official bots on iPad Air.
I can reproduce the flakyness locally.
Increase the timeout to 1s as the loading is not the tested part.

Bug: None
Change-Id: Ie944a99590f8083e2c22d43769dcdf7d9a0dcab1
Reviewed-on: https://chromium-review.googlesource.com/579369Reviewed-by: Ed Chin <edchin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488649}

In this implementation, all script streamer actions are controlled by
ClassicPendingScript, and ScriptRunner ends up asking ClassicPendingScript
to perform the streaming. To facilitate this, ClassicPendingScript has a
new state kReadyStreaming, for cases where we start streaming while the
script has already been 'ready' (and stays 'ready').

Bug: 557466
Change-Id: I990920830af3a820f530f360347f6fa98d8754c2
Reviewed-on: https://chromium-review.googlesource.com/519168Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488648}

InstantService is the only caller of MostVisitedSites::Refresh() and it
is obvious from the caller's side that TopSites should be refreshed too,
when an NTP is opened. Prior to this patch, TopSites would be updated
time-based, leading to more stale NTP tiles when the feature
kNtpTilesFeature is enabled (non-default case).

The bug is believed to make little impact.

Bug: 741431
Change-Id: Iccdc4f89d3ab430eafd9a2faf1b1564f363ff29f
Reviewed-on: https://chromium-review.googlesource.com/581147
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488647}

Bug: 739719
Change-Id: I24f44759324ae715a9d8abbd71753f0d3e85ab5b
Reviewed-on: https://chromium-review.googlesource.com/581189Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488646}

Video frames might never arrive. Waiting is appropriate for a <video> tag,
but not for <audio>.

TBR=hubbe@chromium.org

Bug: 738379
Change-Id: I3f6c886c32b06f6def8024ca585179ca81a6ef29
Reviewed-on: https://chromium-review.googlesource.com/575998
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488645}

Compiled chromium on loongson3a platform(mips64el architecture) with gcc-4.9.3, occurs errors
about that ‘for’ loop initial declarations are only allowed in C99 or C11 mode.

Bug: 746767

R= dpranke@chromium.org, scottmg@chromium.org

Change-Id: I8809ca16d3e647c967fb7117437a635d8ed05bef
Reviewed-on: https://chromium-review.googlesource.com/578630Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488644}

This CL attempts to enable the seccomp-bpf sandbox, as we do for
renderer processes on Android, for the new photo picker when it is
supported by the device.

The implementation loads the native library as if it's a Chrome child
process, and then calls the native InitializePhotoPickerSandbox function
to initialize the sandbox when available. UMA is logged.

Because we end up loading the native library, this does create for an
additional delay of ~700ms before the first photo is shown. There may be
optimization opportunities by separating out the sandbox code in a separate
shared library, but this is made difficult by (a) our build system using
the crazy linker, and (b) the dependencies of //sandbox on //base.

I've verified that the sandbox is enabled on two devices running
different versions of Android, both by printing the status of the
SeccompStarterAndroid, and through the following command:

$ adb shell cat /proc/18424/status | grep Seccomp
Seccomp: 2

(Where "2" means that seccomp-bpf is enabled.)

BUG=730066

Change-Id: I46e608bad8f69d3cf862c0953361c50f4c65c45c
Reviewed-on: https://chromium-review.googlesource.com/577853Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488643}

The mocks are here:
https://docs.google.com/a/google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI/edit?usp=sharing (slide 38)

EasyUnlock is disabled:
https://screenshot.googleplex.com/2WxZMn78UgM

EasyUnlock is enabled (the default value is selected):
https://screenshot.googleplex.com/WJ0KYLa5Jhm

EasyUnlock is enabled, user is selecting the value:
https://screenshot.googleplex.com/AXUadsCLgax

Bug: 724715
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77e3f7a2d28feb9c5c8c9557df39c61c7e9065f0
Reviewed-on: https://chromium-review.googlesource.com/580407
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488642}

BUG=734131, 734136

Review-Url: https://codereview.chromium.org/2962783004
Cr-Commit-Position: refs/heads/master@{#488641}

The wrapper function is no longer useful as WTF::Bind no longer needs
explicit unbound parameter types.

Change-Id: I64e00f1065ce397b1491c71470a62801208f530c
Reviewed-on: https://chromium-review.googlesource.com/580452
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488640}

Bug: 718925
Change-Id: Ie11a88d9864bf6e4a4e85f7dc15c4e4e01bb00fe
Reviewed-on: https://chromium-review.googlesource.com/574856Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488639}

It shouldn't be quoted.

Bug: 
Change-Id: Ie0bbc1cc3ce9c4807f0465da93642939a72120b1
Reviewed-on: https://chromium-review.googlesource.com/578333
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488638}

Bug: 741709
Change-Id: I7ecf2621d51b6ddb1824608007f3b20514652d6b
Reviewed-on: https://chromium-review.googlesource.com/576040
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488637}

Disables the __builtin_adc intrinsics on GCC.

Bug: 746420
Change-Id: I1b16eaba85ca93c2d04dc25755565cd9e0386320
Reviewed-on: https://chromium-review.googlesource.com/580787Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488636}

This reverts commit 1cb215be.

Reason for revert: Problem should be fixed. Reenable tests.

Original change's description:
> Disable SigninInteractionControllerTestCase EG tests.
> 
> Those tests are consistently timing out on iPad, disabling them
> on iPad until the root cause is fixed to turn the bots green.
> 
> Bug: 745798
> Change-Id: I5f0dab981cae4fbef9f81d144ffa0492a16cfa12
> Reviewed-on: https://chromium-review.googlesource.com/576171
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487506}

TBR=sdefresne@chromium.org,jlebel@chromium.org

Change-Id: I5ea0342aa4b6d0c2b1227e52c4f0c0f272695d63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 745798
Reviewed-on: https://chromium-review.googlesource.com/577542Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488635}

Reverting the revert that supposedly broke waterfall tests here:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44127/.
However, successive builds:
* https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44128/
* https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44129/
passed *without* containing the revert commit, which means our original commit most likely was
not the root cause of the broken tests in the first place.

Original CL: https://chromium-review.googlesource.com/c/567925/

Original change's description:

> Pin the Home Page Tile to the first row in the UI.
>
> Calculates the number of columns tiles are layed out in
> at initialization and reorders the home page tile so that
> it is pinned to the first row.
> Follow-up issue: https://crbug.com/746274
>
> BUG=732913
>
> Change-Id: Ieeddf88e8262827c7a22787230c386fe3b43cc17
> Reviewed-on: https://chromium-review.googlesource.com/567925
> Commit-Queue: Ondrej Škopek <oskopek@google.com>
> Reviewed-by: Chris Pickel <sfiera@chromium.org>
> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488203}


BUG=732913

Change-Id: I359fdb6ca03a31626b41626e01731f2970bcb454
Reviewed-on: https://chromium-review.googlesource.com/579907Reviewed-by: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Ondrej Škopek <oskopek@google.com>
Cr-Commit-Position: refs/heads/master@{#488634}

Three fields in traffic annotation proto are updated and all fomer annotations
required update.
In proto3, we cannot specify default value for fields. Enum fields get their
first choice by default and boolean fields get false by default. This way if
one does not specify the value for one field, we cannot distinguish it from the
case that the default value is given as input. To overcome this problem, the
semantics::destination field and policy::cookies_allowed are updated.
Also an extra field named comments is added for possible extra required
human readable comments.

Bug: 656607
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ib6ac74f2abafb16e18283f1b2559f866f0539eea
Reviewed-on: https://chromium-review.googlesource.com/579188
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488633}

static methods previouly in WebViewImpl.cpp are now available in
WebViewBase.cpp. These classes will eventually merge and the schism
will be repaired. 

Usages of base::SingleThreadTaskRunner in WebLocalFrameImpl are replaced
by the alias in platform/WebTaskRunner to satisfy our PRESUBMIT.

Bug: 712963
Change-Id: I76ba9b1d7f15180b8d2dfeaed8cdc93ff9ac091f
Reviewed-on: https://chromium-review.googlesource.com/577429
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488632}

Make the render tests fail if the rendered bitmap does not match the
golden.

Bug: 641973
Change-Id: I432111296893bafab18dc65bfb62b12a8212d68e
Reviewed-on: https://chromium-review.googlesource.com/565399
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488631}

A variable wasn't given the right name inside the ATK support when
a patch consolidated 3 AX properties into single restrictions
property for accessibility objects.

R=aleventhal@chromium.org, jochen@chromium.org

Change-Id: I0c82e055e39614110cfc4f7a7299d226bd4e6ad2
Reviewed-on: https://chromium-review.googlesource.com/580927Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#488630}

This check was initially added to avoid overscroll actions on the terms
page of FRE.
But the terms page does not use BVC at all and is presented by the
WelcomeToChromeView, so the check is not needed.

Bug: 746415
Change-Id: I30c74c0283dc63a88d8233287cf130af70e84ab2
Reviewed-on: https://chromium-review.googlesource.com/580929Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488629}

Change-Id: I4709561d23a03bb4e76219a99520541ad17ec927
Reviewed-on: https://chromium-review.googlesource.com/580177
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488628}

Move same conditional expression of while-statement AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function

This patch moves same conditional expression of while-statement in
|AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries()| into
|IsNonEditableContentInsideTheSameLowestEditableAncestor()| to share code and
simplify if-statement for improving code health.

This patch is similar to the patch[1].

[1] Tree is open (suspected flake, https://crbug.com/743069)
Reply
More   
 Move same conditional expression AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function

Change-Id: I3662b9bcc78add3c465987b370bde82e7b38008f
Reviewed-on: https://chromium-review.googlesource.com/580114
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488627}

HarfBuzzShaper calls ShapeResult::InsertRun() for each run RunSegmenter
segmented.

This patch fixes ShapeResult::InsertRun() to compute
ShapeResult::glyph_bounding_box_ when there are more than one run.

Before this fix, it computes glyph bounding box of each run from (0,0)
then unite all bounding boxes. So if input text is "englishARABIC",
RunSegmenter creates 2 runs and each InsertRun computes:
Run 1: "english", width 70, bounding box (0,0,70,10) (x,y,w,h)
Run 2: "ARABIC", width 80, bounding box (0,0,80,10)
then the united result would be (0,0,80,0) while the total width is 150.

This patch fixes InsertRun() to compute bounding box from the current
point, so that:
Run 1: "english", width 70, bounding box (0,0,70,10)
Run 2: "ARABIC", width 80, bounding box (70,0,80,10)
and the united result would be (0,0,150,0).

This patch also removes incorrect fix made to ShapeResult::CopyRange().
This was done to pass tests in a previous CL[1], but turned out that
the original glyph bounds is incorrect and the fix was wrong.

[1] r487410, https://chromium-review.googlesource.com/c/574508/

BUG=746904, 636993

Change-Id: Iec147e5e9b9853a60489e23355ede730ce918c36
Reviewed-on: https://chromium-review.googlesource.com/577970Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488626}

In content/, this CL replace every renderer-initiated navigations
started with TestRenderFrameHost::SimulateNavigationStart() with a
navigation using the NavigationSimulator.

Bug: 728571

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel
Change-Id: Ibe7bf13c645d202af1a7bb1dd9aecdc20a50d288
Reviewed-on: https://chromium-review.googlesource.com/574865
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488625}

If the setting view controller is being reloaded while being dismissed,
a new SigninPromoViewMediator is created. This new one is not properly
released. -[SigninPromoViewMediator signinPromoViewRemoved] has to be
called before dealloc.

stack trace:
-[SettingsCollectionViewController loadModel]
...
-[SettingsCollectionViewController didFinishSignin:]
...
-[SigninInteractionController cancel]
-[SettingsCollectionViewController settingsWillBeDismissed]
...


Bug introduced with crrev.com/2883093002
DCHECK introduced with crrev.com/c/567923

Bug: 747121
Change-Id: Ida6847e0942c5145ddc8fbd6c4681bfcc87a8904
Reviewed-on: https://chromium-review.googlesource.com/580408
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488624}