- 11 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/977eeb69af7b..0d5c00517887 2020-12-11 michael.liao@microsoft.com [Accessibility]: Improve screen reader text to include count and position of suggest box (e.g. 'suggestion 3 of 5') 2020-12-11 kahinds@microsoft.com [Loc] Fail presubmit on modifications to en-US.json 2020-12-11 chrche@microsoft.com [Loc] Migrate node_debugger to Localization V2 2020-12-11 chrche@microsoft.com [Loc] Migrate js_profiler to Localization V2 2020-12-11 tvanderlippe@chromium.org Improve formatting for CSS variable definitions 2020-12-11 morlovich@chromium.org Add a utility for structured header handling (3/3) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073909,chromium:1136655,chromium:1157329 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I75e521d058d51963d2de1a47c5c79f7a63684888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836253}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607677133-25f70964da7400c139fdb96077d2bf8b05dd84bf.profdata to chrome-win64-master-1607687924-42a73eb0331784066b7e53d64e9d9a239913c74b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fc508813b0e291cec2b86e82764b8cd1d7218d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586102Reviewed-by:
-
Guido Urdaneta authored
This CL makes sure that the destroy method is automatically invoked on VideoFrames when they are sent to a sink. This automatic invalidation is important because there are cases when frames are automatically sent to a sink without the possibility of manual invalidation (e.g., when automatically piping a readable stream to a writable stream). This is also consistent with the automatic invalidation in WebRTC Insertable Streams. Drive-by: Re-enable a disabled test that flaked because of a missing call to wait for a promise to be settled. Bug: 1151913,1153092 Change-Id: I3bc40df3bb02a1ae9852b03af2c94898400a2d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587037 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#836251}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd5c6c03c06f..e94526b4043b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0d6236400c628dac6ac89a6d5378d8da8e657d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587256Reviewed-by:
-
Dave Tapuska authored
Since there are multiple WebViewHelpers running around setting the InstallCreateWebFrameWidgetHook for the entire duration of the object is problematic. Centralize widget creation on methods on WebViewHelper. Set the hook for the duration of the CreateFrameWidget call and that is all. This change collapses a lot of duplicate code into a method on the WebViewHelper. BUG=1097816 Change-Id: If17115ccafe724a365968e7fe299054809837644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585839 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836249}
-
Ben Wagner authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/2566935/5#message-8b391d170d115a9b89c0a985ab0a8a42a208695b The license was discussed in the original code review in https://codereview.chromium.org/2761163003#msg15, but it seems that changing the license was chosen instead. There no longer appears to be an issue with presubmits when a compatible license is used. Only tools/perf/page_sets/update_webrtc_cases is manually edited in this CL. Other changes were generated by this script. `./tools/perf/run_benchmark run webrtc --browser=system` passes locally on Mac. Change-Id: I6fc40e29731205b7115c91127015a9f299449389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573141Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#836248}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c52956d0..84a26597 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I773af8572b5a52b91ce09c96315fcb42e95d2588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587107Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836247}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607687924-da70153108842fcd8bad16a1d91d87a201f64cf8.profdata to chrome-mac-master-1607709601-c889cff9228ed2a408f7c416b610f665b13ded19.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I47a68475dec1edbcda89f27b0e987952fdaa5560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587510Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd5c6c03c06f..e94526b4043b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia2db1cc0609464fb9dc94564c8e7c9c5d84b9c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587488Reviewed-by:
-
Robert Sesek authored
Bug: 1157103 Change-Id: Ie792de078f7d33cc269eeb489d1381d267d1a681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585789Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#836244}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 306e31ad. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Id5ab9b0d17bb9acfbda1c18ba601b0108414714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584498Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836243}
-
Michael Bai authored
Update the prediction after the session starts and notify AutofillProvider the server prediction available. Bug: 1151542 Change-Id: Id41b025f3a99e95167e6a75ee0eea796a4146786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585960 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#836242}
-
Daniel Murphy authored
Change-Id: I38fc9d58a1852deadf4115b5d3d40f172d81f981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586036 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836241}
-
Becca Hughes authored
This reverts commit dd03899c. Reason for revert: Breaks Kaleidoscope build https://ci.chromium.org/p/chrome/builders/try/kaleidoscope-linux/706? Original change's description: > [ntp] Enable downstream Kaleidoscope module > > Requires crrev/i/3453282 to be rolled. > > Bug: 1152205 > Change-Id: Ifed4a0d5b5591f01eccb583c8b72239e9cde6143 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583135 > Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835687} TBR=tiborg@chromium.org,steimel@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152205 Change-Id: I23645d78851ef1879f565d85e857b9b6323540ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586954Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#836240}
-
Dave Tapuska authored
This adds some base plumbing for pepper plugin instance handling. The pepper renderer code allocates and manages the PepperPluginInstanceImpl, this creates the correct encapsulation moving code out of RenderFrameImpl. On the browser side a PepperPluginInstance is created to handle the messages and relay them to the WebContentsImpl which use to handle the processing of Pepper messages. BUG=1157519 Change-Id: I24941bb7eecef56a90bbf961e6396101c8d3c785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585627 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#836239}
-
Theo Johnson-kanu authored
Bug: 1156865 Change-Id: I381d94dd42a3bb99a81bd374488a331064ea1cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585747Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#836238}
-
John Chen authored
This reverts commit 3f73ae0f. Reason for revert: Bug causing test failure is now fixed. Original change's description: > [Perf] Disable failing browse:media:imgur stories > > Disable the following two failing stories on Linux: > * system_health.common_desktop/browse:media:imgur > * system_health.memory_desktop/browse:media:imgur > > Notry: true > TBR: wenbinzhang@google.com > Bug: 1154753 > Change-Id: Ibb654a2736c14e2f74c986475ca705004dc3da16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570739 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833183} TBR=johnchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com Bug: 1154753 Change-Id: I34b0c93e85de4c5dc040c1e1dfda708112be7eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575950 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836237}
-
Jana Grill authored
Adjust IDS_ENTERPRISE_ENROLLMENT_DOMAIN_MISMATCH_ERROR to support FlexOrgs by replacing the usage of "domain" with "organization" and adjusting the description to make it easier for the translators to understand the usage of the text. Bug: b:172679992 Test: Manual Change-Id: I2a3469c698c85179ae509fe4d1cc97bd9c778026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586348Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#836236}
-
Morten Stenshorne authored
This reverts commit b2cf6bb4. Reason for revert: We are worried about use-after-free bugs (long-lived HitTestResult keeping a NGPhysicalBoxFragment reference, which may point to a dead LayoutObject) with this solution; see crbug.com/1152696 Original change's description: > Enable LayoutNGFullPositionForPoint Blink runtime feature. > > Had to change some tests because of this: > > WebFrameTest.SmartClipData and > WebFrameTest.SmartClipDataWithPinchZoom: > Force Android editing behavior, or else it would fail on Mac and UNIX. > CL:2552591 copied behavior from LayoutBlock::PositionForPoint(), where > we'd consider non-hit-test candidates if there were no actual hit-test > candidates. We now do this consistently, while in legacy layout we'll > only do it for block children. The test here has only floated children > (which means that ChildrenInline() will return true). (Adding an empty > regular block next to the floats would change the behavior completely > (since we'd then get the "block children behavior"), which is bogus). > Since the point is below the float, on Mac and UNIX the start offset > will now be at the end position inside the float that's just above the > rectangle (because the caret is moved to the element boundary), rather > than including the entire (parent) container. On Android and Windows > this doesn't happen (since the caret isn't moved to the element > boundary, and the caret happens to be exactly at offset 0, because of > the x position of the point). > > editing/selection/click-on-block-image.html: > Since NG PositionForPoint() finds what actually is the closest box > (rather than doing it inaccurately in some cases, like legacy), we'll > hit the line boxes in the test more than before. Test a bit further down > to keep the test passing. Note that the manual version of the test > passes anyway (i.e. the caret is placed on the correct side of the > image, even when we hit the line boxes instead of the image). > > editing/selection/continuations-with-move-caret-to-boundary.html: > Again, we now find the box that's actually the closest one, so aim > better. > > editing/selection/offset-from-point.html: > Remove workaround for vertical writing modes, since it would make us > fail now. > > fast/writing-mode/positionForPoint.html: > We now hit what's actually the closest box. This test is part of > https://bugs.webkit.org/show_bug.cgi?id=92202 , and there's nothing that > suggests that we depend on the old behavior. > > Bug: 1150362, 829028 > Change-Id: I733b154ef473ab3d8064554213dde2e9b948e040 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553547 > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831049} TBR=yosin@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150362 Bug: 829028 Change-Id: I6a6fc96c11acd379a01060f105f861e70f320ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584855Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#836235}
-
Dirk Pranke authored
This CL makes Python 3 be the default script executable used by Ninja to run action() and action_foreach()'s during the build. This does *not* mean that everything works with Python3; many targets may still use Python 2 via the python2_action() and python2_action_foreach() targets or via custom logic. However, it does mean that it should prevent regressions from creeping in. This CL should not be taken to imply that we can start to write Python3-specific code that can run during the build; we should still be trying to ensure that everything is compatible with Python2. Also, this CL does not enable the use of vpython in actions; we should still avoid that because vpython is slower than direct Python invocations. Bug: 1112471 Change-Id: I472b032b500715156d955b0758640a7ed0384305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#836234}
-
Edman Anjos authored
Bug: None Test: NA Change-Id: Iea59f14f50bb3f3fa6d5f9b4efaad582ec8b9d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584853 Auto-Submit: Edman Anjos <edman@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#836233}
-
John Lee authored
Fixed: 1142080 Change-Id: Ib9fee0ddff34897d56779009ba7463a12fb57940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580183 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836232}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2b4eb95a7eed50807e69e6e2921ffaa3b2fee8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586034Reviewed-by:
-
Joe DeBlasio authored
Enabling by default in preparation for 100% launch. Change-Id: If5bdb740c73758da16cdce4deae7e18bf73b8ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586266 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#836230}
-
Guido Urdaneta authored
This CL updates queue management for MSTP as follows: 1. The main queue management now occurs in the underlying source and not in the stream controller. A frame is enqueued in the controller when pull() is invoked, or a when a new frame becomes available after a previous pull with an empty queue. 2. When the queue is full and more frames arrive (i.e., in a situation of slow consumption), old frames are dropped. Before this CL, incoming frames were dropped when the controller queue desired size exceeded a threshold. 3. The queue size is now configurable from the JS side (via a constructor parameter). This makes it possible to support more use cases than with a fixed queue. The new parameter will also be useful for audio when it becomes available. Fixed: 1157605, 1157604 Change-Id: I0260f7d5fe0495c33cfc022ce534ef04c518e90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587034 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Peter Kasting authored
Technically this variable was not uninitialized, as the caller sets it to 0 beforehand. But this is fragile and unclear. Bug: none Change-Id: I85b56897e9dd767835efa14fd8389ce3005f8e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586185Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836228}
-
Aleks Totic authored
Turn on TablesNG virtual test suite. 23 tests that used to fail in Legacy now pass. 14 tests in the test suite are still failing. 5 fail because of incorrect anonymous table fixup. virtual/layout_ng_table/external/wpt/css/css-tables/anonymous-table-ws-001.html virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-inline-table-001.html virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-inline-table-002.html virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-table-001.html virtual/layout_ng_table/external/wpt/css/css-tables/table-model-fixup-2.html 3 fail because "ignore percent inside flex/grid/td" has not landed virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-001.tentative.html virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-003.tentative.html virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children.html 2 fail because "caption-side:left is not implemented" virtual/layout_ng_table/external/wpt/css/css-tables/floats/floats-wrap-bfc-006b.xht virtual/layout_ng_table/external/wpt/css/css-tables/floats/floats-wrap-bfc-006c.xht 1 fail because "table height distribution to rows does not distribute to head" filed an issue virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/extra-height-given-to-all-row-groups-004.html 2 fail because "rowspan + visibility:collapse differ from standard" virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-colspan-003.html virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-rowspan-005.html I think virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/computing-row-measure-0.html is a bad test. We match FF, will check with dgrogan Bug: 958381 Change-Id: I08e7713e908638262d61cd0742e2bf0b77ed0b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586269 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836227}
-
Hongchan Choi authored
The comment doesn't seem actionable and not sure what the alternative is. Bug: 854229 Change-Id: I87e1ac40e874303e73f043a87d9d56a90b7585e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577533 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836226}
-
Nektarios Paisios authored
Cleanup: Modernizes some parts of CrossPlatformAccessibilityBrowserTest, enables all disabled tests and makes them more consistent with other accessibility browser tests Some tests having to do with iframe traversal in CrossPlatformAccessibilityBrowserTest were disabled. In https://crrev.com/c/2556452, the kPDFRoot role is being added and the kWebArea role is being removed. Iframe traversal tests should be enabled and functioning to ensure the robustness of any code changes in those roles, as they could potentially break iframe navigation. Meanwhile, many of the code convensions used in CrossPlatformAccessibilityBrowserTest were different from all other accessibility browser tests and some have been superceded by changes to C++. This patch switches to using raw literal strings for loading HTML snippets, improves indentation, and uses the same method names for loading test pages as in other accessibility browser tests. Also, useless comments were eliminated and test fixtures cleaned up were necessary. Originally split out from https://crrev.com/c/2556452 AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ia9c3094606581468d7f1b5c8849bb44668b47de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575101 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#836225}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a77bc1f1e690..d9318acc24b0 2020-12-11 syoussefi@chromium.org Roll VK-GL-CTS from 41331850eb21 to 54509765b18d (18 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I34743d47a6b0043dd12eed5fc2e43b482e1f5179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587254Reviewed-by:
-
Yuly Novikov authored
Suppress as flaky on Mac Catalina Unskip on Win10 to gauge flakiness rate Bug: 1085222 Change-Id: I62ee9d7bfa92c9b0f5ec7b577bb94e6c3486749a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585630Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836223}
-
Joel Riley authored
Original patch: http://crrev.com/c/2568547 Revert: http://crrev.com/c/2583106 Fix for issue where focus ring appears below switch access panel. Now clients can specify if they want their focus ring to appear above or below accessibility bubble panels. STS will specify they appear below, though other clients will (by default) specify they appear above all panels. This fixes an issue with the switch access focus ring didn't appear above the switch access panel. Original description: Move focus rings and highlight layers under accessibility bubbles. Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. Bug: 1157261, 1143814 Change-Id: Ibd8dd577ecd4fb5767b628c2eff679a2f6931b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582997Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#836222}
-
Michael Checo authored
Screenshot: http://shortn/_2F4mclWC9p Bug: 1154764 Test: unit_tests --gtest_filter=NearbySh* Change-Id: I76b370e10e2b1b2e38b7c33eb29f4b4b36f677a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576635 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836221}
-
Alex Moshchuk authored
Bug: 1157137 Change-Id: I4ed35a4620b9672baaec7edaa03a5f75cc2516f7 Tbr: omorsi@google.com, emaxx@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586957Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836220}
-
minch authored
The contents of DesksBarView is put inside the ScrollView to support the scrollable desks. And the customized BentoDesksBarLayout is used to layout the contents. The follow up work will include new style of new desk button, define the minimum width of the mini view to make sure the desk's name can always be seen, etc. Bug: 1147245 Change-Id: Ic75f21d1b534723a551f3e56ab0edbfac4e07d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566350Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#836219}
-
Min Qin authored
This CL fixes a couple issues on counting tile impressions on NTP. 1. NTP calls TileManager::GetTiles() to get both the top and sub tiles. While Omnibox makes two separate calls of GetTiles() and GetTile(). This CL fixes the behavior of NTP to match that of Omnibox, so we can count top level tile impression when GetTiles() is called, and counts subtile impression when GetTile() is called. 2. Clicking the home button will often invoke 2 calls to GetTiles(). One caused by QueryTileSection ctor, one caused by OnLoadUrl() for NTP. We don't actually need to reload tiles if user never clicked on any tiles. In most cases, only the call from ctor is necessary. This CL fixes the issue by checking whether tiles has been clicked before reloading all tiles. BUG=1155919 Change-Id: Ief1f4be957d160119c40fec1da71ae79d6258321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576504 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836218}
-
Peter Kasting authored
Various functions were unconditionally casting non-representable values. Bug: 1124595 Change-Id: I811f44164a7c9f5802287e1d826cf403ff2e08e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585669 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Orin Jaworski authored
Bug: 1157612 Change-Id: Iebd56655a223360f716c0d075c68fa2572fd1508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585752Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836216}
-
Dominic Mazzoni authored
The ForcedColors feature is fully implemented and on track to ship in M89. That brings Chrome to parity with Edge in how it handles Windows High Contrast mode and it also gives web developers new CSS features to detect and override it where needed. InvertBubbleView was our previous solution - if a user had high contrast mode enabled, we'd show this bubble to direct them to an extension and theme to get a similar effect. Those recommendations are now no longer necessary. Bug: 970285 Change-Id: I0e0e78e489f2a40f1618055b7ebaea660e155e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586367 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836215}
-
Richard Stotz authored
This CL fixes some minor issues with NativeIO's web platform tests. - The concurrent_io tests obtain a more unified structure to reduce the chance of missing an await. - createFile() is removed from close_async as the exact same function is provided by resources/support.js. Bug: 1157915 Change-Id: I3e33cc8d93e08c31dddc4d844310c92eeba31a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587058 Commit-Queue: Richard Stotz <rstz@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836214}
-
