- 03 Oct, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601661327-f05ef41a3d878972298e1fd51500deb6e41b0834.profdata to chrome-linux-master-1601683014-201429f627457cc5b44b92b2115a108e4b1b601e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I7835e6f0ed9f92b77ed3c1f8940cbbb969f37ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813481}
-
Jesse Schettler authored
Add and implement ScanService::Scan() to allow clients to perform scans. The ScanService currently saves each scanned image to the user's "My files" folder, but future changes will allow clients to specify the file type and save-to location. Bug: 1059779 Change-Id: I628571f8663498bc8499e9b7e53d1d6b144a0816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436385 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#813480}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601661327-f1cf60f844e0debf5bf4063a28b1716a25f6a438.profdata to chrome-mac-master-1601683014-2e92089dc27cc7c1a61187a39c965502feaea852.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib98bba8f4f1ee258d83cb643e96bf468f916c288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447249Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813479}
-
Roman Arora authored
CrIconButton already contains a noink property to disable the ripple effect. Bug: 1128599 Change-Id: I18b503466ec2aee427119aa1041920b0d793266f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446351 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#813478}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8e5f2c0fe3e8..af79da9ee416 2020-10-02 miu@chromium.org [Cast Channel] Add broadcast routing in VirtualConnectionRouter. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I2546c47b8abaf9cf2b02ae6daaade6de1b2e0197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447072 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813477}
-
dpapad authored
The dependency does not seem to be used, and it is deprecated. Bug: 1128151 Change-Id: I1869c968a5cec33d3e08a23da2db598773c7900f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443942 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#813476}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/71413e9..91b544d Bug: 1100470, 1125337 Tbr: jdarpinian@chromium.org Tbr: shrekshao@google.com Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: I185e7703aeeb5eccb59e0286a5fbb4e11a3c08e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446538 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#813475}
-
Lukasz Anforowicz authored
This CL introduces ExternalFileURLLoaderFactory::Create static method that allows creating a ExternalFileURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<ExternalFileURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing ExternalFileURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: Iadb47d1f73c73f08a8d0cd2a9c303ddef7158bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443398 Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#813474}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //cc. Bug: 1113033 Change-Id: If22ea2d9d173834a0e09151f30257603a7c61779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441274Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#813473}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idc3f73f7a3e0419bc26f1fe21d0abb62ccfe24e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813472}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da6894f7a9b4..1407cfd9e5f4 2020-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ibbeceefa66989502d20dba0f2ee58b58241d971c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445574 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813471}
-
Fabrice de Gans-Riberi authored
This reverts commit e9a3e3ec. Reason for revert: Broke Cast Streaming in CastRunner Bug: 1134815 Original change's description: > [fuchsia] Add unittests for message_port.cc, fix flow control bug. > > Adds unit tests which verify propagation of messages and channel > events through FIDL/Blink and Blink/FIDL adapter layers. > > Fixes a FIDL flow control bug and adds a regression test for it. > > Add test main.cc for tests which depend on an active Mojo instance. > > Bug: 1117518 > Bug: 1126571 > Change-Id: Ied814298b82f9e5eef1e99b158b45bfdd9d1fd8e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422476 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Sharon Yang <yangsharon@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810858} TBR=ddorwin@chromium.org,rockot@google.com,kmarshall@chromium.org,jochen@chromium.org,yangsharon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1117518 Bug: 1126571 Change-Id: I9b3079ecf0ed21cb6dfd0c467e20ed8dfbb78f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447098Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#813470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0d95b608dab..35539ee2653d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kelvinjiang@google.com Change-Id: I3d9f79ba2747c020d21fa37b6b58341c4b1ae482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445575Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813469}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b33a7186e6ab..a474fbf41353 2020-10-02 hta@webrtc.org Move more functions called only in sdp_offer_answer into that file. 2020-10-02 elrello@microsoft.com Add a test to show that H264FmtpSpsPpsIdrInKeyframe parameter is not present in generated SDP 2020-10-02 marinaciocea@webrtc.org [Sheriff] Revert "Remove MessageHandler[AutoCleanup] dependency from StreamInterface." 2020-10-02 saza@webrtc.org AEC3: Move option for reverb model in nonlinaer mode into AEC3 config 2020-10-02 tommi@webrtc.org Convert LS_VERBOSE and LS_INFO logs in OpenSSLStreamAdapter to DLOG 2020-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7d9183ce..d4fe6f2b (813111:813271) 2020-10-02 sprang@webrtc.org Cleans up code related to early loss detection flag. 2020-10-02 sprang@webrtc.org Adds field trial to set per-layer speed for libvpx vp9. 2020-10-02 philipel@webrtc.org Set processing time according to the decode time if provided by the decoder. 2020-10-02 terelius@webrtc.org Add method to extract triage alerts from RTC event log analyzer. 2020-10-02 olka@webrtc.org Async audio processing API 2020-10-02 tommi@webrtc.org Remove MessageHandler[AutoCleanup] dependency from StreamInterface. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6e72cf641f0dabea974068c098dbbba3c30f1e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445581Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813468}
-
Kelvin Jiang authored
This CL disables ChromeTracingDelegateBrowserTestOnStartup.StartupTracingThrottle as it is failing on multiple mac builders. Bug: 1134793 TBR: eseckler@chromium.org Change-Id: I72f1702bdb5613d4c86f71adb0c66283ccdb3ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446994 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#813467}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b50b7c41123..1f8d793e3bb0 2020-10-02 treehugger-gerrit@google.com Merge "ui: Bump state version for metrics changes" 2020-10-02 treehugger-gerrit@google.com Merge "Reduce max frame count." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I80d119026b62f88ab40f90f1af977f6903f45540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445578Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813466}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I772e77a3e666847c1450f614e9fb54c7fd9ba439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446250Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813465}
-
Jesse Schettler authored
When a scanner reports no source options, lorgnette reports a default source type in the scanner capabilities. Update the scan app to support this default source type. Bug: 1059779 Change-Id: Ib666ea8199404666291b5e8ae9fb43601c3c4774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443532Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#813464}
-
Regan Hsu authored
The controller sets the MutablePhoneModel using info observed from the the provider class. The provider get browser tab info via SyncedSession (available via SessionService) with a |session_name| that matches the |pii_free_name| of the phone provided by a MultiDeviceSetupClient. If sync is enabled, the class uses a BrowserTabsMetadataFetcher to actually fetch the browser tab metadata once it finds the correct SyncedSession. This CL also replaces FaviconService with HistoryUiFaviconRequestHandler because FaviconService often fails at fetching the favicon. HistoryUiFaviconRequestHandler, from manual testing, has always succeeded. This is because HistoryUiFaviconRequestHandler fetches favicons from google servers instead of the endpoint directly. If it can't find one on google server, it fetches the favicon from the url and caches it on the server. Bug: 1106937 Change-Id: Id2f4949b344d7685a814b7635d2f7986117d10ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427297 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#813463}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f38f24c7..8ae7ae8f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4df876281d6f3fbf346db389c0c0f021e5255d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446970Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813462}
-
Michael Hansen authored
When generating a default device name for Nearby Share, we include the user's given name. If the name is very long, the generated device name will overflow the maximum allowed length. In this case we will truncate the user's given name, for example "Mic...'s Chromebook". Bug: b:169452700 Change-Id: I948e0b7a37ca0e8e7381e19165087ab0a9fc85c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446429 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#813461}
-
Gordon Seto authored
Remove RoutingPrefix property from IPConfigUIProperties and add netmask, update network settings UI text from 'Routing Prefix' to 'Subnet Mask'. Screenshots: Before: https://screenshot.googleplex.com/5Tc47C33Hpkx76Q.png After: https://screenshot.googleplex.com/8LNYKXVqGNpZq4L.png Bug: 1100296 Change-Id: Ib7155a71bd2cc24261a9f4d493162bd9fd0aecd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443401 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#813460}
-
Connie Wan authored
First CL in a series that introduces the Tab Groups extension API. These additions to the Tabs API are standalone and allow extensions to add/remove tabs from groups. There is not yet support for querying or updating group metadata, which will be supported in the Tab Groups API (see child CLs). Bug: 1106846 Change-Id: Ie244b75bc71a6030e22c3a9b931d9aedff7a1003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414921 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#813459}
-
Wei Li authored
Allow ToolbarButton to have metadata and builder support. Also add support for gfx::Insets in type conversions. Bug: 1130078 Change-Id: Ib98aede08866dc0bf88ddab1a3c0a70de3959685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436514 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#813458}
-
Reilly Grant authored
The DCHECK in serial_port_manager_impl.cc:97 is reachable if the kEnableBluetoothSerialPortProfileInSerialApi flag is disabled or GetDevices() is not called first and an unrecognized token is passed to GetPort(). This change adds a check for the flag and initializes the Bluetooth enumerator as necessary. Bug: 1043300 Change-Id: Ib38e297f61cbc86bb9ab567084919a9e268196e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446846 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#813457}
-
Josh Simmons authored
These tests were failing on networkless phones in lab. We should probably figure out how to mock out the translate service for these, but for now this is a step in the right direction. Bug: 1130712 Bug: 1127786 Change-Id: Ifd7cb1176ae9beb89c1f44268af9c0add9f29a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446894 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#813456}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a6ca9757d3a6..09b9eade20d3 2020-10-02 johnstiles@google.com Rename BlendOverlap to BlendOverlay. 2020-10-02 brianosman@google.com Revert "moved SkSL Field data into IRNode" 2020-10-02 ethannicholas@google.com moved SkSL Field data into IRNode 2020-10-02 ethannicholas@google.com fix SkSL dehydration 2020-10-02 johnstiles@google.com Fix indenting on InlineCandidateAnalyzer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I326c38267062d9fd8ef4b1d4a28c7f9f30d5402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813455}
-
Yuly Novikov authored
No longer needed. TBR=bsheedy Bug: 1132963 Change-Id: Ic71eaf030bff5e7b821e6ce24a511d6cce4d2c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446354Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#813454}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3048829bb6b8..2c28e29e9c92 2020-10-02 jalyn@microsoft.com Sources: Don't scroll to top of threads on click If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128826 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia10e50dc11608411fc88aea67d39af1714bd598e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447070Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813453}
-
Andrey Kosyakov authored
Bug: 1090988 Change-Id: I59d49a006d61c948a507633cbb4ed965ec2d11b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447092Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#813452}
-
Wei Li authored
Other than BaseScrollBarButton, other subclasses of Button class in views/ should follow Button's default focus behavior. BaseScrollBarButton should not be focusable, nor accessible for accessibility. Set these default values explicitly so changing Button class's default won't affect them. Bug: 1001103 Change-Id: If32d8dadf69a5ba5f8d23738678e31d285d3e5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429435 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#813451}
-
Jesse Schettler authored
The progress_callback is already nullable, so it doesn't need to be wrapped with base::Optional. Bug: None Change-Id: Ifb43c88ab59b2ec0208225359b11070407fc5912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442571Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#813450}
-
Xiaoling Bao authored
Original algorithm: choose the active policy provider with the highest priority and apply all policies from it. Updated algorithm: for each policy, find the highest priority provider that has defined value, and returns that policy. Bug: 1134303 Change-Id: I3461f476e5404f97a08a6a83f57346804e84e678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443541Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Cr-Commit-Position: refs/heads/master@{#813449}
-
Peter Boström authored
This lets dialogs that don't need to store state inside a DialogModel avoid instantiating (and subclassing) a DialogModelDelegate. DialogModel::Builder::model() is added to permit accessing a pointer to the model before it's been built so that it can be bound to callbacks. This change removes DialogModelDelegate use from WindowNamePrompt and OutdatedUpgradeBubbleView. Bug: 1106422 Change-Id: I66119536ae30e8d7a6a3232bea265b57cb8c9346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442500Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#813448}
-
James Vecore authored
We don't support caching share targets so this code removes an attempt to keep cached targets around which causes duplicates to show up in the ui. Fixed: 1133824 Change-Id: I3162cfffae59ca638b2b21e5f9adf6d4a2cc21a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446845 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#813447}
-
George Burgess IV authored
These existed in the ebuild before for no particular reason. Having them sitting in Chrome seems more theoretically good, and fixes a small bug with some of our simplechrome builders (they weren't picking up the =20 or =30 limits properly, so they were doing =100...) Bug: 937821 Change-Id: I3f89354d377de2e4db7c1b11b644b07867d3b66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446818 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#813446}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/16636f480f81..b3c1e71eb1cb 2020-10-02 nicolascapens@google.com Regres: List regressions before summary If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4e28912a9d5510bbc5d35060f7077b3c0d0e38e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445811Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813445}
-
Haiyang Pan authored
the device usage looks in a good shape and should be able to run at 100%. See the capacity graph http://shortn/_mMR3m6J0Dr Also have weblayer_instrumentation_test_apk running on sailfish since the grash shows walleye capacity could be tight during peak time, while sailfish still has plenty room to hold more test. Bug: 1111436 Change-Id: I7fb68d6a6710a3d2c68fef3f6e54e23af433d2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446513Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#813444}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If2c7e6aa62ced283dc88b1ed79f24d74ea8a8439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813443}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9b8970cc0198..3b50b7c41123 2020-10-02 treehugger-gerrit@google.com Merge "Optimize the scroll_jank_cause_queuing_delay metric." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If61bf5f9f0e2c1f5b2c7c4263b730901ec844b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446911Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#813442}
-