- 18 Sep, 2019 40 commits
-
-
Austin Eng authored
Mapped buffers may still hold onto shared memory when the page is torn down. We first need to destroy all API objects, and then ensure that any shared memory allocations are freed. Bug: chromium:1005284 Change-Id: Ie080e4a26e2b572988a7d219ba0aed2dc61cdc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811345Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#697796}
-
Jeroen Dhollander authored
This allows us adding unittests to AssistantManagerServiceImpl. This has been done by moving most accessors in a |ServiceContext| object. I also moved a call to |EnableHotword| from |AssistantManagerServiceImpl| to |Service|, and I introduced a new |AssistantCommunicationErrorObserver| so the |Service| now knows about communication failures when communicating with libassistant (and can request a new authentication token when required). Finally I replaced all calls to the singletons |CrasAudioHandler::Get()| and |PowerManagerClient::Get()| with method calls on the |ServiceContext| object. This again should make it easier to unittest things, as it makes it easier to spot the fact that a lot of classes use these objects. Change-Id: Icc1cbbe02b771c59785204bd43cd6a8d3672b748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802030 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#697795}
-
Lukasz Anforowicz authored
Before this CL, ExtensionNavigationThrottle would more-or-less ignore main frame navigations (except for special-casing some GuestView scenarios). This allowed some undesirable navigations as pointed out in https://crbug.com/442579. After this CL the throttle continues with WebAccessibleResources checks even for main frames. Before this CL, ExtensionNavigationThrottle would check if the target is one of WebAccessibleResources iff the frame being navigated has an ancestor that has a different origin than the target of the navigation. This doesn't work for main frames (which have no parent). This could be addressed by also going over opener relationship, but the right fix here is to directly consider |initiator_origin| (which is trustworthy and browser-verified). After this CL, |initiator_origin| is considered. Applying the throttle checks to more navigations means that the throttle has to replicate some exceptions from ChromeContentBrowserClientExtensionsPart::ShouldAllowOpenURL. Specifically, the throttle needs to ignore navigations ignored by origins with chrome://, chrome-search:// and devtools:// schemes. Additionally the changes mean that opaque origins (even if they have been derived from an extension origin) cannot navigate to non-WebAccessibleResources. This requires tweaking the sandboxed_pages_csp test. Bug: 442579 Change-Id: Iebc72b05fece9d0936214f5f8e00802b59e84fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776854 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#697794}
-
Jan Wilken Dörrie authored
This change renames base::CheckedRandomAccess(Const)Iterator to base::CheckedContiguous(Const)Iterator. This change is motivated by the fact that this iterator not only fulfils the requirements of RandomAccessIterator [1], but also ContiguousIterator [2]. Furthermore, the implementation of the iterator assumes it is pointing into a single contiguous array, and thus is unsuitable for containers that have random access, but don't operate on an underlying array, such as std::deque. [1] https://en.cppreference.com/w/cpp/named_req/RandomAccessIterator [2] https://en.cppreference.com/w/cpp/named_req/ContiguousIterator Bug: 817982 Change-Id: I7186dfc3b2849818b9f83d62e05ebc5a79aaf5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811377 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697793}
-
Tao Bai authored
In debug build, there is assert to verify the expected callback is larger than zero, so the previous test won't work. This patch simulates user triggering autofill and verifies autofill is triggered once, that proves javascript change didn't trigger the autofill. Bug: 1001309 Change-Id: I2cb9e384f14e98cee9380ccef51b3cc8b8bbc2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802683 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697792}
-
Sunny Sachanandani authored
Animating infobars during startup is speculated to cause regressions and noise in rendering benchmarks. This CL disables animations for bad flag and automation infobars by allowing the InfoBarDelegate to control if the infobar animates or not. Bug: 804324 Change-Id: I2c1067e122cf031ab151a1f51d9d11bc6bac60e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808297Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#697791}
-
Nathan Zabriskie authored
This CL adds SwapTimings to FrameTimingDetails which is sent to Viz clients on each begin frame. The information in SwapTimings will be used in a future CL to add viz-stage histograms to CompositorFrameReporter. Bug: 963787, 963780 Change-Id: I6df2d9654d54e7ef5772e32e6b8a95cd741d485c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764515 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697790}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e70432574670..017dfff534a5 git log e70432574670..017dfff534a5 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 chrisforbes@google.com Implement alpha blend support for VK_FORMAT_A2B10G10R10_UNORM_PACK32 Created with: gclient setdep -r src/third_party/swiftshader@017dfff534a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ida810f3d27bbde13e22c1eac99a09fa27b3344da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811296Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697789}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e34564bafe83..db09eb68b9de git log e34564bafe83..db09eb68b9de --date=short --no-merges --format='%ad %ae %s' 2019-09-18 amaiorano@google.com Increase the max fence wait time in debug builds Created with: gclient setdep -r src/third_party/angle@db09eb68b9de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I840aad49c3854ed9158a579578efa40059db4978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811327Reviewed-by:
-
Juanmi Huertas authored
When we transferToImageBitmap and we do a flush in the Snapshot, it can be that the skImage was null due to some issue. We are adding a new check to ensure that we are not returning a null skImage contained in a valid imagebitmap. Bug: 980057 Change-Id: I91e6b1688ec54b6029bcdd051db3d045421786cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811157Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#697787}
-
Yuly Novikov authored
Since they currently run the same OS version as the Release bots. TBR=kbr Bug: 1005378 Change-Id: I20fc3b846c4e1622a48207aca732cc539d1d607d No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809991 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
-
danakj authored
Make Init() private, add an InitForPepperFullscreen() and InitForMainFrame() that RenderWidgetFullscreenPepper and RenderViewImpl and RenderFrameImpl make use of. Now every callsite declares its intentions. Remove comments about RenderWidget being self-referencing, it is not ref counted any longer. Use render_widget_ instead of GetWidget() in RenderViewImpl. It is the same thing but it makes code more clear about where it is ending up. Especially interesting is the lines: RenderWidget* closing_widget = render_widget_.get(); closing_widget->Close(std::move(render_widget_)); Some cleanups in the RenderWidgetFullscreenPepper code around construction and use of the new RenderWidget Init api. And also in RenderFrameImpl. R=avi@chromium.org Bug: 419087 Change-Id: Ifa1bc6b63d57b557ea14a21cb45e5b42cb903df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811519 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697785}
-
Stephen Martinis authored
This fix seems to have worked for //build/config/ios/codesign.py. Try applying this fix to plist_util.py. See bug for more details. Bug: 1005190 Change-Id: I0858a521ae5027f9d2c09a25f32961490dcd9eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809893Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#697784}
-
John Abd-El-Malek authored
Change-Id: Ifa1b255302e05ca9ee01fdce39e707d6af2deb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811965 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#697783}
-
Andrew Grieve authored
Bug: 1000763, 1005230 Change-Id: Iec51aec1348b96c156cb4689b06c26e445cf3b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811644 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697782}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cbc960899a68..6a17fd7fb73b git log cbc960899a68..6a17fd7fb73b --date=short --no-merges --format='%ad %ae %s' 2019-09-18 rmhasan@google.com [Typ] Raise ValueError from setters when tag validation is enabled Created with: gclient setdep -r src/third_party/catapult@6a17fd7fb73b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:999335 Change-Id: I5a31a873eaff7535e17aa8a88f7d90beaa2ae3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811558Reviewed-by:
-
Clark DuVall authored
M77 has a lot of these reports, and that should be enough to debug for now. Bug: 934317 Change-Id: I3625a60bc39bf0de27e1fd653ae61dbe04333de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811518Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#697780}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/377dbef2b5ab..1070231232ce Created with: gclient setdep -r src-internal@1070231232ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1000513,chromium:None,chromium:None Change-Id: I8a9cd90486ae8b1620bd18be8a82ed99d9809873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811293Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697779}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56f9ee6b49fc..7c1b59b7b8a9 git log 56f9ee6b49fc..7c1b59b7b8a9 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 abodnar@google.com Merge "Populate gpu_slices table with render_stage" 2019-09-18 treehugger-gerrit@google.com Merge "Fix various typos" Created with: gclient setdep -r src/third_party/perfetto@7c1b59b7b8a9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibcc017b4e33a6cf1df6d061ce665deb1141013da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811294Reviewed-by:
-
danakj authored
R=avi@chromium.org Bug: 998273 Change-Id: I0337d4bbb76301546b9b0abda630ef023d696e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790464Reviewed-by:
-
Antonio Gomes authored
... by calling PeerConnectionDependencyFactory::GetWebRtcAudioDevice() directly. It is now possible, after PeerConnectionDependencyFactory Onion soup'ing [1]. [1] https://crrev.com/c/1805159 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ib6089c98a31b91ce47edccba17a8a6e0355e08e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807155 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#697776}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4599045c795c..d91e95a64c1b git log 4599045c795c..d91e95a64c1b --date=short --no-merges --format='%ad %ae %s' 2019-09-18 saklein@chromium.org ArtifactsService: Add image archives endpoint. Created with: gclient setdep -r src/third_party/chromite@d91e95a64c1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2e7555c6a754a56859ca1b2080d0ddf7a1a11a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810824Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3f79763629b4..8baaec47e3bd git log 3f79763629b4..8baaec47e3bd --date=short --no-merges --format='%ad %ae %s' 2019-09-18 vapier@chromium.org repo: pull in updates from latest release 2019-09-18 ehmaldonado@chromium.org Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" Created with: gclient setdep -r src/third_party/depot_tools@8baaec47e3bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:None,chromium:1002153 Change-Id: Idd8e153fe49050a8984d01065e3cae807e22dc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811295Reviewed-by:
-
Toni Barzic authored
If the folder height is reduced too much, the page switcher icons get cut off, and misplaced. It's safer to just keep the original folder heaser size, as scaling it down does not get too much of the height back. BUG=1004705, 1004706 Change-Id: I63e65e2d9badaf4eb4b9932ad48187f9f3e13c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810331Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#697773}
-
Caroline Rising authored
Bug: 984115 Change-Id: I27b7ad2a4760018d31eda10cc247289ad42003d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811292Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#697772}
-
Dana Fried authored
This is one of several potential accessibility fixes being explored for making the active tab more prominent in dark/incognito mode. Currently, there is insufficient contrast between tab and background. Put it behind a flag so that UX and a11y team can mix and match and compare side-by-side. Bug: 1004871 Change-Id: I20cee31c83ad6b535d5f9e2b6146fcff62acb4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810021Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#697771}
-
Andrew Grieve authored
This was causing some changes that reduce size to show as increasing normalized size (and vice versa). Binary-Size: Metrics change Bug: 979205 Change-Id: I90219b7cf454f91dc64474c07caaf0ca0edcbf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811517 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL deletes histogram Download.Service.Finish.ReportedHash. Over 99% of background downloads have hash, it's not very actionable. Bug: 995485 Change-Id: I1176f5d37d608e99eba0acf8fdfa50ea938d5569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803880Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697769}
-
danakj authored
This reverts commit 55474752. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Move page zoom level responsibility into RenderViewImpl." > > This reverts commit 6876fb4f. > > Reason for revert: Breaks layout tests even though they passed in the CQ??? > > Linux: > animations/animationworklet/worklet-animation-responsive-to-zoom.html > svg/as-image/img-zoom-svg-stylesheet.html > fast/media/mq-width-pagezoom.html > > Windows: > animations/responsive/zoom-responsive-translate-animation.html > fast/media/mq-resolution-pagezoom.html > fast/backgrounds/tiny-tile-zoomed.html > > animations/animationworklet/worklet-animation-responsive-to-zoom.html > svg/as-image/img-zoom-svg-stylesheet.html > fast/media/mq-resolution-pagezoom.html > > > Original change's description: > > Move page zoom level responsibility into RenderViewImpl. > > > > Page zoom level is a page/view concept, but the code to manage it is > > currently in RenderFrameImpl, though only run when it is the root frame. > > > > This doesn't dramatically change ownership of responsibility but moves > > the code up into RenderViewImpl. RenderWidget still goes through > > RenderFrameImpl (though more explicitly) to set the zoom level on the > > RenderView. And RenderWidget takes responsibility for closing the page > > popup instead of having multiple "set page zoom" methods on > > RenderViewImpl. > > > > This uncovered some spooky action-at-a-distance and makes it more > > explicit and documented, though no less unfortunate. A local root > > LocalFrame does not initialize with the correct page zoom value because > > it has no parent to read it from. We (accidentally?) worked around that > > by setting the RenderView's page zoom to its current value when > > navigating a (new) LocalFrame, which would call into blink's WebView > > and walk through the entire frame tree setting the value on everything, > > eventually also on the new LocalFrame. > > > > Now on navigation, for a local root, we call RenderWidget's > > UpdateWebViewWithDeviceScaleFactor() which does the same thing by > > re-setting the WebView's page zoom factor. This was done when making > > a new main frame in multiple places (RenderView and RenderFrame both > > called it in the same CreateFrame() callstack). Now it is consolidated > > to a single place on navigation for the main frame and child frames > > giving them more consistent behaviour, and going explicitly through > > this method that should go away if things were well designed, rather > > than re-setting the RenderView to its own value. > > > > Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered > > throughout RenderViewImpl and RenderFrameImpl. What we need is for > > 1) The Page to be updated with PreferCompositingToLCDText when the > > device scale factor changes. > > 2) The WebView to be updated when the device scale factor changes. > > 3) The LocalFrame of a local root needs its page zoom set by poking > > the WebViewImpl to walk through all frames and set it. > > > > R=erikchen@chromium.org > > > > Bug: 419087 > > Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: danakj <danakj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#697687} > > R=avi@chromium.org, dcheng@chromium.org, erikchen@chromium.org > TBR=danakj@chromium.org > > Change-Id: I3177d7f7a601b6692fd931623ca749bacce051c9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 419087 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811937 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697766} TBR=avi@chromium.org,danakj@chromium.org,dcheng@chromium.org,erikchen@chromium.org Change-Id: I58e9fa630128b60e67decc0ba62e72aae7981675 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811861Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697768}
-
Andrew Grieve authored
The two pages are independent, and it's confusing that they shared CSS. Bug: 1001775 Change-Id: I3999e7e641650c98af2246c16b8199829696187d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810770Reviewed-by:
-
danakj authored
This reverts commit 6876fb4f. Reason for revert: Breaks layout tests even though they passed in the CQ??? Linux: animations/animationworklet/worklet-animation-responsive-to-zoom.html svg/as-image/img-zoom-svg-stylesheet.html fast/media/mq-width-pagezoom.html Windows: animations/responsive/zoom-responsive-translate-animation.html fast/media/mq-resolution-pagezoom.html fast/backgrounds/tiny-tile-zoomed.html animations/animationworklet/worklet-animation-responsive-to-zoom.html svg/as-image/img-zoom-svg-stylesheet.html fast/media/mq-resolution-pagezoom.html Original change's description: > Move page zoom level responsibility into RenderViewImpl. > > Page zoom level is a page/view concept, but the code to manage it is > currently in RenderFrameImpl, though only run when it is the root frame. > > This doesn't dramatically change ownership of responsibility but moves > the code up into RenderViewImpl. RenderWidget still goes through > RenderFrameImpl (though more explicitly) to set the zoom level on the > RenderView. And RenderWidget takes responsibility for closing the page > popup instead of having multiple "set page zoom" methods on > RenderViewImpl. > > This uncovered some spooky action-at-a-distance and makes it more > explicit and documented, though no less unfortunate. A local root > LocalFrame does not initialize with the correct page zoom value because > it has no parent to read it from. We (accidentally?) worked around that > by setting the RenderView's page zoom to its current value when > navigating a (new) LocalFrame, which would call into blink's WebView > and walk through the entire frame tree setting the value on everything, > eventually also on the new LocalFrame. > > Now on navigation, for a local root, we call RenderWidget's > UpdateWebViewWithDeviceScaleFactor() which does the same thing by > re-setting the WebView's page zoom factor. This was done when making > a new main frame in multiple places (RenderView and RenderFrame both > called it in the same CreateFrame() callstack). Now it is consolidated > to a single place on navigation for the main frame and child frames > giving them more consistent behaviour, and going explicitly through > this method that should go away if things were well designed, rather > than re-setting the RenderView to its own value. > > Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered > throughout RenderViewImpl and RenderFrameImpl. What we need is for > 1) The Page to be updated with PreferCompositingToLCDText when the > device scale factor changes. > 2) The WebView to be updated when the device scale factor changes. > 3) The LocalFrame of a local root needs its page zoom set by poking > the WebViewImpl to walk through all frames and set it. > > R=erikchen@chromium.org > > Bug: 419087 > Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697687} R=avi@chromium.org, dcheng@chromium.org, erikchen@chromium.org TBR=danakj@chromium.org Change-Id: I3177d7f7a601b6692fd931623ca749bacce051c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811937Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8391bac5c6f0..17a3a0bda946 git log 8391bac5c6f0..17a3a0bda946 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 robertphillips@google.com Last tranche of new SkColorTypes 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@17a3a0bda946 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Iea704ae2d3de29ea0b31724aa46d7a2e1bacb421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811463Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
In incognito tabs, stop reporting page visits to Firebase. Also move the reporting to didFirstVisuallyNonEmptyPaint(), which is closer to when the user perceives a page to be visited. Also skip creating the observer altogether on low-end devices as an optimization. Bug: 1004003 Change-Id: I592521ab9ce5894df48f7994de30a255d9280f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805297Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697764}
-
danakj authored
Instead of signaling if the frame is a local root by sending a routing id or not, and then based on that reading the VisualProperties or not, make the whole widget_params structure optional, and only send it when the frame is a local root. Then the VisualProperties are not included in the IPC at all for non-local roots, nor a routing id. This is a followup for https://chromium-review.googlesource.com/c/chromium/src/+/1797385 R=avi@chromium.org, dcheng@chromium.org Bug: 419087 Change-Id: I49b735ec081aae6c4511a475535ce337ce2a5394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809988 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Fernando Serboncini authored
Bug: 988125 Change-Id: I989a74f5b30ccf9d9d4b5d3d00fdd56131dd5df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801226 Auto-Submit: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#697762}
-
K Moon authored
The set_size() method is used externally only for testing at this point, and provides a dangerous API for violating layout invariants. Remove this API now to avoid having to modify it in a later change to add dirty tracking to DocumentLayout. Bug: 885110 Change-Id: Idb03aaad86131b625589ac07c48c9284caaf0919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810237 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#697761}
-
Dana Fried authored
(dfried@ was original author of this file.) Change-Id: Iadb874be902c430b0a4494a33137d3265ad92a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810194Reviewed-by:
-
Xiaoqian Dai authored
In tablet mode, when doing a tab dragging, the dragged window's size is 1/4 of the work area's size. It worked well for big screens, but on smaller screens, the size might be smaller than the window's minimum size. We should take the minimum size into consideration as well. Bug: 1002728 Change-Id: I6a834150015890f7e9eb949b8d724c064474a84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799693 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697759}
-
Robbie McElrath authored
This cuts a dependency from aw.ui.util to aw.services. Test: ninja -C out/aw system_webview_apk Bug: 934152 Change-Id: Ibdf189e79ef71f948591fe14a0de7316d76da27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794027Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#697758}
-
Justin Cohen authored
kRestoreNavigationTime was a timer created by WKBasedNavigationManagerImpl::Restore and stopped when session restoration begins navigating to its final URL. Unfortunately, WKBasedNavigationManagerImpl::Restore is called for every restored WebState on startup. Actual network access doesn't happen until a tab is selected. That means if you have 10 tabs, background/kill/restore, navigate a bit, and then change tabs, that second tab will have had a timer running since the app started. Instead, start kRestoreNavigationTime when ios/web begins loading the restore page, and finish the timer when ios/web begins loading the real page. This should more correctly tell how much time SlimNav restoration adds. Bug: 1005044 Change-Id: I35fee36bb50ec627d7455d6215669a92a2b4bc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808355 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697757}
-
