- 06 Dec, 2019 40 commits
-
-
Joe Downing authored
Change-Id: Ic6a900d974a9f49493dea88238be77ac5324442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954325 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#722530}
-
Rayan Kanso authored
Add OWNERS file for installedapp directories in chrome/android/java. These are the same owners of installedapp in other directories as well. Change-Id: I75e24357d9c878e9009b8d4f370d5db5dade593e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954477Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#722529}
-
Jasper Chapman-Black authored
Previously the WebAssembly web worker assumed that it should render in diff mode if and only if it was passed a |before| to compare against. With .sizediffs, this assumption no longer holds - the WebAssembly worker extracts both .size files from a single field, so we have to tell JavaScript that it's a diff. Change-Id: I972f7eaca9508c87c033b3f78ad169afa70f2ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954194 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722528}
-
Jimmy Gong authored
- This is another step in removing deprecated printer settings code. - This CL removes the feature flag, kCupsPrintersUiOverhaul. Bug: 1005905 Test: browsertests Change-Id: Iac6ba4980478ce5bef2e5724aa3be4eb2c0783ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937653Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#722527}
-
Bin Wu authored
1. Net.QuicSession.ClosedByRtoAtClient.SentPacketCount. 2. Net.QuicSession.ClosedByRtoAtClient.ReceivedPacketCount. Change-Id: Ifc91f3d97758b8f4f3db4c306199e40878665e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954248Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#722526}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1518fd34d888..80bc1acb9c2b git log 1518fd34d888..80bc1acb9c2b --date=short --first-parent --format='%ad %ae %s' 2019-12-06 danilchap@webrtc.org Add implementations of the VideoRtpDepacketizer interface 2019-12-06 orphis@webrtc.org Reland "Add support for RtpEncodingParameters::max_framerate" 2019-12-06 titovartem@webrtc.org Fix: IvfFrameGenerator won't decode frame on release build Created with: gclient setdep -r src/third_party/webrtc@80bc1acb9c2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I521fd606ee3ce38a7e9c99ee931303dc56f7b3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955662Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722525}
-
Nick Diego Yamane authored
crrev.com/c/1771407 moved window closing logic out of DWTHX11 into DWTHPlatform and XWindow and (likely accidentally) lost delayed resize cancellation before dispatching actual window close operation [1]. Present CL adds back such logic, now into XWindow::Hide(), which is called from DWTHPlatform::Close() -> WTH::Hide() -> PlatformWindow/X11Window::Hide(), just before dispatching real DWTH close task. This is a tentative fix for crashes reported at crbug.com/1021490, as it has not been possible to reproduce them locally. [1] https://crrev.com/c/chromium/src/+/1771407/14/ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc#190 Bug: 1021490 Change-Id: Ibee9ad3edd1631901f869f7ebf60bc0d10bc7d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940939Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#722524}
-
Jimmy Gong authored
- This is the first part of removing legacy printer settings code. - Future CL's will iteratively remove each piece of the feature flag and the code gated by it. Bug: 1005905 Test: Ran browsertests + end to end manual Change-Id: I4e4680e7eb2dcd08d03f69538fc09331b3f39a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935152Reviewed-by:
-
Mark Mentovai authored
31470459b624 Fix line endings on files introduced in 359fc4a1336d Change-Id: Ifdcc53168584ccaaaa645bfbd2f2a86311906cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954252Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#722522}
-
Patrick Monette authored
Now that there's longer any experiments with shutdown hangs, this CL removes the feature flag and defaults the background task runners of the incident reporting service to CONTINUE_ON_SHUTDOWN Bug: 478209 Change-Id: Iec41d087911fadf518d4537da942ed7939b1aa11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954196Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#722521}
-
Chris Lu authored
Bug: 1014959 Change-Id: I1272d6475984716e3b7be14624bd617a5a17410a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946059 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722520}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f9c33d61a661..de3a9d11f377 git log f9c33d61a661..de3a9d11f377 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@de3a9d11f377 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2505eb01a14c6ecfdbf45928ef119d0edd69a683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955473Reviewed-by:
-
Vladislav Kuzkokov authored
Avoid generation on platforms that don't use it. Bug: 964919 Change-Id: Iacba48977c6f9eb089f41dd5409e33f1fad222e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954013Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#722518}
-
Sophie Chang authored
Change-Id: I0e82e38ed2782f6998971b3ce5291193ccd36983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954406Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722517}
-
Thomas Lukaszewicz authored
Removed hard-coded color references for the overlay scrollbar and added the relevant color ids. Added appropriate selectors for gtk native theme. Bug: 1003612 Change-Id: I5c7a8354a151249e2fc5e2a52244c441a15979fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950861Reviewed-by:
-
Sammie Quon authored
This can be triggered if screen is rotated while in overview. Overview will handle resetting paint blur itself when it is exited. Test: manual Bug: 1016267 Change-Id: I004083270a7f99a9b61913295367616da3a6d14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952083Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#722515}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d45b969a0906..c87235c08e05 Created with: gclient setdep -r src-internal@c87235c08e05 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2a2536c301238dbf16e4160ae2802d8123eddd57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722514}
-
meacer authored
Change-Id: Icdc8ce22ae2ae017a11e8ccf2de64feedac456b7 Bug: 1014711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953231Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#722513}
-
Markus Handell authored
Our WebmMuxer doesn't support changing saved format mid-track. This change causes calls to MediaRecorder OnError which emits an event and causes recording to stop. Bug: 1013590 Change-Id: If1dd020dc61980feff33883a4967ac24fc0e0255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893856Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#722512}
-
James Cook authored
Chrome OS SplitSettingsSync has a separate control for syncing OS data types that isn't controlled by the browser's sync-the-feature. Change ModelType::OS_PREFERENCE and OS_PRIORITY_PREFERENCE to run when the transport layer is enabled. They already are controlled by a separate consent flow in OOBE via pref kOsSyncFeatureEnabled. Introduce a temporary base::Feature to disable sync AUTO_START on Chrome OS so that this feature can be tested manually. For example, you can run --enable-features=SplitSettingsSync,SyncManualStartChromeOS and check chrome://sync-internals to see what types are syncing. Bug: 1013466 Test: added to sync_integration_tests Change-Id: I76720c2277781d073e100ac6d9ee935867be8868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951577 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#722511}
-
Kramer Ge authored
To prevent confusion whether delta can be negative. Change-Id: I6c2f3fc31347c0a0af55fb2b9d91ab364d56370c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954319 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722510}
-
W. James MacLean authored
This CL continues removing deprecated BrowserPlugin code. Bug: 533069 Change-Id: Id81d316a7ac7df7270db84e69b2304f559c9d6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951324 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#722509}
-
Torne (Richard Coles) authored
Add an activity to the shell to launch WebView in a second process, separate to the main process used by the shell, to enable manual testing of the support for using WebView from multiple processes at once with WebView.setDataDirectorySuffix. Change-Id: Id97ce8cc9ef4fc38a7cefc90128645d1deeca5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953385 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#722508}
-
Peng Huang authored
Bug: None Change-Id: I40b36e01f42da2dd0e21d5395155073feb356355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955659 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#722507}
-
Nate Chapin authored
ScriptRunner has special cases in Document to allow it to pause/unpause, but ContextLifecycleStateObserver is the standard way to pause/unpause. Bug: 1029822 Change-Id: Ie8b5e427e6a217ba6a1aad9af7a286ce22444918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949225Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#722506}
-
Mihai Sardarescu authored
Bug: 1028182 Change-Id: I6222333fddbc96cc81b7e53445c9dcefa53cd1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954472 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#722505}
-
Nektarios Paisios authored
In crrev.com/c/1930061 the accessibility focus event in TableView was tweaked so that it would always fire after the accessibility information had been updated. However, there are instances when the accessibility information is updated more than one time. We need to fire the focus event after paint, to ensure that the accessibility tree has become stable and won't update right away again. The order of the problematic operations are: 1. The Task Manager refreshes its contents at a constant interval. OnItemsChanged is called which calls SortItemsAndUpdateMapping and which in turn calls UpdateVirtualAccessibilityChildren. This would update the accessibility focus as well. 2. OnPaint is called and in some cases, whenever the contents of the Task Manager are sorted, SortItemsAndUpdateMapping would also be called, which updates the virtual accessibility children a second time without updating the focus, since the focus had already been updated. R=sky@chromium.org, dmazzoni@chromium.org Bug: 811277 Change-Id: Ifbf8a6908f3411030912f30981aa3c22f1874f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946691 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
The PlatformFontWin is deprecated and was replaced by the usage of PlatformFontSkia on Windows. The feature PlatformFontSkiaOnWindows is activated by default. This CL is removing the feature and the code. Bug: 944227 Change-Id: I644321594b4ef6f33e29dfbc36d507d0c695a1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924979 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#722503}
-
Oleh Lamzin authored
Fix typo in GetNetworkService() comment, typo in the phrase `don't want to want to start`. BUG=none TEST=none Change-Id: I7448ab0d565ec53e31f883a717b1a8282e43899b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954014Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#722502}
-
Aaron Gable authored
This reverts commit ebc60412. Reason for revert: Broke compile on iOS https://ci.chromium.org/p/chromium/builders/ci/ios-device/143201 Original change's description: > [omnibox] Fix ZeroSuggestProvider duplicate classifications bug > > The below CL introduces a bug, where ZeroSuggestProvider can create > a match with duplicate text classifications. This triggers a DCHECK > as described in the linked bug. > > https://chromium-review.googlesource.com/c/chromium/src/+/1947765 > > This CL fixes it and adds a test. > > Bug: 1030741 > Change-Id: If59fbd320d720e2a7ff8d2f66d9ee92e11bb9a68 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951557 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#722497} TBR=tommycli@chromium.org,manukh@chromium.org Change-Id: Idba8826447487022b4149a310bdb67e8ae560268 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954941Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#722501}
-
Dave Tapuska authored
http://crrev.com/ece078e2 attempted to clean up some SameOrigin checks and it was discovered that WebFrameTest.NavigateRemoteToLocalWithOpener was creating an invalid state where the Remote Frame's opener was set after creation time which caused the WindowAgentFactory to be different. Expose the opener parameter for RemoteFrame in FrameTestHelpers much like it is done for LocalFrames. BUG=1031480 Change-Id: Iacb3b34489999bb855064490d9448cafe22da1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955654Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#722500}
-
Garrett Beaty authored
The builders should be in a good state at the creation of the beta branch, so the builders that have already been configured for branches will be fully enabled for the beta branch. Change-Id: I73e12a7123d3411e552667bbd02f19c8fb5e79a4 Bug: 1024637, 1024641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953201Reviewed-by:
-
Liquan (Max) Gu authored
Context: This is regarding the Bottom-sheet Payment Handler UI. In slow connection, the toolbar on the UI appears empty and shows no indicator of the current loading status, hardly distinguishing from a state of freezing. Old behavior: upon opening the PaymentHandlerUI, its toolbar shows nothing but the payment app's url. Change: set the minimum loading progress to be 5%. Apply it to the initialization and the progress update. New behavior: upon opening the PaymentHandlerUI, its toolbar shows the payment app's url as well as a progress bar starting from at least 5%, which reassures users that the UI is busy loading the page. Bug: 1029815 Change-Id: I05147c15e9c732c75a039c9c20fd021382ec8a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951649Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#722498}
-
Tommy Li authored
The below CL introduces a bug, where ZeroSuggestProvider can create a match with duplicate text classifications. This triggers a DCHECK as described in the linked bug. https://chromium-review.googlesource.com/c/chromium/src/+/1947765 This CL fixes it and adds a test. Bug: 1030741 Change-Id: If59fbd320d720e2a7ff8d2f66d9ee92e11bb9a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951557 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#722497}
-
Martin Robinson authored
Trusty comes with a version of ATK that does not support the checkable attribute, so we must specifically deny this in the test. A followup change will make this global in order to avoid having to add it to many tests. Original commit message: > Users of ATs on AuraLinux use the default action to know whether or not > to activate nodes via the keyboard or a simulated mouse event. When a > node with a button role cannot receive keyboard focus, have the default > action be click. This heuristic helps ensure that when there is an ARIA > button that cannot be activated via the keyboard, users know to simulate > a mouse click. Bug: 1025264 Change-Id: Ib8e66b369e30c771ce8533de24050f99e32ab579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953709Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee780985a9cd..97228c73dff9 git log ee780985a9cd..97228c73dff9 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 treehugger-gerrit@google.com Merge "Fix process metadata query to avoid empty Package" 2019-12-06 treehugger-gerrit@google.com Merge "Add unique session name to log" Created with: gclient setdep -r src/third_party/perfetto@97228c73dff9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I29d00e65748cce0ff83b3a650b753812684d6be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955653Reviewed-by:
-
Omer Katz authored
When deleting an entry is a hash table which is garbage collected, the entry is zeroed out (so that stale values won't be traced). However, An entry might be deleted while it is being traced. To avoid a data race in such cases, during tracing garbage collected objects should be atomically set to zero size_t by size_t (if the size of the entry is not a multiple of sizeof(size_t), the remainder of entry can be zeroed using memset as it is guaranteed not to hold a pointer). Bug: 986235 Change-Id: Id1a6d2fd82fcc31a18caf13764a3488e57b23177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949466 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Dominic Battre authored
This CL restores the communication of Chrome on iOS with the Autofill server. It broke by commit fc59bb21 which assigned trusted_params to the network request. However, the URLLoaderFactory originated from BrowserState and was therefore shared and not trusted. As per the documentaiton of trusted_params: "Setting these from an untrusted URLLoader will cause the request to fail." This CL removes the trusted_params to bring Autofill back to a working situation. Maybe the iOS or network stack folks can see whether we want to have special URLLoaderFactories for components on iOS. I don't see a precedence for that. Bug: 1031136 Change-Id: Ic2e04f37f3a30e8adb98e23f19205be09fa5375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953707Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#722493}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ia2a516c7c0ab06e8e8c7cce9e2c4d8b75d24914f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955162Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722492}
-
Elly Fong-Jones authored
This change removes overrides of DialogDelegate::GetDialogButtons and DialogDelegate::GetDialogButtonLabel from CrostiniAnsibleSoftwareConfigView in favor of the new setters for these properties. Bug: 1011446 Change-Id: Id1b90b7b62719562138db8c1eddbb53a63cb07ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954665Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#722491}
-
