- 15 Aug, 2018 40 commits
- 
- 
Matt Reynolds authoredUnder normal circumstances, gamepad state can only change in response to certain triggers. By using the gamepadController test API, the gamepad state may be changed in response to many more triggers, including gamepad events themselves, which may cause some events to not be dispatched. This CL modifies the layout test to only change gamepad state outside of gamepad event listeners. This CL also removes a hack where the string representation of the gamepad state was being compared instead of the underlying buffers. This hack was intended as a workaround for a bug caused by incorrect buffer reuse behavior. The bug still exists but the test is modified to test the reuse behavior as intended. BUG=855760 Change-Id: I75144ae68efa355992d03692e2fd52b2f832281f Reviewed-on: https://chromium-review.googlesource.com/1173329 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583428} 
- 
Chris Hamilton authoredThese histograms are currently empty due to (a) incorrect reporting or (b) lack of reporting. Change-Id: Ia19b49a713fc59e57f10cdfa1d5344e39c63ee2e Reviewed-on: https://chromium-review.googlesource.com/1173325 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#583427} 
- 
edchin authoredBug: 870145 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I56a5bb19f366ce570ca058f85853a35df472b4cf Reviewed-on: https://chromium-review.googlesource.com/1176221Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583426} 
- 
Sidney San Martín authoredThis change uses an undocumented interface to the Mac SMC (System Management Controller) to read power consumption by different parts of the computer, including CPU and GPU(s). These web pages and projects were all helpful, or critical, in writing it and checking assumptions: - https://opensource.apple.com/source/PowerManagement/PowerManagement-271.1.1/pmconfigd/PrivateLib.c.auto.html - https://opensource.apple.com/source/IOKitUser/IOKitUser-647.6/pwr_mgt.subproj/IOPMLibPrivate.c - https://web.archive.org/web/20140816041243/http://www.parhelia.ch/blog/statics/k3_keys.html - https://stackoverflow.com/questions/28568775/description-for-apples-smc-keys - https://github.com/theopolis/smc-fuzzer - https://github.com/beltex/SMCKit/ - https://github.com/hholtmann/smcFanControl/ - https://github.com/Chris911/iStats - https://github.com/RehabMan/OS-X-FakeSMC-kozlek/ - https://www.virtualbox.org/svn/vbox/trunk/src/VBox/Devices/EFI/VBoxSmcUtil-darwin.cpp Bug: 871801 Change-Id: I4dcd8e06b7506743e9c5e7514c7f6f9c8f2b3205 Reviewed-on: https://chromium-review.googlesource.com/1165314 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#583425} 
- 
Robert Ogden authoredLoads the original page on a 404 or 503 server response. Further actions for these response types will be in follow up CLs. Bug: 864656 Change-Id: I861685e0d19f5597ade3ed814e9847a3595d9e31 Reviewed-on: https://chromium-review.googlesource.com/1171799 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#583424} 
- 
lanwei authoredThe DispatchKeyEvent in InputMethodWinBaseIMM32 does not have any code special to IMM32, so I move it to InputMethodWinBase, which can be shared by both InputMethodWinBaseIMM32 and InputMethodWinBaseTSF. This CL does not have any new behavior change. This DispatchKeyEvent works when TSF is enabled, but I will try to use TSF API to replace PeekMessage API in the following CLs. Bug: 657623 Change-Id: I0b03f7b393660676ff26df1a9bdbfbbd43dc6a45 Reviewed-on: https://chromium-review.googlesource.com/1173336 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#583423} 
- 
Ned Nguyen authoredThis implements exponential backoff to increase the wait time after each retry attempt. This CL also increase the default number of retry attempts to 4. Bug:864565 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I99c167e1329bbb83d86d310e2acf164cd3f3e7cf NOTRY=true # linux-chromeos-rel flake Change-Id: I99c167e1329bbb83d86d310e2acf164cd3f3e7cf Reviewed-on: https://chromium-review.googlesource.com/1176089 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583422} 
- 
Jacob Dufault authoredPIN is hashed differently, and this hashing needs to happen even if the PIN keyboard is not shown but the user can submit via PIN. Bug: 873328 Change-Id: I658d7343628c6d24a42179966f1aa3c54ed3a4a8 Reviewed-on: https://chromium-review.googlesource.com/1173257 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583421} 
- 
Nico Weber authoredBUILD_DATE used to take the current time and then set BUILD_DATE to the first Sunday of the month (unofficial builds) or to that date at 5am (official builds), so that the date stays constant for a while, to keep binary hashes changing less frequently. (BUILD_DATE makes it into base/, so most binaries contain it.) This behavior is kept, but it's now based off the timestamp of the most recent commit. This has the advantage of being deterministic, so for example if some Android bot builds the same revision twice, it's now guaranteed that both builds will end up with the same timestamp. The motivation is that I want to reland https://chromium-review.googlesource.com/1161104 which broke Android bots which assume fully deterministic BUILD_DATEs and currently only work by accident due to write_build_date_header.py not rerunning in incremental builds. Since querying git is slow and the timestamp will be queried at gn gen time in a follow-up change, let lastchange.py write the last commit's timestamp in a file next to build/util/LASTCHANGE and then read that in write_build_date_header.py. For official chrome builds we ship, this shouldn't make much of a difference, since there's always recent commits when we ship those (if only to update chrome/VERSION). When syncing to an old revision (past the revision this change lands in, of course -- say this lands and then 2 years pass, and then you sync back 1.5 years), that will now have an old date while it had a current date before. This could happen while bisecting. You'd get more security interstitials while bisecting. Embedders might ship old Chromiums without having a recent commit in src. These would have BUILD_DATEs in the past. I announced this change on https://groups.google.com/a/chromium.org/forum/#!topic/embedder-dev/Ymk3bHPQ45M We can add an explicit opt-out if requested. Build date currently affects: - HSTS lists (considered valid for 70 days past build date) -- but only enabled for official chrome builds (GOOGLE_CHROME_BUILD check in TransportSecurityState()) - certificate transparency (considered valid for 70 days past build date) - invalid cert date interstitial (warns if system clock is more than 2 days behind build date, or more than 365 days in the future) - browser upgrade detector indicator UI (stops checking after build is 12 weeks old) - field trials (kNoExpirationYear is 2 years past build date) //base:build_date already depends on lastchange_file and only reruns when that file is touched (and on full builds). Lots of prior discussion in https://codereview.chromium.org/1641413002/ (this approach but without widening was suggested in comment 26, comment 46 mentions security concerns from agl, comment 67 onwards are about security too. Eventually http://crbug.com/584880 got filed with a plan similar to this CL here, but there was no time to evaluate the proposal at the time due to internship schedule reasons. I talked to security -- namely, felt agl ncarter carlosil -- and everyone thinks this has no obvious issues.) Obsoletes https://chromium-review.googlesource.com/c/564598/, a prior attempt at getting deterministic builds (opt-in, by setting an env var with the desired date). Bug: 314403,584880,871173 Change-Id: I6ccd78bff005572a9fa391e9820f4f5f83583c50 Reviewed-on: https://chromium-review.googlesource.com/1167913Reviewed-by: Alex Mineer <amineer@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583420} 
- 
John Abd-El-Malek authoredBug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic6422ecc5f2298c25a8720a7dfeac17114ede0ad Reviewed-on: https://chromium-review.googlesource.com/1173492 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#583419} 
- 
Eric Orth authoredEverything in the struct should have a reasonable default value and the struct param itself is optional using base::Optional. Include DNS qtype and initial priority support in the new parameter. Lots of tests added in now that qtype and priority are supported by the new API. I'll add a similar struct of optional params to the mojo API in the next CL. Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4b628364e53f1c3fdf34819071b6562eaedc9c14 Reviewed-on: https://chromium-review.googlesource.com/1171574 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583418} 
- 
Xiao Yang authoredAdd a check for tablet mode and dismiss virtual keyboard after submitting a query in tablet mode Bug: b/112274024 Change-Id: I715dfb43d3db3211f81e1ac72cde6f62777dbc7f Reviewed-on: https://chromium-review.googlesource.com/1176174 Commit-Queue: Xiao Yang <yanxiao@google.com> Reviewed-by: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583417} 
- 
Weidong Guo authoredChanges: Transition dragged item to the corresponding position in folder icon after drag is complete or cancelled. Demo: https://drive.google.com/open?id=1b2zfBf_owGMfh3wcdmXGWZoKn-bcQs7t Bug: 873853 Change-Id: I18fc427ac2a2b803274e9ff101fcd3aab9bdd7a3 Reviewed-on: https://chromium-review.googlesource.com/1174854 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583416} 
- 
Greg Kerr authoredWith cryptohome's async event loop being deprecated, this calls the modern RemoveEx function. Bug: 211405 Change-Id: I5286ce56596969f21a2455697ef7ccc3fd85a98b Reviewed-on: https://chromium-review.googlesource.com/1141327 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#583415} 
- 
Vlad Tsyrklevich authoredBug: 864705 Change-Id: Ifefb1df326d50f321bb2936979284c545156b38d Reviewed-on: https://chromium-review.googlesource.com/1141048Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#583414} 
- 
Scott Violet authoredfor single-process-ash. Specifically to get the Env from the Widget not the static. BUG=847992 TEST=covered by tests Change-Id: I508f5cbd6dabaecea00cedd05f1702db37df9a2c Reviewed-on: https://chromium-review.googlesource.com/1176375Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583413} 
- 
Nico Weber authoredCurrently, the builder is configured to use goma on the recipe side but not in mb, causing it to build with -j500 but doing local builds. The bot running the build does not appreciate that. Bug: 869973 Change-Id: Id27616762caff158ad660b2b6f2d8ed42a29a41b Reviewed-on: https://chromium-review.googlesource.com/1176269Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#583412} 
- 
Dirk Pranke authoredhttps://chromium.googlesource.com/chromium/buildtools/+log/9a90d9a..2dff9c9 This rolls GN from "UNKNOWN" to 1413 (4cf8d15..e134e49, 33 commits): https://gn.googlesource.com/gn/+log/4cf8d15..e134e49 $ git log 4cf8d15..e134e49 --date=short --no-merges --format='%h %ad %s' e134e493 2018-08-13 Support specifying target and host platform in gen.py dd6a3831 2018-08-13 Switch to libc++ on Linux c218b836 2018-07-02 Don't use -- in exec_script 27ef6b4e 2018-08-13 Fix gn_unittests f8f395ac 2018-08-10 Remove sarcastic error message. f9dbfd12 2018-08-10 Avoid trailing slashes for directory in compilation database c0744edf 2018-08-04 Add string_replace builtin function 09171294 2018-07-31 [output_conversion] Add output_conversion options c2717deb 2018-08-02 [compdb] Properly escape for JSON f4facf42 2018-08-04 Don't allow ./ before target name. 499868c6 2018-07-18 port gn to aix 387e3ab4 2018-07-23 Add an OWNERS file. 11e09914 2018-07-31 [docs] Updating documentation for compdb e2a2940a 2018-07-31 [target] Propagate configs across toolchains when specified d2d7ecb2 2018-07-30 Default to "ar" instead of "llvm-ar" 9ae36b8b 2018-06-13 Update AUTHORS to reflect Chromium-tree contributions 9a9ed6df 2018-07-26 Move all docs to toplevel docs/ folder. cad6b537 2018-07-23 Add notes about the CLA and gn-dev@ to the README. 5d9a4e9a 2018-07-20 Make ICF an option in gen.py d7111cb6 2018-07-16 Enable identical code folding link option a6c2a5d5 2018-07-15 Use -ffunction-sections and -fdata-sections 796ed47b 2018-07-16 Add reference.md 63b72701 2018-07-15 Make LTO an option in gen.py d9bca564 2018-07-13 Fixes for --out-path and --no-sysroot 0e4f3935 2018-07-13 Add options necessary for Chromium's bootstrap.py to forward to gen.py 6ef28560 2018-07-13 Correct grammar in current_{cpu,os} docs 8ce4e49a 2018-07-02 [gn] Add --export-compile-commands switch to gen f0b4405f 2018-07-09 Don't pass -flto. 9911c782 2018-07-03 [command_args] Properly set file and line in dict 39687ba9 2018-07-03 [command_args] Strip the preceding whitespace in comments if not padding fdc7a748 2018-06-29 Improve --version per discussion 9cd5057b 2018-06-29 [recipes] Add --tags to git fetch command 3ddcf64a 2018-06-29 Make gn --version work TBR=fjhenigman@chromium.org Change-Id: I54ae8b0c6d64174ec27e8eae7870eaa67d1dc037 Reviewed-on: https://chromium-review.googlesource.com/1173727 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583411} 
- 
James Cook authoredUse the autoclick mojo app when running mash. Use ash for high contrast mode, not the window service API (which doesn't work under mash). Bug: none Change-Id: I2423ec0fcc90bde9b5f4835450411009ca720427 Reviewed-on: https://chromium-review.googlesource.com/1175234Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#583410} 
- 
angle-chromium-autoroll authoredhttps://chromium.googlesource.com/angle/angle.git/+log/21e5e85a4976..c1551dc2a7dc git log 21e5e85a4976..c1551dc2a7dc --date=short --no-merges --format='%ad %ae %s' 2018-08-15 till.rathmann@gmx.de D3D11 fix: Mipmapping was used although disabled via Sampler Created with: gclient setdep -r src/third_party/angle@c1551dc2a7dc The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I39589a080b39acdeab50d2a7a07a38b9c1f0e2e7 Reviewed-on: https://chromium-review.googlesource.com/1176241Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583409} 
- 
Stephan Stross authoreddisplay.html prompts a user for a stat-file produced by generate_perf_report.py and displays it in a table. Change-Id: Ia82ab50eaedaef35e8c38ca49d8e602f2b6d22b6 Bug: 839491 Change-Id: Ia82ab50eaedaef35e8c38ca49d8e602f2b6d22b6 Reviewed-on: https://chromium-review.googlesource.com/1108965 Commit-Queue: Stephan Stross <stephanstross@google.com> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583408} 
- 
Robert Sesek authoredThis helper can be used in bpf_dsl::Policy::EvaluateSyscall() to make it easier to craft BPF policies that trap to the broker process. Change-Id: I8588b0a934343d7d0009c0d07bf259a085451ece Reviewed-on: https://chromium-review.googlesource.com/1175934 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#583407} 
- 
afdo-chromium-autoroll authoredThis CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3f3868d6dbb44d0e74b88d512f67386d3c0ba35b Reviewed-on: https://chromium-review.googlesource.com/1176362Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583406} 
- 
Min Chen authored1. Added IndicatorType kDragAreaLeft, kCannotSnapLeft to show only left/top drag indicator, kDragAreaRight, kCannotSnapRight to show only right/bottom drag indicator, only kDragAreRight and kCannotSnapRight are used in this change, but still added kDragAreLeft and kCannotSnapLeft to keep consistence. 2. Move the logic to update the opacity of highlight view and label view from SplitViewDragIndicators to SplitViewHighligtView and RotatedImageLabelView instead. see recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiOGV3c0puTkJpTElBNUFSUlZpNEp6TElKUHJZ/view?usp=sharing Bug: 871607 Test: SplitViewTabDraggingTest.DragIndicatorsInPortraitOrientationTest Change-Id: I64f76766cd14dd2bca686be3f13d274993f24639 Reviewed-on: https://chromium-review.googlesource.com/1167998Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#583405} 
- 
Alexey Kozyatinskiy authoredRemoved couple public methods and simplified map of map of map. R=lushnikov@chromium.org Bug: none Change-Id: Iac8b88478f9b7b7c4b722c2f65b723b7094559e4 Reviewed-on: https://chromium-review.googlesource.com/1176291Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#583404} 
- 
Peter Boström authoredMoves c/b/ui/views/harmony/ content into c/b/ui/views/. Also renames HarmonyTypographyProvider ChromeTypographyProvider to match the ChromeLayoutProvider. Bug: chromium:867557 Change-Id: I50a7c27c495187ef59893d417c6047a36499ffb6 Reviewed-on: https://chromium-review.googlesource.com/1175102 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#583403} 
- 
rajendrant authoredBug: 836029 Change-Id: Ia0f2a3608eb9be51b652b2519365737276e4f2c6 Reviewed-on: https://chromium-review.googlesource.com/1175558Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#583402} 
- 
Robert Ogden authoredRenames it to be the UI helper, instead of specifically Infobar. No behavioral changes are done in this CL, just the renaming. Bug: 874523 Change-Id: I3e5a0c992af0a2c2b9c2ee03a9b45d337355abf8 Reviewed-on: https://chromium-review.googlesource.com/1176235Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#583401} 
- 
Marijn Kruisselbrink authoredThis adds a WritableFiles RuntimeEnabledFeature, as well as a new FileSystemWriter interface (exact name TBD) and a mojo interface the implementation uses. Bug: 872460 Change-Id: I830a44d5df75fbfb5fbb1c97048a589a4facedc5 Reviewed-on: https://chromium-review.googlesource.com/1169773 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#583400} 
- 
Yue Cen authoredBug: 835029 Change-Id: Ic37a08411a15be5b5fce1b727dbf6ed5e4a22c65 Reviewed-on: https://chromium-review.googlesource.com/1174980Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#583399} 
- 
David Bokan authoredThis CL implements the "viewport bounds delta" for position: fixed elements. When the URL bar is hidden, the renderer is only resized when the user finishes scrolling. This means that while the scroll is on-going and the URL bar is hiding, the renderer is actually smaller than the visible area - we're revealing new content outside the renderer's bounds. Since position: fixed elements are positioned relative to the top- left corner of a layer, a bottom-fixed element would appear to detach from the bottom of the screen and move upwards as the URL bar hides. CC uses some slight-of-hand to prevent this by adding a "viewport bounds delta" to the scrolling and clipping bounds of the viewport layers. This allows the newly revealed content to be seen and keeps bottom-fixed elements static until the renderer itself is resized and the bounds delta can be cleared. This CL does the following things: 1) Update Blink to set the correct paint property tree state on bottom-fixed objects so that the bounds delta is correctly applied to them. 2) Modify the compositor to apply the bounds delta to the property trees directly, rather than using layers which may no longer exist in BGPT mode 3) Explicitly clamp the scroll offset on pending tree activation. LayerTreeHostImplTest, ClampingAfterActivation was failing after the early return was added to UpdateViewportContainerSizes. We were relying on the viewport scroll anchor to clamp the scroll offsets. Better to do this explicitly. The marked test is currently crashing but tests this behavior. I've confirmed that ignoring the crash causes the test to fail as expected and applying this patch fixes it. TEST=virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html Bug: 850135 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3a2da2648b47c2ccc0baf2876da12c228213dbe6 Reviewed-on: https://chromium-review.googlesource.com/1173441 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#583398} 
- 
Chromium WPT Sync authoredUsing wpt-import in Chromium 22fb8788. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22764 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ic0975f34aac3befbd2d98a41c366dd22ab1beef7 Reviewed-on: https://chromium-review.googlesource.com/1176184 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#583397} 
- 
Charlie Harrison authored|opener| is DCHECKed to be non-nullptr earlier in this function, and is dereferenced a bunch of times. Bug: None Change-Id: Ia071bfb4159cbf7fb28765e21437d2af4817320b Reviewed-on: https://chromium-review.googlesource.com/1175938Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#583396} 
- 
Wei-Yin Chen (陳威尹) authoredFor those subfolders of //chrome/browser without violations, add them to gn check targets. Otherwise, add number of errors in comments. Bug: 367595 Change-Id: Ifa21ab2023fc15b9740bf1ccce8ff5fa20909048 Reviewed-on: https://chromium-review.googlesource.com/1175236Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583395} 
- 
Koji Ishii authoredThis patch implements dom-snapshot inspector protocol for LayoutNG. The offset is not implemented yet in this patch, and thus 2 more tests do not pass yet. Bug: 636993 Change-Id: I0b57685cc6777ab8d06fbce8b5c8d935aed2648c Reviewed-on: https://chromium-review.googlesource.com/1175758 Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#583394} 
- 
Mike Dougherty authoredBug: 862323 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ida6501b7c176b227be691c1120298eb563fd71bd Reviewed-on: https://chromium-review.googlesource.com/1176116 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#583393} 
- 
Lei Zhang authoredPrint Preview needs the PDF plugin to work, but plugin loading happens asynchronously at startup. So querying the PluginService with GetPluginInfoByPath() may fail because the plugins have not been loaded yet. However, since the PDF plugin is a built-in PPAPI plugin, it does not need to be loaded from disk asynchronously. Since it is already registered, call GetRegisteredPpapiPluginInfo() instead. BUG=857074 Change-Id: I729b40329f1de92da6789efbbbae7e2c09ab8b51 Reviewed-on: https://chromium-review.googlesource.com/1175553 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583392} 
- 
Nektarios Paisios authoredR=dmazzoni@chromium.org Change-Id: Icecff9eece2167e4678dca0aba1f0d0e08a457b0 Reviewed-on: https://chromium-review.googlesource.com/1175032Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#583391} 
- 
Hidy Han authoredChange-Id: I3d3113cb89a03b35a36a97fc38e156272729da77 Reviewed-on: https://chromium-review.googlesource.com/1176105 Commit-Queue: Hidy Han <hidyhan@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#583390} 
- 
Chris Lu authoredTest covers the crash in bug 871769. That was fixed with CommandDispatcher forwarding BrowsingDataCommands protocol methods. ApplicationCommands conforms to BrowsingDataCommands, but tabgrid coordinator needs to explicitly dispatch both. Change-Id: I484f37864f2620eaa85c44e3a20c6d4aebd2f072 Reviewed-on: https://chromium-review.googlesource.com/1171796 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583389} 
 
-