GitLab

Currently when we copy over a StyleRule we parse all proeprties
greedily. This should only be the already parsed properties. The greedy
method may result in a dangerous state.

This is a speculative fix for the ClusterFuzz issue.

Bug: 774061
Change-Id: I0b7f09018c7cf2d8ca75ea5d705016fbcce6f0ae
Reviewed-on: https://chromium-review.googlesource.com/722579Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509352}

Currently we over/underflow if a counter value goes beyond the limits
of a 32 bit integer. The spec [1] says we can ignore the increment
if it would cause an over/underflow. This patch implements this
behaviour.

Firefox follows the spec in this.

[1] https://drafts.csswg.org/css-lists-3/#valdef-counter-reset-custom-ident-integer

Bug: 655473
Change-Id: I6e10b6e4f5f672d723a0ccb69fd309d52d1d1204
Reviewed-on: https://chromium-review.googlesource.com/708105Reviewed-by: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509351}

This fixes a regression where touch/click events are not correctly
being picked up by the slider. This adds padding around the timeline
and volume slider which will pick up gestures in these areas. There
is no visual effect of this change.

BUG=773475

Change-Id: Idff48c259438bb776f6794d921625f5340744d1b
Reviewed-on: https://chromium-review.googlesource.com/721319Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509350}

Close QUIC when Quartc closes.  Don't run Close on the QUIC thread.

Closing QUIC when Quartc closes serves two purposes.  First, it sends a
connection close packet to the peer, which closes immediately rather than
hanging around until the user closes it.

Second, it cleans up QUIC state so that the QuartcConnection can be safely
deleted.  QUIC only tears down local state (including alarms & scheduled tasks)
when it's closed or encounters an error.  QuicConnection does not tear down
state in its destructor.  Deleting it before turning off its alarms would
likely result in a segfault.

QuartcConnection::Close() currently runs on the QUIC thread if QUIC closes the
connection (eg. in response to a connection close packet or an internal error).
Close() waits for all tasks on the "default" thread pool to complete.  Some of
those tasks block on QUIC-thread operations (notably, polling the QUIC
bandwidth estimate and "pump" tasks that open streams).  If one of those tasks
starts execution before the connection_state_ is set to kClosed, the task will
block until the QUIC thread becomes available.  But if the QUIC thread is
executing QuartcConnection::Close(), it will block until all tasks on the
default thread pool finish, deadlocking Quartc.

Punting Close() to the default thread pool solves this problem.  However, it's
worth noting that this *must not* use QuartcConnection's "ScheduleTask" method.
OnConnectionClosed() must post Close() directly to the default thread pool.
Otherwise, Close() will block waiting for itself to finish!

Merge internal change: 171325397

https://chromium-review.googlesource.com/c/718907/

Add QUIC V43, which will be for more IETF-QUIC Header format changes.

This is currently a container for the IETF header format changes.
This CL adds no new functionality.

Merge internal change: 171048665

https://chromium-review.googlesource.com/c/719556/

Modify the quartc_session_test, GetStats() test to look at data that is more reliable.  Fix developed in cooperation with mellen@, original author of the test file.

Merge internal change: 170702715

https://chromium-review.googlesource.com/c/719277/

Remove last_packet_number_ from QuicFramer.

It's never read in production code.  It was replaced with
largest_packet_number_ a while ago, but last_packet_number_ was never
removed.

Merge internal change: 170645666

https://chromium-review.googlesource.com/c/718904/

In QUIC, remove unused stream frame buffer allocator from QuicEpollConnectionHelper. No functional change expected.

Merge internal change: 170532273

https://chromium-review.googlesource.com/c/719013/

Deprecate FLAGS_quic_reloadable_flag_quic_set_version_on_async_get_proof_returns.

Merge internal change: 170486605

https://chromium-review.googlesource.com/c/718899/

In QUIC, remove UniqueStreamBuffer from QuicStreamFrame. Also remove the definition of UniqueStreamBuffer.

Merge internal change: 170478067

https://chromium-review.googlesource.com/c/719276/

In QUIC, remove QuicFramer::HasDataProducer function.

Merge internal change: 170474222

https://chromium-review.googlesource.com/c/718898/

Refactor AeadBaseEncrypter and Decrypter to use nonce size

The construction of a nonce using a "nonce prefix" is specific to Google
QUIC.  The nonce size can be computed from the nonce prefix and vice
verse, and specifying the nonce size makes more sense given the nonce
construction in IETF QUIC.

Merge internal change: 170434347

https://chromium-review.googlesource.com/c/719012/

quic: fix minor typos

Merge internal change: 170425380

https://chromium-review.googlesource.com/c/719197/

R=rch@chromium.org

Bug: 
Change-Id: I887eb22b001c726063d8ae7bb5db3d6c081058e8
Reviewed-on: https://chromium-review.googlesource.com/719100
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509349}

'selectStart' event in UpdateSelectionForMouseDrag can affect the document.
So we should check the DocumentAvailiblity after the 'selectStart' event.
We should also check the cached position validity after
the event is dispatched.

Bug: 751817
Change-Id: Ie024fd9464771865d6611da10f69fb5df43754ce
Reviewed-on: https://chromium-review.googlesource.com/713074
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509348}

Bug: 775261
Change-Id: Ia0af1a184a5780c214be7607fdbd40a5a914d295
Reviewed-on: https://chromium-review.googlesource.com/719612Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509347}

This reverts commit 425294bf.

Reason for revert: Broke chrome_public_test_apk

Original change's description:
> [android] Add local results details pages.
> 
> Bug: 772032
> Change-Id: Ieca8a24e1f2d4bfbae1bef4a1a4ebb0a67365710
> Reviewed-on: https://chromium-review.googlesource.com/702682
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Zhiling Huang <hzl@chromium.org>
> Reviewed-by: Yoland Yan <yolandyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509116}

TBR=yolandyan@chromium.org,hzl@chromium.org,jbudorick@chromium.org

Change-Id: I9c20ed803802cae8db453282f43008019103618f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772032,775448
Reviewed-on: https://chromium-review.googlesource.com/722642Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509346}

This reverts commit cbee442c.

Reason for revert: MemorySanitizer found use-of-uninitialized-value in IconLabelBubbleView::SeparatorView::UpdateOpacity(). See https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/3587 for more details.

Original change's description:
> [Views] Fix omnibox separator issue
> 
> Currently, the separator in an omnibox bubble view
> disappears when the ink drop animates in and then
> reappears when it animates out. However, it's
> possible for the ink drop to be removed without
> animation. This causes the separator to go missing
> since its opacity has not be updated.
> 
> This CL fix this issue by updating the separator's
> opacity when the ink drop layer is removed.
> 
> Bug: 772832
> Change-Id: I812d8dcacd79851bf23b0dce2d7fd00330887278
> Reviewed-on: https://chromium-review.googlesource.com/713398
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Sarah Chan <spqchan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509218}

TBR=sky@chromium.org,spqchan@chromium.org

Change-Id: Ide2a32109cb0e3c2f7f34e2c519725a497596b33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772832
Reviewed-on: https://chromium-review.googlesource.com/721444Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509345}

There are some OWNER files which don't reflect the current status.
It might be better to remove these to avoid confusion.

As far as I know, dom-team has never touched these areas.

Bug: 679390
Change-Id: Ie2d59928d8ceb44da3e75b509ee3e17ff638c6d5
Reviewed-on: https://chromium-review.googlesource.com/721104Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509344}

https://webrtc.googlesource.com/src.git/+log/b06b35820705..1b4059e84f5f

$ git log b06b35820..1b4059e84 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I22e3ba70f76745c34c8dd3aaaf720eb2f3fc1b3b
Reviewed-on: https://chromium-review.googlesource.com/722185Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509343}

This patch refactors InRenderedText() by moving the work on InlineTextBox to
LayoutText::ContainsCaretOffset(), so that InRenderedText() no longer works
on InlineTextBox directly.

A follow-up patch will introduce a LayoutNG version of
LayoutText::ContainsCaretOffset().

Bug: 771398
Change-Id: If786ff57cf881869632e72e2347741433f6a4a17
Reviewed-on: https://chromium-review.googlesource.com/721629
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509342}

There were several different k*Cache*Size variables controlling
different caches but with the same name. These collided in jumbo
builds but also made it harder to discuss them and their values
so renaming them seems like a good improvement.

Bug: 746953
Change-Id: I1e8dc4f687c7b1e3ca8a9f9a5e80409029f8c4b0
Reviewed-on: https://chromium-review.googlesource.com/721205Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#509341}

We are going to put non-web-platform things under controller/ and some of them
need some extra configurations at startup and/or frame initialization.
To provide ways to add these configurations this CL adds BlinkInitializer
class which inherits from ModulesInitializer.

Change-Id: I3839d55cdf1b7404d7ba4c45e1ebfdc1c8464279
Reviewed-on: https://chromium-review.googlesource.com/721101Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509340}

This reverts commit da95168e.

Reason for revert: The test failure was already fixed at crbug.com/771729

Bug: 773970

Original change's description:
> Revert "Add RendererSchedulerImpl::V8TaskQueue()"
> 
> This reverts commit f6af34a1.
> 
> Reason for revert: Speculative revert for layout test flake starting at https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/11385   - will reland if the flake does not disappear
> 
> Original change's description:
> > Add RendererSchedulerImpl::V8TaskQueue()
> > 
> > V8 tasks like GC are now posted to a loading task queue. This CL introduces
> > V8 task queue at RendererSchedulerImpl and uses it for V8 tasks for better
> > scheduling.
> > 
> > Bug: n/a
> > Change-Id: If65ad1b12e59de36a448dddc0da0777d2338b58a
> > Reviewed-on: https://chromium-review.googlesource.com/697485
> > Reviewed-by: Alexander Timin <altimin@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#506364}
> 
> TBR=isherman@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: n/a
> Change-Id: I353c558a1a637fcf70da20e537be4e218a993af9
> Reviewed-on: https://chromium-review.googlesource.com/705135
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#507199}

TBR=isherman@chromium.org,rockot@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,skyostil@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: n/a
Change-Id: I2555e1297d430de4f193a5d478a515a74078cc84
Reviewed-on: https://chromium-review.googlesource.com/722401Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509339}

When DICE is enabled, the user should continue to be signed in to Google
on the web when sync is turned off. This CL ensures that the account
reconcilor does not force sign the user out when they turn off sync.


Bug: 774990
Change-Id: Iafdaa6a31e4f5bad7e6cfda5ac56529e2b30b76c
Reviewed-on: https://chromium-review.googlesource.com/719137
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509338}

Removes support for the no longer used OwnPtr

Bug: 
Change-Id: I38faf4aedb9bbc335c9f61bb5e38771338f1a187
Reviewed-on: https://chromium-review.googlesource.com/720861Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509337}

Bug: 
Change-Id: I09a31dcf632c8150cd1fc6f5560af826aed89bd1
Reviewed-on: https://chromium-review.googlesource.com/721360Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509336}

This does nothing interesting now, but can be the base of
coming unit tests for CORSURLLoader.

This test is based on following hintzed's patch, but modified
to be in more common style in chromium.

https://chromium-review.googlesource.com/c/chromium/src/+/558226

Bug: 736308
Change-Id: I93a5a4eccdb3d2379ff4e5a29fab874f9cc8ca7b
Reviewed-on: https://chromium-review.googlesource.com/704419Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509335}

Code is compiled but never used, so as a first step before
deleting the code, stop compiling it (this proves that it
is really unused).

Bug: 775332
Change-Id: Ie38fba7c8f27bf10301c0e37187d1ee69df0ca86
Reviewed-on: https://chromium-review.googlesource.com/722358
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509334}

This patch contains a test for the change in crrev.com/c/722384, which
has been extracted out for easier merging.

Bug: 771984
Change-Id: I22ef843febc297a4f2a85a2d0957e7619981e781
Reviewed-on: https://chromium-review.googlesource.com/722488
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509333}

This CL updates EncryptedMediaSupportedTypesTest (and related tests
classes) to test persistent license support.

BUG=767941
TEST=Add new test cases

Change-Id: Iece24005316ce1e4f09cd807756499d69e4c7821
Reviewed-on: https://chromium-review.googlesource.com/719384
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509332}

Auto fill should work in cases where iframe domain is different
but have same public suffix and the next lower subdomain.

For example, on the homepage of schwab.com, the login form is hosted
in an iframe on a different domain.
(main page: https://www.schwab.com/, iframe: https://lms.schwab.com).
This patch relaxes auto filling only when eTLD+1 is the same for both
the iframe and the main frame.

BUG=770181

Change-Id: Idd44aa5a31aaf8ea159e1f7149043ace657be6b0
Reviewed-on: https://chromium-review.googlesource.com/704435Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#509331}

When enabling --use-zoom-for-dsf, inspecting Android chrome using devtool has
three problems: 1. screencast is zoomed in, 2. the size of selected DOM element
to inspect it is bigger than correct one, 3. a mouse click points weird
position. See crbug.com/737777#c35. The root cause of those problem is that
--use-zoom-for-dsf multiplies the page zoom by the device scale factor (DSF),
so scaling some lengths by the page zoom factor makes them DSF scale. To solve
it, this CL scales down the page zoom factor and the top control height by DSF.

Bug: 737777
Change-Id: I367b7e5cf4c485263f905857ed947977dd44a4ee
Reviewed-on: https://chromium-review.googlesource.com/715080
Commit-Queue: Jaebaek Seo <jaebaek@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509330}

As it is, it's always zipped into 'test_artifacts.zip',
so if there are multiple devices, they'll all write to the
same file, and there might be a race condition.

Bug: webrtc:8391
Change-Id: I490e0678c3ba8558dc7ce9ea9a620b5b7f008a80
Reviewed-on: https://chromium-review.googlesource.com/718704Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509329}

This CL does 2 things:

(1) The Worklet spec defines WorkletGlobalScope must have a unique opaque
origin:

"3. Let origin be a unique opaque origin."
https://drafts.css-houdini.org/worklets/#script-settings-for-worklets

However, our current impl doesn't obey this requirement. PaintWorklet inherits
its owner document's SecurityOrigin. AnimationWorklet and AudioWorklet create a
SecurityOrigin based on their script URL. This CL replaces them with
SecurityOrigin::CreateUnique().

(2) Our current impl checks CORS etc based on ExecutionContext's SecurityOrigin
associated with Modulator. For Worklets, these are WorkletGlobalScope and
WorkletModulatorImpl. However, Worklets need to fetch their scripts as
sub-resources of the owner Document, so the security checks are conducted based
on the owner Document's SecurityOrigin. After changes for (1), SecurityOrigin is
a unique opaque origin and it fails a bunch of tests because of CORS check
failures. To fix this, WorkletModulatorImpl overrides GetSecurityOrigin() to
provide the owner Document's SecurityOrigin for module fetch.

Bug: 773772, 773778
Change-Id: I451999ef09b943c480e907e6536ca8819f446d5b
Reviewed-on: https://chromium-review.googlesource.com/714499
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509328}

Change-Id: Ia593a25d8d305f8df7d0f9647a9f7f328b7897eb
Reviewed-on: https://chromium-review.googlesource.com/717216Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509327}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b83707f4..f4579b90

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I30ccd8527e19c7788f658cbf2d1e7e9e3ac0bcb2
Reviewed-on: https://chromium-review.googlesource.com/721941Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509326}

Before the CL, in case when external removable drive had '#' character
in its name it caused that disk was not accessible through Files App.
The user was able to select the drive, but no content was displayed
neither they were able to add new files to the drive.

This CL sanitizes and suggests mount point names for all mountable
drives to prevent mounting a device with '#' in its name.

Bug: 774241

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I90e5808bb0d8b4a26becaf9ba30b538ce580b3dd
Reviewed-on: https://chromium-review.googlesource.com/720639Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#509325}

The HidCollectionInfo and HidUsageAndPage were defined in mojom,
so the duplicated definitions in C++ should be removed.

The hid.typemap and struct traits are also removed.

BUG=728223

Change-Id: Id53d19ebb930b9b60910c8b23a145dbf058a7f8a
Reviewed-on: https://chromium-review.googlesource.com/708775
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509324}

This CL removes translation strings for external drive rename notifications,
because they are no longer in use.

BUG=775018
CQ-DEPEND=CL:722140

Change-Id: Ia85cc845302f0db83e6dcad88445d2f774bb704a
Reviewed-on: https://chromium-review.googlesource.com/722460Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Cr-Commit-Position: refs/heads/master@{#509323}

DeletionSentinel may fail to detect TaskQueueManager deletion on a
nested message loop:
If there's a nested message loop that spins in task_annotator_.RunTask()
at line 531, ProcessTaskFromWorkQueue() is reentered. As both outer and
inner PTFWQ hold a ref to the DeletionSentinel instance,
protect->HasOneRef() at line 534 doesn't hit even when the
TaskQueueManager is gone.

This CL replaces it with WeakPtr that covers the reentered case.

Change-Id: Ia15947fcac399dc45994b0df7514a3872c6ba25c
Reviewed-on: https://chromium-review.googlesource.com/721219
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509322}

There are 5 different kFilteredMessages arrays in content/browser
and some of them collide in jumbo (chromium unity builds)
build experiments.

This patch renames them to:
kCacheFilteredMessageClasses
kFileApiFilteredMessageClasses
kPepperFilteredMessageClasses
kRenderFilteredMessageClasses
kServiceWorkerFilteredMessageClasses

Bug: 746953
Change-Id: I3fc1b6f6ea3d0e5ccbb2ff47d4d476e02f5c2344
Reviewed-on: https://chromium-review.googlesource.com/721279Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#509321}

In the jumbo build experiment (chromium unity builds) there is a
collision between the two different kDataFile strings. This patch
renames them kNetworkErrorDataFile and kTargetsDataFile which also
matches their intended values.

Bug: 746953
Change-Id: Ib9f47fa4d358303c7cdbb65b54b40080521a915d
Reviewed-on: https://chromium-review.googlesource.com/721299Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#509320}

This eliminates a lot of the code duplication between the new and legacy
integration test frameworks by making the legacy test helper files small
wrappers to load the new *test_runner modules.

* Fixes data_grid_test_runner because the legacy test helpers had two
data grid implementations, one of which was not actually used anymore.

Bug: 667560
Change-Id: I2ad21ec7b50be89a44f643858cec3b9348d8d857
Reviewed-on: https://chromium-review.googlesource.com/722112
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509319}

For a long while now, this method always returns true on desktop and
false on mobile, so any code that's either desktop-only or mobile-only
doesn't need to check it.

Bug: 627747
Change-Id: I6d1b25ad0e6f2c76a0013725b675e5d059f6cff0
Reviewed-on: https://chromium-review.googlesource.com/720922Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509318}

The original code used a different way to check that the extension is an
image extension (and not something else, like .exe), but this depended
on being able to directly access the blink::Image class. When the name
calculation was moved into the browser, blink::IsSupportedImageType was
used instead to ensure that a user doesn't drag out an image and get
something surprising like an executable instead.

However, it turns out that blink::IsSupportedImageType doesn't consider
SVG an image type--since it's actually an XML file. To get around this,
just simply check that the MIME type begins with image/. This is safe
enough, since the filename calculation only takes well-known MIME
types into consideration.

Bug: 767775
Change-Id: I5c71d8ae2daa9a413beab9c3c1cb393760383323
Reviewed-on: https://chromium-review.googlesource.com/721615
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509317}

Bug: 775202
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9565ee77b276fe14ecbdfaf17ec18d348a80cb85
Reviewed-on: https://chromium-review.googlesource.com/722034Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509316}

This CL removes notifications to indicate successfully completed and
pending operation of an external drive rename. Related strings will be
removed in CL:722460.

Bug: 775018
Test: browser_tests --gtest_filter=FileManagerJsTest.DeviceHandlerTest
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3eb43a6f4cc4f53214e074813e04f561262d7767
Reviewed-on: https://chromium-review.googlesource.com/722140
Commit-Queue: Klemen Kozjek <klemenko@google.com>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509315}

The committed interstitial project will use a navigation throttle [1] to watch
for requests that failed due to cert errors. WillFailRequest() will allow it to
decide how to respond, and provide custom error HTML for SSL interstitials.

[1] crrev.com/c/621236

Bug: 751941
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I9a597851d018e3e42d884c185ba2c619b9d31923
Reviewed-on: https://chromium-review.googlesource.com/621873
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509314}

Bug: 
Change-Id: Icb5351bb6112fc89e36dab82c15f32887dab9217
Reviewed-on: https://chromium-review.googlesource.com/720594Reviewed-by: David Vallet <dvallet@chromium.org>
Commit-Queue: Iris Uy <irisu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509313}