GitLab

Apparently it really should be a DCHECK.

TBR=jam@chromium.org
BUG=123495
BUG=119250

Review URL: http://codereview.chromium.org/10094003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132356 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132355 0039d316-1c4b-4281-b951-d872f2087c98

Roll WebKit deps to make the canary usable.

BUG=123313
TBR=scheib@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132354 0039d316-1c4b-4281-b951-d872f2087c98

The version number now follows the form major.minor.build.patch.

Major & minor versions come from remoting/VERSION.
Build & patch versions come from chrome/VERSION.

BUG=122721
TEST=Remoting web-app, plugins and host component executables & DLLs have matching versions in the above form, if versioned.


Review URL: http://codereview.chromium.org/10075002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123378
TBR=thakis

Review URL: https://chromiumcodereview.appspot.com/9972003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132352 0039d316-1c4b-4281-b951-d872f2087c98

This corrects a typo in an earlier ClientSession input pipeline cleanup CL.


Review URL: http://codereview.chromium.org/10082042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132351 0039d316-1c4b-4281-b951-d872f2087c98

Interesting changes in this range:
* The tooling infrastructure landed. Not observable, but it makes it easier
to write clang tools.
* Honor -fno-pic, pie support
* Better diagnostics for several c++11 features
* Cross-compiler changes that hopefully make CrOs clang builds simpler
* Many LTO fixes

Also pick up a minor change to the style plugin: Instead of ignoring
problems below out/, it now ignores them below gen/ and geni/. This
should make it work better with custom build directories.

BUG=none
TEST=none
TBR=mark

Review URL: http://codereview.chromium.org/10081013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132350 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10092001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132349 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132348 0039d316-1c4b-4281-b951-d872f2087c98

Changed InProcessBrowserTest to allow us to use SetUpCommandLine to specify a
UserDataDir via the kUserDataDir switch.  It appears this was intended in the original code, since CreateUserDataDirectory currently checks the commandline for the presence of kUserDataDir.

BUG=122883
TEST=None


Review URL: http://codereview.chromium.org/10037023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132347 0039d316-1c4b-4281-b951-d872f2087c98

R=nirnimesh


Review URL: http://codereview.chromium.org/10084021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132346 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zmo
Review URL: https://chromiumcodereview.appspot.com/10073034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132345 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel
Review URL: https://chromiumcodereview.appspot.com/10084032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132343 0039d316-1c4b-4281-b951-d872f2087c98

We need to be able to merge it back into one final xml file if we
want the flakiness dashboard to work.
Review URL: https://chromiumcodereview.appspot.com/10082014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132342 0039d316-1c4b-4281-b951-d872f2087c98

This patch makes UpdateRecommendedMessageBox more cleaner.

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10084023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132335 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122953

Review URL: http://codereview.chromium.org/10068016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132334 0039d316-1c4b-4281-b951-d872f2087c98

CleanFlimflamDirs() restarts flimflam but does not wait for it to
be fully initialized before returning. This CL mitigates the issue
by restarting Chrome next, giving flimflam ample time to initialize
before the test actually continues. A proper fix will be developed in
crosbug.com/29421.

BUG=chromium-os:29400
TEST=PyAuto chromeos_onc.py


Review URL: http://codereview.chromium.org/10084005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132333 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132330 0039d316-1c4b-4281-b951-d872f2087c98

This archive contains all the files that need to be signed or are
required to build the Me2Me host installer.

This is a re-land of r132270.

BUG=122228
TEST=None


Review URL: http://codereview.chromium.org/10079027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123184
TEST=


Review URL: http://codereview.chromium.org/10082013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132327 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10073028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132326 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123384


Review URL: http://codereview.chromium.org/10081025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132325 0039d316-1c4b-4281-b951-d872f2087c98

Found by clang's newly enabled -Wliteral-conversion:

../../chrome/browser/ui/cocoa/download/download_item_cell.mm:75:40: error: implicit conversion turns literal floating-point number into integer: 'double' to 'const int' [-Werror,-Wliteral-conversion]
const int kCompleteAnimationDuration = 2.5;
          ~~~~~~~~~~~~~~~~~~~~~~~~~~   ^~~
../../chrome/browser/ui/cocoa/download/download_item_cell.mm:78:43: error: implicit conversion turns literal floating-point number into integer: 'double' to 'const int' [-Werror,-Wliteral-conversion]
const int kInterruptedAnimationDuration = 2.5;
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~   ^~~
2 errors generated.

BUG=none
TEST=download animation runs 0.5s longer.


Review URL: http://codereview.chromium.org/10082026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132324 0039d316-1c4b-4281-b951-d872f2087c98

Also remove an obsolete comment.

BUG=121612
TEST=none


Review URL: http://codereview.chromium.org/9950139

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132323 0039d316-1c4b-4281-b951-d872f2087c98

gdata: Remove OnDirectoryChanged from MockGDataSyncClient,
added MockDirectoryChangeObserver for directory change notifications.

BUG=none
TEST=existing GDataFileSystemTest.*

Review URL: https://chromiumcodereview.appspot.com/10081032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132322 0039d316-1c4b-4281-b951-d872f2087c98

pageActions.enableForTab was using the same framework as the newer pageAction
API, which expects a tab ID for the first argument.

BUG=122833
TEST=Load the extension from the bug.


Review URL: http://codereview.chromium.org/10034037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132321 0039d316-1c4b-4281-b951-d872f2087c98

Reset tooltip_controller explicitly so that timer stops at shutdown.
Use tray_ reference in SystemTrayDelegate instead of going through ash instance.
Make sure delegates doesn't access tray after the tray has been deleted.

BUG=104998
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131902

Review URL: http://codereview.chromium.org/9968101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122363
TEST=Print webpage using system print dialog on Windows. Output should look normal.

Review URL: http://codereview.chromium.org/10071024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/10020052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132318 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/10081026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132317 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121580, 122841
TEST=None


Review URL: http://codereview.chromium.org/9969164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132316 0039d316-1c4b-4281-b951-d872f2087c98

```--------------
Reason: build failure on Chromiumos Clang
```

--------------

In file included from chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc:27:
./chrome/browser/chromeos/gdata/mock_directory_change_observer.h:17:3:error: [chromium-style] Complex constructor has an inlined body.
  MockDirectoryChangeObserver() {}
  ^
./chrome/browser/chromeos/gdata/mock_directory_change_observer.h:18:3:error: [chromium-style] Complex destructor has an inline body.
  virtual ~MockDirectoryChangeObserver() {}
  ^
2 errors generated.

-----------------

gdata: Remove OnDirectoryChanged from MockGDataSyncClient,
added MockDirectoryChangeObserver for directory change notifications. 

BUG=none
TEST=existing GDataFileSystemTest.*


Review URL: http://codereview.chromium.org/10081032

TBR=zelidrag@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10086027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132315 0039d316-1c4b-4281-b951-d872f2087c98

gdata: Remove OnDirectoryChanged from MockGDataSyncClient,
added MockDirectoryChangeObserver for directory change notifications. 

BUG=none
TEST=existing GDataFileSystemTest.*


Review URL: http://codereview.chromium.org/10081032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132312 0039d316-1c4b-4281-b951-d872f2087c98

R=pkotwicz@chromium.org
BUG=113624
TEST=Local bot run.

Review URL: http://codereview.chromium.org/10080006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132311 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123311
TEST=sadrul@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132294

Review URL: https://chromiumcodereview.appspot.com/10082008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132309 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132308 0039d316-1c4b-4281-b951-d872f2087c98

Also update P2PPortAllocator for compatibility with the latest libjingle
changes.

BUG=121613

Review URL: https://chromiumcodereview.appspot.com/10069046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132307 0039d316-1c4b-4281-b951-d872f2087c98

- Ability for WebContents to be replaced.
- Various focus/destruction observers.
- Hook up to BrowserView, replacing TabContentsContainer.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10073014

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10086026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132306 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10082037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132305 0039d316-1c4b-4281-b951-d872f2087c98

Revert 132290 - Remove a dcheck I just added since I apparently don't understand the various circumstances that result in this function being called.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10084027

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10080019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132304 0039d316-1c4b-4281-b951-d872f2087c98