GitLab

This adds a tip on best practices to the documentation for getAuthToken,
and also updates the tip on launchWebAuthFlow to correct an inaccuracy.

BUG=372279

Review URL: https://codereview.chromium.org/305843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274184 0039d316-1c4b-4281-b951-d872f2087c98

Convert the video app into a class. No functionality change.

BUG=171191
TEST=browser test passes.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/307863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274182 0039d316-1c4b-4281-b951-d872f2087c98

Update last_modified when closing cache file.

BUG=346625
TEST=unit_tests

Review URL: https://codereview.chromium.org/304183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274181 0039d316-1c4b-4281-b951-d872f2087c98

The browser side code of the new WebSocket stack needs to
know the ID of the render frame where the corresponding
WebSocketBridge is created in order to handle certificate errors.

This CL just ports the code used by the old WebSocket
implementation to new one.

Blink side change: https://codereview.chromium.org/304113002/

BUG=364361

Review URL: https://codereview.chromium.org/308513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274180 0039d316-1c4b-4281-b951-d872f2087c98

Constants for https, http already exists in our_constants. This patch makes gurl use those constants instead of hrad-coded values. Also it adds constants for WS and WSS.

Review URL: https://codereview.chromium.org/301353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274179 0039d316-1c4b-4281-b951-d872f2087c98

Webviews and OOP iframes now have non-empty parentId property pointing to the target they are nested into. Also added 'webview' and 'iframe' target types.

TBR=bulach,mnaganov (for dev_tools_server.cc aw_dev_tools_server.cc)
BUG=378457

Review URL: https://codereview.chromium.org/305903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274178 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274177 0039d316-1c4b-4281-b951-d872f2087c98

Re-enable the failing expectations for the Pixel.CSS3DBlueBox test.
The <meta viewport> tag added to this test is causing failures on some
desktop bots. See Issue 368495.

> Remove failing expectations for pixel tests.
> 
> This is a follow-up patch for r273755.
> 
> BUG=368495
> TBR=kbr@chromium.org
> 
> Review URL: https://codereview.chromium.org/304183008

TBR=alokp@chromium.org

Review URL: https://codereview.chromium.org/306303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274176 0039d316-1c4b-4281-b951-d872f2087c98

Replace GetResourceListCallback with FileListCallback.
Rename GetAllResourceList and GetResourceListInDirectory to GetAllFileList and GetFileListInDirectory.
Rename FakeDriveService counter variables.
Remove GetOldestCreatedFolderResource in drive_backend_util.cc and merged the code to folder_creator.cc

BUG=231125
TEST=unit_tests

Review URL: https://codereview.chromium.org/305913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274175 0039d316-1c4b-4281-b951-d872f2087c98

Before, the net::IOBuffer was being passed as a pointer, from the
FileStreamReader::Read to operations::ReadFile. However, there are PostTask
invocations on the way. When FileStreamReader is deleted after a PostTask is
fired from FileStreamReader::Read, and the operation is not completed, then
the net::IOBuffer will become invalid. When the operation is completed,
operation::ReadFile would cause a segmentation fault.

Since net::IOBuffer is ref counted, we should pass it as ref counted object
to be sure, that the buffer is always valid.

This patch migrates from passing IOBuffer as a pointer, to scoped_refptr.

TEST=Tested manually, that crashing doesn't occur anymore.
BUG=248427

Review URL: https://codereview.chromium.org/301973007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274174 0039d316-1c4b-4281-b951-d872f2087c98

Implement IsNonNativeLocalPathDirectory for supporting non-local non-Drive directory access in apps.

What the CL does is:
* Almost mechanically moves out the local function CheckIfDirectoryExists
from open_util.cc to fileapi_util.cc and just use it for the desired implementation.
* Removes Drive-specific helper code for the feature.
* Allows file_system_api test setup code to refer the info of File Manager app.
(Because the new general implementation checks the directory existence in the
permission level of the file manager, the test needs access to it.)

BUG=367028

Review URL: https://codereview.chromium.org/304373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274173 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) bef… (https://codereview.chromium.org/272173002/)

Reason for revert:
Regression: makes frameless packaged app windows
unmovable in Aero. Confirmed with local git revert.

BUG=374681
TBR=ben@chromium.org

Original issue's description:
> Fix legacy dummy window visibility inheritance. RenderWidgetHostViewAura may be shown(::Show()) before legacy window creation, in such case dummy window was later created hidden which leads to wrong behaviour. E.g. NPAPI Flash in windowless mode tracks associated window visibility and slows down draw invalidation.
> 
> R=ben@chromium.org
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270739

Review URL: https://codereview.chromium.org/309553010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274172 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
3) Fix data member variables to use unix_hacker_ style.
4) Rename file name to mock_web_user_media_client.
5) Rename class name to MockWebUserMediaClient.

BUG=331299
TEST=content_unittests, content_shell. No functional changes
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/308073011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274171 0039d316-1c4b-4281-b951-d872f2087c98

App launch times can (rarely) be equal, so the comparison should have
been less than or equal to.

BUG=379132
TEST=unit_tests (EphemeralAppServiceTest.*)

Review URL: https://codereview.chromium.org/308003011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274170 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/306893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274169 0039d316-1c4b-4281-b951-d872f2087c98

Prior to this change, the browser compositor allocated
buffers on the UI thread while the buffer allocation for
renderers was done on the IO thread.

This moves all allocation to the UI thread, which makes life
easier for GpuMemoryBuffer implementations and avoids
potentially expensive allocation costs on the IO thread.

BUG=

Review URL: https://codereview.chromium.org/302443008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274168 0039d316-1c4b-4281-b951-d872f2087c98

ShellTestHelper doesn't need to spawn a thread. Nuking the thread
simplifies the view manager tests.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/308053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274167 0039d316-1c4b-4281-b951-d872f2087c98

GetOrDownloadAttachments creates state object that tracks set of attachments
for which requests are still pending. Once AttachmentStore::Read finishes 
AttachmentServiceImpl calls AttachmentDownloader to download attachments that 
were not found locally. 

Once all calls to Downloader finish consumer callback is called with results.

I used AttachmentIdSet in this code but didn't update AttachmentIdList to 
AttachmentIdSet in other places. I'd rather do it in separate change.

R=maniscalco@chromium.org
BUG=376073

Review URL: https://codereview.chromium.org/307783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274164 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a crash in the StartPageView that was happening because
an observer was not being cleaned up on destruction.

This CL also adds a profile change unit test which serves as a
regression test for this issue.

BUG=378572
TEST=Have experimental app list enabled and switch between signed in profiles repeatedly. There should be no crash.

Review URL: https://codereview.chromium.org/305123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274162 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA constant for counting IDC_SPELLCHECK_SUGGESTION_*.

TBR=asvitkine
BUG=378933

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273817

Review URL: https://codereview.chromium.org/306103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274161 0039d316-1c4b-4281-b951-d872f2087c98

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/301193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274160 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274154 0039d316-1c4b-4281-b951-d872f2087c98

This allows other tests in the same suite to call SetPolicyProviderForTesting.

TBR=pastarmovj@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/303393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274148 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370433
TEST=None
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/307203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274147 0039d316-1c4b-4281-b951-d872f2087c98

> Record RenderViewContextMenu.Used histogram before calling observers.
> 
> BUG=378933
> 
> Review URL: https://codereview.chromium.org/306103002

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/301233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371530
NOTRY=true
TBR=sievers

Review URL: https://codereview.chromium.org/310603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/292443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274144 0039d316-1c4b-4281-b951-d872f2087c98

- switches::kGoogleBaseURL is moved into the Google component

- The information of whether background networking is enabled is now obtained
  from GoogleURLTrackerClient.

BUG=373222
TBR=thakis

Review URL: https://codereview.chromium.org/301383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274143 0039d316-1c4b-4281-b951-d872f2087c98

This helper method can be used to determine if a policy comes from the
profile cloud policy provider or from another source. It will be used
to determine the source of the Managed Bookmarks policy and set the
folder name accordingly.

BUG=49598

Review URL: https://codereview.chromium.org/304183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274142 0039d316-1c4b-4281-b951-d872f2087c98

TBR=marja@chromium.org
BUG=379579

Review URL: https://codereview.chromium.org/307213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274141 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379574

Review URL: https://codereview.chromium.org/306053009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274140 0039d316-1c4b-4281-b951-d872f2087c98

It seems to be much more common to have this kind of resources file as a
normal GYP file rather than an *include* GYP file.

$ git ls-files | grep resources.gyp$ | grep -v ash_resources | wc -l
9

vs

$ git ls-files | grep resources.gypi$ | grep -v ash_resources | wc -l
3

BUG=None
TEST=None
R=jamescook@chromium.org
NOTRY=true
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/307993007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379570

Review URL: https://codereview.chromium.org/308253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379564
NOTRY=True
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/312473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274127 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366797
TEST=None

Review URL: https://codereview.chromium.org/303233009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=379561
TBR=dtu@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/309623006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274125 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes a couple more changes to accomodate for the implementation
of this policy:

- moved the kManagedBookmarks pref into the bookmarks component, so that
it can be referred to from there;

- moved the strings for the managed bookmarks folder name for the same
reasons;

- updated the policy schema to support child bookmarks;

- updated the ManagedBookmarksPolicyHandler to use the schema validation
code, and added a new unit test for that.

TBR=nyquist@chromium.org
BUG=49598

Review URL: https://codereview.chromium.org/307993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274124 0039d316-1c4b-4281-b951-d872f2087c98

The gyp file has this in OTHER_LDFLAGS.

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/308003010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274123 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274117 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274115 0039d316-1c4b-4281-b951-d872f2087c98