- 04 Dec, 2017 40 commits
-
-
Marc Treib authored
That's the only call site, and none of the other code in search:: depends on that preference anymore. Bug: none Change-Id: Id10ab76d2e8566f2e5c48c389ceec79ac38093d3 Reviewed-on: https://chromium-review.googlesource.com/803282Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#521305}
-
Gauthier Ambard authored
When the fake omnibox displayed on the NTP is tapped, the location bar should become first responder. This CL removes a check which was useless. Bug: 790749, 791033, 791165 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If1312ad12ada919de7c188e84836e54e32a47fad Reviewed-on: https://chromium-review.googlesource.com/803317Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521304}
-
Daniel Bratell authored
X11 headers pollute the global namespace. Instead we use a wrapper header (ui/gfx/x/x11.h) that puts important symbols in the x11 namespace and removes them from the global namespace. Bug: 782184 Change-Id: I3173f2dde17e6991cc31bd89ceaee8e651ccaf3f Reviewed-on: https://chromium-review.googlesource.com/801390Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#521303}
-
Matthew Cary authored
Failing on KitKat tablet, see bug for details. Bug: 791485 TBR: twellington@chromium.org, mdjones@chromium.org Change-Id: I1fca7a125dbb58bf352d66545ca04e022a4ed564 Reviewed-on: https://chromium-review.googlesource.com/805135Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#521302}
-
josyulavn authored
Corrected typo in documentation. Bug: Change-Id: Ie8d11408c0b5cefe5c2ba5a9a240718b89bb1a19 Reviewed-on: https://chromium-review.googlesource.com/805498Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#521301}
-
Gauthier Ambard authored
This CL fixes the constraints applied to the fake omnibox of the NTP when it is scrolled up. Bug: 791486 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iec1ad1069caebcd7c78a78f2ed155be011050374 Reviewed-on: https://chromium-review.googlesource.com/805246Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521300}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/4e70a72571dd..c4a9e5ff69d2 $ git log 4e70a7257..c4a9e5ff6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifd98522063269ab6893207207565d9724a279e7b Reviewed-on: https://chromium-review.googlesource.com/805495Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521299}
-
Olivier Robin authored
This method is implemented in form_autofill_util.cc. Also fix the findChildTextWithIgnoreList logic. (similarly to https://chromium-review.googlesource.com/#/c/chromium/src/+/788385) Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie43c14018ac01f08a587eba27031f4033d931e82 Reviewed-on: https://chromium-review.googlesource.com/788383 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#521298}
-
Marijn Kruisselbrink authored
This method was dereferencing a weak pointer without first making sure the pointer wasn't null, unlike every other method in the class. This fixes that. Bug: 790772 Change-Id: I980fa47a5afceae36d5843056ed03a88e863adce Reviewed-on: https://chromium-review.googlesource.com/802762Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521297}
-
Vaclav Brozek authored
This CL removes intermediate calls of scoped_task_environment_.RunUntilIdle() from PasswordStoreDefaultTest.Notifications and only leaves the last one. This is enough to verify the test expectations and makes the test slightly faster in debug mode. Some local benchmarking showed that in debug configuration on my machine (Z620, Ubuntu) the test takes 45-50ms before the changes and about 40ms after it. No siginificant difference was perceived in release build. Thanks vasilii@ for spotting this test and suggesting this way of speeding it up. Bug: 788875 Change-Id: Ie9b3d6b65ef8a5f99400acc66c097360259e204e Reviewed-on: https://chromium-review.googlesource.com/803342Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521296}
-
Hiroki Nakagawa authored
All networking APIs including dynamic import() are disallowed on WorkletGlobalScope. This CL makes dynamic import() always reject a promise with TypeError[1] on WorkletGlobalScope. [1] https://github.com/w3c/css-houdini-drafts/issues/506#issuecomment-344488690 Bug: 782538 Change-Id: Ieb94a4502b0ba35ff9b56e51c8fc34467ab96d0c Reviewed-on: https://chromium-review.googlesource.com/790059 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#521295}
-
Henrik Lundin authored
Adding the Enabled group, which is the intended launch config. Bug: chromium:780849 Change-Id: I11a7c6074204a009cdb3b6204da2ed8a7c15a76a Reviewed-on: https://chromium-review.googlesource.com/803271Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Henrik Lundin <hlundin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521294}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/56b08b1f2bb8..8509d3eaec1b $ git log 56b08b1f2..8509d3eae --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Make a CXFA_DocumentParser member Unowned. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib1335d520755701f05135122d7d79005ba6fd7a9 Reviewed-on: https://chromium-review.googlesource.com/804924 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521293}
-
suyambu.rm authored
This CL enables the following, 1.Vulkan support for Skia Renderer leveraging Skia's Vulkan backend. 2.Vulkan context creation based on Skia's GrVkBackendContext. Bug: 582554 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I226cd5819dd89e5b71b605093eed1feb6f5074f9 Signed-off-by:
suyambu <suyambu.rm@samsung.com> Reviewed-on: https://chromium-review.googlesource.com/649387 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521292}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0407506a..0b24b652 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I24d5e214d1d6f1ce06b1da824eccd86433b74ed3 Reviewed-on: https://chromium-review.googlesource.com/805157Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521291}
-
cathiechen authored
Marker_container is a zero height anonymous block and marker is its only child. Marker_container positioned at the side of list content, it shouldn't break margin collapse. Gecko already do this. Change-Id: I8a47605e80eb927165c359a4bfcd66da0f847e4d Reviewed-on: https://chromium-review.googlesource.com/773766 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521290}
-
Suneel Kota authored
Adding runtimeFlags.overlayScrollbarsEnabled would help to make more of these branches take the overlay path Bug: 661783 Change-Id: I1d5523922fe3d6c8f671edd1c54789ef9aae399d Reviewed-on: https://chromium-review.googlesource.com/792833Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#521289}
-
Yuichiro Hanada authored
Always create VirtualKeyboardContainer instead of creating on the fly, so we can register it as an ActivationParent correctly. This change also deletes code that checks the existence of virtual keyboard by the existence of the container window. The location of the container has been changed from between ImeWindowParentContainer & KeyboardContainer, to between VirtualKeyboardParentContainer and KeyboardContainer. The new hierarchy is: RootWindow -> ScreenRotationContainer -> LockScreenRelatedContainersContainer -> VirtualKeyboardParentContainer -> VirtualKeyboardContainer -> KeyboardContainer (which is owned by KeyboardController) -> keyboard contents window. Bug: 731537, 616909 Test: Unit tests pass. Change-Id: Ia9d04fe3ef9b2584dfbe1b785b498f8152fc398b Reviewed-on: https://chromium-review.googlesource.com/771470 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521288}
-
cm.sanchi authored
From discussion on chromium-dev, it was decided to remove 'chrome' namespace. TBR=sky@chromium.org Bug: 289619 Change-Id: Ib1071a21f851bded91100b503f991e09d691f0ff Reviewed-on: https://chromium-review.googlesource.com/789090 Commit-Queue: Chandramouli Sanchi <cm.sanchi@samsung.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#521287}
-
Hidehiko Abe authored
BUG=739622 TEST=Ran trybots. Change-Id: I0ed123db414da86e99846c36bebc657a35f4799d Reviewed-on: https://chromium-review.googlesource.com/803874 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#521286}
-
Yutaka Hirano authored
As we have launched LoadingWithMojo, the virtual test suite is no longer needed. Bug: 603396, 788241 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_mojo Change-Id: Id40b27d02de03d3880076c53283527c5fed7a294 Reviewed-on: https://chromium-review.googlesource.com/805175Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#521285}
-
Hiroki Nakagawa authored
This is a clean-up CL. This specifies "Allow-Access-Control-Origin" header by *.js.headers files instead of "pipe=header()" query parameters for simplification. Bug: n/a Change-Id: Ia18ea8a1e00ea6854f69771d911bf3e4d88379d2 Reviewed-on: https://chromium-review.googlesource.com/804921Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#521284}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b8d86800487d..56b08b1f2bb8 $ git log b8d868004..56b08b1f2 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Make CXFA_SimpleParser members const or Unowned. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idcb0aa7f168c7faf084b59abab91a6905ad184d1 Reviewed-on: https://chromium-review.googlesource.com/804611 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521283}
-
Christopher Lam authored
The console logs are going the other way now. Bug: 791393 Change-Id: I2769852d449ce8edc3ead9b2127a7e63b55786ea Reviewed-on: https://chromium-review.googlesource.com/804711Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521282}
-
Raymes Khoury authored
After the refactor in https://chromium-review.googlesource.com/c/chromium/src/+/756657/ which changes the DSE permissions to be reflected in the user's content settings, we need to make sure these are reset to their default values when the user clicks "Clear and Reset" or "Clear Browsing Data". Bug: 780344 Change-Id: I8e18ecc0d60b9ec0442ab2e5291c55cfd2480b61 Reviewed-on: https://chromium-review.googlesource.com/770592 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#521281}
-
Darren Shen authored
CSSNumericValue.toSum converts a CSSNumericValue into the sum of terms with different units. For example, new CSSMathSum(CSS.em(1), CSS.cm(1)).toSum('mm', 'em') returns new CSSMathSum(CSS.mm(10), CSS.em(1)) Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssnumericvalue-tosum Bug: 776173 Change-Id: I073c9c6d0b3246ff2a085092547ba6dfb2b5a873 Reviewed-on: https://chromium-review.googlesource.com/798932 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#521280}
-
David Bokan authored
This patch fixes MouseEvent.layerX and layerY when root-layer-scrolls is enabled. The layer coordinates are calculated by subtracting from the document location the layer offsets of each parent layer starting from the current layer's parent. This yields the offset within the layer. The repeated subtraction gets us back to the absolute coordinate space. Pre-RLS, this was the same as document/content coordinates. With RLS turned on, the LayoutView is the same size as the frame and clips and scrolls its content. Thus, transforming through it yields frame coordinates. Therefore, the change is to start from the event's absolute location. With RLS off, the conversion yields a no-op so there's no change. When RLS is on this accounts for the LayoutView's scroll offset. Bug: 781431 Change-Id: Ib25859effbfb71516e5edb5173154c807ea98314 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/798832 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521279}
-
Raymes Khoury authored
The default search engine can be disabled by enterprise. In this case, we restore the permission settings for the old DSE. We also delete the underlying pref that tracks settings, so that if the DSE is re-enabled, the DSE permissions will be re-initialized for the new DSE as if being initialized for the first time. Bug: 780344 Change-Id: I6df13d6b085dbe8164fe003c3406245e5b8efb2f Reviewed-on: https://chromium-review.googlesource.com/765566 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#521278}
-
Dmitry Gozman authored
This is a preparation to replace routing id + legacy IPC with Mojo interface retrievable from SharedWorkerHost. Temporarily duplicated some code from WorkerDevToolsAgentHost, which makes it possible to migrate shared and service workers separately. Removed a test for WORKER_STATE manipulations altogether with the state itself. Bug: 776009 Change-Id: Id884f4f5009eb70148251c94cae9629d5a1f6e8e Reviewed-on: https://chromium-review.googlesource.com/783110 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#521277}
-
Leo Zhang authored
This CL is based on crrev.com/c/762540 1, Polish the UI. 2, Reading all language infos from native. 3, Enable "Remove" in the language menu. 4, Enable "Add language" for the settings page. 5, Created "Add language" fragment, it will list all unselected languages and provide a "search" function for users to find the language quickly. Tested on my local devices, demo video link https: //googleo.users.x20web.corp.google.com/screenrecord/chrome/lang-settings.mp4 Bug: 783049 Change-Id: Ie5fdba908a99ad1116538bd69fe9c703c4c9051a Reviewed-on: https://chromium-review.googlesource.com/790091 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521276}
-
Tetsui Ohkubo authored
In Chrome OS, notification corners are rounded. However, when the actions row is expanded, its corners were not rounded. TEST=manual BUG=789056 Change-Id: Id29f3d1d193a682c478249089ae4bfa30c52fad3 Reviewed-on: https://chromium-review.googlesource.com/803134 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521275}
-
Xiaocheng Hu authored
This patch exposes two subroutines of ComputeInlineBoxPosition: - ComputeInlineAdjustedPosition - ComputeInlineBoxPositionForInlineAdjustedPosition After this patch, we can start converting callers of ComputeInlineBoxPosition with the following pattern: DoSomeBusiness(position) { adjusted = ComputeInlineAdjustedPosition(position); if (/* adjusted is laid out with LayoutNG */) return NGAlternativeImplementation(adjusted); legacy_box_position = ComputeInlineBoxPositionForInlineAdjustedPosition(adjusted); DoLegacyBusiness(legacy_box_position); } Bug: 771398 Change-Id: Iea01925e7ef986c5b00dd5b6e7172f7065c8df9e Reviewed-on: https://chromium-review.googlesource.com/792453Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521274}
-
Christopher Lam authored
This CL adds the "HostedAppFrame.WrenchMenu.MenuAction" metric which tracks which menu actions are being clicked from the hosted app browser frame. Bug: 785661 Change-Id: I4b6c349892615452ce8ed6ebc8b1c23e5f1a8a9e Reviewed-on: https://chromium-review.googlesource.com/802838 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#521273}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e0e3bb53. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6851 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I2265c0367b490b15126095e36fb4d623f0329ecd Reviewed-on: https://chromium-review.googlesource.com/805097 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521272}
-
cathiechen authored
"Marker_rect" should contains the block direction offset of marker when propagate overflowRect to its ancestors. Change-Id: Idcbd3ab4688f48879bad3a702b5f19f63e8819d6 Reviewed-on: https://chromium-review.googlesource.com/798936Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#521271}
-
Christopher Lam authored
Flake examples: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/51019 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/51016 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-rel/builds/3170 TBR=mkwst@chromium.org Bug: 791389 Change-Id: I23a57c249151746ba07b70f36ee7aa4ee8da0aeb Reviewed-on: https://chromium-review.googlesource.com/804905 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521270}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: Ia61c712446434a346dbe3ed954fb5b7438dd76a2 Reviewed-on: https://chromium-review.googlesource.com/805098Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521269}
-
Tetsui Ohkubo authored
As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL does not remove ash::system_notifier::CreateSystemNotification right now, as we also have to remove ununsed old |icon| assets with it. BUG=757703 Change-Id: Ibb7e8cdbf01068489b2c0f17443a66043834f1eb Reviewed-on: https://chromium-review.googlesource.com/802658Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#521268}
-
Christopher Lam authored
This CL adds standard wrench menu action stats for Copy URL, Open in Chrome, Site Settings and App Info. Bug: 785661 Change-Id: I1b94804076282ef9ecb97c581fb147670adaae70 Reviewed-on: https://chromium-review.googlesource.com/790172 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#521267}
-
Michael McGreevy authored
This histogram has the same function as WebApk.Install.InstallSource (which tracks the mechanism by which a web app is installed on Android), but is intended for use on any platform. The associated enum has an extra entry, which will be used to count installs which are initiated via calls to BeforeInstallPrompt.prompt(). Once there is enough historical data for Android in Webapp.Install.InstallSource, WebApk.Install.InstallSource will be removed (tracking bug: crbug.com/790788) Bug: 785661 Change-Id: Ie7d185a7e66e1caa2c25e850745171cb32165518 Reviewed-on: https://chromium-review.googlesource.com/802336 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#521266}
-