- 28 Sep, 2020 40 commits
-
-
Alex Rudenko authored
The test has been implemented in [1] and now, when DevTools rolled, it can be enabled. [1]: crrev.com/c/2400478 Bug: 1109224 Change-Id: I43e4dffbf7d50eae856b5c78290768079094ab69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435188Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#811260}
-
Mitsuru Oshima authored
Bug: None Change-Id: I793a6870e81b2f5f50bc8341f45f30829dc40260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433585 Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#811259}
-
Gayane Petrosyan authored
This reverts commit 3a4677f6. Reason for revert: bot failures due to crash at blink::AnimationWorkletGlobalScopeTest::RunScriptAndGetBoolean() see https://crbug.com/chromium/1132893 Original change's description: > Introduce ScriptEvaluationResult > > This CL introduces ScriptEvaluationResult with clearer uniform > semantics that covers both classic and module script evaluation. > ScriptEvaluationResult has ResultType enum class, to explicitly > distinguish cases where normal exceptions are thrown (kException) > from cases where not (kNotRun and kAborted). > > This CL merges ClassicEvaluationResult and ModuleEvaluationResult > into ScriptEvaluationResult. > > This maps: > - ClassicEvaluationResult::IsEmpty() > => ScriptEvaluationResult::GetResultType() != kSuccess > - ModuleEvaluationResult::IsSuccess() / IsException() > => ScriptEvaluationResult::GetResultType() == kSuccess / != kSuccess > > To keep the invariant of kSuccess <=> non-empty v8::Value, > this CL makes ModuleRecord::Evaluate() to return > ScriptEvaluationResult with a non-empty value > on successful evaluation + top-level await is not enabled, > while previously it returned ModuleEvaluationResult::Empty(). > This value is not used, and thus this change doesn't change > the behavior. > > Bug: 1111134, 1129743 > Change-Id: I350860171a3c3b63517641dfb9555b8788386438 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417789 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811244} TBR=yukishiino@chromium.org,bashi@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,nhiroki@chromium.org,cbruni@chromium.org,dom@chromium.org Change-Id: Iaaca1345213b1f3e4fc8ec703257217998ec0826 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111134 Bug: 1129743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435918Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#811258}
-
Torne (Richard Coles) authored
When using a subdirectory of the Android cache dir (e.g. in WebView), explicitly create the directory in PathUtils instead of relying on any user of the directory creating it implicitly. Set the directory mode to 02700 which is what it currently gets set to when created implicitly. Fixed: 963640 Change-Id: I8e1c140241d6a2decfcd27186b767ef05e7a4320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432447Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811257}
-
Titouan Rigoudy authored
For subresource URL requests, the renderer URLLoader uses its factory's parameters to determine the client security state of the request initiator. Navigations however use a central URLLoaderFactory in the browser process. This change introduces a new trusted parameter in ResourceRequest specifying the client security state applying to the current request, if not was set in the factory parameters. Regarding //services/network and BUILD.gn changes in particular: A lot of these changes stem from the introduction of ClientSecurityState as a new dependency of url_loader.mojom and URLRequest's typemap, ResourceRequest. This breaks the existing layering scheme: mojom:url_loader_base -> cpp:cpp_base Because suddenly cpp:cpp_base must depend on mojom:url_loader_base for client_security_state.mojom.h. We break the cycle by extracting the dependency of mojom:url_loader_base from cpp:cpp_base into its own build target: cpp:cpp_base -> mojom:url_loader_base -> cpp:cross_origin_embedder_policy Bug: chromium:1124346 Change-Id: Ie42d604b628a147a3963df0b20cc88b8b61bf98b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401523 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#811256}
-
Aga Wronska authored
The feature has been disabled in Chrome OS < M87 with Finch kill-switch and in this cl we apply the same change in Chromium repo. Bug: 1132862 Change-Id: I7c3446b6a6d7e4d06cdf2df5f12d6cf9eec4dc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435721Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Auto-Submit: Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811255}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad6aeace6eee..59d660c075bd 2020-09-28 ethannicholas@google.com Revert "Revert "moved SkSL BoolLiteral data into IRNode"" 2020-09-28 johnstiles@google.com Update OutParams unit test to demonstrate SkSL failure. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I58a2d4c4e667f379a145bd2816313123aa079d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811254}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/667efcdc..685e35de Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1efc2ba62f0ebbb7588a76c4e37787ea0c8d4800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435658Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811253}
-
Gayane Petrosyan authored
This reverts commit b8368dd1. Reason for revert: CreateSignedInProfile test causes failures on multiple bots Bug: 1132882 Original change's description: > [Profile creation] Show sync confirmation and finish the flow > > This CL proceeds with the happy path of the signed-in profile creation > flow: > 1) After a successful sign-in, the current WebUI for sync confirmation > gets displayed; > 2) After choosing whether to sync, the flow is finished by opening a > browser window for the new profile. > > Error handling and restyling the confirmation page is left for follow-up > CLs. > > Bug: 1126913 > Change-Id: I17b43fe4ec0c0e0f2f9725b1df8e8e59d2c35f3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421592 > Commit-Queue: Jan Krcal <jkrcal@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811140} TBR=droger@chromium.org,jkrcal@chromium.org Change-Id: I89cf0130e744a1feee9649df1895839e0fe4b314 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435330 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This should make tests slightly faster in general, but in particular they may help on Mac where the wait contributes to flakes. Change-Id: I7b8711676123a7fd1ce58505dffbd29f4043b482 Bug: 1131588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434329 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#811251}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ba3d5932bb28..58ceb60bf6b1 2020-09-28 tvanderlippe@chromium.org Move compiler options into tsconfig.base.json 2020-09-28 bmeurer@chromium.org Improve error reporting for the language plugins. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1132281 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I99168aaa966b0e9f201a9c4913a5b555b592887e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435621Reviewed-by:
-
arthursonzogni authored
Since: https://chromium-review.googlesource.com/c/chromium/src/+/2428976 the "receive" timeout is now infinite. It means all the tests in property.https.html will either all succeed or if one of them fails, it will timeout. This patch split the test in order to get individual results. This allow us to prevent individual regression. Bug: 1090273 Change-Id: I5629e4130dbabde44755468bc7b28ea0d0e802f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435638Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811249}
-
Chunbo Hua authored
Bug: 1129754 Change-Id: I6e9c50880541095008f8b71d25455e9a59128f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397669Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#811248}
-
Andrew Grieve authored
Noticed this in binary size review as having a lot of nested classes. Also removes most explicit null checks in favor of implicit ones. Bug: None Change-Id: I9777788512371b497c4236f16073a2b342e1acb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419121Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#811247}
-
cfredric authored
This reverts commit 35a98eb4. Reason for revert: HIDDevice is a "leaf" API, so we should instrument via navigator.hid.getDevices() instead. Original change's description: > Instrument access to HIDDevice and HIDReportItem fields. > > This cl causes the bindings generator to automatically collect UKM when > these attributes are accessed. This will be used to analyze how much > entropy leaked by this API can be used for cross-site tracking. > > Change-Id: I25fddca92048669e25674070b0f619368270346c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424073 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Cr-Commit-Position: refs/heads/master@{#809753} Change-Id: I48f17cb23f3ba7fe7d31be78d6549127f6186fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432666 Auto-Submit: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#811246}
-
https://crbug.com/skia/10744Fredrik Söderqvist authored
SkPictureImageFilter (as wrapped by RecordPaintFilter) now returns the specified target/crop rect when mapping forward. Adjust DiscardableImageMapTest.CapturesImagesInPaintFilters to reflect this, changing the size of the RecordPaintFilter target rect to better show that it is being applied. Bug: skia:10744 Change-Id: I62378591dcf30694d6fe5b2d68eb31d22f2d71f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431489Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#811245}
-
Hiroshige Hayashizaki authored
This CL introduces ScriptEvaluationResult with clearer uniform semantics that covers both classic and module script evaluation. ScriptEvaluationResult has ResultType enum class, to explicitly distinguish cases where normal exceptions are thrown (kException) from cases where not (kNotRun and kAborted). This CL merges ClassicEvaluationResult and ModuleEvaluationResult into ScriptEvaluationResult. This maps: - ClassicEvaluationResult::IsEmpty() => ScriptEvaluationResult::GetResultType() != kSuccess - ModuleEvaluationResult::IsSuccess() / IsException() => ScriptEvaluationResult::GetResultType() == kSuccess / != kSuccess To keep the invariant of kSuccess <=> non-empty v8::Value, this CL makes ModuleRecord::Evaluate() to return ScriptEvaluationResult with a non-empty value on successful evaluation + top-level await is not enabled, while previously it returned ModuleEvaluationResult::Empty(). This value is not used, and thus this change doesn't change the behavior. Bug: 1111134, 1129743 Change-Id: I350860171a3c3b63517641dfb9555b8788386438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417789Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#811244}
-
Andrew Grieve authored
And refactors how input_jars_paths and proguard_configs works a bit. You can now any put any of these variables on any java target's build_config. Bug: 1105693 Change-Id: I332c0ea5637eb7778a12d1ddca3b5fddd54f308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431788 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811243}
-
Francois Beaufort authored
This PR makes sure required PTZ constraints in the basic constraint set are denied (and throw a TypeError) and PTZ capability constraints ({ zoom: true } etc.) are ideal in the basic constraint set. Therefore, a PTZ constraint in the basic set cannot cause getUserMedia() to fail conditionally. Spec: https://github.com/w3c/mediacapture-image/pull/261 https://github.com/w3c/mediacapture-main/pull/707/ Bug: 934063 Change-Id: I7324ae32b064dbf3b89325166834e2694eca593b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411946 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811242}
-
Andrew Shulaev authored
Context: https://docs.google.com/document/d/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA/edit# Bug: 1007635 Change-Id: I28ba29b8360f030f62945b351555cbea69127482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435641Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Andrew Shulaev <ddrone@google.com> Cr-Commit-Position: refs/heads/master@{#811241}
-
Ewann authored
This CL adds parametrized tests in order to be able to test the different file types added with the kExtendOpenInFilesSupport feature. Bug: 1117398 Change-Id: I1c7fc04cc9ce2c0ac2f9f6a135b50fea524f2267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379716 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#811240}
-
Gayane Petrosyan authored
This reverts commit 1b36f1a7. Reason for revert: causes weblayer_browsertests failure Bug: 1132848 Original change's description: > Add autoplay parameter to navigations. > > Bug: 1131881 > Change-Id: Ia152dc0a76d1f9ad6eff87f74fef2ad17b327b91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432755 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810932} TBR=sky@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1131881 Change-Id: Id853eaab83af2bc6cf4392a12d3b104bf6652442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435718Reviewed-by:
-
Alex Rudenko authored
Refactoring done in [1] is changing the internals of the overlay that the test intercepts. This CL disables the test temporarily and modifies it to intercept the new function. I have verified that the test is passing with the new changes in [1]. [1] https://crrev.com/c/2429775 Bug: 1131801 Change-Id: Ibd586a7435270aed3c82c5b1e26946d75fd37043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435644Reviewed-by:
-
Alice Wang authored
This CL adds an observer to update ProfileDataCache when user's profile photo(include monogram) from IdentityManager is updated. Bug: 1127886 Change-Id: I0c70f72708e50dceb63eb122055315f7818cba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430984Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811237}
-
Olivier Robin authored
WebStateListMetricsBrowser requires SessionRestorationBrowserAgent, so it must be initialized earlier. Also initialize WebStateListMetricsBrowser member variables that were left uninitialized. Bug: 1132784 Change-Id: I28b9d5afca58870a6273eb1c3b3418a45c9fcd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435344 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811236}
-
Mohamed Adel authored
The newly added response builder returns an NSDictionary that can then be used to process the notification and to handle interactions with it. Bug: 1131515 Change-Id: I81703650acde994c287945cc8f6a323b1bc18c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426586Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#811235}
-
Sebastien Lalancette authored
These tests cover both Recent tabs from Settings as well as from the Tab grid. They test the Copy link, Open in New Tab and Share functionalities. Also disabling drag-and-drop in Recent Tabs when EarlGrey tests are running. This fix is temporary as the EG team is working on resolving the problem. Clean-up is being tracked in: crbug.com/1129058 Bug: 1131831 Change-Id: I61e069102e7932e9b51860e82f0eeedbcd0459c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431786 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#811234}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Ic655bd6062ee95ba1bc2e11d0b77bdac10fc322c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347036Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#811233}
-
Danyao Wang authored
Also updated ownership. Bug: 1128111 Change-Id: Iba6ba54d4a47e02579faa69ff7078ba6ab012333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426977 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811232}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601272286-5f5720137a0694fa0bfa67350ff5844644ba53c0.profdata to chrome-linux-master-1601294375-f18d3a3ac9a6313011d7149de4bf7e7984859ae2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I1022e3730c315dadb814ead5dc00cc1f4e6c0288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435618Reviewed-by:
-
Robbie Gibson authored
Currently, text zoom doesn't work on iPad. This experimental method should work there. Bug: 1061119 Change-Id: Iaad93125be9752b5d70385be39ed6414a566228b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424142 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#811230}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/55c178693cdc..b6103ff5f992 2020-09-28 danilchap@webrtc.org Test scalability structures do not suggest disabled layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4ac5135fc1e26bc566f092771a2eba9d141cd654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435262Reviewed-by:
-
Dominik Röttsches authored
When attempting to match a font from Android downloadable fonts, there is a scenario in which no font can be created from the returned file descriptor. Check for null SkData before testing for isEmpty() Bug: 1127513 Change-Id: Icaa8e6fadfca6750e9eccb78e6d20c5de20c7f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429272Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#811228}
-
chrome://flagsArthur Hemery authored
Removes the now deprecated cross-origin-opener-policy flag. Note that unfortunately it is not possible to completely remove the feature, due to selective disabling on Android Webview. BUG=1129108 Change-Id: I226f87d3583ea38be1a486ec623fb5d59a30f69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425050Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601272286-d5061451d97ba33a632a304f531ce91f70d7428a.profdata to chrome-mac-master-1601294375-805284c073a4c807365387c8b737f70c270f4966.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id9156081c22a3a4e13f1fc038634c63f4941747d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435619Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2f6cc6f606c..059781eddd4e 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 7f9879b1b1fa to e1ba543c6789 (1 revision) 2020-09-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 9e17b9d07a25 to 4b07d50cd9a0 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I65dc84f58b6d2acca645cea0b4e972b0e59acbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435258Reviewed-by:
-
Viktor Semeniuk authored
This change adds possibility to edit username in Settings > Passwords. If edited username is already used for the same website error message is shown. Bug: 377410 Change-Id: Ifbd45f459e2d6731f8e5fd6bf7df069efd6999ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424315 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#811224}
-
Saurabh Nijhara authored
Currently we are only reporting metrics when force installed extensions either fail installation or ExtensionRegistry's OnExtensionLoaded (...) event is received. This CL reports the time elapsed for enterprise policy forced extensions to become ready for use by reporting statistics when force installed extensions either fail installation or ExtensionRegistry's OnExtensionReady(...) event is received. These statistics are being collected as part of the effort to improve force installed extensions reliability. Following histogram is added: Extensions.ForceInstalledReadyTime Bug: 1131418 Change-Id: Ief524819deb8cca81231765439700c265d9e7b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424286Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#811223}
-
Caitlin Fischer authored
The switch appears to be unused. Bug: 1126640 Change-Id: I07728ca316e91051c349615b49304e27c3e81ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427074Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#811222}
-
Adam Rice authored
Change the expectations for the web test fast/dom/Window/window-postmessage-clone-deep-array.html so that it no longer produces "unexpected pass" messages. The test still fails, but this is handled by an -expected.txt file only, without an entry in TestExpectations. Change-Id: Icfb89c4942cc9147fa3d24972464d5f2eeda31aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432704Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#811221}
-
