- 07 Aug, 2018 40 commits
- 
- 
Chris Hamilton authoredBUG=846953 Change-Id: Ic354c61147f14f080341aba36220cb81324df81e Reviewed-on: https://chromium-review.googlesource.com/1165302 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#581285} 
- 
Penny MacNeil authoredChange-Id: I22e31b6dd6a5e2a6c809f0563a614b4d3150a969 Reviewed-on: https://chromium-review.googlesource.com/1164390Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#581284} 
- 
Sam Maier authoredCurrently, AsyncTask.execute() defaults to the SERIAL_EXECUTOR. This exector is good for preventing concurrency errors since it guarantees serial execution, but bad for performance since the entire app shares this single queue. It looks like these callsites are stuck with the SERIAL_EXECUTOR, since they both call updateAccountRenameData() which is not thread safe. Bug: 869907 Change-Id: I23ac4430cd10acb61842ee1b37c36d8c36f0f8af Reviewed-on: https://chromium-review.googlesource.com/1161092Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#581283} 
- 
Guido Urdaneta authoredThis CHECK should be removed since it is being hit in rare cases. This first CL is to try to gather more information in clustefuzz reports about the state when the CHECK is hit, since we have been unable to reproduce it locally. The CHECK will be removed in a follow-up CL. Bug: 871714 Change-Id: Iefed096801002e8f4d022723c07c876ff10b0014 Reviewed-on: https://chromium-review.googlesource.com/1165542Reviewed-by: Florent Castelli <orphis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#581282} 
- 
Yue Li authored- Assistant need to be destructed before voice interaction controller client in order to correctly remove the observer. Bug: b/112273549 Test: Manual Test Change-Id: I6360dcdca38dd8d50ac6bbf768841f34d375b31b Reviewed-on: https://chromium-review.googlesource.com/1164411 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581281} 
- 
webrtc-chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/7008287219b6..b3e2c8eb1b16 git log 7008287219b6..b3e2c8eb1b16 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 buildbot@webrtc.org Roll chromium_revision 39d45f08..474eca05 (580730:581204) 2018-08-07 srte@webrtc.org Makes units constexpr when possible. 2018-08-07 titovartem@webrtc.org Move spl_sqrt_floor dep to proper third_party directory Created with: gclient setdep -r src/third_party/webrtc@b3e2c8eb1b16 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id7e6656b8df57fe0f234221bd46e94f229afc40f Reviewed-on: https://chromium-review.googlesource.com/1165325Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581280} 
- 
Wez authoredThe AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I8bd55d5ff4eb7c3078d5d1b8bb075bcfff5a7345 Reviewed-on: https://chromium-review.googlesource.com/1165590Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581279} 
- 
Jacob Dufault authoredTap to unlock still should work on an empty password, though. Bug: 839320 Change-Id: Id5fd17c9428ddc2b6823cd3c63a5f21aa486b860 Reviewed-on: https://chromium-review.googlesource.com/1164257 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#581278} 
- 
Fredrik Hubinette authoredThis reverts commit 1638e067. Reason for revert: New tests are flaky and causing problems when submitting code. Original change's description: > [heap] Do not revive WeakMember during incremental marking > > Overwriting deleted values with cleared values potentially revives > buckets in collections. For atomic garbage collections this is not a > problem as those values are filered out in the visitors already. For > incremental garbage collections the deleted values may be introduced by > erasing a value from a container after it has been visited by the > incremental marker. > > Bug: chromium:870196, chromium:757440 > Change-Id: I1d628f00c2e2ea6e36e880d50a397dcbcc8566d1 > Reviewed-on: https://chromium-review.googlesource.com/1164950 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581238} TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org Change-Id: I632b5594d137acd37b4639ebcd46f8d61638dbc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:870196, chromium:757440 Reviewed-on: https://chromium-review.googlesource.com/1165328Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#581277} 
- 
Charlie Andrews authoredBattOr is being removed from Chrome tracing. Before the code for it can be deleted, we need to do this. TBR=inferno@chromium.org Bug: 859514 Change-Id: I3f88e147570e05c4056052aebfc085648231a4f3 Reviewed-on: https://chromium-review.googlesource.com/1162631 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#581276} 
- 
Gauthier Ambard authoredWhen the UnifiedConsent view is presented by the ConsentBump, it shouldn't be interactable: it shouldn't be possible to change the selected account or to tap the settings link. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I343157986df387382539746e12cca87e0121b413 Reviewed-on: https://chromium-review.googlesource.com/1165148 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581275} 
- 
Avi Drissman authoredBUG=871740 TBR=tnijssen@google.com Change-Id: I6c19c03148cdd7f5499d2fba114690a4b258d8c8 Reviewed-on: https://chromium-review.googlesource.com/1165319Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581274} 
- 
Jérôme Lebel authoredReorganizing GoogleServicesSettingsCommandID enum and <GoogleServicesSettingsCommandHandler> to match the UI layout. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie60468e0d3f2f2ad3b9ad3d515675ab4deafaaa8 Reviewed-on: https://chromium-review.googlesource.com/1163663 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#581273} 
- 
Ryan Meier authoredTabStrip now calls ActiveStateChanged() on tabs when they are removed from the view model, giving them a chance to update any relevant state (such as background/text color, etc). Bug: 859321 Change-Id: Iaad9d3dfa2d378c708a648315e5bdef9e2f2ff5f Reviewed-on: https://chromium-review.googlesource.com/1162429 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#581272} 
- 
Stefan Zager authoredBUG=847623 R=chrishtr@chromium.org Change-Id: Ib8cefc856ecbeadfdeecabcf7f20b6d3b457db6a Reviewed-on: https://chromium-review.googlesource.com/1164473 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581271} 
- 
Min Chen authoredBug: 862308 Change-Id: I2f018ab228eaee5ca3bcbdd9a318d71f05612ca3 Reviewed-on: https://chromium-review.googlesource.com/1164564Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#581270} 
- 
Ted Choc authoredBUG=870843 Change-Id: I1ae9d16a9238fd5f669ab487eeed02f45068ba92 Reviewed-on: https://chromium-review.googlesource.com/1162708 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#581269} 
- 
yoshiki iguchi authoredThe sidebar was the project which replaced the current system tray but it was taken over by the unified system tray. So the sidebar was no longer used. This CL removes the sidebar-related unused code. Bug: 871665 Change-Id: Iaea91177182bf87d8b09c00a9a38edfa78daedda Reviewed-on: https://chromium-review.googlesource.com/1164815Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#581268} 
- 
Matt Menke authoredRemove several tests that have been renamed, and annotate two other sets of tests with more details and new bugs. Bug: 769401 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic8d7b9158ebb6b3c551546c83639e3ad1431db26 Reviewed-on: https://chromium-review.googlesource.com/1164313Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581267} 
- 
Becky Zhou authoredThe maximum scroll offset varies among different screen height. It's not very reliable to use the hard-coded html body height for testing. This patch simulates scroll based on the maximum scroll offset from the RenderCoordinates instead. Bug: 871305 Change-Id: I983036b8d72d60c4077eea1cbc39b2177e6aebf4 Reviewed-on: https://chromium-review.googlesource.com/1164416 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581266} 
- 
Adrienne Walker authoredThis test case has a DrawRecord in the middle of it. There was some hope previously that because this fuzzer memset all the memory it was allocating, then all the unwritten memory could be consistent. However, because a bunch of other memory gets allocated when serializing then that memory can have garbage in the padding. When simple ops memcpy as a part of serializing or deserializing, they bring along that garbage, which can cause binary differences. This was lucky that this has ever worked on Skia serialization, so remove the binary comparison and just use the logical comparison. Bug: 870647 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie20097c4df4953bb6503caff81ad811dc69acc63 Reviewed-on: https://chromium-review.googlesource.com/1162746Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#581265} 
- 
Kenneth Russell authoredThis reverts commit a0c5484d. Reason for revert: Still causes failures of maps_pixel_test, this time on Nexus 5 device: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205%29/7545 . Previously seen in http://crbug.com/870001 . Original change's description: > Reland [blink] Add a time limit to message processing in MessagePort > > In addition to existing limit of 200 messages in a single task also > limit it to 10 milliseconds to avoid starvation. > > This logic will be removed when message-per-task mojo dispatching > will be implemented. > > BUG=867133 > R=mek@chromium.org > > Reviewed-on: https://chromium-review.googlesource.com/1152815 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#579751} > Change-Id: Idb757ddbc91c3e732e34e834bf8e00cc2292ddb5 > Reviewed-on: https://chromium-review.googlesource.com/1163782 > Cr-Commit-Position: refs/heads/master@{#581184} TBR=mek@chromium.org,altimin@chromium.org Change-Id: I9de23aa6fa95b06e5aa47cedc30ecd5f9d6ccaed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867133 Reviewed-on: https://chromium-review.googlesource.com/1165527Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581264} 
- 
Nico Weber authoredFixes a few things I got wrong in https://chromium-review.googlesource.com/1163932 - Also add win-asan to the chromium.memory standalone console. Main waterfall and sub-waterfall consoles are apparently completely independent, so do the same bot reordering I did in the above CL here too. - Also add win-asan to the luci.chromium.try bucket Bug: 869973 Change-Id: I9e32f15b2869b0adafb4f291e9e4147184baa84a Reviewed-on: https://chromium-review.googlesource.com/1164645Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581263} 
- 
Toni Barzic authoredThe CL fixes FindConfig implementation to return nullptr for unknown components. FindConfig used std::find_if to find a matching component config. For non-existing elements, find_if returns the last iterator (in this case std::end(kConfigs)), which is invalid, but non-null. BUG=None Change-Id: I53ff08d43131d4f8bfd02c8e02347de095ed6094 Reviewed-on: https://chromium-review.googlesource.com/1164581Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581262} 
- 
Oksana Zhuravlova authoredChange-Id: I4dc93adea48598f3ad98775c3d5235235943ae1b Reviewed-on: https://chromium-review.googlesource.com/1162390Reviewed-by: Ken Rockot <rockot@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#581261} 
- 
Aga Wronska authoredonline and offline). Bug: 868025 Test: Run DemoSetupTest, DemoSetupControllerTest and WizardControllerDemoSetupTest. Change-Id: Ifca8bc7f4c053d2ff060ee0fc529f38690124a65 Reviewed-on: https://chromium-review.googlesource.com/1157543Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#581260} 
- 
Chromite Chromium Autoroll authoredhttps://chromium.googlesource.com/chromiumos/chromite.git/+log/06a50f7eab7c..265047706b90 git log 06a50f7eab7c..265047706b90 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@265047706b90 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I575a18ba4f053aac43480f476195d7c63828b1fe Reviewed-on: https://chromium-review.googlesource.com/1165324Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581259} 
- 
Tommy C. Li authoredIn a previous CL, we moved the security chip label left by 2dp to align with URLs in the case where we have an unlabeled lock icon. However, in doing so, we accidentally un-aligned the indented search keyword label with the suggestions text. This CL fixes that. As far as I can tell, in the old pre-Refresh world, the extra internal spacing used for the search keyword provider just matched the value of GetPrefixedSeparatorWidth() as a matter of coincidence. This CL divorces those two for post-Refresh, because "something's gotta give". Bug: 865546 Change-Id: I464cd61f360d6ba1a53bca46a973cd0193ede9fc Reviewed-on: https://chromium-review.googlesource.com/1164394Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#581258} 
- 
Avi Drissman authoredBUG=871812 TBR=rjwright@chromium.org Change-Id: I64dc5078e3f92c18fb95b7eec1e664798bd18d26 Reviewed-on: https://chromium-review.googlesource.com/1165315Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581257} 
- 
Randy Rossi authoredChromevox on chromecast was failing on providing chrome.metricsPrivate API due to its id hash not being in the whitelist. This halted processing of swipe gestures. Added hash to whitelist. Bug: 871792 Test: Manual Change-Id: Ic37100b70e3ca32890b88c8de0470f26ee93864b Reviewed-on: https://chromium-review.googlesource.com/1155162 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#581256} 
- 
bsheedy authoredMoves the workaround for the Daydream controller flakily disconnecting and reconnecting immediately after entering VR into the EmulatedVrController class. This means that we don't have to add sleeps anytime we use the emulated controller, and tests don't have to care about the workaround unless they're re-entering VR while using the emulated controller (none currently do). Bug: 870031 Change-Id: Icd590ffbd1348764cc945ddd1d72e341febba33e Reviewed-on: https://chromium-review.googlesource.com/1164317Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#581255} 
- 
Theresa authoredThis reverts commit 79a6ffe5 and introduces test implementations of the scheduler and network client. These test implementations ensure the Feed stops trying to load content so that Chrome can finish starting up. BUG=854866 Change-Id: I41da8b433a7ab3b7a6786a3be2960598f3e3479e Reviewed-on: https://chromium-review.googlesource.com/1162771 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#581254} 
- 
Ted Choc authoredThe MVC refactor for UrlBar.java: https://chromium-review.googlesource.com/1148680 converted empty text strings to pass in SCROLL_BEGIN. The logic for properly scrolling empty RTL text existed only within SCROLL_TO_TLD. This moves and unifies the logic within the SCROLL_BEGIN handling. This also fixes some issues with resetting the previous scroll state too aggressively so that multiple calls would need to recalculate. BUG=871147 Change-Id: I8cbe07a4765b991fa39999dd92ae8dcc8f08538a Reviewed-on: https://chromium-review.googlesource.com/1164477 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581253} 
- 
Corentin Wallez authoredTo allow embedding SPIRV-Tools in multiple projects (Chromium, ANGLE, Skia, Dawn) we added overridable variables that replace hardcoded paths to dependencies. BUG=chromium:870747 Change-Id: I2041528305739035b46c700719386597bd9b553a Reviewed-on: https://chromium-review.googlesource.com/1162239Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581252} 
- 
Quinten Yearsley authoredBug: 871456 Change-Id: Id3a70ac107c7a06a210a7bc90392a63f557c0d8c Reviewed-on: https://chromium-review.googlesource.com/1164254Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#581251} 
- 
Scott Violet authoredWithout this tests that try to connect to ash a service hang. I get the following gl errors: libGL error: No matching fbConfigs or visuals found libGL error: failed to load driver: swrast [171208:171216:0802/122357.849400:5628725490183:ERROR:gl_context_glx.cc(227)] Couldn't make context current with X drawable. [171208:171216:0802/122357.849448:5628725490229:ERROR:gpu_info_collector.cc(68)] gl::GLContext::MakeCurrent() failed BUG=869739 TEST=test only change Change-Id: Ib3fa4e01c715664e17bdcafd1af0ca98c34ff2dc Reviewed-on: https://chromium-review.googlesource.com/1161171Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581250} 
- 
Rouslan Solomakhin authoredBug: 775647 Change-Id: I78a9cf071fb843808effdd63c4380a99b59046a4 Reviewed-on: https://chromium-review.googlesource.com/1165310Reviewed-by: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581249} 
- 
Avi Drissman authoredThis reverts commit 7dae0f63. Reason for revert: As per the Findit comment, this introduced flakiness. Original change's description: > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy > > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed: > 1. If the policy was disabled before, and becomes enabled, > subsequent calls to StartRemoteLogging() will succeed (barring > unrelated issues), even for peer connections created while the > policy was disabled. > 2. If the policy was enabled before, and becomes disabled: > a. Peer connections associated with the profile reject > calls to StartRemoteLogging(). > b. Active logs (associated with the profile) are stopped, > and those log files deleted. > c. Pending log files (associated with the profile) are deleted. > d. If a log file associated with the relevant profile is > currently being uploaded, the upload will be cancelled, > and the file deleted. > > Bug: 775415 > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f > Reviewed-on: https://chromium-review.googlesource.com/1162168 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Elad Alon <eladalon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581167} TBR=avi@chromium.org,pastarmovj@chromium.org,guidou@chromium.org,eladalon@chromium.org Change-Id: Ia8d317dbd6d058d94255554c05d3d0393045af75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 775415, 871809, 871810 Reviewed-on: https://chromium-review.googlesource.com/1165602Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581248} 
- 
Avi Drissman authoredBUG=871799 TBR=miu@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I63e3694a2f006daab624cf434da682dbd725f789 Reviewed-on: https://chromium-review.googlesource.com/1165313 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581247} 
- 
Peter Kasting authoredBug: none Change-Id: I01f71178f5319556d5d749ff360b8433fac507ed Reviewed-on: https://chromium-review.googlesource.com/1139180Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581246} 
 
-