- 15 Jul, 2020 24 commits
-
-
Maksim Ivanov authored
The <cmath> header is needed for the log() function. Without this, the build fails in some configurations (e.g., when building inside Chrome OS SDK). Bug: none Change-Id: I425913a03173936a1949c022679852cc5242618d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297509Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#788429}
-
Matt Falkenhagen authored
Bug: 1092329 Change-Id: If310c9209d347315f531221fd8c46bc6227f70be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291185Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788428}
-
Shakti Sahu authored
This CL adds an additional flag that will act as a gateway for query tiles feature. Any current usage of query tiles will check for this feature as well. This is required for running country based experiments while not introducing crosstalk with other omnibox experiments. Finch CL : https://critique-ng.corp.google.com/cl/321059391/ Bug: 1105246 Change-Id: Ic89ed0c0be462709fe99b58b680bcbc15b5fe087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296287 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788427}
-
Xiyuan Xia authored
Crashes in https://crbug.com/1088432 and https://crbug.com/1099844 seems related to InkDrop and somehow an invalid LayerAnimationSequence gets in LayerAnimator's |animation_queue_|. Suspect it is caused by calling InkDropImpl::DestroyInkDropHighlight recursively when removing the layer. In such case, "highlight_->set_observer(nullptr)" could cause memory corruption since |highlight_| could be released. I don't have a repro but the recursive call could happen for InkDropImpl::DestroyInkDropRipple. This CL revises the two functions to prevent them being called from under Layer::Remove as speculative fix of the suspected memory corruption. Additionally, DestroyInkDropRipple() could trigger highlight to be created. This is unnecessary during destruction and sometime crashes, e.g. http://crash/34b439742c22c966 Bug: 1088432, 1099844 Change-Id: Ic5c032bce827a98ad5c564e4d67333743ea67189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293215 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#788426}
-
Frank Liberato authored
base::Optional used |&| in its placement new and operator->() implementations, which doesn't work as intended for types that provide overloads of operator&(). This CL replaces them with std::addressof. Bug: 1104378 Change-Id: I2301f435223ae45338c93469965b2b188a194ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293223 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788425}
-
Dirk Pranke authored
This reverts commit b6798215 (change #784739) and re-lands commit 956c4dcc (change #784653) (without the addition of //docs/testing/test_executable_api.md, which landed separately already). Other changes landed that made the re-land possible. Original change's description: > Add a first pass of the desktop test wrapper scripts. > > As described in the linked bug and documented in > https://docs.google.com/document/d/19qpDeR2z-8j-WQJC-5waSd134kz94UXgYU_e_N-VplU/edit?usp=sharing > we want to change how tests are launched under swarming so that > they all have a consistent API and usage. > > We need to do at least some of this work now in order to unblock > work going on in Swarming to change how a task's command line and > list of files are specified, but doing all of the work in the linked > doc and bug will significantly restructure how we configure and launch > tests, and should bring a lot more consistency to our continuous > integration infrastructure. > > This CL is a first step: a proof of concept that converts > url_unittests on desktop to the new API in a backwards-compatible > way (i.e., this will work with the existing chromium recipes). TBR=tikuta@chromium.org, liaoyuke@chromium.org Bug: 816629 Change-Id: Ia4d20501783f844fdbc1728ee986724c5301d638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280322Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#788424}
-
Steven Bennetts authored
NetworkStateHandler::SetProhibitedTechnologies has an unused error callback that unnecessarily complicates the ShillPropertyHandler implementation. This removes it to simplify the code and the conversion to OnceCallback. Bug: 1007660 Change-Id: I43cf4b7cafa847754ae36f2d12737b331bf54d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292726Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788423}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594670295-0a4f7f614ea3d9de6fcc3b138431b409b2b96371.profdata to chrome-win32-master-1594753046-ef9d371c47540400b1490f52cf3260906b5b98d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I40ac37e0c2da2d47a948a187190b52b70b387506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788422}
-
Chris Cunningham authored
Feature disabled by default. Enable with command line: --enable-features=MediaCapabilitiesQueryGpuFactories Historically info.powerEfficient was determined by the VideoDecodePerfHistory DB. This patch instead queries the GpuFactories (proxy for hw decode) for to ask the question directly. The critical difference is that the DB requires some past data to be correct, while GpuFactories will know the answer without ever having played a video. Change-Id: I402bc03d008c73fa1bccf61beb61609efaf42ddf Bug: 1105258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295684 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#788421}
-
Sorin Jianu authored
This reverts commit 2a3cc46b. Reason for revert: it is breaking the Android build. Original change's description: > Make CrxDownloader a ref-counted thread safe type. > > This avoid retention issues and allows instances of CrxDownloader to > be shared between sequences when interfacing with RPC modules such as > BITS/DO for Windows. > > There are some mechanical changes such as removing macros.h and > replacing thread checkers with sequence checkers (but not for the > BITS downloader, which has thread affinity due to COM RPC). > > Change-Id: I62e159d4ae8999ec70da94247f91f9cc26a5d278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293461 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#787857} TBR=sorin@chromium.org,waffles@chromium.org,makumo@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I17b5dd71fdcbe709dcbb4396edb6d8f520beafb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297714Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788420}
-
Roman Arora authored
Bug: 1099917 Change-Id: Ide10c0b59f3e677fb2b9afc63ec6882ff778d8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292818 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#788419}
-
Maksim Ivanov authored
Add ability to wait until the extension's background page gets ready into the ExtensionForceInstallMixin. Migrate the tests in signin_profile_extensions_policy_browsertest.cc to this new functionality. Bug: 1090941 Change-Id: I096407bad477bf44256db90feae24bbe10171bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290630 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#788418}
-
David Black authored
Before: http://shortn/_GZDd6jROyK After: http://shortn/_hAfM7eHYxM Bug: b:157510970 Change-Id: I1ab5552d7766d9c57d9dd88b8d27ea3bcf2a0d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296362Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#788417}
-
Noel Gordon authored
Refer to CL:2096321, in which we mentioned exposing more of the elider button tap target (for touch users) by moving the breadcrumb drop down menu vertically down 8px per the files-ng spec [1]. [1] At the time we used 4px to match the gear and sort buttons, filing a bug to remind us to shift all the "action-icon" drop down menus down 8px (they should not overlap their 48px tap target box). .___. | | <= <button> tap-target 48px box |___|_________. | | | menu-item 1 | | menu-item 2 | <= drop-down menu box | menu-item 3 | |_____________| Bug: 1059490 Change-Id: Ic6d36caf7ac4c26cd7ef329bcb9d51a60547e769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297020 Auto-Submit: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#788416}
-
Henrique Nakashima authored
Bug: 1093962 Change-Id: Ic19ea0b07ac9cd20f361f2a39048a55e78533910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297713 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#788415}
-
Evan Stade authored
KitKat is deprecated so this is obsolete. Also, remove some reflection since the P SDK is now available. Bug: 1095714 Change-Id: I241f8ebbf0c319d9033f5adde58133799cf3ee9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296363 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#788414}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fad2090a5e81..35dec5f127c3 2020-07-14 guterman@google.com Add gerrit_change_owner field to tryserver recipe api 2020-07-14 nodir@chromium.org [dirmd] Add dirmd executables 2020-07-14 nodir@chromium.org [dirmd] Deploy dirmd 2020-07-14 guterman@google.com Analyze DEPS autorolls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104246,chromium:923016 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: If2214cecee5fee1ef17fce596d649b4a38c1e655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298197Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788413}
-
Gayane Petrosyan authored
Add Sharing Highlights android specific flag and dummy icon to Sharing Hub. screenshot: default - https://screenshot.googleplex.com/doZDXMtS1wM.png dark - https://screenshot.googleplex.com/ch3op4EHiOX.png Bug: 1102382 Change-Id: Ia82579c95f0782b0ca5b5f2bacd9dd4d42f188fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295779 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#788412}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8db0c721..7e3ef3c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2436035671b2710e2c6fd60ab96584286bc5665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298265Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788411}
-
David Benjamin authored
This fixes some easy instances of the privacy_mode_enabled boolean. Rather than reconstruct the enum out of QuicServerId's boolean, use the Chromium accessor. (The Chromium accessor currently reconstructs things itself, but I'm hoping we can change that. Either way, this avoids some duplicated code.) Where privacy_mode_enabled was logged as a boolean, I've switched to a string rperesentation pulled out of url_request_netlog_params.cc. Also I've filled in a few missing parts of QuicSessionKey in one of the log events and sync'd up with the comments in net/log. Bug: 1103350 Change-Id: I6906fa802f6ebb0a8b6c187519df68a74a1d3b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296629 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#788410}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/5bd5f0f67a5e..c46e79c76012 $ git log 5bd5f0f67..c46e79c76 --date=short --no-merges --format='%ad %ae %s' 2020-07-11 wzk784533 avoid unnecessary memory copy Created with: roll-dep src/third_party/leveldatabase/src Change-Id: Ie3bc5ceb4539ddc92da2f6439b6790aebf728e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296799 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#788409}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e5c184751160..4ad0f250a010 2020-07-14 jmadill@chromium.org Revert "Vulkan: Enable VK_KHR_get_memory_requirements2 extension" 2020-07-14 timvp@google.com Update README.md to indicate GLES 3.1 conformance 2020-07-14 lehoangq@gmail.com Metal: Create a dedicated class for Window Surface. 2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 2a164e9680a5 to 858b13a1220a (1 revision) 2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from d704d1bc0e11 to 0bc4c2ae7012 (1 revision) 2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ad65826a2ab1 to cd0af6456eb1 (5 revisions) 2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 4e13c90944e9 to fe24a54808c2 (3 revisions) 2020-07-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 68bfbc219497 to 521eaacef67a (1 revision) 2020-07-14 syoussefi@chromium.org Vulkan: Fix resolve draw path 2020-07-13 m.maiya@samsung.com Vulkan: Enable VK_KHR_get_memory_requirements2 extension 2020-07-13 enga@chromium.org Revert "Refactor DisplayGbm::generateConfigs" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1105208,chromium:1105609 Tbr: jonahr@google.com Change-Id: I94d94d763cfd0df6de4a23f1d876f42ae3b963dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788408}
-
Aya ElAttar authored
Added the ClipboardDataEndpoint destination trying to read the clipboard data as a as a parameter for all ui::Clipboard Read*() functions. This destination is intended to be used only on ChromeOS and Test platforms. This CL adds this plumbing. Implementation of filtering will be done in following CLs. Bug: 1096456 Change-Id: If689ed3e38fc92c0ec50c043bf67312e59aeaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266901 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788407}
-
Marijn Kruisselbrink authored
We plan to ship with this disabled in M86, so turn all the old API surface off sooner rather than later to give people using the origin trial more time to adapt. Bug: 853326 Change-Id: Iacc74d13715bad6d5baaba1e24fd353e002aec16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246904Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#788406}
-
- 14 Jul, 2020 16 commits
-
-
Adam Rice authored
Start running browser test WebSocketBrowserTest.SendCloseFrameWhenTabIsClosed on Windows again. This was flaking on the bots 2 years ago but doesn't fail when run locally. Experimentally re-enable it to see if it is still flaky. BUG=616958 Change-Id: I2f927e47593ba5e2e2541a4843db37327129792a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282840Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#788405}
-
Steven Bennetts authored
This is part of a greater effort to cleanup callbacks in chromeos/network. Bug: 1007660 Change-Id: Iab7825de0892295d2758082764775d645915ef29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290548 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#788404}
-
Lukasz Anforowicz authored
The rewriter used to recognize that //v8 is in a separate git repository and treated it as third-party. After this CL, the rewriter knows about additional, similar paths that 1) are in a separate git repository and 2) do not contain a "third_party" substring. Bug: 1069567 Change-Id: I6ff1a8e10ec3a4b8bae4521aaebe88aed7714be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296826Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#788403}
-
Andrey Kosyakov authored
This includes an IWYU fix for <alogrithm>. TBR=kvitekp@chromium.org Change-Id: If016f6b1e8e4ef92a04c36c99aeed5b21032b9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298170Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#788402}
-
Christopher Cameron authored
This is no longer needed. A follow-up patch will delete the factory itself. Bug: 1092155 Change-Id: I436c065c844eb7ce07f8918f5c093c15c6c2b409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296274Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788401}
-
Jin Chen authored
Bug: internal b/159937174 Test: CQ, build chromecast Merge-With: eureka-internal/423679 Change-Id: I993eea66d26b410f7bacffac9b971f986fd01ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293105 Commit-Queue: JinJie Chen <jinjiechen@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788400}
-
chrome://appsJun Kokatsu authored
This change makes chrome://apps compatible with Trusted Types mitigation by combination of removing usage of dangerous sinks, and assigning TrustedHTML to dangerous sinks either with emptyHTML or creating Trusted Type policies. This change also renames variable names according to guidelines. Bug: 41905 Change-Id: I7aea389a8d23849fb5bc89d12a10e46d3c2fddcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239707 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#788399}
-
rbpotter authored
Move the annotations bar to a separate element. Also delegate some logic related to the ink controller to this new element from the pdf_viewer, instead of relying on events and getters to pass data back from the viewer down to the annotations bar and back. Specifically: - Pass the ink controller to the annotations bar via polymer bindings - Listen for annotation-undo-state events and call redo/undo directly from the annotations bar, instead of doing this in the viewer. - Add a new loaded event in the ink controller, so that the annotations bar can listen for this event to update the annotation tool when the ink controller loads, instead of needing to access the tool from the pdf viewer. Bug: 1100431 Change-Id: Ifb4219d1df321d84666091f3707686a544f96e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285479 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#788398}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dcda36de8344..4290f3d1534f 2020-07-14 aerotwist@chromium.org [TypeScript] Fix formatter_worker/HTMLFormatter types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1098730 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3fcee98f0f1c574656089624ff0be4ca1a43fee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298247Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788397}
-
Christopher Cameron authored
This was IOSurface-specific for no good reason. Move it to the common GLImage code. TBR=geofflang Bug: 894929 Change-Id: If39c03985ebf0e3db72fd96534a903975cac0ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296568Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788396}
-
Kenichi Ishibashi authored
This CL replaces old resource reader in ServiceWorkerInstalledScriptReader. The new mojo-based reader gives a data pipe for reading response body so ServiceWorkerInstalledScriptReader no longer needs to have helper functions that converted a net::IOBuffer to a data pipe. Bug: 1055677 Change-Id: I3d0edafa4ea6fcb80bcb0167c5d54d0afef43138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282552Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788395}
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of partition_alloc.h by 160KB. This CL has no behavior changes. This CL affects 8,400+ compilation units. Bug: 242216 Change-Id: I7cfa2a79f8ed7604fcd71fef2ec21cfa11b295a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297026 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#788394}
-
Justin Cohen authored
Bug: 1101058 Change-Id: Ic2bb25d5652a77c401471f067c76feef7e740303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277977 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#788393}
-
Kenichi Ishibashi authored
This is a wrapper of ServiceWorkerStorage::GetRegisteredOrigins(). Bug: 1055677 Change-Id: Ifca679ed80a0b06c6e30bab824275b8b6b5a8137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291922Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788392}
-
Fergus Dall authored
This reverts commit c670ba45. Reason for revert: Test is still broken, see https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/57063 Original change's description: > Reland "Turn on Media History by default" > > This is a reland of ccf0e2f9 > > Fixes TSAN issue in the constructor of sql::Database > by moving it to the main thread. > > Original change's description: > > Turn on Media History by default > > > > BUG=1024351 > > > > Change-Id: Id01595e63f5f776a226087741ef602ba30b80328 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224 > > Auto-Submit: Becca Hughes <beccahughes@chromium.org> > > Commit-Queue: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787954} > > Bug: 1024351 > Change-Id: I19be665637f5c28261f7197547ddc5fe6671127e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296884 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788312} TBR=beccahughes@chromium.org,steimel@chromium.org Change-Id: I49684e84563a84f09c8436d55371c88122129132 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297209Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#788391}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/a5812a0bf342..ad56e3f17dd1 $ git log a5812a0bf..ad56e3f17 --date=short --no-merges --format='%ad %ae %s' 2020-07-14 quiche-dev Consolidates bool members of quicspdysession to reduce wasted padding. 2020-07-14 wub In bbr2sender::adjustnetworkparameters, 1) do not inject a bandwidth sample to max bandwidth filter, and 2) update pacing rate after cwnd is updated. protected by --gfe2_reloadable_flag_quic_bbr2_improve_adjust_network_parameters. 2020-07-14 bnc Minor improvements to quic/core/http:end_to_end_test 2020-07-14 dschinazi Deprecate Q048 and Q049 2020-07-14 bnc Fix hpack error code mapping to quicerrorcode. not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ieb4bc409e7d0c6a569107588453dac88c29e27b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298167 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788390}
-