- 13 Oct, 2020 40 commits
-
-
Yoichi Osato authored
This reverts commit 77bfcdcd. Reason for reland: added Linux SlowTests expectations. Original change's description: > Revert "Enable fetch send ArrayBuffer more than 128 MB" > > This reverts commit 96c04c00. > > Reason for revert: crbug.com/1136750 > > Original change's description: > > Enable fetch send ArrayBuffer more than 128 MB > > > > This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> > > so that fetch can send big ArrayBuffer. > > > > Bug: 919361 > > Change-Id: I45c3c560ca787858453c677cc0c7fbc8c1983063 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415810 > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#815479} > > TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,yoichio@chromium.org > > Change-Id: Ie4339d0cf4b709efb961abe569cbe1fa7cb116e3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 919361 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462908 > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815506} TBR=kinuko@chromium.org,rockot@google.com,yhirano@chromium.org,hajimehoshi@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 919361,1136750 Change-Id: I11049160e52a93bd7c757ec75eaa035b029124b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462979 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#816800}
-
Meilin Wang authored
Screenshot: https://screenshot.googleplex.com/77SePNbWg2gvy53.png BUG=1106937,1126208 TEST=unittested. Change-Id: I75974a008dae69e282d34091202c0887c34e4ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464087Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#816799}
-
Vincent Boisselle authored
Bug: 1137846 Change-Id: Ie695a12b14ec58a240ec3242a5c27958ad4e4405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463717 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#816798}
-
Adam Langley authored
We already skipped splitting batches for caBLE devices, but AOA is a different transport. But it needs the same accommodation. BUG=1002262 Change-Id: I1dbe58516464ba1cd1294327b4b42f277e16e949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463810 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#816797}
-
Brian Malcolm authored
Manager may be either a domain (foo.com) or the email address of the admin of the organization (user@foo.com). BUG=chromium:1081272,b:169152988 Change-Id: I11be31e4ea04bc637c700b6ebedbe94b67cd223b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467981 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#816796}
-
Steve Kobes authored
As a side effect, this fixes layoutShiftScoreBeforeInputOrScroll in the "CumulativeShiftScore::AllFrames::UMA" trace event added in crrev.com/768267, which was previously always 0 as we did not set layout_shift_score_before_input_or_scroll in PLMUD::page_render_data_. Also correct description of MainFrame.BeforeInputOrScroll UKM to reflect that both element and document scrolls terminate the accumulation. UKM collection review: go/hofeq Bug: 1115529 Change-Id: Icc7b4b30ef813bf4b774e9c5dfb64c0472d08ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351961Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#816795}
-
Wan-Teh Chang authored
Undo an unintended whitespace change in commit 87f7cffc, except that TABs are replaced by spaces. Change-Id: Ib1f08a4ff8bc14869cd8579fe37d30701953be3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468710Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816794}
-
sczs authored
Bug: 1122031 Change-Id: Ie2733764f57d824cb9bf61155c69ddb248e4c704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468715Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#816793}
-
minch authored
Bug: None Change-Id: Ia980d35c49adc85e7bbca908c6e6a6438d668a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468572 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#816792}
-
Alexei Svitkine authored
As mentioned on the referenced bug, these are no longer logged. Bug: None Change-Id: If52c473b89dddf3fb60e16b86cbd3caa70c949b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462224 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#816791}
-
Phu Le authored
The OpenXR runtime on Windows supports both "opaque" (WMR VR devices) and "additive" (Hololens). This change simply turns on support for Immersive-AR session according to the WebXR AR-module spec. The majority of the change is to let the runtime to decide about the blend_mode and interaction_mode instead of the current guessing logic at at the renderer layer. Bug: 1069350, 944936 Change-Id: I26bfd02c17405299b2880045326d23fc880ea069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468358Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Phu Le <phle@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816790}
-
wutao authored
Currently in Settings page, the request settings and update settings calls are independently, which could make local cache |settings_| out of sync of server side. Two potential timing issues are: 1. Call UpdateSettings(), and immediately call RequestSettingsAndAlbums(). It is possible that RequestSettingsAndAlbums() reads stale settings on server earlier than the server is updated. When RequestSettingsAndAlbums() returns, it will overwrite local |settings_| with old value, but the server got updated with new value. 2. Vice versa, call RequestSettingsAndAlbums(), and then immediately call UpdateSettings(). RequestSettingsAndAlbums() returns with old value and overwrite local |settings_| with old value. For example: 1. On album selection page (ambientMode/photos page), user makes changes to select different albums. It will change local cache |settings_| to the selected albums list. And call update settings to server. 2. Immediately, user goes back to ambientMode page, current code will trigger requesting settings from server. 3. It is not guarantee that update settings will update server before request settings, so if request settings succeeds earlier, it will return stale data and overwrite local |settings_|. The major changes in this patch: 1. When request settings, if there is ongoing UpdateSettings(), we do not call RequestSettingsAndAlbums(). We update the UI when UpdateSettings() returns. 2. When update settings, if there is ongoing RequestSettingsAndAlbums(), we invalidate the weakPtr to prevent changing local settings, and call UpdateSettings(). 3. If UpdateSettings() fails, will update UI with previous settings data. Bug: b/169448409 Test: Added new unittests Change-Id: Icfc156fba22087b6b438464d7ac9a711a31a390c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458951Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#816789}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ca259e28639..1148dc0fdaad 2020-10-13 chrche@microsoft.com Remove backtick for lock terms in en-US.ctc.json files 2020-10-13 brgoddar@microsoft.com CSS: Fix inspector-stylesheet links on devtools reload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1137527 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I20a3497e4a2896d4bf693de82b823933354eba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468386Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816788}
-
Kartik Hegde authored
Add the GatewayCanBePinged routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) Applied GatewayCanBePinged changes and successfully ran the GatewayCanBePinged routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=gateway_can_be_pinged). Change-Id: I942ead41313756f84a9b717809390809f6f331f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344648Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#816787}
-
Swapnil authored
We want to investigate why the force installed extensions fail to install with error CRX_HEADER_INVALID. This CL adds UMA statistics to record whether the extension is downloaded from cache or not when extension fails with CRX_HEADER_INVALID error to get more details about it. New histogram added: "Extensions.ForceInstalledFailureWithCrxHeaderInvalidIsFromCache" Bug: b/170087934 Change-Id: I843e4a1c2cce87b3975e2ad426f9b8177a744878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460734Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#816786}
-
Jesse Schettler authored
Instead of using UTC timestamps in the filenames of scanned images, use local time. Bug: 1059779 Change-Id: I163e1181a5b8c0412d9930f3c11f8f219bc15c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469137 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#816785}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c197a4f6. With Chromium commits locally applied on WPT: f7ed1fa9 "Avoid DCHECK failure when reusing space and newline with white-space:pre" c2d62d36 "[Longtasks] Fix buffering before observer" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I26ae27a154a200bc93f0aeec642deb625d5493a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468917Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816784}
-
Meilin Wang authored
Previously the Dismiss button on notification opt in view is not focus traversable when navigating through the tab key. This CL fixes this issue by replacing it with the existing |InterstitialViewButton| which is focusable by default and shares the common setup of system menu buttons. Screenshot: https://screenshot.googleplex.com/4qjFN3Aqm9rKENp.png BUG=1106937,1126208 Change-Id: I12da67a65f064793322628c5bb5a5ea1f45dee43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466977Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#816783}
-
Nina Satragno authored
https://github.com/fido-alliance/fido-2-specs/pull/1036 fixed the member ID for large blob key on GetAssertion. The spec used to quote both 0x0b and 0x07, and I originally implemented the one that didn't get chosen. This feature is guarded behind the WebAuthenticationLargeBlobExtension feature flag. https://w3c.github.io/webauthn/#sctn-large-blob-extension Bug: 1114875 Change-Id: I7ae04dbb35b5df586271737858071b6ee5601cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468639 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#816782}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //ios/build. R=sdefresne@chromium.org Bug: 1113033 Change-Id: I83aeb5ac131c5adbdfa5ade47adda727d3a1c6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468714Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#816781}
-
Cammie Smith Barnes authored
This change fixes the ranges for PageLoad.Clients.Ads.Memory.MainFrame.Max and PageLoad.Clients.Ads.Memory.UpdateCount, which were initially too small. This CL also replaces 'bytes' with 'kilobytes' in the histogram descriptions of the PageLoad.Clients.Ads.Memory.*.Max metrics. We are not versioning the metrics as this is a bug fix just a couple days after launch. Bug: 1136598 Change-Id: I790abcf40d0469469ad519401470bcd09ced59ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462339Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#816780}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b60eeeee9ddb..01898ca871b2 2020-10-13 bsheedy@chromium.org Reland "[Devil] Add install sanity check" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1132297 Tbr: nuskos@google.com Change-Id: I042d45ffcd5eed9e6ba3ac2f9141590d5df52bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468284Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816779}
-
Taylor Bergquist authored
Prior to this CL, the tabstrip always occupies the entire width of the titlebar area (minus the caption buttons). Changing this allows us to lay out the NTB just to the right of the tabstrip view itself instead of having the tabstrip control the NTB's bounds. This CL does that by simply changing the FlexRule governing the tabstrip's width (and fixing the numerous resulting bugs). This is a modified reland of https://crrev.com/c/2336296. Changes from that version: - PreferredSizeChanged() while dragging, since the dragged tabs may have been moved past the previous extents of the tabstrip. - Take tab closing mode into account when determining the tab area's preferred width. - Bypass ScrollView when observing the tabstrip's preferred size changes. - PreferredSizeChanged() in SnapToIdealBounds, since the tabs may have been snapped outside the previous extents of the tabstrip. Known issues: - Tab closing mode doesn't play nicely with scrolling in all cases. That was true before this CL, but this moves around which cases are broken. Bug: 1093972 Change-Id: I214534847bd07c53829005b7496a9b9bc63e6d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432088 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816778}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: Id077c3928c977f6eabc70d6849970d1809445019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468942Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#816777}
-
Zentaro Kavanagh authored
- components/viz/host/client_frame_sink_video_capturer.h :99 Add #include <memory> for unique_ptr<> :127 Add #include <string> for string Bug: None Test: No linter errors Change-Id: I35a38c1e5e4b1c6f1ada7e0396d30504f0da35a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468959 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816776}
-
Roberto Moura authored
Add the HorizontalReorderingLayout, which is the layout of the thumb strip when reordering cells while the DragAndDrop flag is disabled. Add a set of helper functions to be called by both the HorizontalReorderingLayout and the GridReorderingLayout. Change-Id: Id0b475c7e9cb97c537ce3b30d3936d0c82d1f2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462125Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#816775}
-
Xinghui Lu authored
The "turn on enhanced protection" text is less than 48dp tall. As a workaround, make the entire block tappable on mobile: http://screen/Tsh8yQNYnrLNgeW Bug: 1097120 Change-Id: I20c7e280609ad48ac9bebd74520c3cfebed6e885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466723Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816774}
-
Elly Fong-Jones authored
When building with coverage support, clang splices in some extra instructions to gather coverage data. This change has ImmediateCrashTest skip over these extra instructions when built with coverage support, which makes this test pass properly under coverage. Bug: 1137062 Change-Id: I70b03c8ced865ed169d307448a22be44db2537c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468240 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#816773}
-
Etienne Pierre-doray authored
This is necessary so that results show up in telemetry. Change-Id: I6f0329f9efb9874def0e60418d14e69d69da9e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456514Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#816772}
-
David Grogan authored
Change-Id: If3cafee7b0627d3b930e63f975a793d7bee8c421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468790Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816771}
-
Yue Ru Sun authored
This changes the counts of chosen event types logged to the UMA histogram UKM.Entries.Recorded.ByEntryHash. This is for testing alert setups that monitors significant spikes or drops of UKM event counts by event type. This change does not affect any counts or values reported to UKM. See linked bug for justification regarding the choice of event types and multiplier values. Bug: 1137922 Change-Id: I40e529800aaa0b7883140c6ee5a2258981e737f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464083Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#816770}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //cloud_print. R=thestig@chromium.org Bug: 1113033 Change-Id: Ia122edb4dbc3ef1918f0b27102c784833cd262e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468262 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#816769}
-
dpapad authored
Leverage latest improvements to autogenerate WebUI .grd files for optimized builds as well. Also rename c/b/r/settings:build_polymer3 to :build, and settings_v3.html to just settings.html, as there is no longer a need to differentiate between versions. Bug: 1132403 Change-Id: Ie7e7a06e256bab540da673f458880f8caef367df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465505Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816768}
-
Chan Li authored
Bug: 1108016 Change-Id: I16519d67523fc0f2079d836c663b2604a188cc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468936Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#816767}
-
danakj authored
This reverts commit 47c81eeb. Reason for revert: Was landed for M87 branch Original change's description: > Remove CHECK for same-document provisional frames for M87 beta. > > R=nasko@chromium.org > > Bug: 1125106 > Change-Id: If05f064715add137e16118a08da153d1d5ed0e3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465809 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816752} TBR=danakj@chromium.org,nasko@chromium.org Change-Id: I6a37a0026dde48dd06f07d26aaed140c8713c36e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1125106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468243Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816766}
-
Daniel Classon authored
Adds a metric for the kTouchpadSpeed setting on the Device Page. It records the sensitivity value that the slider was set to. Bug: 1133553 Change-Id: I85cbc27b0bced774672fa1bbbcbc2508ff23092c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459789 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816765}
-
Samuel Huang authored
This reverts commit 3b99bb24. Reason for revert: Suspected of causing TraceEventDataSourceTest.StartupTracingTimeout failure in services_unittests on Builder Linux CFI. Original change's description: > Reland "[tracing] Remove special handling of task execution and log events" > > This reverts commit 989724c3. > > Reason for revert: > Fixing test failures. The msan failures were due to hash operator trying > to hash uninitialized padded bytes of the struct. Fix the struct to not > have any padding. > > Original change's description: > > Revert "[tracing] Remove special handling of task execution and log events" > > > > This reverts commit f79b1513. > > > > Reason for revert: Breaks WebKit Linux MSAN > > > > The following tests started failing since this landed: > > > > * http/tests/devtools/tracing.js > > * http/tests/devtools/tracing/decode-resize.js > > * http/tests/devtools/tracing/timeline-paint/update-layer-tree.js > > * http/tests/devtools/tracing/timeline-style/parse-author-style-sheet.js > > * http/tests/devtools/tracing/tracing-record-input-events.js > > * http/tests/devtools/tracing/user-timing.js > > * http/tests/devtools/tracing/worker-events.js > > * http/tests/devtools/tracing/worker-js-frames.js > > * inspector-protocol/sessions/tracing-start.js > > * inspector-protocol/timeline/tracing-proto-format.js > > > > First run that failed, also the run where the CL landed: > > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7830 > > > > Original change's description: > > > [tracing] Remove special handling of task execution and log events > > > > > > The task execution and log events are handled specially for writing > > > proto arguments because we did not have the support for typed events in > > > base and interning support for the event macros. Now these events can > > > use the new client library API. > > > The events have to be migrated together because the source location > > > interning index is common for all events in the API and does not > > > account for the special handling in event sink. > > > > > > BUG=1136635 > > > TBR=chirantan@chromium.org > > > > > > Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636 > > > Reviewed-by: ssid <ssid@chromium.org> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Reviewed-by: danakj <danakj@chromium.org> > > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > > Reviewed-by: Eric Seckler <eseckler@chromium.org> > > > Commit-Queue: ssid <ssid@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#815911} > > > > TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1136635 > > Change-Id: I7a84356400bbdcae3144fd65afdcab7a4407dcd9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462895 > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#816069} > > TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1136635 > Change-Id: Ia659185ebeb265dc47ff6c2ef47bd9d8cc43dd65 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466507 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: ssid <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816620} TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org Change-Id: Ib19224f57b12b423dfbf40f51ebfcc946be061ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1136635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468503Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#816764}
-
Dave Tapuska authored
The frame could be null, ensure if it is we return early. BUG=1130991 Change-Id: I8ced1223f4beb281adcb06c99d9b0fc4b761333e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468237Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#816763}
-
Siyu An authored
AutofillEnableStickyBubbleAndUpdatedLogging" Change was reverted in crrev.com/c/2438609. Reason was that for upload save card bubble we need to explicitly enable flag features::kAutofillUpstream. Bug: 1070799 Change-Id: Ib2d2cb35306b2d855a6223942249b3d7a4f4b5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464203 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#816762}
-
Wenbin Zhang authored
Removing ANGLE test from WIN 7 test builder. Bug: chromium:1137628 Change-Id: Ib234e8351716b77261bf9a4efb4ab9804f0424f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466621Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#816761}
-