- 13 May, 2014 40 commits
-
-
tfarina@chromium.org authored
This parameter is unused, so we don't need to pass it down to DidChangePriority() anymore. This is another small chunk from r267947 unlikely to regress anything. BUG=265753, 338338, 237249 TEST=content_shell works fine + content_unittests --gtest_filter=ResourceDispatcherTest.* R=jam@chromium.org Review URL: https://codereview.chromium.org/272343003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269996 0039d316-1c4b-4281-b951-d872f2087c98
-
sungmann.cho@navercorp.com authored
Currently, the lint warns at: Error: Field requires API level 18 (current min is 14): android.provider.Settings#EXTRA_ACCOUNT_TYPES [InlinedApi] Error: Field requires API level 16 (current min is 14): android.view.View#SYSTEM_UI_FLAG_FULLSCREEN [InlinedApi] So we need to add @TargetApi to suppress these lint error. BUG=327768 Review URL: https://codereview.chromium.org/273313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269995 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Review URL: https://codereview.chromium.org/284703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269994 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
Send the device scale factor from Windows 8 ASH during initialization via the MetroViewerHostMsg_SetTargetSurface IPC message. cpu, please review everything. sky, please review the ash/chrome/ui portions. I added a dependency on gfx in the metro_driver project for a subsequent change to send the correct device scale factor on Windows 8 as the metro API does not appear to work correctly causing text, etc to appear very small on high dpi monitors with scales above 125%. BUG=371219 R=cpu,sky Review URL: https://codereview.chromium.org/271543009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269993 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
BUG=372497 Review URL: https://codereview.chromium.org/283503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269988 0039d316-1c4b-4281-b951-d872f2087c98
-
leng@chromium.org authored
There is a small chance that the permission bubble manager for a given web contents has been deleted before an asychronous permission request has been handled. BUG=371085 Review URL: https://codereview.chromium.org/282693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269987 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=372098 TEST=none TBR=sky Review URL: https://codereview.chromium.org/279393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269986 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
"Native" theme is sometimes synonymous with "system" theme, and sometimes not. Change some uses of "native" to "system" to avoid confusion with the class called NativeTheme. BUG=none Review URL: https://codereview.chromium.org/244893004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269985 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
TBR=markusheintz@chromium.org BUG=356741 Review URL: https://codereview.chromium.org/288443003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269983 0039d316-1c4b-4281-b951-d872f2087c98
-
ycheo@chromium.org authored
The test is 30% failed in Galaxy Nexus, JellyBean at DCHECK(!needs_establish_peer_) of WebMediaPlayerAndroid::play(). We need to defer the steam texture creation also when we have the switch, kForceUseOverlayEmbeddedVideo. BUG=372174 Review URL: https://codereview.chromium.org/281523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269982 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269979 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
BUG=364318 Review URL: https://codereview.chromium.org/279683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269977 0039d316-1c4b-4281-b951-d872f2087c98
-
zysxqn@google.com authored
BUG= Review URL: https://codereview.chromium.org/268673007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269976 0039d316-1c4b-4281-b951-d872f2087c98
-
jbauman@chromium.org authored
The callbacks are overridden by WebTestProxy in layout tests, and layout tests should be the only times that they're called, so they're not useful anymore. BUG=362164 Review URL: https://codereview.chromium.org/279373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269975 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This is a split of https://codereview.chromium.org/279213002/, to avoid merging issues. It is almost impossible to land a CL adding histograms via CQ, without a merging conflict. TBR=isherman@chromium.org TEST=Just histograms, no actual changes. BUG=248427 Review URL: https://codereview.chromium.org/280783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269973 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
New in this version: - Runs checklicenses.py against the code when running update_dom_distiller_js.sh - Picked up a couple new changes (including fix for checklicenses.py failure) Original Description: The update script should build `ant package` and copy the entire out/package directory. This moves the path to domdistiller.js to .../package/js so update that reference. The old (non-proto) API is still supported, so this keeps using that. Picked up changes: a15dc85 Change json protoc generation directory f9c9a21 Add GENERATED FILE header to proto-plugin files e99285f add *.pyc to .gitignore fdb023d Fix Proto module's path 44e9366 This adds two simple protoc plugins. Review URL: https://codereview.chromium.org/282663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269972 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
These are required by Blink platform which I'm working on now. Also adds a missing enum to the GN target name description function. BUG= Review URL: https://codereview.chromium.org/276263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269971 0039d316-1c4b-4281-b951-d872f2087c98
-
wjywbs@gmail.com authored
The ToString() overloading function of inline and reference enums will conflict because they exist in both global namespace and local classes. This patch chooses the correct ToString() function in different namespaces. R=kalman@chromium.org BUG=371042 Review URL: https://codereview.chromium.org/279833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269969 0039d316-1c4b-4281-b951-d872f2087c98
-
mtomasz@chromium.org authored
This is a split of https://codereview.chromium.org/284443002/, to avoid merging issues. It is almost impossible to land a CL adding histograms via CQ, without a merging conflict. TBR=isherman@chromium.org TEST=Just histograms, no actual changes. BUG=248427 Review URL: https://codereview.chromium.org/288483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269968 0039d316-1c4b-4281-b951-d872f2087c98
-
bajones@chromium.org authored
Only fails with D3D9 ANGLE. Didn't notice earlier because D3D11 and Conformance 1.0.3 updates happened at roughly the same time. BUG=372511 TBR=kbr@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/285583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269966 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=372423 Review URL: https://codereview.chromium.org/284543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269965 0039d316-1c4b-4281-b951-d872f2087c98
-
vangelis@chromium.org authored
> use accessTopLayer instead of (DEPRECATED) getTopDevice > > NOTRY=True > > the win_chromium_rel failure must be a flake, since my CL only edits mac-only files. > > the mac gpu failure is unrelated to this CL > > Review URL: https://codereview.chromium.org/248113005 TBR=reed@google.com Review URL: https://codereview.chromium.org/275813005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269964 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
The tip is to suggest auth flows are initiated from app UI explaining why. Without this, if a signed out user launches an app that immediately initiates an interactive auth session, the first thing the user sees is a chrome signin screen. BUG=372279 Review URL: https://codereview.chromium.org/273423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269963 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
There's some logic in ServiceRuntime to support a future implementation for CloseManifestEntry, but since we don't take any useful action, it's much simpler to always return true. This makes ServiceRuntime even smaller. This also removes an unused struct in ServiceRuntime. BUG=239656 Review URL: https://codereview.chromium.org/280613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269962 0039d316-1c4b-4281-b951-d872f2087c98
-
vandebo@chromium.org authored
BUG=NONE Review URL: https://codereview.chromium.org/269603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269960 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
This is important to make sure apps handle this, particularly when we remove the sign in requirements. BUG=372279 Review URL: https://codereview.chromium.org/277313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269959 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
BUG=361266 Review URL: https://codereview.chromium.org/232843006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269958 0039d316-1c4b-4281-b951-d872f2087c98
-
rsadam@chromium.org authored
We currently have tests only for the full IME layout. Expand the IME test framework to test the Compact layout as well. BUG=372539 Review URL: https://codereview.chromium.org/272293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269957 0039d316-1c4b-4281-b951-d872f2087c98
-
zea@chromium.org authored
BUG=339762 Review URL: https://codereview.chromium.org/278053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269956 0039d316-1c4b-4281-b951-d872f2087c98
-
tsepez@chromium.org authored
Also try to touch (potentially corrupt) arrays, but do not insist on specific values being present. I also tidy up the JS a bit, getting rid of some underscores and double-quotes that crept in despite what the style guide says. R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/267343006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269955 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
The ViewMsg_SetBackground message currently passes an SkBitmap that signals if the RenderView should have an opaque background or not. We can use a bool instead to convey this data. Rename the ViewMsg_SetBackground to ViewMsg_SetBackgroundOpaque as well as the Set/GetBackground methods on the various RenderWidget/View classes. RenderWidget itself no longer needs to know about the background opaque changes. R=kenrb, piman BUG=362164 Review URL: https://codereview.chromium.org/274453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269953 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=none R=sbc@chromium.org Review URL: https://codereview.chromium.org/275523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269952 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
* Be tolerant of truncated files. These happen in practice if the fuzzer runs out of disk space. * Clear the decoder's input buffer if decoding fails. * Relax third-stage decoder checks, as there are valid cases where the second-stage encoder produces an output which the decoder will refuse. BUG=353237 Review URL: https://codereview.chromium.org/284643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269951 0039d316-1c4b-4281-b951-d872f2087c98
-
rlp@chromium.org authored
[Hotword] Add new base URLs for the additional languages so it works on their respective local search urls. The function has been tested manually inside Chrome since it will not work as part of the larger system until the extension and some server side pieces are in place. BUG=345806 Review URL: https://codereview.chromium.org/277523005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269950 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
BUG=371469 Review URL: https://codereview.chromium.org/280673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269949 0039d316-1c4b-4281-b951-d872f2087c98
-
teravest@chromium.org authored
GetPNaClResourceInfo() currently performs a 1 megabyte allocation. Though any memory allocation can fail, this one is more likely due to its size. This change mitigates this problem in two ways. If memory allocation fails, we report an error and return early instead of using memory. Additionally, this change checks the size of the file before performing a memory allocation. This should lead to smaller allocations and more successful plugin loads. BUG=370965 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269791 Review URL: https://codereview.chromium.org/274673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269948 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
BUG=370925 TEST=ash_unittests and visual (using wifi advanced dialog which is the biggest known dialog) Review URL: https://codereview.chromium.org/277223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269947 0039d316-1c4b-4281-b951-d872f2087c98
-
ccameron@chromium.org authored
With this patch, pixels appear on screen and tab capture works. Add a OnNativeSurfaceBuffersSwapped mechanism to display an IOSurface to an NSView. This is wired up to the existing CompositingIOSurfaceMac. In a future refactoring, something much more light-weight than CompositingIOSurfaceMac will be used (CompositingIOSurfaceMac has capture code, etc, in it). Add a DelegatedFrameHost to RenderWidgetHostViewMac, and hookup the DelegatedFrameHostClient implementation. Create the DelegatedFrameHost when a delegated frame is received, and use its existence to determine which mode is active. BUG=314190 Review URL: https://codereview.chromium.org/267073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269946 0039d316-1c4b-4281-b951-d872f2087c98
-
plundblad@chromium.org authored
Change log for this release: - Remove searchvox uncompiled js files. - Allow aria live regions to be announced when observed on a background tab. - Correctly speak live regions that have opacity 0 when shown but subsequently fade in. - Announce changes to controls trigged on key up, not just on key down. - Remove key echo work around so Google U.S. English (from the web store), can speak characters again. - Don't read the entire contents of a dialog when first focused. BUG=372552 TBR=dtseng@chromium.org Review URL: https://codereview.chromium.org/274963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269945 0039d316-1c4b-4281-b951-d872f2087c98
-
bengr@chromium.org authored
BUG=372349, 371626, 371204 Review URL: https://codereview.chromium.org/280583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269944 0039d316-1c4b-4281-b951-d872f2087c98
-