GitLab

Allow Elements who are not styled but have class set to be retrieved using getElementsByClassName.

Matches FF behavior.

https://bugs.webkit.org/show_bug.cgi?id=94718

Review URL: https://codereview.chromium.org/458663003

git-svn-id: svn://svn.chromium.org/blink/trunk@180414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add support to new-line character handling in error and warning console
message texts which are shown in a popover in editor.

BUG=404380
R=vsevik

Review URL: https://codereview.chromium.org/478963002

git-svn-id: svn://svn.chromium.org/blink/trunk@180413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/476083002

git-svn-id: svn://svn.chromium.org/blink/trunk@180412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch adds tooltips with actual pixel values of serifs, representing
CSS breakpoints on CSS ruler.

BUG=391240
R=pfeldman, dgozman

Review URL: https://codereview.chromium.org/478953002

git-svn-id: svn://svn.chromium.org/blink/trunk@180411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There's no need to repaint fixed position layers that are squashed. Necessarily
they must be squashed onto other fixed position layers, which means they don't
move during scrolling.

R=vollick@chromium.org

Review URL: https://codereview.chromium.org/478823002

git-svn-id: svn://svn.chromium.org/blink/trunk@180410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The event should report DOM.RGBA color instead of string.

R=pfeldman@chromium.org, pfeldman

Review URL: https://codereview.chromium.org/478943002

git-svn-id: svn://svn.chromium.org/blink/trunk@180409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove the HarfBuzzRun cache as using the run text value as the cache
isn't good enough when shaping across runs (support for which is coming
in a separate change) or when text rendering settings have changed (CSS
font-feature-settings).
Early testing indicates that the performance implications of removing
the cache are negligible as the overhead of maintaining the cache
negates most of the savings.

R=behdad@chromium.org,leviw@chromium.org
BUG=345401
TEST=PerformanceTests/Layout/hindi-line-layout.html

Review URL: https://codereview.chromium.org/167703008

git-svn-id: svn://svn.chromium.org/blink/trunk@180408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently "https://" is accepted and treated like "https:". This behavior has never been part of any standard.

The syntax is specified in http://www.w3.org/TR/CSP11/#source-list-syntax

host-source       = [ scheme-part "://" ] host-part [ port-part ] [ path-part ]
host-part         = "*" / [ "*." ] 1*host-char *( "." 1*host-char )

As you can see, the host-part is NOT optional.

BUG=404295

Review URL: https://codereview.chromium.org/470723006

git-svn-id: svn://svn.chromium.org/blink/trunk@180407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/471863002

git-svn-id: svn://svn.chromium.org/blink/trunk@180406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since we now use non-null to represent union member presence, either by
wrapping with Nullable<> or using the implicit null value (for pointers
and strings,) we must make sure the locals we pass to the implementation
are all properly initialized to null.

For strings and RefPtr<>/OwnPtr<>, this requires no special care due to
default constructors taking care of it. For RawPtr<> (when used in
practice, i.e. mostly in Oilpan builds) we need to initialize explicitly.

This fixes Oilpan crashes introduced by this CL:
  https://codereview.chromium.org/466323002/

Review URL: https://codereview.chromium.org/474323002

git-svn-id: svn://svn.chromium.org/blink/trunk@180405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

More webkitpy cleanup.

webkitunittest isn't needed once we required Python 2.7.

mock.Mock() was really only being used in one file (and didn't need to be used
there, either), and I'm not generally fan of the generic Mock approach
it uses (preferring concrete mock objects or fakes).

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/467133003

git-svn-id: svn://svn.chromium.org/blink/trunk@180404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=404324
R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/479723003

git-svn-id: svn://svn.chromium.org/blink/trunk@180402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan@chromium.org
NOTRY=true
BUG=399734

Review URL: https://codereview.chromium.org/476903003

git-svn-id: svn://svn.chromium.org/blink/trunk@180401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing for Document::ownerElement() return value. It returns an
HTMLFrameOwnerElement* but a lot of callers assign it to an Element* variable.

This gets rid of a few unnecessary type checks and avoids an unnecessary
isHTMLElement() check in isHTMLFrameElementBase() in several cases.

R=adamk@chromium.org, rob.buis@samsung.com

Review URL: https://codereview.chromium.org/476223003

git-svn-id: svn://svn.chromium.org/blink/trunk@180400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=388780

Review URL: https://codereview.chromium.org/460713002

git-svn-id: svn://svn.chromium.org/blink/trunk@180399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use Traversal<>::firstAncestor() API more in the code base to simplify the
code and increase readability.

R=adamk@chromium.org

Review URL: https://codereview.chromium.org/476273004

git-svn-id: svn://svn.chromium.org/blink/trunk@180398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

webkitpy.common.editdistance, webkitpy.common.lru_cache, and
webkitpy.common.thread were no longer being used.

webkitpy.common.newstringio could be (and should've been) replaced by
io.StringIO() or io.BytesIO() as appropriate to indicate if you were
dealing with text or bytes.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/479633002

git-svn-id: svn://svn.chromium.org/blink/trunk@180397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/472423002

git-svn-id: svn://svn.chromium.org/blink/trunk@180396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No one uses this value. We can remove it.

R=skobes@chromium.org

Review URL: https://codereview.chromium.org/480623002

git-svn-id: svn://svn.chromium.org/blink/trunk@180395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turns out we don't have any test coverage for this case.

R=leviw@chromium.org
BUG=403734

Review URL: https://codereview.chromium.org/474373002

git-svn-id: svn://svn.chromium.org/blink/trunk@180394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This isn't awesome, but it was the best icon I could find and it
at least will be more clear since it's not using something that's
overloaded for opening menus.

BUG=404049
NOTRY=true

Review URL: https://codereview.chromium.org/475323002

git-svn-id: svn://svn.chromium.org/blink/trunk@180393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds a preferCompositingToLCDText setting, and makes it be set by the
setAcceleratedCompositingForFixedPositionEnabled() WebSettings method so
that behaviour is not changed. Next, Chromium will be changed to call
setPreferCompositingToLCDTextEnabled instead so we can remove this method
from settings.

Later, other accelerated compositing trigger settings will be merged with
preferCompositingToLCDText.

R=abarth
BUG=365851

Review URL: https://codereview.chromium.org/476273003

git-svn-id: svn://svn.chromium.org/blink/trunk@180392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves the expectations for the new w3c repos upstream
from test_expectations_w3c.txt.

This is patch 5 of 6 in the roll.

TBR=phoglund@chromium.org
BUG=404022

Review URL: https://codereview.chromium.org/469993005

git-svn-id: svn://svn.chromium.org/blink/trunk@180391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For from/to/by animations, the length of keyTimes and keyPoints
attribute if are specified must be equal and must have at least
2 values.

R=fs@opera.com,dschulze@chromium.org
BUG=377050

Review URL: https://codereview.chromium.org/453243003

git-svn-id: svn://svn.chromium.org/blink/trunk@180390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When doing a tap, if the synthetic mousedown lands on some node, but
changes the DOM such that there's no node at that point afterwards
(eg. a frame scrollbar), then we'll pass a null node pointer to
commonAncestor and crash.

In addition to adding a test for this case (the mousedown case in
gesture-tap-frame-scrollbar) I added tests for a number of similar
cases (null hit test and removed node) that are already working
correctly but could be subject to similar bugs.

Also corrected a minor typo in a related test
(gesture-tap-click-common-ancestor) - doesn't change behavior, just
better reflects the intention of the test (the ancestor node itself
should not be hittable).

BUG=402338

Review URL: https://codereview.chromium.org/466143005

git-svn-id: svn://svn.chromium.org/blink/trunk@180389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This completes the remaining bulk renames for repaint to paintInvalidation.

BUG=338691

Review URL: https://codereview.chromium.org/478733002

git-svn-id: svn://svn.chromium.org/blink/trunk@180388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Layout tests shouldn't be used to test compositor features.  The cc
pixel tests already include a large number of pixel tests for non-GPU
composited output that cover the set of cases that are required.

Additionally, non-gpu canvas is already tested via the fast/canvas
non-virtual suite.

R=abarth@chromium.org,senorblanco@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/473473003

git-svn-id: svn://svn.chromium.org/blink/trunk@180387 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL changes the sheriff-o-matic to collapse the commit list by default.
Each repository has a button you can press to expand the list of commits.

BUG=399715
NOTRY=true

Review URL: https://codereview.chromium.org/441393002

git-svn-id: svn://svn.chromium.org/blink/trunk@180386 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL creates a model to hold information on the commit lists. This is
in prepartion for adding the ability to expand the commit list.

BUG=399715
NOTRY=true

Review URL: https://codereview.chromium.org/464963003

git-svn-id: svn://svn.chromium.org/blink/trunk@180385 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The current implementation sets default values in
V8T::toNative(). However, there are some code paths in which
we don't call V8T::toNative(). For example, if an IDL dictionary
is an optional argument and it isn't given, the binding layer
creates impl class by calling T::create() and passes it to
blink without calling V8T::toNative(). Since all dictionary impl
class instances should have default values, we should sets
default values in impl constructor.

BUG=321462

Review URL: https://codereview.chromium.org/479563003

git-svn-id: svn://svn.chromium.org/blink/trunk@180384 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/469213003

git-svn-id: svn://svn.chromium.org/blink/trunk@180383 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds code for removing spelling markers under words on 
blink's side.

BUG=3506

Review URL: https://codereview.chromium.org/419563003

git-svn-id: svn://svn.chromium.org/blink/trunk@180382 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yurys, pfeldman

Review URL: https://codereview.chromium.org/476153002

git-svn-id: svn://svn.chromium.org/blink/trunk@180381 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Do not fire a DOMSubtreeModified event when Attr.value attribute is set. This
event is deprecated and both Firefox 31 and IE 11 do not fire it in this case.

Firing a DOMSubtreeModified event is problematic because it is synchronous and
it can lead to calling Attr::setValueInternal() recursively if the JS callback
sets Attr.value again. This can lead to serious problems as setValueInternal()
calls:
1. Element::willModifyAttribute(oldValue, newValue)
2. Attr::setValue(newValue);
3. Element::didModifyAttribute(newValue)

Due to recursivity, we can end up with the following call stack:
1. Element::willModifyAttribute("old-id", "new-id")
2. Attr::setValue("new-id");
3. Element::willModifyAttribute("new-id", "id-from-callback")
4. Attr::setValue("id-from-callback");
5. Element::didModifyAttribute("id-from-callback")
6. Element::didModifyAttribute("new-id")

After this, the Element's id is "new-id" because the id attribute is updated
in Element::didModifyAttribute(). However, the id in the DocumentOrderedMap
is "id-from-callback" because the id DocumentOrderedMap is updated in
Element::willModifyAttribute(). This mismatch between the DocumentOrderedMap
and the actual Element id can cause getElementById() to return incorrect
result. Even worse, it can result in a use-after-free (as in Bug 402255)
because the DocumentOrderedMap does not hold a reference to the StringImpl
used as key, assuming the StringImpl will be kept alive as it is used as 'id'
for an Element.

BUG=402255
TEST=fast/dom/Attr/set-attr-value-no-DOMSubtreeModified.html

Review URL: https://codereview.chromium.org/452093003

git-svn-id: svn://svn.chromium.org/blink/trunk@180380 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch simplifies our handling of watched selectors, allowing us to
remove the remaining pieces of user stylesheets. Currently a special
-internal-callback property is added via a user stylesheet, which depends
on the StyleBuilder applying all values and not just the cascaded values
to function correctly. The approach in this patch is to have this logic
separate to applyMatchedProperties, which means we won't need to have a
separate property and we can still use the matched properties cache in
these cases. This also allows us to remove the Vector of StyleRule in
MatchResult.

BUG=316960

Review URL: https://codereview.chromium.org/418163003

git-svn-id: svn://svn.chromium.org/blink/trunk@180379 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/475233003

git-svn-id: svn://svn.chromium.org/blink/trunk@180378 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These don't do anything, since all it does is update the fill color, which is
not even used in drawHighlightForText (it takes its own color argument).

After this, nearly all updateGraphicsContext calls correspond to a
paintTextWithShadows call, which opens some refactoring options.

Review URL: https://codereview.chromium.org/477143002

git-svn-id: svn://svn.chromium.org/blink/trunk@180376 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The expectation lines have been moved to test_expectations_w3c.txt, so
they are safe to delete from TestExpectations.

This is patch 3 of 6 in the roll.

TBR=phoglund@chromium.org
BUG=404022

Review URL: https://codereview.chromium.org/477043002

git-svn-id: svn://svn.chromium.org/blink/trunk@180375 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Drop unnecessary RadioNodeList::m_onlyMatchImgElements member and replace it by
an inline function that does a CollectionType comparison.

The generated assembly for RadioNodeList.o is about the same size (1 line
shorter).

R=adamk@chromium.org

Review URL: https://codereview.chromium.org/480473002

git-svn-id: svn://svn.chromium.org/blink/trunk@180374 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/469203002

git-svn-id: svn://svn.chromium.org/blink/trunk@180373 bbb929c8-8fbe-4397-9dbb-9b2b20218538