- 27 Feb, 2018 26 commits
-
-
Jun Choi authored
Add encoding logic in U2fRequest that creates APDU encoded byte array given U2fRequest parameters. U2fRequest::CreateApduEncoded{Register,Sign}Command() is defined in U2fRequest interface--not its implementing classes-- as sign operation is needed in both U2fRegister and U2fSign classes. Bug: 798573 Change-Id: Ib675114b6e0d8d10d3243895c36fe220e45911a5 Reviewed-on: https://chromium-review.googlesource.com/847963 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#539336}
-
Jinsuk Kim authored
ContentViewCore doesn't need to stand between ImeAdapter and the above classes to forward events. This CL lets the classes implement ImeEventObserver to get notified of the event directly, and disarms ContentViewCore further. Bug: 598880 Change-Id: Ia67b45f9c297e7cbe5959d6d7bf1292fbbf1bf9b Reviewed-on: https://chromium-review.googlesource.com/933682Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#539335}
-
Jandro Alderman authored
InspectorDOMAgent populates a field for ShadowRootTypes for nodes, but InspectorDOMSnapshotAgent does not. This change exposes InspectorDOMAgent's method for identifying the relevant type so that InspectorDOMSnapshotAgent can populate its output analogously. R=dgozman@chromium.org Change-Id: Ida6f2d2bb370925dfdb301619258db275b8c5129 Reviewed-on: https://chromium-review.googlesource.com/932648Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jandro Alderman <aalderman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539334}
-
Blake O'Hare authored
This will expand yhanada's ownership (who already has ownership of chrome_keyboard_ui* in this file) to the following files: - keyboard_controller_browsertest.cc - keyboard_end_to_end_browsertest.cc - keyboard_ui_service.cc - keyboard_ui_service.h Change-Id: I1f0e9607413792689d2cf029449a07c9b07e8976 Reviewed-on: https://chromium-review.googlesource.com/936505Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539333}
-
Oliver Chang authored
R=eugenis@chromium.org Change-Id: Iff7213d5d2b483fe8c51cbe20ac15952719fdccb Reviewed-on: https://chromium-review.googlesource.com/936881Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#539332}
-
kylechar authored
Add tests to FrameSinkManagerTest that exercise the OOP-D code path that use CreateRootCompositorFrameSink() and CreateCompositorFrameSink(). Call CreateRootCompositorFrameSink() needs a DisplayProvider implementation, so add TestDisplayProvider that creates a Display with a FakeOutputSurface. Bug: 814475 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0bfef35d8bcf0c513307b371422e134f06f6aaaf Reviewed-on: https://chromium-review.googlesource.com/938160 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#539331}
-
Kyle Horimoto authored
This CL was originally landed as: https://chromium-review.googlesource.com/c/chromium/src/+/929867 Then, it was reverted as: https://chromium-review.googlesource.com/c/chromium/src/+/935901 The original change is uploaded as patchset 1 of this CL. Changes to that CL to fix broken tests are uploaded as subsequent patches. Original CL description: Previously, such hotspots could only be displayed once per use login to ensure that we do not spam the user. However, user feedback indicates that users expect to see the notification each time they unlock their devices again. This change makes it possible for the notification to be displayed multiple times per user login, as long as the user has locked their device in between each time. Bug: 813838, 672263 Change-Id: I8eee7398ee63c82206df01f9d0c39d21e309860a TBR: achuith@chromium.org, hansberry@chromium.org Reviewed-on: https://chromium-review.googlesource.com/938582Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#539330}
-
Siddhartha S authored
This reverts commit affe36d3. Reason for revert: Experimental CL. Reverting before branch cut. Original change's description: > Add heap profiler events for jni generated functions > > The native functions invoked are sometimes not run as a task which is > registered with TaskAnnotator. Add events on generated jni functions to > be able to trace them. > Causes 80KB regression on the binary size, so use for temporary > debugging in Dev channel and revert CL. > > BUG=801260 > > Change-Id: I80931fc07d74ed27edebe3cf35bce689f8138099 > Reviewed-on: https://chromium-review.googlesource.com/853081 > Commit-Queue: Siddhartha S <ssid@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531028} TBR=ssid@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 801260 Change-Id: I5fb690cb4fa24ee4f2305d2b90264cae40f3cefd Reviewed-on: https://chromium-review.googlesource.com/938561Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#539329}
-
Ryan Sleevi authored
This introduces a FieldTrial/Feature configuration that allows CAs and site operators to simulate CT Enforcement on a particular date. The use case is to allow the testing of a CA's issuance practices, to ensure all newly-issued certificates are CT Compliant. This can be enabled using the FieldTrial command-line flags of chrome.exe --enable-features="EnforceCTForNewCerts<EnforceCTTrial" \ --force-fieldtrials="EnforceCTTrial/Group1" \ --force-fieldtrial-params="EnforceCTTrial.Group1:date/{date}" Note that in the above syntax, "{date}" should be replaced with the number of seconds since the Unix Epoch. For example, "EnforceCTTrial.Group1:date/1512086400" enforces CT for all new certs issued after 2017-12-01 00:00:00 UTC. BUG=816543 Change-Id: I305ba604740d6d64738a2c4612dd40266776e3e2 Reviewed-on: https://chromium-review.googlesource.com/937689 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539328}
-
Amirhossein Simjour authored
When we are in VR, we can enabled the ModalDialogView for PermissionDialogs. This won't change anything for 2D users. This will also impact the auto reject of the permission requests in VR. As a result, if the permission is already granted, the website will be able to use it. (All of this is behind flag VrBrowsingNativeAndroidUi) BUG=811134,779126,738209 Change-Id: Ic30362acc53c1e7b15a9d9e54457d1c7b3776a2d Reviewed-on: https://chromium-review.googlesource.com/926882 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#539327}
-
Dominic Mazzoni authored
Bug: 622387 Change-Id: I41eb5ed6a4ba57fad3e884b24a317036e44eb218 Tbr: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/938223Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#539326}
-
Charles Harrison authored
We've launched abusive experience enforcement (aka the safe browsing triggered popup blocker). However, we don't have great metrics moving forward to discern click-through metrics from that feature vs the standard popup blocker. This CL breaks that out into another PopupBlockerTabHelper::Action. Change-Id: I2f8277619ddc90532d3fef5136f746bc63130a62 Reviewed-on: https://chromium-review.googlesource.com/938585Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#539325}
-
erikchen authored
Memlog is disabled for syzyasan, so also disable the tests. Bug: 804001 Change-Id: I1f0033230e85cf1f5708d8ed0c3ab22053e1f67c Reviewed-on: https://chromium-review.googlesource.com/934684Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#539324}
-
Wei Li authored
Properly gate oopif printing for site isolation flag or feature, or top document isolation. Previously we missed site isolation feature. BUG=455764 Change-Id: I05a1b373c6186c29f22210bfa2013302f3664c79 Reviewed-on: https://chromium-review.googlesource.com/898504Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#539323}
-
Oksana Zhuravlova authored
mojo_perftests includes tests from mojo_public_bindings_perftests, mojo_public_system_perftests and mojo_message_pipe_perftests. Relevant infrastructure files were updated (including //src/build/android/pylib/gtest/gtest_test_instance.py). Bug: 812773 Change-Id: I80fa1471a0c8c6c6949bade682a5391c9b40cae3 Reviewed-on: https://chromium-review.googlesource.com/933090 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#539322}
-
Paul Jensen authored
Bug: 520198 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I3c25909d57a0e5841e15d24b868c30f51f65f4b1 Reviewed-on: https://chromium-review.googlesource.com/937583 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#539321}
-
Kurt Horimoto authored
Snapshotting cancels in-progress overscroll animations, so page loads that occur before the overscroll "bounce back" animation finishes will cut that animation short. Bug: 805165 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifb105b79bbb700bca752000ebfb15f4123e90f38 Reviewed-on: https://chromium-review.googlesource.com/933586Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#539320}
-
Eugene But authored
Setting layoutMargins on iOS 10 had no effect, so the view did not have any padding (the view hight was the same as statusLabel.heightAnchor). Setting directionalLayoutMargins only added top and bottom margins, not left and right, so using directionalLayoutMargins was not super useful either. This CL simply adds shadow height constant to view.layoutMarginsGuide.topAnchor, which looks cleaner (no OS version conditions and actually work on iOS 10). Bug: 813979 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I574651f8ce459e57667550a67bf68d6e038d74e3 Reviewed-on: https://chromium-review.googlesource.com/927605Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#539319}
-
Peter Boström authored
Keeps section labels in conditional titlecase as they can be displayed as the bubble heading and are properly titles within the dialog. It also replaces 'Your payment' with 'Review your payment' to provide a full sentence. Bug: chromium:810111, chromium:812362 Change-Id: I4db492f772339e5a32fb92e1f3027d9aa047a67b Reviewed-on: https://chromium-review.googlesource.com/935748Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#539318}
-
Ryan Landay authored
This method has two call sites. I was stuck for a while trying to understand how they work, but it appears this method is actually completely unnecessary. I can't find any change in behavior after removing it and cleaning up its call sites. Change-Id: I7ac62a9dbce34caba5f69da13427e7ef827c1074 Reviewed-on: https://chromium-review.googlesource.com/933061Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#539317}
-
Michael Thiessen authored
When we send scroll events we need to make sure the touch events we generate exceed the touch slop value required to initiate a scroll. This also fixes fling cancels, which were previously not doing anything at all. Bug: 816568 Change-Id: I119d1d467cb10b1e578c8cd01ffba3351e7b70a4 Reviewed-on: https://chromium-review.googlesource.com/932561Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#539316}
-
Marijn Kruisselbrink authored
Bug: None Change-Id: I27a7a3f3b55f2e11a6ac82a5a5aa4e90e84cddd3 Reviewed-on: https://chromium-review.googlesource.com/938746Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#539315}
-
James Cook authored
Bug: none Change-Id: Ieb2a2dac242e39d6bef8a0eeddf33a6d39b5c951 Reviewed-on: https://chromium-review.googlesource.com/933249Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#539314}
-
David Benjamin authored
Bug: 714018 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Icb3d2393ddf8cec56ceeb7a8c1adb1fe1be3b7ef Reviewed-on: https://chromium-review.googlesource.com/935781 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#539313}
-
Candice Sy authored
Use an empty progress bar instead of an indeterminate progress bar for pending downloads in Downloads Home. Bug: 796324 Change-Id: I9ecd0e244aec8527449e7c30af6a314b93e9fb81 Reviewed-on: https://chromium-review.googlesource.com/933298Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Joy Ming <jming@chromium.org> Commit-Queue: Candice Sy <cmsy@google.com> Cr-Commit-Position: refs/heads/master@{#539312}
-
James Forshaw authored
This CL converts AppContainerProfile to use a virtual interface. This is due to different parts of Chrome compiling the code differently which can result in crashes when releasing the profile. Test=service_manager_unittests.exe Bug: 812590 Change-Id: I0a154099ca37eedd82cfc22041e986e0ce0318cc Reviewed-on: https://chromium-review.googlesource.com/925602 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#539311}
-
- 26 Feb, 2018 14 commits
-
-
Mike Dougherty authored
Run the exsiting context menu Earl Grey tests with both the |kContextMenuElementPostMessage| feature flag disabled and enabled. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f838fb459d31d1d4309f3acf794f8f56f14c098 Reviewed-on: https://chromium-review.googlesource.com/930580 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#539310}
-
Nick Carter authored
This special case would have been hard to port to the network service. It's easier to just force the net_error_helper to issue a CORS-enabled request, which https://www.googleapis.com/rpc readily understands. A browsertest is added to explicitly test that CORB is applied to subresources loaded by error pages. Currently this test fails; we'll fix that in a separate CL. Manual testing: in an official/branded Chrome build, navigate to "http://blog.thestranger.com" and on the resulting DNS error page, observe a suggested correction link (of "http://thestranger.com/blog"). Repeat these steps with a chrome://net-internals trace running, and observe a request to "https://www.googleapis.com/rpc" that has the "Origin: null" request header, and which includes an "Access-Control-Allow-Origin: *" header in the response. BUG=814913,792546 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib7434bd52a27909dd67c5e9a867db1dab7090d59 Reviewed-on: https://chromium-review.googlesource.com/927561Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#539309}
-
Thomas Guilbert authored
This CL adds the java MediaController interface. It exposes simple commands to control media content. It is modelled after the media router's Mojo MediaController interface. The only implementer for the moment is the RemoteMediaPlayerWrapper, but the interface is simple enough to be reused whenever we switch to Cast SDK V3. This CL also stores the current CastSession's presentation ID in the ChromeCastSessionManager. We then use that ID to make sure that a given presentation ID is still current, before returning a MediaController to issue commands to the current RemotingCastSession. Bug: 790766 Change-Id: Ia49552cf748eaa7837cacafae05a3897fa2ec21d Reviewed-on: https://chromium-review.googlesource.com/905573 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#539308}
-
Primiano Tucci authored
This CL cleans up the hack put in place in base::Singleton to reset the TraceLog instance in tests, in favour of a least worst hack to reset the instance within trace_log.cc . Other than cleaning up singleton.h, this also removes a TSan violation caused by calling Singleton::OnExit() (see bug). The violation was reported, I believe, for the following reason: - A thread (that ends before the test reaches TearDown()) accesses the Singleton instance pointer in GetOrCreateLazyPointer with a load-acquire. - TearDown() clears up the Singleton instance pointer with a non-barriered write. This is enough to make TSan conclude "this will be racy" even if the race doesn't happen (because of causality in the TearDown(), all threads created by the tests should be gone once there). This CL fixes the problem by switching TraceLog's singleton to a base::NoDestructor. This should also make TraceLog::GetInstance slightly faster in production builds as it removes one layer of pointer dereferencing (Singleton's instance is heap-based, base::NoDestructor is bss-based). The ResetForTesting method is implemented by simply invoking the destructor, clearing up the static storage and re-placement-new-ing the object. This keeps the pointer returned by GetInstance() unchanged, but still achieves the reset needed by tests. Bug: 815234 TBR: rouslan@chromium.org Change-Id: I4c0dfc33ea45e64f36234da2006ece96905914b9 Reviewed-on: https://chromium-review.googlesource.com/935841Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#539307}
-
Fredrik Söderquist authored
After https://chromium-review.googlesource.com/716679, this method has no callers. Remove it. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3e2f427c8349bfa410718cd24782f64c7ad2e0e0 Reviewed-on: https://chromium-review.googlesource.com/735861Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#539306}
-
https://chromium.googlesource.com/catapult.git/+log/4607515962f8..38e8eedc7bb6 $ git log 460751596..38e8eedc7 --date=short --no-merges --format='%ad %ae %s' 2018-02-14 eakuefner Reland "[Telemetry] Remove FailureValue from the value system" Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I44eef5e712b51553df53aaae55ac2da2eecaabaf Reviewed-on: https://chromium-review.googlesource.com/938182 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539305}
-
Daniel Murphy authored
Since the tab restore code keeps a reference to the session namespaces of recently closed tabs (see sessions::ContentPlatformSpecificTabData and sessions::TabRestoreService), a SessionStorageNamespaceImpl can outlive the destruction of the browser window. A session restore can also happen without the browser context being shutdown or destroyed in between. This change keeps track of all 'alive' namespaces in a map. When a SessionStorageNamespaceImpl is created and there is an entry alive in that map, then that object is used instead. This allows the browser to re-use objects that are still alive thanks to the sessions component. Bug: 811189 Change-Id: I5c9e94ab4fe7b0017264c0f8f522d20134ea0c2b Reviewed-on: https://chromium-review.googlesource.com/930325 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#539304}
-
Lei Zhang authored
Change-Id: I22a02aaf461e425d5a1742370036a08c60319d69 Reviewed-on: https://chromium-review.googlesource.com/935757 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#539303}
-
Chong Zhang authored
http/tests/devtools/oopif/oopif-cookies-refresh.js failing since it's added in r539268 http/tests/devtools/network/oopif-targets.js turned into flaky instead of crash. (The original DCHECK was changed) TBR=kinuko@chromium.org NOTRY=true Bug: 805310 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I92e5b76383a0b882459e0f4853269a12c1eb8de9 Reviewed-on: https://chromium-review.googlesource.com/938649 Commit-Queue: Chong Zhang <chongz@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#539302}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I64812517880f954b9c8f27d773b495eabe01bbfc Reviewed-on: https://chromium-review.googlesource.com/938663Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#539301}
-
Hongchan Choi authored
This CL adds |currentFrame| property to AudioWorkletGlobalScope according to: https://github.com/WebAudio/web-audio-api/pull/1493. 1. Previously the time stamp (currentTime) was updated when the first worklet processor gets called, and it was inconsistent with how it is updated in the other nodes. Now updating the frame number is streamlined, so the worklet processor also gets the same treatment. 2. In order to streamline this process, WorkerThread reference was added to BaseAudioContext. Due to the GC rule, BaseAudioContext cannot keep a reference of WorkletGlobalScope, so it always derives the global scope from the worker thread. Bug: 814794 Test: http/tests/webaudio/audio-worklet/timing-info.html Change-Id: I4b313377d80f8678c473cf788211e373fd1644cb Reviewed-on: https://chromium-review.googlesource.com/935157 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539300}
-
Majid Valipour authored
Intent to Experiment: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AZ-PYPMS7EA/DEqbe2u5BQAJ Bug: 811922 Change-Id: I967df8e38d55cffc985ca8982f3762e95aa08ae7 Reviewed-on: https://chromium-review.googlesource.com/917125 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539299}
-
Eugene But authored
DownloadManagerCoordinator should not present another view controller if in existing download is replaced with a new download. Instead coordinator should simply update the UI by setting new download task to mediator. Bug: 815366 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0298b2be999be9acda3c200a8182ba425b318010 Reviewed-on: https://chromium-review.googlesource.com/935840 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#539298}
-
Nasko Oskov authored
Change-Id: I27c3d145a2eef11930f16afbb33e73ba60f243c9 Reviewed-on: https://chromium-review.googlesource.com/937901Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#539297}
-