- 25 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/04cffe3289f7..9a5c2e82ebbb git log 04cffe3289f7..9a5c2e82ebbb --date=short --no-merges --format='%ad %ae %s' 2019-06-25 mbonadei@webrtc.org Remove unused command_line_parser dependency. Created with: gclient setdep -r src/third_party/webrtc@9a5c2e82ebbb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6918a241f21562c2ffe9f4d247217a48f88f2a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677026Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672223}
-
Yue Zhang authored
* Shift the grid in dialog up by 8dp. * Put dialog title in the correct position and modify the text appearance. * Replace the original hide dialog button with back arrow. * Round the corners of the dialog by 8dp. Bug: 977273 Change-Id: Id0df26d12264dca313ad4554f8e115366e1d5bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674924 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#672222}
-
Reilly Grant authored
This reverts commit fa0a6456. Reason for revert: UserImageManagerTest.SaveUserImageFromProfileImage failing in browser_tests and viz_browser_tests. Bug: 978578 Original change's description: > Add support for FIFE Avatar URL format > > The method GetAvatarImageURLWithOptions() is updated to support > image URLs coming in the FIFE Avatar URL format. > > This should resolve issues related to color-inverted account images > on the Chrome surface. > > Bug: 911332 > Change-Id: I8c0a10be69bc87a40a39cf46e0428b418d97b021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670888 > Commit-Queue: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Boris Sazonov <bsazonov@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672116} TBR=msarda@chromium.org,bsazonov@chromium.org,tangltom@chromium.org Change-Id: I70e2b5b7940158668ce455286cf3d3d8ac679b10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677157Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672221}
-
Wenjie Shi authored
This document introduces the proposed design changes for modernizing the Chromium sensor backend on Windows allowing it to use the new Windows.Devices.Sensor WinRT APIs instead of the deprecated ISensor Win32 API. This README will not cover the context or justification for the modernization work as it is already captured by this document: https://docs.google.com/document/d/1Vr5xXOu4v-H6ydeCJed1bU_WR9kBYm3ANV-GB-JPZuw/edit?usp=sharing The new README file also reads more like a future looking document (contains "will do this..." and "proposed") since it not implemented yet. Change-Id: Ibcfeb9020bd930d50ab9898ce0ee145c9e645e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664111 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672220}
-
Christian Biesinger authored
Now that LayoutNG is on by default, use this bot to run without LayoutNG. R=eae@chromium.org, thakis@chromium.org Bug: 591099 Change-Id: I0d2a9fefed5830e2f83d198e3b196e346484b14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674614 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#672219}
-
Florian Uunk authored
We used this histogram to estimate Butter QPS, but this is no longer needed. BUG=975013 Change-Id: Ib56e84b99c2257f290d165218c4db5008e584010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665937Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#672218}
-
Lucas Furukawa Gadani authored
Bug: 908139 Change-Id: I5ade2d364906e02be87c819d7a97a13f767f1ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676236Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#672217}
-
Jared Saul authored
Screenshots are attached in the bug. Will immediately follow up with attempting a browsertest CL, but since Butter-based browsertests were previously flaky, I don't want to include it in this same to-be-merged CL just in case. Bug: 978514 Change-Id: I4cee091e1335d697dbac5e9bbacf44813fa24e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676674 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#672216}
-
Sebastien Marchand authored
The SQL DB owned by the QuotaManager gets destroyed asynchronously, so given the current ordering of the parameters: base::ScopedTempDir temp_dir_; scoped_refptr<QuotaManager> quota_manager_; The release of |quota_manager_| will post a task to close the database stored in temp_dir_ but this is racy with the destruction of |temp_dir_|. Bug: 974310 Change-Id: Ib54ea1fe1652028a1bcf6b7f6107a01d3e99f2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660833 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#672215}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I9db92543edefaf4ae788e36e0d16a7fc36372677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672214}
-
Bence Béky authored
SPDY has been deprecated years ago and HTTP/2 is widely deployed. It is time to update net error codes, especially because many of them can be surfaced to confused users on an error page. Bug: 345769 Change-Id: I4f5880a73fecbea630c441c08255daef1d7831ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1651050 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#672213}
-
Robert Kroeger authored
trace_test on (nvidia-quadro-p400-win10-stable) GPU on Windows on Windows-10 appears to intermittently time out. Add test suppression. BUG: 978516 Change-Id: I1a1dc3a79f2c7499b8e60b4a641a05e2208694a2 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677006Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#672212}
-
Martin Kreichgauer authored
This adds, behind a disabled feature flag, UI for enumerating and deleting (not yet implemented) resident credentials stored on a CTAP2 security key to the existing security keys settings page. Demo: https://drive.google.com/open?id=1-b_oXQH75mlysJGO7xFXxbfF_52E2LWV Bug: 955859 Change-Id: I870bd25d00c62bb7421a815e99f43f1acc967e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650524 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#672211}
-
Tommy C. Li authored
This is a reland of 8967c490 We are re-enabling these by default. Original change's description: > [omnibox] Steady State Elisions - Enable flag by default > > To prepare for launch, enabling these by default on tip of tree. > > Bug: 842236 > Change-Id: I0d40540fcfb6262238670ccfbcbe3d7f371e05e2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577488 > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Commit-Queue: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652916} Bug: 842236 Change-Id: I55a77cbf871dbe0114180ff81bce0bd8129940a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677024Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#672210}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/4080a859725c..8da8f7162b76 $ git log 4080a8597..8da8f7162 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 bnc Add static_cast<uint8_t> in HpackVarintEncoderTest. 2019-06-25 bnc Add helpers and use StringPiece in HttpDecoderTest. 2019-06-24 bnc Implement QuicStreamSequencerBuffer::PeekRegion(). 2019-06-24 bnc Remove test-only HttpDecoder::current_frame_type() accessor. 2019-06-24 nharper Remove CreateSslCtx argument from QUIC crypto config constructors 2019-06-24 bnc Do not handle impossible outcomes in HttpDecoder. 2019-06-24 renjietang Avoid performing pending stream actions after the connection is closed. 2019-06-24 bnc Clean up HpackVarintEncoder internals. 2019-06-24 fayang gfe-relnote: In QUIC, replace member variables current* with on stack struct ReceivedPacketInfo in QuicDispatcher. Refactor only, not protected. 2019-06-24 bnc Clean up HpackVarintEncoder interface. 2019-06-24 bnc Clean up QpackInstructionEncoder internals. 2019-06-24 bnc Introduce IovecToStringPiece() in QuicStreamSequencerBufferTest. 2019-06-24 bnc Add |written_| member to QuicStreamSequencerBufferTest. 2019-06-24 bnc Clean up PrefetchNextRegion. 2019-06-24 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_terminate_gquic_connection_as_ietf. 2019-06-24 fkastenholz Alter QuicConnectionDebugVisitor::OnConnectionClosed to take QuicConnectionCloseFrame 2019-06-21 bnc Modify QpackInstructionEncoder API. 2019-06-21 dschinazi Ignore C++ warnings in auto-generated proto headers 2019-06-21 quiche-dev Add test to ensure that a push promise on a data stream closes the connection. 2019-06-21 quiche-dev Add test to ensure that a push promise on a control stream closes the connection. 2019-06-21 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_tolerate_reneging. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic732cdbc8e428e3ba45b71ab9f38d7ddf16b8c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1673581 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#672209}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1e2dfd22680d..eb77ffa955c6 git log 1e2dfd22680d..eb77ffa955c6 --date=short --no-merges --format='%ad %ae %s' 2019-06-25 saklein@chromium.org PackagesService: Uprev 2019-06-25 eashanbhatt@google.com cros_test_unittest: Add Tast Test Unittests Created with: gclient setdep -r src/third_party/chromite@eb77ffa955c6 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9db1dfdb2d3f60c0c49eb5ccad1fdc5b2be9869a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676824Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#672208}
-
Jian Li authored
We need to also set PageTransition.FROM_ADDRESS_BAR in order to force the reload. Otherwise, the loading will not proceed if it is same document. Bug: 819359 Change-Id: Ic861c295c1b42fc37f0161b771a1275912b6156e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674591 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#672207}
-
Sinan Sahin authored
Forcing it to LTR makes sure the URL is not shown out-of-order when the first strong character of the URL is RTL. This CL also updates the RevampedContextMenuHeaderMediator's constructor to have a ContextMenuParams parameter instead of several parameters that are possible to extract from the ContextMenuParams. Bug: 655359 Change-Id: I10373120472d4b8a6c354e454232c13c63c73587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676675Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#672206}
-
Ryan Hamilton authored
if the client's IP address agrees with the server's view of it. This will help track down if we're seeing v6-v4 NAT (or vice versa). Change-Id: Ib3b9636345a2cae5325f9423ec70e32d95fb8d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674642 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#672205}
-
Maxim Kolosovskiy authored
- Adds additional formats of UPI VPA based. - Allows more symbols in UPI name. Changes are made based on the specification (https://www.mpf.org.in/docs/08/NPCI%20Unified%20Payment%20Interface%20UPI%20Specifications,%20October%202015.pdf) Bug: 977377 Change-Id: I8f805e99e530e463717525e991c8d4f22680398e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672067 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#672204}
-
Antoine Labour authored
The only calller was GpuMemoryBufferVideoFramePool, but doesn't need to any more as crbug.com/819914 was fixed. Bug: 819914 Change-Id: Ife76f3a9ed7e287f94ea0db97f0c27a6179f4a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674408 Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672203}
-
John Lee authored
Bug: 973674 Change-Id: I88399b1b8a9b3cf82caa08ea11c0525294edcd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674454Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#672202}
-
Andrew Grieve authored
Follow-ups to https://chromium-review.googlesource.com/c/chromium/src/+/1673453 Bug: 964169 Change-Id: I968cadb22ae636b4043866b33067e0f2b8fa20a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676734 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672201}
-
Vlad Tsyrklevich authored
Previously GWP-ASan only exposed separate flags for whether it was enabled for a given allocator. Create a convenience buildflag for places when we need to check whether GWP-ASan is enabled for any allocator and use it where appropriate. Bug: 973167 Change-Id: I76f8ee2c258279ebd07e3b6f72651498358a95da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671866 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#672200}
-
Daniel Rubery authored
Currently, for dangerous downloads on ChromeOS, we show a notification with an empty message, and the progress_status set to the WarningStatusString. But for a blocked download, we don't show the progress bar, so the WarningStatusString is ignored. This CL sets the notification message to the WarningStatusString. Previous behavior: https://screenshot.googleplex.com/GOtztKVUrJe.png New behavior: https://screenshot.googleplex.com/hHu62tdx6vx.png Bug: 973000, 807334 Change-Id: I48b060d57d1bc0ad26e5c02d0cdfce2b3664d9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663081Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#672199}
-
Fernando Serboncini authored
There's no hard standard on this, so we are matching the behavior of detached canvas. Bug: 977876 Change-Id: I84f8e32000f290d6826722863bb6fb16116e2f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675911 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#672198}
-
Matt Menke authored
Bug: 966896 Change-Id: I622badcc10a54ae98a1f9ce642247a025a486515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676307Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#672197}
-
Regan Hsu authored
PageVisibility is undefined for windows, so the restart button and description associated with switching Google Chrome UI language are preprocessed out, which is not intended. This CL ensures that PageVisibility will not be considered when building for windows. Change-Id: Ib418acdd6b7e747dbab7f3e3db0e38c6166306be Bug: 974424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663325Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#672196}
-
Imranur Rahman authored
|volume_| can be set on the control thread and read on the rendering thread at the same time. Declaring |volume_| as an atomic variable solves the problem. Bug: 923844 Change-Id: I48ee9a8dfa7b7b77baa93619a08d3a0a9b989939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663835Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#672195}
-
Bruce Dawson authored
This updates the previous package to use the 10.0.17763 version of the Debuggers directory. This is necessary because the 10.0.18362 version of dbghelp.dll doesn't load on Windows 7 and we rely on it. This package was created by replacing the Debuggers directory in the previous package. Therefore it is: Mostly 10.0.18362 Debuggers from 10.0.17763 d3dcompiler_47.dll from 10.0.17134 The instructions for the previous package are included below: Packaging was done on a Windows Server 2019 VM, cleanly created for this purpose. The package was created by downloading VS 2017 Update 9.3, from https://visualstudio.microsoft.com/vs/older-downloads and downloading the 15.9 Visual Studio Professional 2017, and then running the installer like this: $ PATH_TO_INSTALLER.EXE ^ --add Microsoft.VisualStudio.Workload.NativeDesktop ^ --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ --includeRecommended --passive Then the 10.0.18362.0 SDK was installed from: https://developer.microsoft.com/en-US/windows/downloads/windows-10-sdk Then the packaging script was run like this: python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.18362.0 Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid shipping that the final packaging step was to unzip the package, copy over the two copies of that DLL from win_sdk\Redist, and then repackage the toolchain with: > python package_from_installed.py --repackage=<full-path-to-toolchain-dir> This is needed to make progress towards two-phase lookup. Bug: 970064, 976161, 919163 Change-Id: I1043a01c91b040fd7e47a160f953fd5b6502ed0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674628 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#672194}
-
Ken Rockot authored
This adds the GenericPendingReceiver type to the bindings library. The type encapsulates a receiving pipe endpoint, paired with the name of the interface assumed by the corresponding remote endpoint. This can be used for convenience in place of an ad hoc string/pipe pair. Bug: 977637 Change-Id: I8ff968e4f0d64c1beca1246f8b2dee3d2f3719db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674252Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#672193}
-
Dominic Battre authored
Bug: 975939 Change-Id: I7a92d33e966cb315508c7ee795aea1ea676829ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675351Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#672192}
-
Greg Thompson authored
All signs indicate that it is exceptionally rare for initialization to fail. BUG=975750 R=pmonette@chromium.org,jwd@chromium.org Change-Id: I5cee019454c882c9702d69d3c4877d7cda97d5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670889 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#672191}
-
Eugene But authored
CHROME_EG_ASSERT_NO_ERROR is unnecessary anymore, because helpers can assert with correct file name and line number. Bug: 963613 Change-Id: Ied9d4595c04f81a70e93cd32da24449a74618b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672707 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#672190}
-
Nate Fischer authored
The gitiles navbar doesn't correctly render the "home" link. It's unclear why this started happening recently, but this CL fixes the issue by explicitly specifying the path instead of using the "[home]" alias (which is already used to make the logo clickable). Bug: 918221 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I4e3db63f43f2cbe5809c44d247fd293faecbdad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674846 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#672189}
-
Fabrice de Gans-Riberi authored
The call was renamed in Fuchsia, the transitional *_new variant is going to be removed soon. Bug: 977753 Change-Id: I4d189066cb7ceff1ed4bfc18a9a434a3c2e6ec34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677010 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#672188}
-
Avi Drissman authored
-[NSView inputContext] will create an input context if one does not exist. -[NSTextInputContext initWithClient:] takes a weak reference to the view. Pre-Catalina, that weak reference was just a raw pointer; in Catalina, that weak reference is an actual __weak reference, accessed with objc_storeWeak() et al. Pre-Catalina, a call to -[NSView inputContext] in a dealloc impl that ends up trying to create an input context just ends up taking the raw pointer reference; not the best idea, but not the end of the world. With Catalina, doing so involves trying to create a weak reference to a dying object, which makes the ObjC runtime incredibly unhappy. This is a sanity check that is breaking the code; remove it. BUG=977918 TEST=as in bug Change-Id: Ic3d242117c3c5ada0852e4a77296a507b0fccfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676424Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672187}
-
Lucas Furukawa Gadani authored
Bug: 908139 Tbr: boliu@chromium.org, lazyboy@chromium.org, scottmg@chromium.org, johannes@chromium.org, seantopping@chromium.org Change-Id: I56fafc55cdb6e77f479c6d657be8dd20162cd2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667790 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#672186}
-
Eric Stevenson authored
Currently provides access to a subset of the items in the dex format including method items, proto items, type items, type lists, and strings. Bug: 976358 Change-Id: I002645358a83ec01eb5bcf848c5bfa50b5f03af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660123 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#672185}
-
Caleb Raitto authored
This doesn't include the libcurl implementation -- just headers and samples to build an alternative implementation of the libcurl API. The full libcurl repo with its implementation and repo history would be nice to have, but not strictly necessary. Since this code isn't intended to be shipped with Chrome, but rather as headers for an alternative API for the components/cronet library, it makes sense to avoid having Chromium developers sync the full library. Bug: 973603 Change-Id: I3879241ab7b2aa0177cd09cc2e8ef73739fd5feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664790Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#672184}
-