GitLab

BUG=335449

Review URL: https://codereview.chromium.org/138833012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251286 0039d316-1c4b-4281-b951-d872f2087c98

Flakiness should be fixed.  Renabling tests.

BUG=335916,341265
TEST=trybots

Review URL: https://codereview.chromium.org/145093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251285 0039d316-1c4b-4281-b951-d872f2087c98

Fix most users of ExtensionSystemFactory::GetInstance() to use ExtensionsBrowserClient::Get()->GetExtensionSystemFactory(). Clean up extension_system_factory.h includes.

Follows https://codereview.chromium.org/137753016/

BUG=337707

Review URL: https://codereview.chromium.org/148083014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251284 0039d316-1c4b-4281-b951-d872f2087c98

Speculative revert to determine whether it is causing the below
WebViewTest.AutoSizeSW failure on the Linux Test bots (e.g.,
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/30888/steps/browser_tests/logs/AutoSizeSW):

FATAL:texture_layer.cc(141)] Check failed: !mailbox.IsValid() || !holder_ref_
|| !mailbox.Equals(holder_ref_->holder()->mailbox()).

This failure also appeared on the trybot run for this CL.

> Use gpu::Mailbox instead of std:string in IPCs
> 
> - easier to read
> - safer since gpu::Mailbox is constant size and checked in the ParamTraits
> 
> BUG=None
> 
> Review URL: https://codereview.chromium.org/148003006

TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/163433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251281 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163173003/)

Reason for revert:
The original CL (https://src.chromium.org/viewvc/chrome?view=rev&revision=251213 )  was reverted (and reverted twice more) because VMtest on chromeos-{x86,amd64} failed to find icudtl.dat. It turned out that my Chrome OS side change (chromeos-chrome.ebuild) was not picked up by build bots until several hours after landing of that CL. 

It's now picked up [1] and VMtest (on chromeos_x86 bot) finally passed with the original CL still in. 

So, I'm re-landing the original CL by reverting.  


[1] See LGKMSync section at http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/19858

Original issue's description:
> Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/164333003/)
> 
> Reason for revert:
> CrOS-side change (chromeos-chrome.ebuild) may not be used by a buildbot.  
> 
> ./1_autotest_tests/results-27-experimental_login_OwnershipNotRetaken/login_OwnershipNotRetaken/sysinfo/var/log/ui/ui.LATEST still has 
> 
> [0214/002103:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU()
> 
> Original issue's description:
> > Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/)
> > 
> > Reason for revert:
> > https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. 
> > 
> > Original issue's description:
> > > Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/)
> > > 
> > > Reason for revert:
> > > https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 
> > > 
> > > 
> > > Original issue's description:
> > > > Turn on icu_use_data_file_flag on CrOS
> > > > 
> > > > See also https://chromium-review.googlesource.com/#/c/185937/
> > > > 
> > > > The switch has to be turned on in two places (chromeos-chrome.ebuild and
> > > > build/common.gypi). One or the other can get landed separately, though.
> > > > 
> > > > BUG=72633
> > > > TEST=net_unittests:*IDN* and base_unittests:*String*
> > > > TBR=mark
> > > > 
> > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213
> > > 
> > > TBR=mark@chromium.org
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=72633
> > > 
> > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214
> > 
> > TBR=mark@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=72633
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251220
> 
> TBR=mark@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=72633
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251276

TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633

Review URL: https://codereview.chromium.org/166513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251279 0039d316-1c4b-4281-b951-d872f2087c98

During the teardown process, media pipeline will be waiting on the
render main thread. If a Decryptor depends on the render main thread
(e.g. PpapiDecryptor), the pending DecryptCB will not be satisfied.

This CL adds a DecryptingDemuxerStream::Stop() method so that the
stopping process doesn't wait for any pending operation.

BUG=343748
TEST=Add unittests to cover this case.
R=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/165733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251277 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/164333003/)

Reason for revert:
CrOS-side change (chromeos-chrome.ebuild) may not be used by a buildbot.  

./1_autotest_tests/results-27-experimental_login_OwnershipNotRetaken/login_OwnershipNotRetaken/sysinfo/var/log/ui/ui.LATEST still has 

[0214/002103:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU()

Original issue's description:
> Revert of Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/165593002/)
> 
> Reason for revert:
> https://chromium-review.googlesource.com/#/c/185937/ just got landed and this CL can go in now. 
> 
> Original issue's description:
> > Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/)
> > 
> > Reason for revert:
> > https://chromium-review.googlesource.com/#/c/185937/ has to go in first. 
> > 
> > 
> > Original issue's description:
> > > Turn on icu_use_data_file_flag on CrOS
> > > 
> > > See also https://chromium-review.googlesource.com/#/c/185937/
> > > 
> > > The switch has to be turned on in two places (chromeos-chrome.ebuild and
> > > build/common.gypi). One or the other can get landed separately, though.
> > > 
> > > BUG=72633
> > > TEST=net_unittests:*IDN* and base_unittests:*String*
> > > TBR=mark
> > > 
> > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213
> > 
> > TBR=mark@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=72633
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214
> 
> TBR=mark@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=72633
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251220

TBR=mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=72633

Review URL: https://codereview.chromium.org/163173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251276 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jln

Review URL: https://codereview.chromium.org/166303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251273 0039d316-1c4b-4281-b951-d872f2087c98

The setuid sandbox waits on its one child and then dies
afterwards.

When receiving SIGABRT, instead of dumping core, simply exit the
process. There is no interesting information to be gathered from
knowing that the process is inside waitid(2), one should look at
the child process instead.

This patch is in hope to reduce red herrings.

BUG=334345
TBR=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/166193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251271 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=compiled

Review URL: https://codereview.chromium.org/133503012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251270 0039d316-1c4b-4281-b951-d872f2087c98

> Setuid sandbox: exit(2) on SIGABRT
> 
> The setuid sandbox waits on its one child and then dies
> afterwards.
> 
> When receiving SIGABRT, instead of dumping core, simply exit the
> process. There is no interesting information to be gathered from
> knowing that the process is inside waitid(2), one should look at
> the child process instead.
> 
> This patch hopes to reduce red herrings.
> 
> BUG=334345
> NOTRY=true
> R=jorgelo@chromium.org
> 
> Review URL: https://codereview.chromium.org/165673002

TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/164373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251269 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/163013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251268 0039d316-1c4b-4281-b951-d872f2087c98

Dead code. It became unused in https://codereview.chromium.org/146983002.

BUG=none

Review URL: https://codereview.chromium.org/165223005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251267 0039d316-1c4b-4281-b951-d872f2087c98

SCTs viewer is only used by Views and should not be included in other
platforms.

TBR=newt
BUG=326023

Review URL: https://codereview.chromium.org/163983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251266 0039d316-1c4b-4281-b951-d872f2087c98

The setuid sandbox waits on its one child and then dies
afterwards.

When receiving SIGABRT, instead of dumping core, simply exit the
process. There is no interesting information to be gathered from
knowing that the process is inside waitid(2), one should look at
the child process instead.

This patch hopes to reduce red herrings.

BUG=334345
NOTRY=true
R=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/165673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329786

Review URL: https://codereview.chromium.org/165793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251264 0039d316-1c4b-4281-b951-d872f2087c98

due to data races raised on the tsan v2 bot.

BUG=343802

> Trace event micro-optimization: use finer grained lock.
> 
> GetCategoryGroupEnabledInternal is a hotspot.
> It traverses an append-only list, so it's safe to use a finer-grained lock,
> and avoid it altogether for the "fast path", i.e., when the category is
> already known.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/144423009

TBR=bulach@chromium.org

Review URL: https://codereview.chromium.org/163613006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251262 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/164923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251259 0039d316-1c4b-4281-b951-d872f2087c98

Remove the client_address member from QuicCryptoNegotiatedParameters.
Replace it by the client_address_ member of QuicConnectionLogger.

Add kCADR support to CryptoHandshakeMessage::DebugStringInternal.

R=jar@chromium.org,rch@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/159143007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251258 0039d316-1c4b-4281-b951-d872f2087c98

Mirrors Views' IMAGE_GRID macro, reducing boilerplate code.

BUG=none
R=rsesek@chromium.org

Review URL: https://codereview.chromium.org/160253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251257 0039d316-1c4b-4281-b951-d872f2087c98

This new header conforms to RFC 2616. With this change,
both the old and new header will be supported. Eventually,
support for the old header will be removed.

BUG=340333

Review URL: https://codereview.chromium.org/156373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251256 0039d316-1c4b-4281-b951-d872f2087c98

So that the string can be directly copied into histograms.xml.

BUG=111542

Review URL: https://codereview.chromium.org/164253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251255 0039d316-1c4b-4281-b951-d872f2087c98

To track effectiveness of the app launcher install education pages in
enabling users to find, and start using, the app launcher when it is
auto-enabled upon installing the first v2 packaged app from the Web
Store.

Histogram recording committed in http://crrev.com/250348.

BUG=314235

Review URL: https://codereview.chromium.org/156963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/165383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251253 0039d316-1c4b-4281-b951-d872f2087c98

Previously, we didn't properly clear all the network caches.
1. DNS and predictor caches were left in tact. This was fixed by calling the
   net benchmarking extension methods.
2. Live resources in the memory cache were left in tact. This is fixed by
   navigating to about:blank to destroy the old renderer.

Also, --enable-net-benchmarking is supported on the stable channel, so we can
remove the workaround.

With this, cold loads are consistent on Android:

*RESULT cold_times: page_load_time= [4637,4493,4479,4564,4611,4549] ms
Avg cold_times: 4555.500000ms
Sd  cold_times: 62.602716ms
RESULT warm_times_by_url: http___www.youtube.com_watch?v_LIJOhk6FscY= [2122,2104,2079,2094] ms
Avg warm_times_by_url: 2099.750000ms
Sd  warm_times_by_url: 18.043928ms

BUG=

Review URL: https://codereview.chromium.org/165193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326023
TBR=cpu

Review URL: https://codereview.chromium.org/165253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251250 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251248 0039d316-1c4b-4281-b951-d872f2087c98

R=markusheinz@chromium.org

Review URL: https://codereview.chromium.org/153973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251246 0039d316-1c4b-4281-b951-d872f2087c98

The field accessor functions for the Views test helpers only obtain
values from sections that are actually active. (By virtue of the way
the Views dialog is built). Match OSX to do the same.

NOTRY=true
BUG=none
R=estade@chromium.org

Review URL: https://codereview.chromium.org/162813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251245 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334280
TEST=WorkspaceWindowResizerTestSticky.StickToBothEdgeAndWindow

Review URL: https://codereview.chromium.org/163833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251244 0039d316-1c4b-4281-b951-d872f2087c98

Patch Set 1 here is Lei's original patch:
https://codereview.chromium.org/109623005/
That was reverted for causing http://crbug.com/343042

This performs the same cleanup without the print preview regression.
(keeps ConstrainedWebDialogDelegateViewViews::CreateNonClientFrameView)

BUG=166075
TEST=No behavior/appearance changes; no dialog frame regressions (print preview or otherwise).
TBR=wittman@chromium.org,sky@chromium.org,thestig@chromium.org

Review URL: https://codereview.chromium.org/165073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251243 0039d316-1c4b-4281-b951-d872f2087c98

BUG=176158

Review URL: https://codereview.chromium.org/158983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251242 0039d316-1c4b-4281-b951-d872f2087c98

TextButton will be deprecated soon; use LabelButton.
Use views::Border as the AvatarLabelBorder base class.
Other minor cleanup.

BUG=155363
TEST=No regressions of this Windows/CrOS/LinuxAura supervised user UI.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/163953006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251241 0039d316-1c4b-4281-b951-d872f2087c98

(this is a fresh copy of https://codereview.chromium.org/121713002/ with correct BaseURL)

BUG=340702
NOTRY=true

Review URL: https://codereview.chromium.org/149673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317027

Review URL: https://codereview.chromium.org/163393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251239 0039d316-1c4b-4281-b951-d872f2087c98

LayerIterator takes 4 parameters. One is the FrontToBack ordering
but that is now the only option. The other 3 are for the type of layers,
render surfaces, and the render surface layer list. The latter two are
now already available as typedefs off of Layer and LayerImpl, so we
only need Layer/LayerImpl in the template arguments.

R=enne
BUG=YAK

Review URL: https://codereview.chromium.org/156603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251238 0039d316-1c4b-4281-b951-d872f2087c98

R=mangini@chromium.org
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/165353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251237 0039d316-1c4b-4281-b951-d872f2087c98

Moves AddMatchToMap method to the common base class. Adds method parameters
so that both SearchProvider and ZeroSuggestProvider can use this method.

For SearchProvider this is a pure refactoring. I added some helper classes
in SearchProvider to avoid duplicating code.

For ZeroSuggestProvider, this introduces some additional functionality on
top of what it used to have. Mainly the method may record additional metadata on
the AutocompleteMatch. This metadata is not currently used by zero suggest
provider and as far as I can tell will not in any way affect the operation
of zero suggest provider today. In the future, some of the metadata
recorded will actually be useful (e.g. I am planning to take advantage of
deletion_url).

BUG=338955
TBR=mpearson

Review URL: https://codereview.chromium.org/158053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251236 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/164693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251235 0039d316-1c4b-4281-b951-d872f2087c98

Creates a new helper function to extract search terms from the URL irrespective of the availability of InstantExtendedEnabledParam. 

Previously, InstantSearchPrerenderer invoked chrome::GetSearchTermsFromURL() to extract search terms from the search page url. chrome::GetSearchTermsFromURL() returns a valid non-empty string iff the url has an InstantExtendedEnabledParam("&espv"). If the query extraction is turned off, the search request url will not have an InstantExtendedEnabledParam. In those cases, chrome::GetSearchTermsFromURL() returns an empty string to the InstantSearchPrerenderer.

To extract search terms for InstantSearchPrerenderer, we should not depend on the query extraction flag or the Instant support state of the page.

Follow up of crrev.com/151813002.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/141893009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251234 0039d316-1c4b-4281-b951-d872f2087c98