- 07 Jan, 2021 40 commits
-
-
Sven Zheng authored
InProcessBrowserTest times out on mac. I can't repro this issue locally, nor the tryjob. When running locally with 4 parallel jobs, I do occasionally see RunLoop timeout. It's just not hundreds of test failing. But if I run with 1 parallel job, I don't see any failures. This cl use 1 parallel job first and see if this can reduce the flakiness. This will make the job slower. But as it's not on CQ, it should be fine to try this out. Bug: 11527703 Change-Id: I55ff27a506676b1688455c404611a65d643b30fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601578Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841184}
-
Francois Doray authored
Change-Id: Iee2654bfbfa321c9249de4785edbe6549532ba6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615819Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#841183}
-
James Cook authored
This is the target directory for //chrome/browser/chromeos code. See bug for migration plan. Since the code is moving, not changing, clone the DEPS file as-is to avoid bothering OWNERS. Bug: 1164001 Change-Id: Ie15d4faff0d235110a49a103fb780f5940e66a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616101Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#841182}
-
Joshua Pawlicki authored
Bug: 1163625 Change-Id: Iaf87321b3ed90fc563f991d61a8300f3c6c7edf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614861 Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841181}
-
Austin Eng authored
These test cases microbenchmark important entrypoints in the WebGL and WebGPU APIs where CPU performance is critical. Variants are added with/without V8's Fast API calls as the feature is still in development, and we don't want to regress performance. Bug: 1155348 Change-Id: I21a0b2ba9c2cb8be2ca56f7470ca8bf37ec90b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573385 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#841180}
-
Ben Pastene authored
This copies the following builder to chromium.memory: https://ci.chromium.org/p/chromium/builders/ci/UBSanVptr%20Linux And also renames it to conform to the lowercase, hyphenated builder naming scheme. The old builder's configs will be removed after the new builder is up and running. Bug: 1137496 Change-Id: Ie0bd99a377d63654261c6e9b484793120c84c30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615132Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#841179}
-
Jérôme Lebel authored
This patch should have been part of crrev.com/c/2612844. Bug: 1143204, 1146459 Change-Id: I494e6520794936a2f969c18b9d522836ac9365cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613969 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#841178}
-
Xing Liu authored
Add 2 flags so people can enable weekly reminder notification in chrome://flags. Bug: 1139073 Change-Id: Id1aeb192d2c4b587053a6b4a8ee53ec3cf0883f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615583 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841177}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/06aa1af28a72..00fcab636a05 2021-01-07 cwallez@chromium.org Fix default viewDimension in deprecated BGLEntry path. 2021-01-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 40b4928a73b7 to 766e31d50710 (4 revisions) 2021-01-07 bclayton@google.com Reland "Update PrimitiveTopologyTests to use WGSL" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: Ie963b70767806b5da73fa34c64e5d933120c37a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615838Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841176}
-
Chris Harrelson authored
The bugfix is: https://chromium-review.googlesource.com/c/chromium/src/+/2586969 Bug: 1141739 Change-Id: I8056b71d60442f53ab52d62066e152f76ed02db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615305Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841175}
-
Tommy Martino authored
This reverts commit 909901eb. Reason for revert: Causing failures on Mac bots, see crbug.com/1164011 Original change's description: > [Controls Refresh Android] Fixes input missing border > > Prior to this CL, controls-refresh text input is missing its border. > > The fix is to make sure property text_field.has_border is passed to > native theme. This property is only used by form controls-refresh > so it has no impact on existing text input. > > Bug: 1155397 > Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495 > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Yu Han <yuzhehan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841106} TBR=clamy@chromium.org,masonfreed@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org Change-Id: I2704b803c8aea565781632e8f07bbd0b29947f6f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616279Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#841174}
-
Austin Eng authored
The device lost callback is stored in a unique_ptr since it may never be called. If it's never called we need to free the allocation on GPUDevice deletion. However, if it is called, we should release the managed pointer since the callback is self-deleting. Bug: 1160448 Change-Id: I780eae1dcb8fac34a0128351f47224c83d8c6727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612120Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I257ca719bf6abdbe801f7c88ddc532a5aeeddf74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615459Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#841172}
-
Max Curran authored
the new Translate metrics. The initial implementation of the new Translate metrics assumed that when a translation failed or was cancelled there would be some error. There are a few cases where this is false, including when a translation is interrupted for a new translation with a different source or target language. This CL adds a second input parameter to TranslateMetricsLogger.LogTranslationFinished so we can specify if a translation finished successfully and if there was any translation error separately. Bug: 1155291 Change-Id: I762fe069ee9b69969a7ade84f5d5933cf43d8552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583107 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#841171}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610019930-98b4330725909b282b32db0e07c7a238a41191db.profdata to chrome-linux-master-1610042255-43b4d84a21124c058546cf1e621ecfbb55dbe4e7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I32251f5cdb2534e94b49d994ff9e2d1ac77e6af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615919Reviewed-by:
-
Scott Violet authored
This reverts commit ff9183ee. Reason for revert: for various reasons this is no longer necessary. Reverting. Original change's description: > cct: adds extra that controls whether client data header is added > > Prior to this the header was always added. After this, the header > is only added if an extra is supplied. This only changes whether > setClientDataHeaderForNewTab() is called and does not alter > the implementation of that function. > > BUG=1163158 > TEST=covered by tests > > Change-Id: Ic5d222d719a81c6da3d4e0c7866e18cbcee6e817 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611340 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840370} TBR=sky@chromium.org,tedchoc@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1163158 Change-Id: I97429cd16f7a2830d612f787a52b3270f05ccaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615302Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#841169}
-
Alex Leung authored
Bug: b/174777644 Test: internal CQ Change-Id: I3d4ed076e290f1dd3cda60f111b0ad747d73bc27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615658Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#841168}
-
Nancy Wang authored
BUG=1146900 Change-Id: Iebbf4b53aef5723dfc71e394a302ff3f9557a17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611144 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841167}
-
Nick Czajka authored
This change cleans up type definitions in display_layout.js for improved readability. Bug: 1077365 Change-Id: Ib1aac690ca56db9a833cbc7c87985eb80922fc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596063 Commit-Queue: Nick Czajka <czajka@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#841166}
-
Victor Costan authored
sql::Statement is not thread-safe. Add checks documenting this. The checks are currently excluded on Android, because the Android implementation of History uses sql::Statement in a thread-unsafe way -- see https://crbug.com/866218. Landing the checks on all other platforms now is a bit ugly, but has the benefit of preventing new errors from creeping into the codebase while the Android issues are figured out. Bug: 863724 Change-Id: Ia0d087f40bd892c2ed084e3acfc3cf1ecf12e6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1137851 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#841165}
-
Avi Drissman authored
base::SysInfo::OperatingSystemArchitecture() should return the architecture of the underlying OS, not the architecture of the Chromium binary. However, arch(3) under Rosetta will lie. Therefore, on the Mac, rely on the documented API to determine if Chromium is running under Rosetta and return correct values. Fixed: 1155315 Change-Id: I94e851b8e64eeacf776d1fed0579e5e543539402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613154 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841164}
-
Michael Hansen authored
If we launch the settings app by navigating to the Nearby Share subpage, the "enabled" toggle can be seen animating from the off to the on state. This is because prefs are not bound until after the page is visible. Other elements also appear or update after the page loads, but this toggle is especially noticeable because of the animation. This fix wraps the toggle in a template so that it appears in the correct state after prefs have been bound. Fixed: 1158520 Change-Id: Ifbc753ca3faf6db65bba183621c861bc716c6746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602576Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#841163}
-
Francois Beaufort authored
This CL has no functional changes. It adds a manual web platform test case which navigates a second after requesting NFC permission. Bug: 1034607 Change-Id: I1174c4d53f192b5b8ff4639d360a39e9170212cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607885Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#841162}
-
Alex Ilin authored
This reverts commit 73bb9dcf. Reason for revert: failing test has been fixed Original change's description: > Revert "[ProfilePicker] Enable picker on startup only for active users" > > This reverts commit 82afac04. > > Reason for revert: This CL broke StartupBrowserCreatorPickerTest.TestSetup. > > Bug: 1163675 > > Original change's description: > > [ProfilePicker] Enable picker on startup only for active users > > > > Keep the picker disabled on startup until: > > - multiple profiles were used in the last 28 days, or > > - the picker has been shown once > > > > A new prefs::kBrowserProfilePickerShown pref is added to track whether > > the picker has been shown before. > > > > Bug: 1063856 > > Change-Id: Ia35a3b2212b3811ed592d81fa516bc1ffc07accc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598848 > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840598} > > TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I306f0b7fa225b9d4043e948ec4c7a15e82ed9859 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1063856 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612309 > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840869} TBR=horo@chromium.org,droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 1163675 Bug: 1063856 Change-Id: Idfd5668b970ec0fcaf805ef8bb5ee52778987bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613970Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841161}
-
Dylan Cutler authored
This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Bug: 1102874 Change-Id: I8a46712557129ddd7fcddca78d96ced6f174746a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594016Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#841160}
-
Yoav Weiss authored
Bug: 1157818 Change-Id: Ie5e75ccb239735f3500f8763e4d9255eba2056e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592792 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#841159}
-
Alex Ilin authored
This reverts commit e2029732. Reason for revert: WebViewLayoutTest#testWebViewIncludedStableInterfaces is failing because the new API doesn't set up whether it should be exposed in WebView. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > serial: Mark the API stable > > Updates runtime_enabled_features.json5 and the stable webexposed tests > to mark the Web Serial API stable on desktop platforms. > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/RCtZPCQLLOQ > > Bug: 884928 > Change-Id: Ifefaa045a239d3b482287016c98e72c0d8c1da15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579840 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840355} TBR=reillyg@chromium.org,chrishtr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884928, 1163922 Change-Id: Ib6cc7c3e2d5c323abf4d135da576a87d178653ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611260Reviewed-by:
Alice Wang <aliceywang@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841158}
-
Yann Dago authored
Inclusive policies that have values because their older deprecated value has been migrated programmatically should not be in error, they should be in a warning state. Visual: http://screen/4XmySdAwkiTuor5 Bug: 1033069 Change-Id: I48a481ef60207516102f739a942a8c12093a980c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611548Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#841157}
-
Aya ElAttar authored
Introduced the following changed to DataTransferPolicyController: - Renamed IsReadAllowed to IsClipboardReadAllowed to be used for clipboard copy/paste. - Added IsDragDropAllowed to be used for drag-n-drop. - The logic for IsDragDropAllowed will be changed later upon confirmation from the PM & UX side. Bug: 1139886 Change-Id: Ie0594e1d68abed98145106c2aa8afe480c9b3b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595293Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
Previously 2 places in the code were interacting with |CrasAudioHandler|: - |PlatformApiImpl| subscribes to device changes, and passes this information to |AudioInputHost|. - |AudioInputHost| posts the new hotword model to |CrasAudioHandler|. This made it hard/impossible to split |AudioInputHost| from |PlatformApiImpl|, which is needed to handle audio input in the Libassistant mojom service. To solve this I moved all interactions with |CrasAudioHandler| inside a new class |AudioDevices|, of which an instance is owned by |AudioInputHost|. This also allowed me to add a bunch of new unittests. deployed on real hardware. Bug: b/171748795 Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" and manually Change-Id: I8ec9cec6672236f6365345b292efbe828518be69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610953 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841155}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5ff758df67da..603d14ec2a26 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I389176ef20478493eb5c86e73ad3a0c873eb6ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614848Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/603d14ec2a26..070ef598892a 2021-01-07 ddrone@google.com Merge "Use Chrome's TrackEvent extensions in trace processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifd709c5a57382bca35ac0c7f58415ebe600d6717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614728Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This adds the basic internal changes to SafeBrowsingPrivateEventRouter needed to report per-profile events. This CL doesn't add new tests, as this is difficult without other per-profile CLs being submitted. Adding such tests is tracked in crbug.com/1159930 Bug: 1159533 Change-Id: I65f626941367fb31ac6005fa230624d01f861718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595833Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841152}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Idcc33a8fe0e0c1591bc1a9d023ba3a6d2c2fd9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614727Reviewed-by:
-
Toni Barzic authored
App list view state changes are animated whenever app list view bounds change, which includes cases where app list transition starts from position midway between app list view states - for example, after dragging app list view, or if a state transition interrupts another state transition. Reporting animation smoothness for all app list view state transition introduces some noise - this cl reduces the cases where animation smoothness is reported to only cover full app list state changes. I.e. the animation smoothness in now reported only if the initial bounds and transform match values expected for the starting (current) app list state. This requires OnStateTransitionAnimationCompleted() to be moved to the animation observer callback, rather then animation smoothness report callback, as the report callback will now not run for all transitions. With this change, state transition animation completion is reported sooner, before the metrics results are reported. This alone breaks launcher perf tests - the tests wait for the app list view state to get to a target state, and then close the app list view. New transition timing means that app list view state change may happen before the smoothness metric gets reported - the reporter target state gets reset when the app list view state changes, and causes the reporter not to reporting the metric for the just completed state transition. To fix this, the reporter callback creation is updated to return a callback with an argument bound to the current state at the time of callback creation, instead of using the cached app list state at the time the report callback is run. Additionally, not reporting smoothness for transitions that start mid way through previous transition broke reporting for directly showing app list in fullscreen mode. The app list was initially shown in peeking state and then immediately moved to fullscreen state, which meant that transition from closed to fullscreen state was always starting from an interrupted transition to peeking state. To address this, change AppListView::Show() interface to accept preferred initial state. The change exposed an issue where observers were notified of state change before the internal AppListView state was updated (in cases where transition animations were immediate), potentially causing nested state changes - specific case: app list close transition was causing search box to be cleared, which updates the app list view state, and because it happened before app list view state got updated to closed, this started transition to fullscreen state. The CL updates the state change flow to notify observers that the app list view transition finished only after internal state is updated. BUG=1114525 Change-Id: I38193b0101fea8c8fec6badb07a0e08b0776f8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608848Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841150}
-
Mitsuru Oshima authored
Bug: None Change-Id: Ic670b45600d30ec1b4e8a679d9033803c2cea3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608655Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#841149}
-
Dan Harrington authored
This is provided for use by xsurface. It is backed by Chrome's shared ProtoDatabase. Data is automatically wiped on the same events that wipe other feed data. Bug: 1158468 Change-Id: Id215ec00311883acc65c7f3d6b87570c4b255278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590649Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#841148}
-
Nathan Zabriskie authored
Currently when using OneCopyRasterBufferProvider we perform an upload from CPU shared memory to the GPU and then a GPU to GPU copy during raster playback. This CL allows direct upload of CPU shared memory to the output shared image texture through the use of a new hint in RasterDecoder::CopySubTexture that indicates CPU memory should be used directly. This also allows us to unify how the copy is implemented in RasterDecoder to always use Skia. Bug: 984045 Change-Id: I6ac7d238cf3b2f43562481e2e1b36b3c4670a6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517149 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#841147}
-
Sophie Chang authored
Bug: 1154790 Change-Id: I737a56b26abf8cbe56e5f613e73b02dbffbcbc5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611649Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841146}
-
Tanya Gupta authored
LongScreenshotsEntry allows for management of multiple FDT requests and generated bitmaps. EntryManager is responsible for managing all of the entries. Bug: 1153969 Change-Id: I11053f9b0ba0a47282f0e1e6153f37675de3ab1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605600 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#841145}
-
