- 05 Nov, 2018 16 commits
-
-
Tetsui Ohkubo authored
This CL restores disabled TrayAccessibilityTest browser tests by using SystemTrayTestApi mojo interface. Although now the style of the test is Mash compliant, it still doesn't work with Mash because some a11y features are not yet ported to Mash. TEST=browser_tests BUG=850014 Change-Id: I25bc3ec4b7409eb97632e9b14fc91aedf8fed178 Reviewed-on: https://chromium-review.googlesource.com/c/1309554Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#605227}
-
Alexander Nohe authored
Set the index to the first image when there are no images selected. This change will allow the edit text to appear visible when shift selecting all the images in the gallery. Bug: 900619 Change-Id: I673b8ab229e9e665b2852d3e0c9d357dc82a40bc Reviewed-on: https://chromium-review.googlesource.com/c/1309997Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#605226}
-
Kent Tamura authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL renames it to not "event_names" but "event_interface_names" because "event_names" is ambiguous between event type names and event interface names. This CL has no behavior changes. Bug: 889726 Change-Id: I7bc12ae7cacff0b4a8e36eafe1dbe0d77dd804ca Reviewed-on: https://chromium-review.googlesource.com/c/1314087Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#605225}
-
Trent Apted authored
Also add a unit test to seed the base folder for testing. Bug: 879035 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I031545c083f7dab84a1d0605cda16fc02f7367b6 Reviewed-on: https://chromium-review.googlesource.com/c/1306959 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
-
Xi Cheng authored
Bug: 888276 Change-Id: Ibd3e557ad55ff48daf1e3347ec27ff6fd235a47f Reviewed-on: https://chromium-review.googlesource.com/c/1311837 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605223}
-
Fredrik Söderquist authored
The referenced bug seems to be fixed, and nothing seems to read the flag (anymore.) Change-Id: I9975182364e9344e2dde88cb70211e78b10b69c1 Reviewed-on: https://chromium-review.googlesource.com/c/1314634Reviewed-by:
Luna Lu <loonybear@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#605222}
-
Sam McNally authored
If a FakeItem is the current entry and a volume is mounted or unmounted, Files app switches to the default display root since the FakeItem doesn't have a VolumeInfo. Omit switching if the current root is not a native entry. Bug: 900870 Change-Id: I943959112135ceb5752207f87e6810a4ec60ae0f Reviewed-on: https://chromium-review.googlesource.com/c/1312148 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Jamie Madill authored
These files were from an obsolete ANGLE integration. Bug: 843346 Tbr: thakis@chromium.org Change-Id: I630cf9c5126c979fa28c768f04cafb80dceb2083 Reviewed-on: https://chromium-review.googlesource.com/c/1316594 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#605220}
-
Trent Apted authored
This is basically a "revert" of r155769, which landed 6 years ago. Problem: The hardware play/pause key currently stops working in the CrOS Audio Player in tablet mode. The event is not dispatched to the web contents. Note an external keyboard or USB headset can send this key event in tablet mode, even though events from a convertible's regular keyboard are suppressed. r155769 introduced logic that causes all accelerators to be processed as though they have the same priority as, e.g., Alt+Tab when the AppList is visible. Now, in tablet mode, the AppList _always_ declares itself visible. So currently no key combinations bound to Ash accelerators are dispatched to webcontents when in tablet mode. This is bad. r155769 was to fix https://crbug.com/142067 - "Ctrl+Space unable to switch keyboard layouts in the AppList". This occurred because an AppList button had focus, not the text field. To retain current behaviour, instead update the two Button subclasses to return false for SkipDefaultKeyEventProcessing(), thereby prioritizing accelerators over their 'space' activation. There are other buttons in the app list, but they do not currently forward space to the search box (See https://crbug.com/901245). These button types disappear or change focus to the search box when searching anyway - only SearchResultBaseView seems to really benefit from being able to handle Ctrl+Space. Bug: 899094 Test: AudioPlayerBrowserTest.NativeMediaKey Change-Id: I1cb585d88d57a775fdfa15ecfdce197ae52dfcdd Reviewed-on: https://chromium-review.googlesource.com/c/1312439 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Jeremy Roman authored
ScriptPromise is perfectly happy with a v8::Local<v8::Value>, which is created on the way to ScriptValue anyhow. Change-Id: Ib9e6529bcac0262ffd2ddb89ce4de0cfe5587c81 Reviewed-on: https://chromium-review.googlesource.com/c/1316098Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605218}
-
Maggie Chen authored
This is an optimization to reduce the size of damage rect in surface aggregation. When clipping is on, we should clip the child surface damage rects before adding them to the parent damage rect. BUG=900422 Change-Id: Ia85f1d86bf4ba13ac66167c5de04c657d66d175c Reviewed-on: https://chromium-review.googlesource.com/c/1309318Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605217}
-
Mike Klein authored
This flag was repurposed... the real thing we're rebaselining is https://skia-review.googlesource.com/c/skia/+/167264, which affects situations with solid colors and unusual blend modes. Change-Id: I1da6486ca54d5f6c60bb0b04db05f6dc92487039 Reviewed-on: https://chromium-review.googlesource.com/c/1316754 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#605216}
-
Ilya Sherman authored
There is no reason to include "slowly" in this method name, as it's not meaningfully slower than any other histogram that might be recorded in Java. (I would expect any JNI calls to dominate the runtime performance.) TBR=jochen@chromium.org Bug: None Change-Id: Id606696351783a5b39fa7908cbc3f3d681188567 Reviewed-on: https://chromium-review.googlesource.com/c/1313672Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605215}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifc4f8515bb5a26edbdbdd595c88ef943d701fbd7 Reviewed-on: https://chromium-review.googlesource.com/c/1317172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605214}
-
Giovanni Ortuño Urquidi authored
For the most part, this CL just moves the controller logic out of BluetoothDetailedView and into UnifiedBluetoothDetailedViewController. But there are three exceptions: 1. Before, Layout() was called at the end of BluetoothDetailedView::DoUpdate(). Now, Layout() is called indirectly in UpdateDeviceScrollList() through, ShowBluetoothDisabledPanel, HideBluetoothDisabledPanel, and BluetoothDetailedView::UpdateDeviceScrollList(). 2. BluetoothDetailedView::UpdateDeviceScrollList() used to perform the following steps: 1. Clear the device list 2. If state is not "powered" show the "bluetooth disabled" panel and return. 3. Otherwise hide the "bluetooth disabled" panel. 4. Update the device list. Now UBDVC::UpdateDeviceScrollList() performs the following steps: 1. If state is not "powered" then call BDV::ShowBluetoothDisabledPanel() and return 1.1. Clear device list 1.2. Show "bluetooth disabled" panel 2. Otherwise call BDV::HideBluetoothDisabledPanel() 2.1. Hide "bluetooth disabled" panel 3. Call BDV::UpdateDeviceScrollList() 3.1. Clear device list 3.2. Populate device list with current devices. Similar set of steps but except that "clear device list" is performed by two separate functions. 3. Discovery stops when UnifiedBluetoothDetailedViewController gets destroyed. Before, discovery was stopped when BluetoothDetailedView was destroyed. Change-Id: I4727bcdf35e0f84ab16ff0bace8f3d89aefc58de Reviewed-on: https://chromium-review.googlesource.com/c/1308241 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605213}
-
Eric Karl authored
To make Viz's GPU proc startup more like non-Viz, and hopefully avoid the increased crash rate when trying to connect, this change delays establishing the connection to the Viz/GPU process until we establish our first GpuChannel. TBRing fsamuel as I want to get this baking in tonight's Canary for potential mergethis tuesday. TBR=fsamuel@chromium.org Bug: 897272 Change-Id: I4234040a58cb5af13594adf2e1d9287b043aac1b Reviewed-on: https://chromium-review.googlesource.com/c/1317031 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#605212}
-
- 04 Nov, 2018 15 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 55aff748. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I93cc8076f2e377eec1d1bdeeb377a0e97c7a1776 Reviewed-on: https://chromium-review.googlesource.com/c/1317130 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605211}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I68849e37c788f2d4423e95ca8afe0bceb49a5455 Reviewed-on: https://chromium-review.googlesource.com/c/1316697Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e4081554d06..2b21e88ed6dd git log 7e4081554d06..2b21e88ed6dd --date=short --no-merges --format='%ad %ae %s' 2018-11-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@2b21e88ed6dd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I65f58e4a975f397bec02d20219de18aefec9338a Reviewed-on: https://chromium-review.googlesource.com/c/1316695Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682c7b60bfe3..46e156a4422d Created with: gclient setdep -r src-internal@46e156a4422d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia3dc993851fc54046a98355c9a88d0b2c817a5f7 Reviewed-on: https://chromium-review.googlesource.com/c/1316694Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605208}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/35240cdb..d88f2e88 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3b3704448e20be5bb5815ab6e1be21631ad97e29 Reviewed-on: https://chromium-review.googlesource.com/c/1317128Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605207}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ff910b52. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mcasas@chromium.org: external/wpt/mediacapture-record NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I118f911c1cf15e3dac5c9487c53b04d79a9c75a7 Reviewed-on: https://chromium-review.googlesource.com/c/1317127 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/994675e1ee78..682c7b60bfe3 Created with: gclient setdep -r src-internal@682c7b60bfe3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie0842b741a18a2082939aa94a793d47cf7f4372b Reviewed-on: https://chromium-review.googlesource.com/c/1316693Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d46eb19b40ee..994675e1ee78 Created with: gclient setdep -r src-internal@994675e1ee78 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I94080e79a6469ed4561f0d2eec693d24469644b6 Reviewed-on: https://chromium-review.googlesource.com/c/1316692Reviewed-by:
-
Sergey Ulanov authored
The old fuchsia.ui.viewsv1 API is being replaced with views support in Scenic. This CL prepares chromium for that migration: 1. Adds implementation of fuchsia.app.ViewFactory in WebComponent. fuchsia.viewsv1.ViewFactory will be removed in the future after it's removed and all consumers are updated. 2. Added CreateView2() method in the chromium.web.Frame interface. It is compatible with ViewsV2 and will replace the old CreateView(). 3. Updated content_shell and ozone_demo to use Presenter::Present2(), which is compatible with ViewsV2. Bug: 899348 Change-Id: I82d066cdd60dc06cf598f336a40cca4584d1e3bb Reviewed-on: https://chromium-review.googlesource.com/c/1311123 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#605203}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c7e70126c1b..d46eb19b40ee Created with: gclient setdep -r src-internal@d46eb19b40ee The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibb56829395b3a3bea1058b6ca5df0e1f7dfb0f9f Reviewed-on: https://chromium-review.googlesource.com/c/1316691Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I4771d0d4954dd677c8065154a1cbcdb359bc2621 Reviewed-on: https://chromium-review.googlesource.com/c/1316597Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#605201}
-
Mike Reed authored
See https://skia-review.googlesource.com/c/skia/+/168024 Change-Id: If548e9c6149ad4444eb0f8a522732b3ddd3b3aac Reviewed-on: https://chromium-review.googlesource.com/c/1316595Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/774a7b3a25ea..7c7e70126c1b Created with: gclient setdep -r src-internal@7c7e70126c1b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4b9d82f7cca81b8d78cb86c3a5e1465ea1dda81f Reviewed-on: https://chromium-review.googlesource.com/c/1316690Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f678f08b6f6f..774a7b3a25ea Created with: gclient setdep -r src-internal@774a7b3a25ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2a3bc720ba4de662ac398918b6ee3065bf8e0223 Reviewed-on: https://chromium-review.googlesource.com/c/1316689Reviewed-by:
-
Christian Biesinger authored
R=mstensho@chromium.org Change-Id: Ia16d22e1ac587de7588a17be48c0e6d171457022 Reviewed-on: https://chromium-review.googlesource.com/c/1316596Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#605197}
-
- 03 Nov, 2018 9 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ceed0c76caf9..f678f08b6f6f Created with: gclient setdep -r src-internal@f678f08b6f6f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8a3fb69d00542aedaa44e045a144869575370ed4 Reviewed-on: https://chromium-review.googlesource.com/c/1317001Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I30f7e6fe2143a42c5c361e4f56f9842d8a96c800 Reviewed-on: https://chromium-review.googlesource.com/c/1317000Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3304997ac5db..ceed0c76caf9 Created with: gclient setdep -r src-internal@ceed0c76caf9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If445c404e7bc42265ea23976f7a2bf548d5ee5cf Reviewed-on: https://chromium-review.googlesource.com/c/1316999Reviewed-by:
-
Takuto Ikuta authored
This is detected by PRESUBMIT Change-Id: I3d278f45cc03c8b1907bce2fcd0978a478f87129 Reviewed-on: https://chromium-review.googlesource.com/c/1317008 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#605193}
-
Justin Cohen authored
Previously calling -loadURL immediately after loading an NTP in a test would yield expected ios/web callbacks. With a non-native content NTP, -loadURL must be called after the NTP webState load completes. This is similar to loading any other web site. Bug: 826369 Change-Id: Ice1364aee6299ab00b5fd9f0188e56ab0c73095c Reviewed-on: https://chromium-review.googlesource.com/c/1316591Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605192}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/671341ac6669..9f878f6e97fa git log 671341ac6669..9f878f6e97fa --date=short --no-merges --format='%ad %ae %s' 2018-11-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b58a0334..4e7c87b5 (605082:605184) Created with: gclient setdep -r src/third_party/webrtc@9f878f6e97fa The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifa81ec6e0c2127fd99fb395feecba01ad4b3709d Reviewed-on: https://chromium-review.googlesource.com/c/1316998Reviewed-by:
-
Xiaohan Wang authored
Since COMPONENT_EXPORT(MEDIA) is too long, still keep MEDIA_EXPORT. But instead of defining our own, define it to be COMPONENT_EXPORT(MEDIA). Bug: None Change-Id: I0b24844d3227f918ef1d567a405a03356f66d289 Reviewed-on: https://chromium-review.googlesource.com/c/1313879 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#605190}
-
Koji Ishii authored
This patch changes NGPaintFragment to remove children before it is destructed. Because NGPaintFragment keeps its children as a linked list, the destructor will deref its first child and next sibling, which will call their destructors recursively. This patch removes children first to avoid stack overflow when there are many children. Bug: 901105 Change-Id: I0bbb5745468926178ce0132208d4c07f56839cf4 Reviewed-on: https://chromium-review.googlesource.com/c/1314020 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605189}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/072d61b49093..3304997ac5db Created with: gclient setdep -r src-internal@3304997ac5db The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie198e35c34adf0af81f5c8a8b5aba3043fd42972 Reviewed-on: https://chromium-review.googlesource.com/c/1316997Reviewed-by:
-
