- 16 Dec, 2020 40 commits
-
-
Hiroki Nakagawa authored
The mode is deterministically kPrefetchOnly. It's not necessary to propagate it. Bug: 755921 Change-Id: Ib297fba318436d78d72be3c1f2507bb86a372ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592273Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#837589}
-
Nate Fischer authored
This updates the styleguide to recommend androidx.annotation.Nullable because android.support.* is generally deprecated. We've already migrated chromium to the AndroidX imports, so this just updates the styleguide to be in line with our current practices. This deletes the word "other" from the section header because this is the only reference I could find to Java annotations. Test: tools/md_browser/md_browser.py styleguide/java/java.md Test: Upload to gerrit > open file > click "gitiles" Change-Id: I84a78e3396fc05eeabda1114aab1658593a9be66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593182 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#837588}
-
Robbie Gibson authored
crrev.com/c/2136232 added the ability to block the web content area when an HTTP auth dialog from a different host is displayed. However, in this case, the tools menu site info item is still enabled and shows the incorrect url. This disables that info when the content area is blocked. Bug: 1157800 Change-Id: I0004c0ce608303e41e970f4389481ad31bcd050d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592998 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837587}
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. There is a section about the renaming on http://go/lacros-macros. Bug: 1052397 Change-Id: If5bf960d24f9b860647288759a411dfd687c3e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593852 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#837586}
-
Thiabaud Engelbrecht authored
This Cl is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2564938, which added metrics for ParkableImages. This CL fixed a typo ("Memory.ParkableImages.TotalSize" -> "Memory.ParkableImage.TotalSize") which was preventing collection of metrics. Bug: 1154295 Change-Id: Iaa3b5cce518b761c87fc2cea719d31ab7e2a7a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589027Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#837585}
-
Corentin Wallez authored
TBR=ynovikov@chromium.org Bug: chromium:1159394 Change-Id: Ibbf7a20405d38ad3ca3dd2d6586dffbce0629889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593105Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#837584}
-
Nick Burris authored
* Make ExternalAuthUtils provide its own instance instead of callers having to use AppHooks. A follow up patch will remove the ExternalAuthUtils instance from AppHooks. * This is patch 3/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2587430 after adding the missing dependency to the android_sync_integration_tests target. Bug: 1154371, 1159404 Change-Id: I28a98e549dd139af9cfcb5f9a802e02839c3e0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593652Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#837583}
-
Yuta Hijikata authored
The change is mechanical replacing GN variable is_chromeos with is_chromeos_ash. (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Ib66985f4e40f01ec17be99c7ad1545403b243dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594619 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837582}
-
Liquan (Max) Gu authored
Motivations: * Provides test coverage for the integration of Chrome and PRService. * The integration test for GooglePayPaymentApp & factory will be added based on the test supports of this CL. Summary: This CL adds an integration test for the integration of: - PaymentRequest - MojoPaymentRequestGateKeeper - PaymentRequestService - ChromePaymentRequestService ...excluding: - Ui (PaymentUiService) - App factories (e.g., Android, service-worker payment app factory) In order to rule out the low level details, CPRService delegates the following creators/static methods so that mocks can be injected: * PaymentUiService * ChromeActivity * AndroidPaymentAppFactory * PaymentAppServiceBridge * AutofillPaymentAppFactory * AutofillPaymentAppFactory.canMakePayments * PaymentRequestServiceUtil.isWebContentsActive * PaymentHandlerHost Bug: 1158522 Change-Id: Ica52f4858042dded01e328824ce4550dcff68901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566372Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837581}
-
Sean Gilhuly authored
This reverts commit 297828da. Reason for revert: Suspected cause of crbug.com/1159427 Bug: 1159427 Original change's description: > Roll ANGLE from c47b951ecbcb to f32fbb51e8a1 (4 revisions) > > https://chromium.googlesource.com/angle/angle.git/+log/c47b951ecbcb..f32fbb51e8a1 > > 2020-12-15 m.maiya@samsung.com Add EXT_shader_framebuffer_fetch_non_coherent entry points > 2020-12-15 m.maiya@samsung.com Vulkan: Add the tests for EXT_clip_cull_distance > 2020-12-15 timvp@google.com Vulkan: flushCommandsAndEndRenderPass during glFenceSync() > 2020-12-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c16dc7107fd3 to fa44979d90aa (5 revisions) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/angle-chromium-autoroll > Please CC cwallez@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: cwallez@google.com > Change-Id: Ib3a7f645466a7bd9b9d3189dcfed4fb9ff763621 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593591 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#837367} TBR=cwallez@google.com,chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Icb842f4f1d82cdd083eccfb46d7f5f10deca3b28 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595587Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#837580}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 85af6214. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I2fd61fb5c54ae2fed2d9c92c743a7b80fd2ca618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592146Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837579}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ibf751a9e735f13a3e643e18dab2cf3f79331ff63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595011Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837578}
-
Benoit Lize authored
No need to use int, makes one of the tables fit in single cache line. Bug: 998048 Change-Id: I29d35e872f4e39c823bf787977defb6058a69866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593385Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837577}
-
Scott Violet authored
This reverts commit f770838a. Reason for revert: This is causing crashes. See https://bugs.chromium.org/p/chromium/issues/detail?id=1159386 . Original change's description: > Reland "Remove unneeded CursorLoaderWin::SetPlatformWindow calls" > > This is a reland of 1208732e > > Original change's description: > > Remove unneeded CursorLoaderWin::SetPlatformWindow calls > > > > SetCursorNative is only called from WindowTreeHost::SetCursor, which > > guarantees that the platform cursor has been set. > > > > Bug: 1097556 > > Change-Id: I4c140a872482ba33bf957ed6817279c275bf7f36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417893 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#810120} > > Bug: 1097556 > Change-Id: I89b742a80ddd9fee7a77b5af1bee07b58c18f39b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445550 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> > Cr-Commit-Position: refs/heads/master@{#837132} TBR=sky@chromium.org,hferreiro@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I4bec9fe875e8bfd6c97663e63a499bc4b27d390f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595510Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#837576}
-
Akihiro Ota authored
Modal dialogs are supposed to trap focus inside the context of the dialog. This change fixes an issue in OOBE where focus was incorrectly moved from a dialog to the login shelf when pressing tab enough times. Bug: 1157982 Change-Id: Ia426871d02dbf3e2f66aa1ca42d48c0f322e4c44 AX-Relnotes: Ensure dialogs in OOBE trap focus. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590371Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#837575}
-
Steven Bingler authored
With the constructor use of CanonicallCookie greatly reduced (with ongoing work to privatize the constructor) CookieMonster no longer needs to set the source scheme of a cookie. This change will fix a bug in which cookies set by DevTools always get ovewritten with a "Secure" scheme regardless which sourceScheme they entered the CookieMonster with. Bug: 1031721 Change-Id: I58d9a938755bc04b085f4a6b6279bd4898e1d1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590016Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#837574}
-
Ioana Pandele authored
Bug: 1044930 Change-Id: Ia52660f3bab6dfe405fd0d77e6147d402a4196c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593001Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#837573}
-
Joon Ahn authored
prevent computed values from updating before initial values have been set. Bug: 1158524 Change-Id: I993fbd30730e9a64a8b584e6d5634674d048ee10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594236Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#837572}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012160600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/F2qSaG03RybV34PPKgVY50FpLeJhLL-u5pz5Gmi9s9AC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/138961540,b/168070817,b/173980515,b/174286210 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia0251d6f45a55f83bb56c917e4faada6e291e3c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594097Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837571}
-
Michael Thiessen authored
Bug: 783819 Change-Id: Iead5ba95a981fcdaebd9db54bfd22fbec47e9e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593762Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#837570}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7248453cc6d3..68cf42e8f227 2020-12-16 alcastano@google.com Refactor to use Map rather than Object in PresentationConsoleMessageHelper.js 2020-12-16 szuend@chromium.org Report Trust Token operation result in network panel 2020-12-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-16 tvanderlippe@chromium.org Add assertNever to exhaustive switch statements 2020-12-16 kimanh@chromium.org Use a ResourceTreeFrame's security origin as context in console If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126824,chromium:1132260,chromium:1150883,chromium:1159332 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic270eb254b072c82c6ed605b2c05ac9854a53b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594455Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837569}
-
Bo Liu authored
This is a reland of 012b87aa SetSurface is called when a surface is resized. On lollipop, destroying and recreating an egl surface for the same java surface fails, which then causes a CHECK failure. Instead, if the same Surface instance is set again, just skip native SetSurface. Original change's description: > aw: Switch instrumentation shell to SurfaceView > > Also refactor the fake draw_fn implementation. This is to prepare for > adding a vulkan draw_fn implementation. > > Split draw_fn implementation into: > allocator.cc/h: Controls functor data lifetime > context_manager: Effectively global. Responsible for owning the surface > and EGL context. Calls sync/draw/context_destroyed on > functor and responsible for owning the "impl reference" > to functor data. > > context_manager uses EGL bindings from ui/gl, but nothing else > to avoid conflicting with chromium side implementations, and to avoid > initializing a TaskRunner on render thread. Only GLES call is > glReadPixels after draw, which relies on chromium implementation not > releasing its bindings after draw. > > Refactor and simplify the java side by explicitly adding a thread to > post tasks and a WaitableEvent; this avoids saving state and using > a Lock object. > > Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-android-m-nexus-5x-64 > Bug: 1141687 > Change-Id: I71752b31f401fdb277062fe1347dfa826a20bb81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587238 > Auto-Submit: Bo <boliu@chromium.org> > Commit-Queue: Jonathan Backer <backer@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837094} Bug: 1141687 Change-Id: I2af0a20201aba8156bfa7e9fec6ac37729f5ab55 Cq-Include-Trybots: luci.chromium.try:gpu-fyi-try-android-m-nexus-5x-64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593878 Auto-Submit: Bo <boliu@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837568}
-
Sanja Perisic authored
Updated AppLaunchSplashScreenView and FakeAppLaunchSplashScreenHandler, so that they now support tests for app launch state. Added verification for app launch state in Kiosk browser test. Bug: 1156788 Change-Id: If2ebead7e75c80bdbcfe1dbf62c2dd415fcee024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588933Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837567}
-
Shik Chen authored
The snackbar should align to the bottom left of the viewfinder box instead of the window. Bug: b/172879638 Test: Manually Change-Id: I02e9cc47026a8dbaae8f8c5409f76841670adcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593850 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#837566}
-
Friedrich Horschig authored
As discovered by ioanap@, the TouchToFill view object is indefinitely referenced by the touch_to_fill_controller. This means that the java object cannot be cleaned up by the GC and for a simple site with one credential, this amounts to ~60KiB in retained memory for the entire lifetime of the WebContents object. Since TTF is only shown once, releasing the reference after any interaction (dismiss, fill or manage pwds) does the trick. This change also would work on consecutive calls since the controller creates the view lazily before showing it. Bug: None Change-Id: I7a9d78c92e370adec4544de8634ec427e9472c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593627Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#837565}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/54174aefa84c..df1712b41e9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2eb16c96fd9624a62f107c1530f5d1e0da2cab36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595012Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837564}
-
Devon O'Brien authored
Change-Id: I7568523f0a1e93cd1d0133e9dc15f561e5be7a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593519 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837563}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/54174aefa84c..df1712b41e9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I33db6f651242a14794798bfedb46ff910150f363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837562}
-
Stephen McGruer authored
This reverts commit 21349955. Reason for revert: Very tentative revert (with apologies if it's completely wrong) for strange crashes in mini_installer tests: https://crbug.com/1159411 Original change's description: > [PartitionAlloc] Use exponential backoff for periodic purge. > > Periodic purge should ideally not be scheduled at all when a process is > fully idle from the allocator's standpoint, that is doesn't > allocate. The current current scheme achieves that, with non-trivial > complexity (including managing reentrancy in the allocator). > > Make the code simpler, by modulating purge frequency with exponential > backoff, rather than the complex mechanism we have. > > Bug: 998048 > Change-Id: I7faa5b2bb8450e41dba1c6cbdc0f65cd2d9a1dec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593373 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837539} TBR=haraken@chromium.org,lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I1d47a0aaf1f66ca8be50934b99b5222a07289855 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048, 1159411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595088Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837561}
-
Yi Gu authored
Bug: 1152279 Change-Id: I9e0de0b74d17ba0fa8834114507fedbe6fac3460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594010Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837560}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608097529-96e83b64d2e55c9fef1094979ebe73b794f619fe.profdata to chrome-linux-master-1608119279-7581a2bc471fb45383c585f2e908653a380f92f3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I20e3eb67be9c7caf297ef1502c6b9bd1cb7ce7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594456Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837559}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608097529-4473bb129a43d499a6f4ca2ef772a18f6300cda1.profdata to chrome-mac-master-1608119279-b562d5ec97263b932edf0a2d650ba22af7f72930.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4bcb80ec87b73efe4b3f4aae2b72e49b2039ad57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837558}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cec10df94078..352fcae17686 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jdoerrie@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1138973 Tbr: jdoerrie@google.com Change-Id: I1df5991204e4e3f26139c4fc8ce311df6895c410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594892Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837557}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df1712b41e9f..6bf9e131d05a 2020-12-16 fmayer@google.com Merge "Support deobfuscation in heap_profile." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifcba2df0eac9c4d86f0c84c3da41eddd7e333c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837556}
-
Shakti Sahu authored
This CL adds field trial testing config for read later feature. TBR=dtrainor@chromium.org Bug: 1158565 Change-Id: I8c30b6cb39d9081f00aae6683a108d1d889f4414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591227Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837555}
-
Jan Wilken Dörrie authored
This reverts commit bf31a52a. Reason for revert: https://crbug.com/1159404 Original change's description: > Make ExternalAuthUtils a singleton instance > > * Make ExternalAuthUtils provide its own instance instead of callers > having to use AppHooks. A follow up patch will remove the > ExternalAuthUtils instance from AppHooks. > * This is patch 3/5 for providing ExternalAuthUtils as a singleton > instead of from AppHooks. > > Change-Id: I6527d93dbce453626aa0c02f7093d7686f67266a > Bug: 1154371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587430 > Commit-Queue: Nick Burris <nburris@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837354} TBR=tedchoc@chromium.org,agrieve@chromium.org,nburris@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I10df0927d2dcc291e93e1edd0a3e8ea1c74f10a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594774Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#837554}
-
Stepan Khapugin authored
Adds a fading alpha animation when dismissing the blocking UI. Bug: none Change-Id: I014b8e67d230045e130343894cb4759ce05b8ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593633 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#837553}
-
Stepan Khapugin authored
Adds a screen title, makes the blocking screen a modal, and adds a magic tap to start authentication. I don't have the final string yet, the bug 1138892 is updated with the new one that's required. Bug: 1138892 Change-Id: If6312eb90a1686446f554f8713a1047bdb30256d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593265Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837552}
-
Nazerke authored
This CL adds the zPosition for the selected cells in the tabstrip to make them fully visible. Bug: 1154122,1128249 Change-Id: If11dd52e456bc5b3c625ef3aaf226a39326e72d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575025Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#837551}
-
Thomas Tellier authored
Bug: 1158825 Change-Id: I740a162a81768fa2cc7271315b553070636757fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592800 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837550}
-