- 13 Jul, 2020 37 commits
-
-
Kenichi Ishibashi authored
This doesn't seem to be used. Bug: N/A Change-Id: I050398b164cb58d86ee7b1af271fa91fdc43a2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294500Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787643}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ia300db2ed184529cd8ae587b3a40c3a84d100167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291520 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#787642}
-
Yuki Shiino authored
Updates ExceptionState::ContextType so that it better fits with the new IDL interface implementation. Bug: 839389 Change-Id: Ia7e9bed5ceb93718336c07d98156ee89260ea8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291822 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#787641}
-
Manuel Rego Casasnovas authored
NGOutOfFlowLayoutPart received a NGBoxStrut representing border and scrollbar sizes, so in layout algorithms we were computing that sizes and passing them to NGOutOfFlowLayoutPart. This has 2 problems: * We're doing this operation even when we don't have positioned descendants. * Some callers are forgetting to add scrollbars which can lead to bugs. With this refactoring we do this computation only in NGOutOfFlowLayoutPart constructor, after the early return (in case we have no positioned descendants). BUG=1098231 Change-Id: I9380d58f74c1034d4dd643073f19535bd3b603fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279758Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#787640}
-
Anand K Mistry authored
This only changes the argument types, not the return type, which will be updated in a follow-up change. Bug: 646113 Change-Id: Idea5cc9bddf13143720aaba17cf43e36b5bf8e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291294 Commit-Queue: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#787639}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/609ea210e2c0..f64be13cbf84 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fe36a64765c5 to 7d82d29398cc (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I2c88b0e4fe4266ad0055ba561e36f7209cbe9d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787638}
-
Anand K Mistry authored
Bug: 1007788 Change-Id: I1b9323a44a54639707b4f2bb937e5b72bf5ffdd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279340Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Anand K Mistry <amistry@chromium.org> Auto-Submit: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#787637}
-
Xianzhu Wang authored
Change-Id: I3c106e9decfdd6017db943d07058dfa9138d7e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294338 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#787636}
-
Quang Minh Tuan Nguyen authored
Bug: 1007686 Change-Id: I0e9741b65b522006808d8731d5980e71124f3469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291174 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Auto-Submit: Quang Minh Tuan Nguyen <nqmtuan@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#787635}
-
Maggie Cai authored
This CL gets the icon urls for the file tasks queried from app service. BUG=1092784 Test: Manually tested with files app. Change-Id: I691f09ea9203a419c120caf9caa9d0d80ed22a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291562Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#787634}
-
Eric Willigers authored
File sharing has shipped. We no longer need a separate flag for WebShareV2. Change-Id: Ib865e8389ced9df3cce9b96cd93f17dcc4819861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279513Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#787633}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594598363-0f08cd7fd83096035f2df6543642255aef7772e8.profdata to chrome-win32-master-1594600621-783048b6dd03c460bf0ffdecd7c0b42fb3608f4c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia436075b68f20a8b9bc8326cf9a32a0a39d5f249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294475Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787632}
-
Kent Tamura authored
|run_fonts| should have no items on calling GetRunFontData(). This CL has no behavior changes. Change-Id: Ie5f8220b172543559473cc9a33c484aabc19b3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291803 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#787631}
-
David Munro authored
We don't reset settings.Router between tests, meaning runs after the first start already on the page being tested. A typical pattern for our pages is load data on attached then update as required, starting already on the page introduces a race between how quickly we can set up our test data and how quickly Polymer loads in the page. Bug: chromium:1096432 Test: Since flake mostly happens on buildbots, check Flake Portal after push Change-Id: I41cacffa0ee44428f5fda78c32916a6c56deec7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280776 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#787630}
-
John Chen authored
NOTRY=True TBR=wenbinzhang@google.com Change-Id: Ib644820981abd902cb6372d3008c1ee0b372b9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288100Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787629}
-
Jing Wang authored
Also change the variable name from show_tab to show_annotation since we don't have tab icon now. Test: tested with Chrome on Linux Bug: 1099498 Change-Id: I2d4cb00c6e329fd6b59aa730c2efb5827f99fb75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291918 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#787628}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/120e1d66c8ff..7d82d29398cc 2020-07-13 jiajia.qin@intel.com Refactor DisplayGbm::generateConfigs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Id51043a9e0b92eebfadcc2ec775f6165058bc3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294472Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787627}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f8336121437..6723c14bd63c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I842c3e8c02d498fab45b2833b0383512d7ea247b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294474Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787626}
-
Jing Wang authored
Chrome on linux doesn't have WMHelper, so the DCHECK in exo::WMHelper::GetInstance() will always fail. This bug only repro when you build in debug mode where DCHECK is enabled. Bug: 1095204 Change-Id: I48f6b50bb9a382dcf2b9360d422ed315ece4b81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291921Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#787625}
-
Hiroki Nakagawa authored
Bug: 1007635 Change-Id: Ica9e9a0d21bb8359835c606f37eafc191fea81b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280818 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#787624}
-
kouhei authored
Bug: None Change-Id: Icc2e54d85b33c0ddd5110fd5e3921503c2655a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291305 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#787623}
-
Yoshifumi Inoue authored
This patch implements |LayoutText::PositionForPoint()| by iterating over associated fragment items, like legacy layout wchich iterates over inline text box, instead of iterating over all lines in containing block to avoid handling of hit testing in position:relative in |LayoutBlockFlow::PositionForPoint()|. Bug: 982194 Change-Id: I929d2ec232b82203aec576ae8c1af1f335e64f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291300Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787622}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594592389-af5b3849078a14dae1cc2ee4cd89c514efdae653.profdata to chrome-win32-master-1594598363-0f08cd7fd83096035f2df6543642255aef7772e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id7bf07ed5aded87d69804a7a04af794ce09eafa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787621}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594575324-966115032581effdab5f5f010cfa293f68539e16.profdata to chrome-win64-master-1594598363-93f916054c84cb07f9e79c6e6fd62a54f73f0a49.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand@google.com,jeffyoon@google.com Change-Id: I6996f41fdac5e775acb7c836a19ea17f2c288517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294471Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787620}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I285ac33732f206d096c11a50aca2660b7704c465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294356Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787619}
-
Meilin Wang authored
Bug: b/153041587 Test: covered by unittest. Change-Id: Ic8141b9c91199b5d798f5ef8fc518caed1efc35d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288359 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#787618}
-
chrome://media-appTrent Apted authored
A lot of ChromeOS file volumes are read-only, but this isn't communicated back through reliably until a write attempt fails. `Save` is a critical step when editing images (i.e. there is no "Done", only "Save"), so the experience is very broken if Save fails. To fix, automatically show a file picker when Save fails, and transparently "slot in" the new file handle into the set of open files, so that later Save requests re-use the same file. This works because the NativeFileSystem API is configured not to show any non-native volumes as an option in the file picker. To reduce type gymnastics, updates some declarations in in web_app_file_handling.externs.js to use bespoke return types for the show{OpenFile,OpenDirectory,SaveFile}Picker functions. (Previously the externs had just copied the `requestFileEntry` return type, which is now overly generic). Bug: b/160827952 Test: Add an image to a zip file on ChromeOS, open the zip, open the image, edit it, save it [get a file picker], save again [overwrites]. Change-Id: Idfe3867e409a383319d06f9a1cffbbe4d1e0c78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289574 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#787617}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 08d777bf. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I783181d3294dea12b0f0d86b12630d7d252fceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293200Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787616}
-
Minoru Chikamune authored
The HeapMojoWrapperMode::kWithoutContextObserver was a HeapMojoWrapper's "safe mofe" to keep the existing behavior during the release freeze. Bug: 1049056 Change-Id: I0ee6b4c02ee1f21ac0fadf28611e63fa05be68c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291797Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#787615}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a19aae790c05..9f8336121437 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: Ia0416c4578054809e7d34068283e4fe13a367693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294463Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787614}
-
Jinsuk Kim authored
Moves the logic for Navigation history sheet triggered by longpress on back button to TabbedRootUiCoordinator. Bug: 1103696 Change-Id: I7809db3eb0c193c4b4e73e4c5bdc2ce6fc9d9fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291813Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#787613}
-
nancylingwang@google.com authored
BUG=1016195 Change-Id: I3b8066eae359428dfad82cf5e0e8d80855dc8433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291916Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787612}
-
Yusuke Sato authored
Previously, Chrome just stored a randomly generated serial number in the user's prefs and passed it to ArcVmClientAdapter when it starts the VM. This CL changes the way of the serial number generation as follows: 1) Chrome no longer stores the serial number itself in the pref. It stores the "salt" instead. 2) The pref location is changed from the user's prefs to Local State. 3) When /var/lib/misc/arc_salt (which is for ARC container) exists, Chrome copies the file's content to the Local State pref. 4) Generate the serial number for the user in exactly the same was as ARC container which is sha256(user_id + salt_in_local_state). 5) Don't set the local state pref unless ARCVM is in use. As a result, devices that are upgraded from ARC container to ARCVM can continue to use the same ro.serialno on ARCVM. This CL depends on https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2271390 (platform2). BUG=b:143976415 TEST=try, ARC container/VM still starts Change-Id: Ia75e0e09d25d0eb3f806e865c1b19bca77507c9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271534 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#787611}
-
Koji Ishii authored
When `::first-line` state was changed, some lines may be still reusable, but reusing may put the fragment tree in a strange state where the block container doesn't think different text/styles are needed for `::first-line`, but |NGFragmentItem| may require the style/text for `::first-line`. This patch disallows reusing lines from `::first-line` if new block container does not have different `::first-line` text/style. Bug: 1104533 Change-Id: Ieb8745726ea8664480c248bca2ec991813027f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291181 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787610}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594584635-bb45e78f33683581551756e1852261c845dc0466.profdata to chrome-win32-master-1594592389-af5b3849078a14dae1cc2ee4cd89c514efdae653.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie8bcc03468ed09662d09ba91bb10739ae437745c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787609}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594575324-3bb990652f30631acc2ce7b13811538834e8b35d.profdata to chrome-mac-master-1594598363-c555f7e8a80b40cf8a42d21663f74bad4c776a90.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I21c87cd2e0b044663d40dd64e0c7a43269e7e6a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787608}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ide249d1c9427142d6a77ba93e30379ec5ec287db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294461Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787607}
-
- 12 Jul, 2020 3 commits
-
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594580299-5b87349d544b49583bd7f6393c8b831bfa21604e.profdata to chrome-win32-master-1594584635-bb45e78f33683581551756e1852261c845dc0466.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com Change-Id: Ieae937bdc0b70bf019188ce5e9b0e08ee2322606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294460Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787606}
-
Xing Liu authored
This CL adds the metrics for download later feature. TBR=holte@chromium.org Bug: 1103920,1078454 Change-Id: I6967350524ac4bac96b266b3d2b7522b5c09cb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291313 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787605}
-
Kenichi Ishibashi authored
Tests in ServiceWorkerSingleScriptUpdateCheckerTest don't depend on EmbeddedWorkerTestHelper. Remove the helper. Bug: N/A Change-Id: Ia236ee0bfe20e38b18185a2653f6a6d30d363619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291295Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787604}
-