- 03 Feb, 2018 12 commits
-
-
Peter Boström authored
Also removes a stale promo string that has been replaced. Bug: chromium:807886 Change-Id: I63d64ec65573eb2742fcb59cea790a720fae0a41 Reviewed-on: https://chromium-review.googlesource.com/900053Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534217}
-
Miguel Casas authored
Gpu FeatureInfo::FeatureFlags.chromium_image_xr30 doesn't work on Swiftshader because it doesn't support GL_BGRA(_EXT) for glImage2D(), making our texture uploads fail. This failure is legit because GLES 3.0 supports only GL_RGBA data format. So this CL disables chromium_image_xr30 until the swiftshader bug is addressed (adding a TODO), and also corrects the OpenGL version where GL_EXT_texture_type_2_10_10_10_REV was inlined, which is 3.3 and not 4.2 as I wrote erroneously before, oops! (see http://go/gl3.3) Bug: 808172, swiftshader:95 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0c6952b14ff53fb504bf292c51a8bc2ffe612918 Reviewed-on: https://chromium-review.googlesource.com/899462Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#534216}
-
Jeffrey Kardatzke authored
This allows desktop capture to also include the mouse cursor without having to induce a separate compositing stage for desktop capture itself. Bug: b:38452042 Change-Id: Ibfa75454ef44b8329d643dcfcc94a1b7b65018e4 Reviewed-on: https://chromium-review.googlesource.com/899606 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#534215}
-
Min Qin authored
This CL is the ongoing effort to make download a standalone component BUG=803135 Change-Id: I0b4c740d3785712b7106026cb624c29db0e6fcfb Reviewed-on: https://chromium-review.googlesource.com/897967Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534214}
-
Bin Zhao authored
We are moving DIAL sink query logic from extension side to browser side. Added a feature to enable/disable in-browser sink query. - Added EnableDialSinkQuery feature - Added enable_dial_sink_query field to MediaRouteProviderConfig in media_router.mojom Bug: 779892 Change-Id: Ib05013b1124f22a45a3647765f026f20614e8d4f Reviewed-on: https://chromium-review.googlesource.com/896265Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#534213}
-
Christian Fremerey authored
A previous CL [1] added feature switches for determining if the video capture service is supposed to run in a dedicated process or in the Browser process. This CL adds the code for registering the video capture service as an embedded service for the Browser process. It uses a task runner from the base Task framework via base::CreateSingleThreadTaskRunnerWithTraits() in order to have the service methods execute on a thread that allows blocking IO. [1] https://chromium-review.googlesource.com/c/chromium/src/+/759412 "--enable-features=RunVideoCaptureServiceInBrowserProcess,MojoVideoCapture", navigate to https://webrtc.github.io/samples/src/content/getusermedia/gum/ and verify that video capture works. Shut down Chrome and verify there is no crash or DCHECK triggered. Tested and confirmed working on Android, Linux, and Windows. Test: Run chrome with flag Bug: 792621 Change-Id: I404e9f2bca14c238b5969e680a38dc004a815486 Reviewed-on: https://chromium-review.googlesource.com/894443 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#534212}
-
Saman Sami authored
This reverts commit a438b798. Reason for revert: Causes crbug.com/808282 Original change's description: > content: Send ResizeParams in ViewMsg_WasShown > > Don't send any WasResized messages when the RenderWidgetHostImpl is > hidden, and once it's visible, send the ResizeParams along with the > WasShown message. When a WasShown message that has ResizeParams > arrives in the renderer, the resize will be performed before setting > the visibility to true. This CL makes it easier to send a new > LocalSurfaceId to an evicted background tab when it becomes visible. > (Allocating a new ID will happen in a subsequent CL) > > Bug: 777881 > Change-Id: Ibbc1a3604fb93806059d6beb3e51872f5aeaad4c > Reviewed-on: https://chromium-review.googlesource.com/894262 > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533357} TBR=fsamuel@chromium.org,tsepez@chromium.org,piman@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 777881,808282 Change-Id: I71691467ef1868042d43bc4280bb55a0d71e859d Reviewed-on: https://chromium-review.googlesource.com/899924Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#534211}
-
Xianzhu Wang authored
Previously subframe printing was not testable in layout tests. We had to create ManualTests to test subframe printing, but it's hard to maintain. Add testRunner.setPrintingForFrame(frame_name) to allow testing subframe printing. This won't automate testing of anchor printing though, because location of anchor is invisible. That still requires viewing the generated pdf file. R=dmazzoni,bokan TBR=dmazzoni@chromium.org (already lgtm'ed) Test: printing/print-subframe.html Bug: 808219 Change-Id: I1f927c5ea500a6da8fe558139433b7d548bc2e2e Reviewed-on: https://chromium-review.googlesource.com/898244 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534210}
-
Zhiling Huang authored
Bug: 726431 Change-Id: Ia8b6e3ccbf2f66b1038c6a15be03899367859965 Reviewed-on: https://chromium-review.googlesource.com/896570Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#534209}
-
Ryan Hamilton authored
This reverts commit 1e31ca06. Reason for revert: v41 is going to be deprecated Original change's description: > Enable QUIC v41 by default > > Change-Id: I12c2ce5551bcd2630af75ac9e9f6e15758c3a7e6 > Reviewed-on: https://chromium-review.googlesource.com/889639 > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Reviewed-by: Buck Krasic <ckrasic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532785} TBR=rch@chromium.org,ckrasic@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I932329a83dc70e7da7ba8750a87e4e7e71cd544a Reviewed-on: https://chromium-review.googlesource.com/900102Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Jana Iyengar <jri@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#534208}
-
https://chromium.googlesource.com/catapult.git/+log/ec32a8f0bee7..f601e519d114 $ git log ec32a8f0b..f601e519d --date=short --no-merges --format='%ad %ae %s' 2018-02-02 simonhatch Dashboard - Associate bisects with the alerts they were started from. 2018-02-02 eakuefner [Metrics] Switch RHB in loading_metric to RNM Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I9d4ece8cfa180bc9910f3a6ee652cb95f137f2e2 Reviewed-on: https://chromium-review.googlesource.com/900139Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534207}
-
Ryan Tseng authored
Bug: 731552 Change-Id: I4fc33ca2343d180d7920992ab4a7b5d3cadc7657 Reviewed-on: https://chromium-review.googlesource.com/899872Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#534206}
-
- 02 Feb, 2018 28 commits
-
-
Daniel Cheng authored
Prior to C++17, it's not defined if the LHS or RHS of an assignment is evaluated first: the only that's defined is the evaluation of the LHS and RHS happen before the assignment. Bug: 805881 Change-Id: Ieece0dd53f174d82a8e32ff41418e894f0c27ddd Reviewed-on: https://chromium-review.googlesource.com/899948Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534205}
-
Daniel Cheng authored
Bug: 805881 Change-Id: I29434a3e34a816412696188674ae9ecf47e6fed6 Reviewed-on: https://chromium-review.googlesource.com/899945Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534204}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ff23b06. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11528 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Ibe46494f52534ad2da439936157d29b07e83c547 Reviewed-on: https://chromium-review.googlesource.com/899468 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#534203}
-
Miguel Casas authored
Minor cleanups around GVAF & co: - const/constexpr - early return - use = default iso {} [1] Otherwise no new code, unit tests and such should cover it all. [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/qgU4mh_MpGA Bug: 803975 Change-Id: I7a14a28a3b7ee3703885e40ec0829cc6b4453592 Reviewed-on: https://chromium-review.googlesource.com/897707 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#534202}
-
Mike Dougherty authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia4cdf1f83336fc4f1c5b8dff8891e323ad4c0a14 Reviewed-on: https://chromium-review.googlesource.com/883042 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534201}
-
wutao authored
This cl implementation allows the client to provide custom views to styled label and set the horizontal alignment. Features: 1. The client can provide any view. 2. The client can set the horizontal alignment. 3. All views in a line are center aligned. 4. The custom view is one unit, cannot be wrapped into different line. 5. If width is not wide for the custom view, the custom view will be cutoff. bug. Bug: 793414 Test: Tested with different views and layout. Examples are posted in the Change-Id: Icf7d70da812c9e40362e20cbc30dc118cdf6d77b Reviewed-on: https://chromium-review.googlesource.com/888543 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534200}
-
Christian Fremerey authored
In Issue 807887, ClusterFuzz provided a very useful stack trace demonstrating a use after free, which is likely the same as Issue 777608. Root cause was a Mojo connection error getting invoked on a base::Unretained() pointer to a deleted object. I added a unit test case the reproduced the issue before the fix. There are two possible fixes. 1. In ~DeviceMediaToMojoAdapter() call Stop() in order to reset the connection error handler before it gets invoked. 2. Use base::WeakPtr. I am opting for option 2. because seeing/proving that solution 1. is effective is unreasonably complex and also requires more code. Test: services_unittests --gtest_filter="DeviceMediaToMojoAdapterTest.*" Bug: 807887, 777608 Change-Id: If42094796fbb095caccad7af9f72263b1d5f3ed6 Reviewed-on: https://chromium-review.googlesource.com/898256 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#534199}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the same constant twice with the same name will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch inlines the constants in chrome_visibility_observer.cc and desktop_session_duration_tracker.cc. Bug: 746957 Change-Id: I1b7d4b2f4a83a8a75c248f07199af6f4e72e87f5 Reviewed-on: https://chromium-review.googlesource.com/897533 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#534198}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and if that causes there to be overloaded functions, the address operator won't know what function's address the code refers to. This happens in base::Bind, and results in compilation failures. In preparation for jumbo in chrome/browser, this patch renames the three OnAcquireFileAccessPermissionDone to OnDownloadAcquireFileAccessPermissionDone OnThrottleAcquireFileAccessPermissionDone OnOfflinePageAcquireFileAccessPermissionDone Bug: 746957 Change-Id: I6bd1fa44e9cc1ab44d9bdb653dd8117280ff9325 Reviewed-on: https://chromium-review.googlesource.com/897943Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#534197}
-
Sam Clegg authored
This was broken by https://chromium-review.googlesource.com/728950 Change-Id: I913650b267bb42ee9d4bf0d64b03b22eadb9f04a Reviewed-on: https://chromium-review.googlesource.com/900295Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#534196}
-
Allen Bauer authored
Bug: 654142 Change-Id: I0bd9cd4fcf4337b20809a99329e429f62f14994f Reviewed-on: https://chromium-review.googlesource.com/896165 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#534195}
-
Katie D authored
Previously, we tracked inlineTextBox nodes using their index in the staticText parent. However, if the container holding the text was resized, the staticText parent indices change as the flow of boxes within them changes. This change removes all dependency on the index of the inlineTextBox within the staticText node, and instead relies purely on character indices to determine nodes to highlight. Bug: 800912 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0c0ecb2f78912b376040cc029f77a32fec6f5c85 Reviewed-on: https://chromium-review.googlesource.com/898206 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#534194}
-
bsheedy authored
Adds the option of not specifying initial good/bad values for the VR bisect script. If not specified, the script will run additional tests at the good/bad revisions to determine the initial values. Change-Id: Ic15cad0968b2a6154e342f3fca799bf7784e02e6 Reviewed-on: https://chromium-review.googlesource.com/899607Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#534193}
-
David Tseng authored
Bug: 796861 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I54973fff39522225398d490877c2d03690dfd71f Reviewed-on: https://chromium-review.googlesource.com/889040 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#534192}
-
Khushal authored
Transport the target color space for OOP raster in BeginRasterCHROMIUM to ensure we set up a color transform canvas for raster if necessary. R=enne@chromium.org, piman@chromium.org Bug: 757610 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8cf03e9f129d2c004f4e228dffa6621d964bf6f0 Reviewed-on: https://chromium-review.googlesource.com/894860 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534191}
-
Jérôme Lebel authored
Tracking: src/components/ButtonBar/src/ColorThemer/MDCButtonBarColorThemer.h src/components/ButtonBar/src/ColorThemer/MDCButtonBarColorThemer.m src/components/ButtonBar/src/MDCButtonBarButton.h src/components/ButtonBar/src/private/MDCButtonBarButton+Private.h src/components/ButtonBar/src/private/MDCButtonBarButton.m Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4e77cf843916da31fb574993729a37137b05bb23 Reviewed-on: https://chromium-review.googlesource.com/897863Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#534190}
-
Daniel Cheng authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib40ea583e23fb46aec4f56fc3328fee7107c89fe Reviewed-on: https://chromium-review.googlesource.com/898243Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#534189}
-
https://pdfium.googlesource.com/pdfium.git/+log/f7c84e910899..bbeb10daef8b $ git log f7c84e910..bbeb10dae --date=short --no-merges --format='%ad %ae %s' 2018-02-02 tsepez Small tidy of fxjs 2018-02-02 tsepez Remove V8 context from CJS_V8 2018-02-02 tsepez Make global object function names clearer. 2018-02-02 hnakashima Add asm.js to third_party/build/build_config.h. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic357d112579ce8a96f85647099e9d25a3c0d4a85 Reviewed-on: https://chromium-review.googlesource.com/900209 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534188}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69113b91..0f936675 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I78d7df35df64b7cab881f4002f65131f04f9e603 Reviewed-on: https://chromium-review.googlesource.com/899990Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534187}
-
Ria Jiang authored
Currently, HitTestAggregator is owned by RootCompositorFrameSinkImpl, which would only work for the viz display compositor (OOP-D) case. In non-viz, we use DirectLayerTreeFrameSink, and it calls to create a CompositorFrameSinkSupport with |is_root| equal to true through HostFrameSinkManager. 1. This changes CompositorFrameSinkSupport to own the HitTestAggregator when it is a root CFSS, and pass its FrameSinkId to the HTA. 2. Change FrameSinkManagerImpl to be a HitTestAggregatorDelegate. 3. Update DirectLayerTreeFrameSink to activate HitTestAggregator:: Aggregate(). Bug: 805581 Test: viz_unittests Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0d3d93405dc99e7a5a6edb8f0587c5d0d24ffad7 Reviewed-on: https://chromium-review.googlesource.com/884324 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#534186}
-
Weidong Guo authored
Changes: Using system display api setDisplayProperties to turn on mirror mode is deprecated. Replace the usage in display.js with the new api setMirrorMode. BUG=807825 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I86458ebf7aaa446d6ff23cde05c7eae819d11558 Reviewed-on: https://chromium-review.googlesource.com/896796 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534185}
-
Christopher Grant authored
- Plumb more Autocomplete request information out of the UI - Include input and autocompletion text in suggestions - Augment Text/TextInput to display a selection, if specified - Add selection colors to the colorscheme - Make the testapp's fake keyboard act much more like a keyboard BUG=799201 R=vollick, ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6371875a93149496aee4ac80f9fad3b78ebed245 Reviewed-on: https://chromium-review.googlesource.com/899905 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#534184}
-
Nico Weber authored
No behavior change. Bug: 177475 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7d5d28d208cca14819572e9a982ea155d6c725df Reviewed-on: https://chromium-review.googlesource.com/899113 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#534183}
-
Daniel Bratell authored
In jumbo builds many cc files compile in the same translation unit and then they share the same anonymous namespace. Having the same constants and helper functions in several files will then result in compilation failures. In preparation for jumbo in chrome/browser, this patch deduplicates the GetWebContents() helper function and the constants kOMADrmMessageMimeType, kOMADrmContentMimeType, kOMADrmRightsMimeType1, kOMADrmRightsMimeType2. Bug: 746957 Change-Id: Ie268f77c7a099a8de01ae08c70870306f38fc05a Reviewed-on: https://chromium-review.googlesource.com/897612Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#534182}
-
Kyle Horimoto authored
This UI is shown on the settings page when a phone tells the Chromebook that it does not have GmsCore notifications enabled. Note: This CL's contents were already landed in https://chromium-review.googlesource.com/c/chromium/src/+/894729. However, part of that CL needed to be merged to the M-65 branch, so I'm re-landing two separate CLs and only merging the other one to the M-65 branch. Bug: 793936, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I647fd141415bf4d255405eec4989aebf19aef9e8 Reviewed-on: https://chromium-review.googlesource.com/898547Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#534181}
-
Theresa authored
BUG=808524 TBR=mthiesse@chromium.org Change-Id: If2c4030ca63dc472a1894993f9633e029d021f7f Reviewed-on: https://chromium-review.googlesource.com/900208Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#534180}
-
Marijn Kruisselbrink authored
This test makes assumptions about ordering of different task sources that are not guaranteed by either the spec or the implementation. Bug: 784909 Change-Id: I6c5d25fd5c684594ca272a84a664692c90caff6e Reviewed-on: https://chromium-review.googlesource.com/896034 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#534179}
-
Tim Dresser authored
Previously we excluded swiping input. We now include swipes (map panning, carousel rotation), but still exclude scroll. Also records a UKM. Bug: 803935 Change-Id: I8f9d5a77ad61221eb9b614e8d4e11e2b757af9e2 Reviewed-on: https://chromium-review.googlesource.com/894826 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534178}
-