GitLab

Fixed the debug test failure by removing contact manager all together
from the onboarding page test since it was not actually needed in the
fist place.

PS1 has the original
PS2 has the fix


> [Nearby] Add onboarding to receive dialog
>
> This converts the onboarding and visibility pages to use the
> nearby-template-page and hosts them in receive dialog. If the user
> attempts to enter high visibility mode and nearby is not enabled, we
> force onboarding to be run first.
>
> Screenshot of onboarding running from settings:
> http://screen/xnm86ZduzQ6bGEr.png
>
> Bug: b:154866951
> Change-Id: I195fa803762635f0a19d58d7d4db919c825b8ffc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420770
> Commit-Queue: James Vecore <vecore@google.com>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809599}

Change-Id: I1825dbcfd1006ba32acaf16379945afbd306db27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426864
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#810063}

https://webrtc.googlesource.com/src.git/+log/3a5612a8de0b..5e85c8bc3139

2020-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dc725cd5..adce4958 (809732:809911)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I70a8ff473c35f7f7c05d66a873972736680ac59b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427564Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810062}

This is only used in one place for qemu. Use the implementation
directly for this one usage.

Bug: 1104411
Change-Id: Ifcc86426a87abbcbe8e539c2f028a7bdcc24dd38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427036Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810061}

LinkLoader::LoadLink() aborts inflight prerendering by calling Abort()
at the beginning of the function, so it doesn't have to run another
abort sequence later.

This is tested by the existing PrerenderTest.MutateTarget test case.

Bug: n/a
Change-Id: Ibc70b94c0acaae52eb4f7d27f1a65210c15f9c10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426664Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810060}

This is because Windows has a command line size limit and too many
testing configs can result in the limit being hit.

See comment 1 on the bug for details on why these studies are candidates
for removal.

Bug: 1126640

Change-Id: Ib3c5b2fdc5917bdf6a4119ff35657c1c29082bd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402108Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#810059}

Bug: 1124062
Change-Id: I5422ddab8a7e9fafa9042bd65e59b1430dc4211a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422106Reviewed-by: Keith Lee <keithlee@chromium.org>
Commit-Queue: David Vallet <dvallet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810058}

Bug: 953308
Change-Id: I2315038143d708324783eaa788cb08d277b0d4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397035
Commit-Queue: Omid Tourzan <oto@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810057}

This reverts commit fe6e27d6.

Reason for revert: newly-added OpenOrClosedShadowRootInBackgroundPage is very flaky, see https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 or https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

Original change's description:
> Allow access to closed shadow root from Extension
> 
> This CL introduces chrome.dom.openOrClosedShadowRoot that is a
> read-only property to allow access to the closed shadow root in
> the Extension's content script.
> 
> Bug: 778816
> Change-Id: I933bc5d3996a74f46ee75181c535150901a5a46a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319951
> Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Reviewed-by: Kent Tamura <tkent@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809277}

TBR=peria@chromium.org,yukishiino@chromium.org,rdevlin.cronin@chromium.org,tkent@chromium.org,karandeepb@chromium.org,mkwst@chromium.org,masonfreed@chromium.org,myid.shin@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 778816
Change-Id: If2a26a4aea10a0e03c9a8bca25ca34965bca9110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426265Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810056}

Does the following minor refactoring, prompted by the fact that ANGLE
is in the process of adopting Gold and can make use of some existing
code if it's moved into the common implementation.

1. Moves //content/test/gpu/gpu_tests/skia_gold/gpu_skia_gold_session.py
   and its associated tests to
   //build/skia_gold_common/output_managerless_skia_gold_session.py.
2. Makes 'chrome' the default instance in SkiaGoldSessionManager since
   the GPU tests have moved to using that instance and thus all tests
   use the 'chrome' instance.
3. Makes _GetSessionClass() no longer protected and uses its return
   value in test runners instead of manually importing the class.

Bug: angleproject:4090
Change-Id: I1c2743d2dbe10e168f00e5f169f25fe9568c7c94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427354
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810055}

This is a reland of 5aa92900

Original change's description:
> Rough in support for multiple selection in holding space.
>
> Holding space needs to support selection of multiple holding space items
> to perform bulk context menu and drag/drop operations on them at a time.
>
> This CL refactors HoldingSpaceItemContextMenu into a shared
> HoldingSpaceItemViewDelegate to facilitate these requirements.
>
> Note that this CL does not change any existing behavior, just lays the
> groundwork for supporting multiple selection.
>
> Bug: 1129981
> Change-Id: If4da6c19ba01bd7104a1b1487350c362d7be1dd4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419136
> Commit-Queue: David Black <dmblack@google.com>
> Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809625}

Bug: 1129981
Change-Id: I122a335d92a3df5e51933fc2eadf35080d0e87c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425894
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810054}

caBLEv2 shard IDs have turned into 24-bit routing IDs.

Also, fix a race caused by the fact that the network service sends
notice of a data frame before writing its contents to the Mojo data
pipe. Thus the data might not be ready to read as the code previously
assumed.

BUG=1002262

Change-Id: I2af2ce1ffa909f09559fc061881ce8bc72fbea55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416562
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#810053}

Previously, the view-source table used the UA stylesheet value for
word-break, which was break-word. This, combined with the prior
quirks-mode view source document, was a very slow Layout path.
With this change, the view-source table is set to break-all, which
should be faster. Long lines are now broken at the edge of the
page, rather than on word boundaries. So the display is different
than before. However, the content is the same, so this should
be ok.

Bug: 920571
Change-Id: Ic045c4dc5f6f467ef1bfb3a6317d6c9020968370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424038
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810052}

Change-Id: I6812f253ad2fde354219816298ebfd0c2f511f5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427080
Auto-Submit: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810051}

This change is behind the kReadLater feature flag and uses styles shared
with the Tab Search feature. The delete button removes entries from the
reading list model and the mark as read/unread button updates the
status. Both buttons will trigger an update to the menu items so changes
are seen as they are triggered.

Bug: 1109316
Change-Id: Iaa093427c4f9be78901833eca3fd1dabec8ec1b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422246
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810050}

This reverts commit 0ca8e290.

Reason for revert: Seems to turn linux-chromeos-rel red, e.g.
https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/680586?
https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel?limit=200
has 151 red builds due to this at the moment.

Original change's description:
> Check for static initializers on linux-chromeos-rel.
> 
> Bug: 537099
> Change-Id: I7d006d2a563de005b22945f0eabb723f86657862
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416563
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809945}

TBR=thakis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org

Change-Id: Ic23eb82c485521ff52bb3c5574d048b3b66e3bd5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 537099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427572Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810049}

- Split createDirectoryContents_ into 2 functions
  isSearchDirectory() and createScannerFactory()
- Removed all DirectoryContents.createFor*() functions.

Bug: 1126742
Test: trybot
Change-Id: I11c697952bdc275bc398f1e329feb359cfc95559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421848
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Auto-Submit: Satoshi Niwa <niwa@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810048}

It's enabled by default at crrev.com/c/2415709.

Bug: 935267
Change-Id: Icc35a4f8934a209b03b5f405f35cb559a855d845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423701Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810047}

Change-Id: I4b44ac7e7cb067bfd6679322ed3af245d3d4dbc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427106
Auto-Submit: Elaine Chien <elainec@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810046}

Our current VP9 accelerator uses a Chromium-only, non mainline ABI to
communicate with the kernel. As we are about to introduce the
upstream-based ABI, and the corresponding VP9 accelerator, rename our
older one to "legacy" following the model already followed for H.264 and
VP8.

BUG=b:161415741
TEST=Chromium builds for arm-generic.

Change-Id: I582814b5efc2f6d10c9fd7a7305593dc211a61d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423653Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810045}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/19ce8322..4ee4324d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Icc8066c1fd0577bf8fa8a666471779329b01b4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426545Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810044}

[MBI] Make ThreadTaskRunnerHandle::Get() return currently active AgentGroupSchedulerImpl's default task runer.

[related design doc]
https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A

Bug: 1105403
Change-Id: I4a215c8cd93f10e894071af6836027289d8225a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413728Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Tal Pressman <talp@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810043}

This CL fills VideoEncoderInfo::fps_allocation in
VaapiVideoEncodeAccelerator properly in temporal SVC.

Bug: 1030199
Test: vaapi_video_encode_accelerator_unittest
Change-Id: Iba020a26841d6ed35ad4b5bbf0d4cfc1442b282f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425606
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810042}

Using wpt-import in Chromium 6a4f6db0.
With Chromium commits locally applied on WPT:
8f02a380 "Use allow attribute for delegation in web serial WPT"
8d82b92f "Origin isolation: add crash test for noopener popup windows"
6a4f6db0 "MSE-in-Workers: Cross-thread registry with stubbed attachment"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: If2e72a490c721d20991eaa5cc3d362dc57f676c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426367Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810041}

While we are in "media" namespace, no need to use "media::"

Change-Id: Icf214d62b2d2c7203ce8399cce6ee68c0b771503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427020
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Auto-Submit: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810040}

Since owned_fd (and future 'owned' objects) have their own notion of
being null/invalid and are mutually exclusive of one another, there
is no need to keep a separate GpuFenceHandle "type" member variable.

To facilitate empty objects on some platforms, adjust the declaration
of needs_comma to avoid 'variable not used' warnings from the compiler.

Bug: 1131616
Change-Id: I2da1b719ac2770edcbf1f5e9c26b909004925170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423164Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#810039}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ie6290c0851c773a43ca2a466801bdf119e127780
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427663Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#810038}

https://crrev.com/809702 added a global constant to
ambient_background_image_view.cc, but the constant adds a static
initializer. Avoid this by making the constant local to the method it is
used in. Then it is initialized on first use instead.

Bug: 537099
Change-Id: I1724e5a563e1a30a6aa6c8b306626ec86f6a570a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427549Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810037}

This change is behind the kReadLater feature flag. Add new tab context
menu option for adding one or more tabs to read later.

Bug: 1131030
Change-Id: Id902a40ccb3c3bc86a28fc8b9aa5ab7d92878896
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426343
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810036}

Log SafeBrowsing.Settings.* user action sequence on both desktop and
Android. Break "Showed" into different entry points so we can analyze
users's behavior based on different entry points.

Bug: 1124491
Change-Id: I6a30765ae8754b88eb8cb4a6f9fcd89be0d7d78e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416564
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810035}

Bug: 1123750
Test: Manually
Change-Id: Ic690c74ebab88563d98ae753213ab25e3d763435
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425687
Auto-Submit: Inker Kuo <inker@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Inker Kuo <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810034}

Load a file containing UTF-8 and other characters in the preview panel
and wait for the <webview> to load and display the file content [1].

Read the displayed text content and verify. Test is a PASS if the text
content of the <webview> contains 'їсти मुझे |∊☀✌✂♁ 🙂\n' and the right
file size "191 bytes" is shown in the quick view metadata box.

[1] Note: the test file must have a file extension that is known to be
text (an extension that files app deems to be text) to enable UTF-8 in
the preview panel <webview> renderer.

Test: browser_tests --gtest_filter="*openQuickViewUtf8Text"
Bug: 1064855
Change-Id: I7c07b7f98922a1bb93ea2b46c3bc93dd4ee9085d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426084
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810033}

Bug: None
Change-Id: I5590d0fa8e19f8d8c40bc1acc6cf458e6850d8b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426467Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com>
Cr-Commit-Position: refs/heads/master@{#810032}

This CL fixes this script to use a correct exception class
(RuntimeError) instead of non-existing RuntimeException one.

Bug: none
Change-Id: I221f66ac7eac4af46f53f7137840fbf62445e4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426567
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#810031}

This reverts commit e69195e1.

Reason for revert:
This is a speculative revert. updater_tests has been failing on Win7
Tests (dbg) since the CL range containing this change:
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85110

Original change's description:
> Initialize the WRL::Module only once.
> 
> The issue with the crashing code is that on the RPC client side
> of the updater, both update and control services must be instantiated.
> They both called WRL::Module::Create, which caused WRL code to assert.
> 
> The server side of RPC also initializes the module, in a slightly
> different way. Therefore, module initialization in the App base
> class is not practical. It has to be done in a way specific to
> the client, or the server, or the mode App is instantiated as.
> 
> Using a leaky singleton is not great. However, there is singleton
> already in the WRL::Module, so a leaking singleton in the updater
> just shows that fact.
> 
> Bug: 1128748
> Change-Id: I646c5ef779c4affe7f2fe8f751d1dea1f16f8608
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414847
> Reviewed-by: S. Ganesh <ganesh@chromium.org>
> Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
> Commit-Queue: Sorin Jianu <sorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807682}

TBR=ganesh@chromium.org,sorin@chromium.org,waffles@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1128748
Change-Id: I63884d9bc165130c7eaab196520eb4583c87970d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426149Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810030}

Use Clang option -ftrivial-auto-var-init=pattern in production on more
platforms. Previously it was only enabled on Linux in production; now
it's on for all Desktop platforms.

This CL may reduce time efficiency and increase object code size. We
hope the effect is within an acceptable range, however. Notably, V8
opts out.

Bug: 977230
Change-Id: I785638c3a6d0d08c999031769ed9f858086515b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410588
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#810029}

This should be a no-op because the functionality
for this switch was removed back in May, in
https://chromium-review.googlesource.com/c/chromium/src/+/2191161.

Change-Id: I630a03b4a82857c1e9785e4472c5cb4108dd57e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422256Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#810028}

This reverts commit 23b8809f.

Reason for revert: Showed regression even on non debug builds crbug.com/1131453

Original change's description:
> Insert CheckIsNotDestroyed() in all LayoutObject Methods
> 
> CheckIsNotDestroyed() will be used to ensure LayoutObject is not used after the Destroy() call once LayoutObject is moved to GarbageCollected.
> CheckIsNotDestroyed() should be the first statement for all methods on LayoutObject and its subclasses.
> 
> Bug: 1030176
> Change-Id: I4862ad8d068311b8cccf3881b21f0d62f787c333
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409837
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809687}

TBR=haraken@chromium.org,keishi@chromium.org,ikilpatrick@chromium.org

Change-Id: I99213419df0c39d9d6c39e4b8117354126c4e2e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1030176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427605Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810027}

This reverts commit b179b125.

Reason for revert: for debugging crbug.com/1121730

Original change's description:
> Enable transformed rasterization for most layers
> 
> Background: transformed rasterization is used to render sharp text in a
> composited layer with fractional transform. It snaps the composited
> transform of the layer to whole pixels, then applies the fraction
> during rasterization.
> 
> Previously we disallowed transformed rasterization in blink for directly
> composited layers (excluding backface-visibility:hidden and trivial 3d
> transforms such as translateZ(0)), especially for will-change:transform
> because change of fractional transform would cause re-rasterization
> which would defeat the purpose of will-change:transform.
> 
> Now for a layer that was not eligible for transformed rasterization,
> calculate the initial raster translation which achieves sharp text
> rendering with the initial transform. When the transform of the layer
> changes, keep its original raster translation to avoid invalidation
> of tilings, to ensure animation performance. The rendered result will
> be blurry during animation but the initial rendering result is sharp.
> 
> Remove blink-side transformed rasterization conditions and let cc
> decide it based on screen and draw transforms of the layers.
> 
> Bug: 1111195
> Change-Id: If0455be2f29e69cd7152c951626e6e8cc143b5bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351164
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798268}

TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1111195, 1121630
Change-Id: Ibab42e963cab263cab062377ffa2aad38291c5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427125Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810026}

This CL splits ExternalWebAppManager's config loading flow into discrete
steps and removes the various testing entry points that omit or
duplicate logic used by the real thing.

Tests can now inject data (file_utils, config_dir, configs) into the
config loading pipeline instead of having separate mini pipelines just
for them.

This change is in preparation for adding a new "FilterExtensionIds" step
to the config loading flow. Without this refactor there would be
duplication of logic between real and test code code paths that would be
prone to bitrot and missing real coverage.

Bug: 1128801
Change-Id: Ie5e87b26ab47782fab6589a4127df3ea5e876fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423823Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810025}

Seems fonts are only loaded when it is needed. Adding empty text view to
load Google Sans to "preload" for following pages.

More context in the original bug.

Bug: 1119990
Change-Id: I026b80cf15b939c30f97a1174aad4d8259ef66b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427524Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810024}