- 01 Nov, 2017 12 commits
-
-
Becky Zhou authored
Before this fix, bottom sheet contents are not updated when creating new tab in a different mode with a new tab already opened. It also causes duplicate calls to destroy pref observers. OffTheRecordProfile is not necessary for PrefChangeRegistrar, and to fix bottom sheet content separately, we now remove BottomSheetContent when switching mode. Bug: 779474 Change-Id: I263d9041184701c737cbada78e725a96ca9ade6b Reviewed-on: https://chromium-review.googlesource.com/745221Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#513027}
-
chrome://interventions-internalsThanh Le authored
The tab navigation bar is now stretch across the page The table also fit to the device width, and the "URL" column in the "Logs" tab is now scrollable to make it nicer for longer hostnames on mobile Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3MlA2bnNYNUhfdVU Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3RXQ3clFLRFBtaVU Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3THd0Q3JVcm44c00 Bug: 764419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieba316275f2acfa60dea480be701995c68fb2f7a Reviewed-on: https://chromium-review.googlesource.com/747865Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#513026}
-
Tommy Steimel authored
This CL adds a WasEverAudible method to WebContents which returns true if audio has played since the last navigation. This is then used by the Page Info bubble to decide whether or not to show the sound content setting. Bug: 779878 Change-Id: I66453161dfe17df6868e66f11e7fce0b3c3a87b8 Reviewed-on: https://chromium-review.googlesource.com/747069Reviewed-by:
Lucas Garron <lgarron@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513025}
-
John Chen authored
Use the MediaLog ID associated with each WebMediaPlayerImpl object as a unique identifier, to allow the media metric to handle multiple media playbacks in a single trace. Bug: 775264 Change-Id: I412bbf5bf8ccab223c027cb5c936fac3de47251e Reviewed-on: https://chromium-review.googlesource.com/741143Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#513024}
-
Philip Rogers authored
The app shell (content shell) sets the default LOG setting to have tick counts. This means a LOG(INFO) looks like: [42745:775:1031/103842.350408:395648516798307:INFO:LocalFrameView.cpp(3456)] test This patch updates the default setting to not have the tick count so LOG is less verbose. I think this will promote more LOG usage and happier developers. A LOG(INFO) now looks like: [42846:775:1031/104021.499705:INFO:LocalFrameView.cpp(3456)] test Change-Id: I37b27730114519e8f08f59bf076eb3b090bcb12e Reviewed-on: https://chromium-review.googlesource.com/747363Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#513023}
-
Sonny Sasaka authored
This is a continuation from crosreview.com/737056. When Stop() discovery fails because Discovering property changes to false, that means all the discovery sessions have been stopped bluez, so Stop() is expected to fail and there is no need to log this as error. BUG=777953 TEST=Reproduce the case and check that device event log is categorized as DEBUG instead of ERROR. Change-Id: I41f6e3e83e9f6377bf28f4bb2210be34bdf1c732 Reviewed-on: https://chromium-review.googlesource.com/747603Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#513022}
-
rbpotter authored
Test that PrintPreviewHandler forwards renderer messages from the PrintPreviewUI to the Print Preview javascript correctly, and that it tries to kill the renderer if it receives unexpected messages. Bug: None Change-Id: Iec26fcd115270a167de6370aba2b90d5c68cf380 Reviewed-on: https://chromium-review.googlesource.com/742649 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#513021}
-
Mark Pearson authored
In many memory histograms, the last sentence is "Emitted once per UMA ping." But actually some subset of those are emitted multiple times, one for each process. In most of those cases, reading the rest of the histogram description will make that clear. In a few, it's not crystal clear; one of them confused me for example. I was going to simply fix the more confusing ones, then simply decided that it's best to be consistent. This changelist adds "per process" to the last sentence as appropriate on all memory histograms. Bug: 765470 Change-Id: Ia8187581381a13913f9eada5a1b0d82b8d1b3fbe Reviewed-on: https://chromium-review.googlesource.com/747629Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Mark Pearson (busy Oct 31) <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#513020}
-
Chris Bentzel authored
The comment indicated that blob, data, and other URLs could be included. However, the implementation in MetricsWebContentsOvbserver::OnRequestComplete filters out requests that do not have HTTP or HTTPS schemes. Change-Id: I8873a2bb57eb8a548ae2a8c8b4a4f32596fd5bed Reviewed-on: https://chromium-review.googlesource.com/745827Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#513019}
-
James Cook authored
Many ash_unittests fail under --mus and --mash because the TestScreenshotDelegate is not created. This happens because of some legacy AcceleratorControllerDelegate code that dates back ~18 months to when we couldn't use aura::Window* in mash code. That isn't a problem anymore. * Move ownership of ScreenshotDelegate to ScreenshotController * Create the delegate in ShellDelegate, similar to how we do other ash delegates * Move screenshot accelerator code back into AcceleratorController * Re-enable tests under mus and mash via filter files Screenshots don't work yet under --mus and --mash due to lack of graphics readback support and lack of a mojo interface, but we now exercise more of the UI and accelerator handling code. Bug: 557397, 632111 Test: ash_unittests (--mus, --mash), manually take screenshots Change-Id: I7dd1946ddc30bddb407c9dbf6095caf8efb4fd1f Reviewed-on: https://chromium-review.googlesource.com/744295Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#513018}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/90dabec62f9b..4dbdc677affd $ git log 90dabec62..4dbdc677a --date=short --no-merges --format='%ad %ae %s' 2017-10-31 csmartdalton Fix undefined behavior in normalize_t_s 2017-10-31 csmartdalton Allow GrAppliedClip to have >1 clip coverage FP 2017-10-25 mtklein Some lowp refactoring 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ b8ee9dd35..c1f14fbea (1 commit) 2017-10-31 brianosman Use color filter to undo GBR (actually BRG) 2017-10-31 mtklein Revert "Fix int overflow issues with clip and path bounds." 2017-10-31 caryclark cataloger 2017-10-31 bsalomon Devirtualized token management in GrDeferredUploadTarget. 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 1b605ee34..b8ee9dd35 (1 commit) 2017-10-31 kjlubick Add Pixel 2 XL to waterfall 2017-10-25 mtklein clean up SK_LEGACY_LOWP_STAGES 2017-10-31 bsalomon Make deferred upload handling and draw recording be virtual interfaces implemented by GrOpFlushState. 2017-10-31 scroggo Simplify SkColorSpace::MakeICC 2017-10-31 bungeman Remove SK_IGNORE_SUBPIXEL_HINTING_FIX. 2017-10-31 fmalita Don't store legacy colors in gradient shaders 2017-10-31 mtklein Revert "gbr- has been brg- this whole time..." 2017-10-31 robertphillips Add a GM to test out odd matrix draws (take 2) 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ 2c5c41f9b..1b605ee34 (1 commit) 2017-10-31 mtklein gbr- has been brg- this whole time... 2017-10-31 jvanverth Fix int overflow issues with clip and path bounds. 2017-10-31 robertphillips Revert "Add a GM to test out odd matrix draws" 2017-10-31 angle-deps-roller Roll skia/third_party/externals/angle2/ d922775b6..2c5c41f9b (1 commit) 2017-10-31 mtklein update valgrind suppressions for revised keepalive thread Created with: roll-dep src/third_party/skia BUG=743617,779346 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I6c60d600f1b6ac2555e482e37465f2220492326a Reviewed-on: https://chromium-review.googlesource.com/747886Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513017}
-
Ted Choc authored
This removes the similar Activity launching logic in SearchActivityTest and replaces it with the same functionality in ActivityUtils. In addition, it adds additional logs in ActivityUtils on failure to attempt to help figure out what the state of the system is. BUG=778239 Change-Id: Ic2aac185958044a8ba733213ac8daf5a4c8aa618 Reviewed-on: https://chromium-review.googlesource.com/738843 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#513016}
-
- 31 Oct, 2017 28 commits
-
-
Matt Falkenhagen authored
* Add //static annotation for some static functions. * "WebEmbeddedWorkerInstance" doesn't exist, replace with WebEmbeddedWorker or delete. * Clarify ServiceWorkerNetworkProvider documentation. Change-Id: Id540473565059c1c5aadeffd3bb0ee136fd9e5b1 Reviewed-on: https://chromium-review.googlesource.com/746508Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#513015}
-
khmel authored
This modifies ChromeOS settings for metrics instead of lower level metrics preferences. ChromeOS settings change has mapping to lower level metrics but not the opposite way. That is why change in metrics mode from ARC OptIn page was not propogated to Chrome settings. Test: Manually on device Bug: 755716 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I81ce5d38d34ade6d6f2737804eee5c1e7fa0822e Reviewed-on: https://chromium-review.googlesource.com/736145Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#513014}
-
Kevin Bailey authored
There is a large piece of code within |HQP::DoAutocomplete()| that can be on its own trivially. This change moves it to another method, and should not change behavior. This is to facilitate a downstream change. Bug: Change-Id: Ifdbbac697aee1efd0f42068f2e0825bb176a8076 Reviewed-on: https://chromium-review.googlesource.com/747064 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#513013}
-
Lei Zhang authored
Change-Id: Ic6489f81849456c7ce225cda73c5c08ec41e8e29 Reviewed-on: https://chromium-review.googlesource.com/747161 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#513012}
-
Peter Boström authored
Removes IDS_IMPORTER_LOCK_CANCEL as the dialog is no longer intended to be distinguished from other Cancel button labels. This specialized label caused translation confusion as it looks like it is intended to be specialized for the import dialog but is not "Cancel import" or similarly specialized content. Bug: b:68235708, chromium:754034 Change-Id: I15e35d90eafb621ce6a5d90a0e573edceae99ef1 Reviewed-on: https://chromium-review.googlesource.com/747633Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#513011}
-
Xiaocheng Hu authored
This patch changes the API to take Position parameters to better support mapping non-text anchored positions to LayoutNG canonical text. After this patch, NGOffsetMapping is fully converted to take Position parameters. Bug: 699017 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iee9956dc59c1ab34fe03f9f0f11fe890ddf9e568 Reviewed-on: https://chromium-review.googlesource.com/744733 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513010}
-
Matt Reynolds authored
A GamepadDataFetcher represents a host interface for receiving gamepad state and communicating commands to a gamepad connected over a particular host interface. This CL modifies GamepadDataFetcher to support haptics commands. Haptics commands received by GamepadService are routed to the fetcher corresponding to the gamepad's host interface. BUG=749295 Change-Id: I82629d34494871ed59c574a9846c0b4ff088f229 Reviewed-on: https://chromium-review.googlesource.com/739926 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513009}
-
Eric Karl authored
In preperation for adding the OOP Transfer Cache, I'm splitting ClientDiscardableManager into two classes: - ClientDiscardableManager - manages DiscardableHandles only - ClientDiscardableTextureManager - manages GL textures and uses a ClientDiscardableManager. This will allow the ClientTransferCache to also use a ClientDiscardableManager to manage its own DiscardableHandles. Eventually I plan to merge the transfer cache and discardable texture systems, but while the TransferCache and OOP raster is in flux, I'd like to keep them seperate. Bug: 777622 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iebfbdc31d9676d98abf7f422204d65c503df2d33 Reviewed-on: https://chromium-review.googlesource.com/745539 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513008}
-
Stanislav Chiknavaryan authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9d2153a6a7be53b8a6fcc1ce837a1ba1f7b9239d TBR=kbr@chromium.org Change-Id: I9d2153a6a7be53b8a6fcc1ce837a1ba1f7b9239d Reviewed-on: https://chromium-review.googlesource.com/744381 Commit-Queue: Stanislav Chiknavaryan <stanisc@chromium.org> Reviewed-by:
Stanislav Chiknavaryan <stanisc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513007}
-
Lei Zhang authored
Change-Id: Ie24494686e8a054aed8280320f27090e2703b974 Reviewed-on: https://chromium-review.googlesource.com/746150 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#513006}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ab816ce8ff61..47b67c426b1d $ git log ab816ce8f..47b67c426 --date=short --no-merges --format='%ad %ae %s' 2017-10-31 hinoka Reland "bot_update recipe: Upload source manifest" 2017-10-31 thomasanderson Add vs_files.ciopfs to gitignore Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Id4a1a05212fa00660d9a7a749f3ffd1987b98c36 Reviewed-on: https://chromium-review.googlesource.com/747893Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513005}
-
Kenichi Ishibashi authored
This CL adds OomInterventionTabHelper which is attached to a WebContent when the "OomIntervention" feature flag is enabled. When the WebContent is a foreground tab, the helper tries to detect near-OOM situation by using NearOomMonitor. Currently the helper doesn't initiate any intervention (e.g. pause JavaScript execution) but records some metrics. Metrics include: 1) Elapsed time between near-OOM detection and a crash/process termination/page navigation. 2) The number of crashes of OOM protected renderers without near-OOM detection. 3) The number of renderer termination without near-OOM detection. 4) The number of navigations without near-OOM detection. 1 will be used to examine true/false positives (near-OOM is detected, is it a success estimation or not?) 2, 3, 4 will be used to examine true/false negatives (near-OOM is not detected, isn't it overlooked?) TBR=isherman@chromium.org Bug: 776665 Change-Id: I439ef7abeb90ba09df41e7fbb7a61e1599d2edc7 Reviewed-on: https://chromium-review.googlesource.com/743039 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513004}
-
danakj authored
Makes a CompositingModeReporter mojo API that is implemented in the viz process (which is the browser in this CL). The API allows registering a CompositingModeWatcher which hears about compositing mode fallback from gpu to software. Tracks the compositing mode in GpuProcessTransportFactory and ensures that decisions to use software compositing are sticky and global. Gives the current compositing state to new renderers on the command line. Tracks the compositing mode in RenderThreadImpl, based on the command line and from being a CompositingModeWatcher, and ensures that the compositing mode there is also sticky and global. Exposes the real compositing mode to blink via the Platform API instead of just exposing the state at startup (ie the command line flag). No longer tries to fall back to software compositing in the renderer process as a local decision. Tries gpu compositing indefinitely until hearing otherwise from being a CompositingModeWatcher. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/714365 In that version, the renderer would crash with LOG(FATAL) if it could not connect to the browser process RenderProcessHostImpl to make a gpu channel. This causes a lot of test and canary crash reports, as the browser side seems to disappear before the renderer does. So instead report back to the caller if the channel failed because of a connection error. And in that case since the browser side is gone, don't bother to retry making a compositor context at all, and just await the renderer's apocalypse. R=boliu@chromium.org, kenrb@chromium.org, pdr@chromium.org, piman@chromium.org, sadrul@chromium.org TBR=boliu@chromium.org, kenrb@chromium.org, pdr@chromium.org Bug: 772574 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2305c8bf83afeadb057e8ee4f4401bf0518a77e5 Reviewed-on: https://chromium-review.googlesource.com/747382 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#513003}
-
Caleb Rouleau authored
Currently these tests only provide audio_time_to_play and video_time_to_play media metrics (along with generic cpu and memory metrics). Adding new metrics after these tests are committed simply means adding trace events to the product code and turning those into metrics in media_metric.html. In this way, the code I have added is just the scenarios. These scenarios are meant to be working examples that can be edited significantly in the future. That said, once this is committed, we're probably fine dropping the legacy mse_cases (since they are really flaky and haven't been finding any bugs.) These tests will be enough to cover them. Bug: 772971,713335 Change-Id: Ib2c32e4ab97738cc8d8e4b745b11820761213ad3 Reviewed-on: https://chromium-review.googlesource.com/733985 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#513002}
-
Mike Dougherty authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I64bf009972f035a8c7fbc5d2abf12209fee69ffb Reviewed-on: https://chromium-review.googlesource.com/746963 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#513001}
-
Dan Sanders authored
Before this change, BoxReader could read syntax elements outside of a box in cases where the MP4 was invalid. This isn't a security concern, since the reads were still bounded by the buffer size, but it did make it hard to interpret the later failures. This CL shrinks |buf_size_| to match |box_size_| when the box size is read. OOB reads will now result in Parse failures immediately. Bug: 779321 Change-Id: I54be6ba3815d1502233b5e95d099ce9d9a54b3cc Reviewed-on: https://chromium-review.googlesource.com/747080Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#513000}
-
sczs authored
Creates animations for expanding and contracting the location bar/omnibox using entirely UIViewPropertyAnimators. The feature is behind a new flag that is disabled by default. Real time video: https://drive.google.com/open?id=0Byo6-Nuda2jgVE1yTjBPRU9ybjg Slow Animations video: https://drive.google.com/open?id=0Byo6-Nuda2jgR21YM3k0amEwUEE Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib3a4f8f7aac9e72b674b881af2f463fabf76393a Reviewed-on: https://chromium-review.googlesource.com/729839 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#512999}
-
Muyuan Li authored
BUG=b:65588340 BUG=779815 TEST=test via local chrome variation server. Change-Id: Ieb791cab0b84bcf8e8525a11d085e20ad99128bb Reviewed-on: https://chromium-review.googlesource.com/747764Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#512998}
-
Lucas Garron authored
TBR=palmer@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic03627a7b7af205989503b8c444ddc4be45641a1 Reviewed-on: https://chromium-review.googlesource.com/747880 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#512997}
-
kylechar authored
This CL fixes the ash add/remove display accelerators when running with --mus. When the accelerator is pressed it needs to call TestDisplayController::AddRemoveDisplay(). The TestDisplayControllerPtr is moved into DisplayManager to simplify things. This allows removing the special case for the DEV_ADD_REMOVE_DISPLAY accelerator. Both --mus and --mash will set TestDisplayControllerPtr on startup if they are running on Linux desktop. It would be possible to do something similar with classic ash in the future. Bug: 779845 Change-Id: I70b058777944217e55ef105b9d1ac65f05e28b3a Reviewed-on: https://chromium-review.googlesource.com/746375Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#512996}
-
Boris Sazonov authored
https://crrev.com/2772203004 introduced a crash as dialogs can't be dismissed when container activity has been destroyed. This CL fixes this crash by storing an instance of ConfirmSyncDataStateMachine in AccountSigninView and calling cancel() when the view becomes invisible. This CL also reimplements ConfirmSyncDataStateMachineDelegate dialogs as DialogFragments. Bug: 774421 Change-Id: I2af2a8571921d7b7587b1f25ab771df14af5dbc3 Reviewed-on: https://chromium-review.googlesource.com/730708 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#512995}
-
gogerald authored
This CL parses and stores 'basic-card' specific capabilities, and uses them to filter service worker payment apps. The capabilities will also be used to filter modifiers. Bug: 777470 Change-Id: Ifab1054ec3bccd4f279cde5348cc68abf504a88d Reviewed-on: https://chromium-review.googlesource.com/730845 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#512994}
-
rbpotter authored
Bug: None Change-Id: I3441a7a704df305fcb4379ee46cc00b5d3b3619d Reviewed-on: https://chromium-review.googlesource.com/740704 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#512993}
-
Chris Blume authored
Zlib's fuzzer (and other tests) should all be close to the code it is related to. Move zlib_uncompress_fuzzer into third_party/zlib. BUG=779823 Change-Id: I960561b5cd83a629e9d296f56c75c7bfcec2663a Reviewed-on: https://chromium-review.googlesource.com/744597Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#512992}
-
Jay Civelli authored
Updating the doc of TestConnectionFactory, which I forgot to do when I changed the API in a previous CL. Bug: None Tbr: rockot@chromium.org Change-Id: I5b3e6d968b686a8a44f2c0d1561351fec394c5af Reviewed-on: https://chromium-review.googlesource.com/747888Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#512991}
-
Dimitri Glazkov authored
Add Daniel, Yoav, and Ojan to the API_OWNERS file. TBR=philipj,rbyers Bug: Change-Id: Ia87e64c3c57a4c8beb7626604002b5937a6962fb Reviewed-on: https://chromium-review.googlesource.com/747818Reviewed-by:
Dimitri Glazkov <dglazkov@chromium.org> Commit-Queue: Dimitri Glazkov <dglazkov@chromium.org> Cr-Commit-Position: refs/heads/master@{#512990}
-
dpapad authored
During initial population of the extensions and apps lists, addItem() was called N times, which internally performs a linear search N times, as well as triggres splice() notifications that are unnecessary. As revealed by DevTools (for a total of 30 extensions and apps): - before: the N calls to addItem() were taking ~22ms total - after: The initialization of the lists takes ~5ms total Bug: 764126 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If66d752cd3e7ac4b4ecd01ea4964ca6fd8d8f0db Reviewed-on: https://chromium-review.googlesource.com/746967Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#512989}
-
Xianzhu Wang authored
We should use IntRect instead of FloatRect for the bounds of bitmap. Previously the loop variables in BitmapEquals() exceeded the actual bounds of the bitmap if the given FloatRect was not integral. Bug: 779949 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib814cc8d3dcdcd9404654cd1f6352fb98d1e15f9 Reviewed-on: https://chromium-review.googlesource.com/746988Reviewed-by:
Walter Korman <wkorman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#512988}
-